Simplified truename(): eliminated the addSep state by adding a backslash in

every new segment, including a trailing backslash. Simplified . and .. logic.
Converted switch to if because there were few cases left.


git-svn-id: https://svn.code.sf.net/p/freedos/svn/kernel/trunk@1478 6ac86273-5f31-0410-b378-82cca8765d1b
This commit is contained in:
Bart Oldeman 2009-07-07 13:04:53 +00:00
parent f26372a241
commit d8537c13ef

View File

@ -264,7 +264,6 @@ COUNT truename(const char FAR * src, char * dest, COUNT mode)
char *p = dest; /* dynamic pointer into dest */ char *p = dest; /* dynamic pointer into dest */
char *rootPos; char *rootPos;
char src0; char src0;
enum { DONT_ADD, ADD, ADD_UNLESS_LAST } addSep;
tn_printf(("truename(%S)\n", src)); tn_printf(("truename(%S)\n", src));
@ -447,7 +446,6 @@ COUNT truename(const char FAR * src, char * dest, COUNT mode)
} }
/* append the path specified in src */ /* append the path specified in src */
addSep = *src ? ADD : DONT_ADD; /* add separator */
state = 0; state = 0;
while(*src) while(*src)
@ -456,40 +454,35 @@ COUNT truename(const char FAR * src, char * dest, COUNT mode)
segment(s), this is an invalid path. */ segment(s), this is an invalid path. */
if (state & PNE_WILDCARD) if (state & PNE_WILDCARD)
return DE_PATHNOTFND; return DE_PATHNOTFND;
switch(*src++)
/* append backslash if not already there.
MS DOS preserves a trailing '\\', so an access to "C:\\DOS\\"
or "CDS.C\\" fails; in that case the last new segment consists of just
the \ */
if (p[-1] != *rootPos)
addChar(*rootPos);
/* skip multiple separators (duplicated slashes) */
while (*src == '/' || *src == '\\')
src++;
if(*src == '.')
{ {
case '/': /* special directory component */
case '\\': /* skip multiple separators (duplicated slashes) */ ++src;
addSep = ADD; if (*src == '.') /* skip the second dot */
break; ++src;
case '.': /* special directory component */ if (*src == '/' || *src == '\\' || *src == '\0')
switch(*src)
{ {
case '/': --p; /* backup the backslash */
case '\\': if (src[-2] == '.')
case '\0':
/* current path -> ignore */
addSep = ADD_UNLESS_LAST;
/* If (/ or \) && no ++src
--> addSep = ADD next turn */
continue; /* next char */
case '.': /* maybe ".." entry */
switch(src[1])
{ {
case '/': /* ".." entry */
case '\\':
case '\0':
/* remove last path component */ /* remove last path component */
while(*--p != '\\') while(*--p != '\\')
if (p <= rootPos) /* already on root */ if (p <= rootPos) /* already on root */
return DE_PATHNOTFND; return DE_PATHNOTFND;
/* the separator was removed -> add it again */
++src; /* skip the second dot */
/* If / or \, next turn will find them and
assign addSep = ADD */
addSep = ADD_UNLESS_LAST;
continue; /* next char */
} }
continue; /* next char */
} }
/* ill-formed .* or ..* entries => return error */ /* ill-formed .* or ..* entries => return error */
@ -499,16 +492,10 @@ COUNT truename(const char FAR * src, char * dest, COUNT mode)
return fstrchr(src, '/') == 0 && fstrchr(src, '\\') == 0 return fstrchr(src, '/') == 0 && fstrchr(src, '\\') == 0
? DE_FILENOTFND ? DE_FILENOTFND
: DE_PATHNOTFND; : DE_PATHNOTFND;
default: /* normal component */
if (addSep != DONT_ADD)
{ /* append backslash */
addChar(*rootPos);
addSep = DONT_ADD;
} }
/* normal component */
/* append component in 8.3 convention */ /* append component in 8.3 convention */
--src;
/* first character skipped in switch() */
/* *** parse name and extension *** */ /* *** parse name and extension *** */
i = FNAME_SIZE; i = FNAME_SIZE;
@ -554,17 +541,12 @@ COUNT truename(const char FAR * src, char * dest, COUNT mode)
} }
} }
/* *** end of parse name and extension *** */ /* *** end of parse name and extension *** */
break;
}
} }
if (state & PNE_WILDCARD && !(mode & CDS_MODE_ALLOW_WILDCARDS)) if (state & PNE_WILDCARD && !(mode & CDS_MODE_ALLOW_WILDCARDS))
return DE_PATHNOTFND; return DE_PATHNOTFND;
if (addSep == ADD || p == dest + 2) if (p == dest + 2)
{ {
/* MS DOS preserves a trailing '\\', so an access to "C:\\DOS\\" /* we must always add a seperator if dest = "c:" */
or "CDS.C\\" fails. */
/* But don't add the separator, if the last component was ".." */
/* we must also add a seperator if dest = "c:" */
addChar('\\'); addChar('\\');
} }