tyler.durden/notepad-plus-plus
1
0
Fork 0
mirror of https://github.com/notepad-plus-plus/notepad-plus-plus.git synced 2025-07-23 22:04:55 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix network shared files saving regression

Browse Source 
Cause:
https://github.com/notepad-plus-plus/notepad-plus-plus/issues/14300#issuecomment-1791313760

Solution:
https://github.com/notepad-plus-plus/notepad-plus-plus/issues/14300#issuecomment-1798075334

Enhancement:
https://github.com/notepad-plus-plus/notepad-plus-plus/issues/14300#issuecomment-1804910680

Fix  #14300, close #14344
This commit is contained in:
Don Ho 2023-11-10 16:52:42 +01:00
parent 4ff9d77d2b
commit 2337a7b5b6
1 changed files with 28 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
PowerEditor/src/MISC/Common/FileInterface.cpp
View File

@ -29,15 +29,40 @@ Win32_IO_File::Win32_IO_File(const wchar_t *fname)
std::wstring_convert<std::codecvt_utf8_utf16<wchar_t>> converter;
_path = converter.to_bytes(fn);
DWORD dispParam = ::PathFileExistsW(fname) ? TRUNCATE_EXISTING : CREATE_ALWAYS;
WIN32_FILE_ATTRIBUTE_DATA attributes_original{};
DWORD dispParam = CREATE_ALWAYS;
BOOL doesFileExist = ::PathFileExistsW(fname);
if (doesFileExist)
{
// Store the file creation date & attributes for a possible use later...
::GetFileAttributesExW(fname, GetFileExInfoStandard, &attributes_original);
// Check the existence of Alternate Data Streams
WIN32_FIND_STREAM_DATA findData;
HANDLE hFind = FindFirstStreamW(fname, FindStreamInfoStandard, &findData, 0);
if (hFind != INVALID_HANDLE_VALUE) // Alternate Data Streams found
{
dispParam = TRUNCATE_EXISTING;
FindClose(hFind);
}
}
_hFile = ::CreateFileW(fname, _accessParam, _shareParam, NULL, dispParam, _attribParam, NULL);
// Race condition management:
// If file didn't exist while calling PathFileExistsW, but before calling CreateFileW, file is created: use CREATE_ALWAYS is OK
// If file did exist while calling PathFileExistsW, but before calling CreateFileW, file is deleted: use TRUNCATE_EXISTING will cause the error
if (_hFile == INVALID_HANDLE_VALUE && ::GetLastError() == ERROR_FILE_NOT_FOUND)
if (dispParam == TRUNCATE_EXISTING && _hFile == INVALID_HANDLE_VALUE && ::GetLastError() == ERROR_FILE_NOT_FOUND)
{
_hFile = ::CreateFileW(fname, _accessParam, _shareParam, NULL, CREATE_ALWAYS, _attribParam, NULL);
dispParam = CREATE_ALWAYS;
_hFile = ::CreateFileW(fname, _accessParam, _shareParam, NULL, dispParam, _attribParam, NULL);
}
if (doesFileExist && (dispParam == CREATE_ALWAYS) && (_hFile != INVALID_HANDLE_VALUE))
{
// restore back the original creation date & attributes
::SetFileTime(_hFile, &(attributes_original.ftCreationTime), NULL, NULL);
::SetFileAttributesW(fname, (_attribParam | attributes_original.dwFileAttributes));
}
NppParameters& nppParam = NppParameters::getInstance();