tyler.durden/notepad-plus-plus
1
0
Fork 0
mirror of https://github.com/notepad-plus-plus/notepad-plus-plus.git synced 2025-07-25 14:54:39 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix static analyzer issue "A virtual function was overridden incorrectly"

Browse Source 
V762 It is possible a virtual function was overridden incorrectly. See third argument of function 'create' in derived class 'UserDefineDialog' and base class 'StaticDialog'. userdefinedialog.h 332
V762 It is possible a virtual function was overridden incorrectly. See first argument of function 'redraw' in derived class 'SplitterContainer' and base class 'Window'. splittercontainer.h 61
V762 It is possible a virtual function was overridden incorrectly. See third argument of function 'create' in derived class 'FindReplaceDlg' and base class 'StaticDialog'. findreplacedlg.h 245
V762 It is possible a virtual function was overridden incorrectly. See third argument of function 'create' in derived class 'GoToLineDlg' and base class 'StaticDialog'. gotolinedlg.h 45
V762 It is possible a virtual function was overridden incorrectly. See third argument of function 'create' in derived class 'FindCharsInRangeDlg' and base class 'StaticDialog'. findcharsinrange.h 52
V762 It is possible a virtual function was overridden incorrectly. See third argument of function 'create' in derived class 'ColumnEditorDlg' and base class 'StaticDialog'. columneditor.h 45
V762 It is possible a virtual function was overridden incorrectly. See third argument of function 'create' in derived class 'WordStyleDlg' and base class 'StaticDialog'. wordstyledlg.h 77
V762 It is possible a virtual function was overridden incorrectly. See first argument of function 'redraw' in derived class 'WordStyleDlg' and base class 'Window'. wordstyledlg.h 99
V762 It is possible a virtual function was overridden incorrectly. See third argument of function 'create' in derived class 'PluginsAdminDlg' and base class 'StaticDialog'. pluginsadmin.h 100
This commit is contained in:
Oleksandr Redko 2017-10-29 18:11:05 +02:00
parent 81847599d0
commit 29f28098ae
12 changed files with 20 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
PowerEditor/src/ScitillaComponent/FindReplaceDlg.cpp
View File

@ -242,9 +242,9 @@ FindReplaceDlg::~FindReplaceDlg()
delete[] _uniFileName; delete[] _uniFileName;
} }
void FindReplaceDlg::create(int dialogID, bool isRTL) void FindReplaceDlg::create(int dialogID, bool isRTL, bool msgDestParent)
{ {
StaticDialog::create(dialogID, isRTL); StaticDialog::create(dialogID, isRTL, msgDestParent);
fillFindHistory(); fillFindHistory();
_currentStatus = REPLACE_DLG; _currentStatus = REPLACE_DLG;
initOptionsFromDlg(); initOptionsFromDlg();

2
PowerEditor/src/ScitillaComponent/FindReplaceDlg.h
View File

@ -242,7 +242,7 @@ public :
_ppEditView = ppEditView; _ppEditView = ppEditView;
}; };
virtual void create(int dialogID, bool isRTL = false); virtual void create(int dialogID, bool isRTL = false, bool msgDestParent = true);
void initOptionsFromDlg(); void initOptionsFromDlg();

4
PowerEditor/src/ScitillaComponent/GoToLineDlg.h
View File

@ -42,8 +42,8 @@ public :
_ppEditView = ppEditView; _ppEditView = ppEditView;
}; };
virtual void create(int dialogID, bool isRTL = false) { virtual void create(int dialogID, bool isRTL = false, bool msgDestParent = true) {
StaticDialog::create(dialogID, isRTL); StaticDialog::create(dialogID, isRTL, msgDestParent);
}; };
void doDialog(bool isRTL = false) { void doDialog(bool isRTL = false) {

4
PowerEditor/src/ScitillaComponent/UserDefineDialog.h
View File

@ -329,8 +329,8 @@ public :
void setScintilla(ScintillaEditView *pScinView) { void setScintilla(ScintillaEditView *pScinView) {
_pScintilla = pScinView; _pScintilla = pScinView;
}; };
virtual void create(int dialogID, bool isRTL = false) { virtual void create(int dialogID, bool isRTL = false, bool msgDestParent = true) {
StaticDialog::create(dialogID, isRTL); StaticDialog::create(dialogID, isRTL, msgDestParent);
} }
void destroy() { void destroy() {
// A Ajouter les fils... // A Ajouter les fils...

4
PowerEditor/src/ScitillaComponent/columnEditor.h
View File

@ -42,8 +42,8 @@ public :
void init(HINSTANCE hInst, HWND hPere, ScintillaEditView **ppEditView); void init(HINSTANCE hInst, HWND hPere, ScintillaEditView **ppEditView);
virtual void create(int dialogID, bool isRTL = false) { virtual void create(int dialogID, bool isRTL = false, bool msgDestParent = true) {
StaticDialog::create(dialogID, isRTL); StaticDialog::create(dialogID, isRTL, msgDestParent);
}; };
void doDialog(bool isRTL = false) { void doDialog(bool isRTL = false) {

4
PowerEditor/src/WinControls/ColourPicker/WordStyleDlg.cpp
View File

@ -836,9 +836,9 @@ void WordStyleDlg::setVisualFromStyleList()
} }
void WordStyleDlg::create(int dialogID, bool isRTL) void WordStyleDlg::create(int dialogID, bool isRTL, bool msgDestParent)
{ {
StaticDialog::create(dialogID, isRTL); StaticDialog::create(dialogID, isRTL, msgDestParent);
if ((NppParameters::getInstance())->isTransparentAvailable()) if ((NppParameters::getInstance())->isTransparentAvailable())
{ {

4
PowerEditor/src/WinControls/ColourPicker/WordStyleDlg.h
View File

@ -74,7 +74,7 @@ public :
Window::init(hInst, parent); Window::init(hInst, parent);
}; };
virtual void create(int dialogID, bool isRTL = false); virtual void create(int dialogID, bool isRTL = false, bool msgDestParent = true);
void doDialog(bool isRTL = false) { void doDialog(bool isRTL = false) {
if (!isCreated()) if (!isCreated())
@ -96,7 +96,7 @@ public :
_gOverride2restored = (NppParameters::getInstance())->getGlobalOverrideStyle(); _gOverride2restored = (NppParameters::getInstance())->getGlobalOverrideStyle();
}; };
virtual void redraw() const { virtual void redraw(bool forceUpdate = false) const {
_pFgColour->redraw(); _pFgColour->redraw();
_pBgColour->redraw(); _pBgColour->redraw();
::InvalidateRect(_hStyleInfoStaticText, NULL, TRUE); ::InvalidateRect(_hStyleInfoStaticText, NULL, TRUE);

4
PowerEditor/src/WinControls/FindCharsInRange/FindCharsInRange.h
View File

@ -49,8 +49,8 @@ public :
_ppEditView = ppEditView; _ppEditView = ppEditView;
}; };
virtual void create(int dialogID, bool isRTL = false) { virtual void create(int dialogID, bool isRTL = false, bool msgDestParent = true) {
StaticDialog::create(dialogID, isRTL); StaticDialog::create(dialogID, isRTL, msgDestParent);
}; };
void doDialog(bool isRTL = false) { void doDialog(bool isRTL = false) {

4
PowerEditor/src/WinControls/PluginsAdmin/pluginsAdmin.cpp
View File

@ -203,12 +203,12 @@ long PluginsAdminDlg::searchFromCurrentSel(generic_string str2search, bool inWhi
return -1; return -1;
} }
void PluginsAdminDlg::create(int dialogID, bool isRTL) void PluginsAdminDlg::create(int dialogID, bool isRTL, bool msgDestParent)
{ {
// get plugin installation path and launch mode (Admin or normal) // get plugin installation path and launch mode (Admin or normal)
collectNppCurrentStatusInfos(); collectNppCurrentStatusInfos();
StaticDialog::create(dialogID, isRTL); StaticDialog::create(dialogID, isRTL, msgDestParent);
RECT rect; RECT rect;
getClientRect(rect); getClientRect(rect);

2
PowerEditor/src/WinControls/PluginsAdmin/pluginsAdmin.h
View File

@ -97,7 +97,7 @@ public :
Window::init(hInst, parent); Window::init(hInst, parent);
}; };
virtual void create(int dialogID, bool isRTL = false); virtual void create(int dialogID, bool isRTL = false, bool msgDestParent = true);
void doDialog(bool isRTL = false) { void doDialog(bool isRTL = false) {
if (!isCreated()) if (!isCreated())

2
PowerEditor/src/WinControls/SplitterContainer/SplitterContainer.cpp
View File

@ -118,7 +118,7 @@ void SplitterContainer::display(bool toShow) const
} }
void SplitterContainer::redraw() const void SplitterContainer::redraw(bool forceUpdate) const
{ {
assert(_pWin0 != nullptr); assert(_pWin0 != nullptr);
assert(_pWin1 != nullptr); assert(_pWin1 != nullptr);

2
PowerEditor/src/WinControls/SplitterContainer/SplitterContainer.h
View File

@ -58,7 +58,7 @@ public :
virtual void display(bool toShow = true) const; virtual void display(bool toShow = true) const;
virtual void redraw() const; virtual void redraw(bool forceUpdate = false) const;
void setWin0(Window* pWin) void setWin0(Window* pWin)
{ {