tyler.durden/notepad-plus-plus
1
0
Fork 0
mirror of https://github.com/notepad-plus-plus/notepad-plus-plus.git synced 2025-07-24 14:24:58 +02:00
Code Issues Packages Projects Releases Wiki Activity

Simplify word detection for SmartHighlighter

Browse Source 
Utilizes SCI_WORDSTARTPOSITION and SCI_WORDENDPOSITION from Scintilla. Fixes #2110
This commit is contained in:
dail8859 2016-07-20 22:46:30 -04:00
parent bd373788ad
commit 2e4defe459
2 changed files with 15 additions and 69 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

81
PowerEditor/src/ScitillaComponent/SmartHighlighter.cpp
View File

@ -39,54 +39,25 @@ SmartHighlighter::SmartHighlighter(FindReplaceDlg * pFRDlg)
void SmartHighlighter::highlightView(ScintillaEditView * pHighlightView) void SmartHighlighter::highlightView(ScintillaEditView * pHighlightView)
{ {
//Get selection // Clear marks
CharacterRange range = pHighlightView->getSelection();
//Clear marks
pHighlightView->clearIndicator(SCE_UNIVERSAL_FOUND_STYLE_SMART); pHighlightView->clearIndicator(SCE_UNIVERSAL_FOUND_STYLE_SMART);
//If nothing selected, dont mark anything // If nothing selected, dont mark anything
if (range.cpMin == range.cpMax) if (pHighlightView->execute(SCI_GETSELECTIONEMPTY) == 1)
{ return;
auto curPos = pHighlightView->execute(SCI_GETCURRENTPOS);
auto wordStart = pHighlightView->execute(SCI_WORDSTARTPOSITION, curPos, true);
auto wordEnd = pHighlightView->execute(SCI_WORDENDPOSITION, wordStart, true);
auto range = pHighlightView->getSelection();
// Make sure the "word" positions match the current selection
if (wordStart == wordEnd || wordStart != range.cpMin || wordEnd != range.cpMax)
return; return;
}
int textlen = range.cpMax - range.cpMin + 1; int textlen = range.cpMax - range.cpMin + 1;
char * text2Find = new char[textlen]; char * text2Find = new char[textlen];
pHighlightView->getSelectedText(text2Find, textlen, false); //do not expand selection (false) pHighlightView->getSelectedText(text2Find, textlen, false); //do not expand selection (false)
//GETWORDCHARS for isQualifiedWord2() and isWordChar2()
auto listCharSize = pHighlightView->execute(SCI_GETWORDCHARS, 0, 0);
char *listChar = new char[listCharSize+1];
pHighlightView->execute(SCI_GETWORDCHARS, 0, (LPARAM)listChar);
listChar[listCharSize] = '\0';
bool valid = true;
//The word has to consist if wordChars only, and the characters before and after something else
if (!isQualifiedWord(text2Find, listChar))
valid = false;
else
{
UCHAR c = (UCHAR)pHighlightView->execute(SCI_GETCHARAT, range.cpMax);
if (c)
{
if (isWordChar(char(c), listChar))
valid = false;
}
c = (UCHAR)pHighlightView->execute(SCI_GETCHARAT, range.cpMin-1);
if (c)
{
if (isWordChar(char(c), listChar))
valid = false;
}
}
if (!valid) {
delete [] text2Find;
delete [] listChar;
return;
}
// save target locations for other search functions // save target locations for other search functions
int originalStartPos = (int)pHighlightView->execute(SCI_GETTARGETSTART); int originalStartPos = (int)pHighlightView->execute(SCI_GETTARGETSTART);
@ -140,28 +111,6 @@ void SmartHighlighter::highlightView(ScintillaEditView * pHighlightView)
// restore the original targets to avoid conflicts with the search/replace functions // restore the original targets to avoid conflicts with the search/replace functions
pHighlightView->execute(SCI_SETTARGETRANGE, originalStartPos, originalEndPos); pHighlightView->execute(SCI_SETTARGETRANGE, originalStartPos, originalEndPos);
delete [] listChar;
delete[] text2Find;
} }
bool SmartHighlighter::isQualifiedWord(const char *str, char *listChar) const
{
for (size_t i = 0, len = strlen(str) ; i < len ; ++i)
{
if (!isWordChar(str[i], listChar))
return false;
}
return true;
};
bool SmartHighlighter::isWordChar(char ch, char listChar[]) const
{
for (size_t i = 0, len = strlen(listChar) ; i < len ; ++i)
{
if (ch == listChar[i])
{
return true;
}
}
return false;
};

3
PowerEditor/src/ScitillaComponent/SmartHighlighter.h
View File

@ -37,9 +37,6 @@ public:
void highlightView(ScintillaEditView * pHighlightView); void highlightView(ScintillaEditView * pHighlightView);
private: private:
FindReplaceDlg * _pFRDlg; FindReplaceDlg * _pFRDlg;
bool isQualifiedWord(const char *str, char listChar[]) const;
bool isWordChar(char ch, char listChar[]) const;
}; };
#endif //SMARTHIGHLIGHTER_H #endif //SMARTHIGHLIGHTER_H