From 3c89b57167a9a22e463bf6a71fab85de05bcd3db Mon Sep 17 00:00:00 2001 From: Don HO Date: Fri, 31 Dec 2021 21:03:10 +0100 Subject: [PATCH] Installation: Let users decide to keep or not HexEdit plugin Fix #10828, close #10972 --- .../installer/nsisInclude/mainSectionFuncs.nsh | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/PowerEditor/installer/nsisInclude/mainSectionFuncs.nsh b/PowerEditor/installer/nsisInclude/mainSectionFuncs.nsh index 65860e764..d0983cbac 100644 --- a/PowerEditor/installer/nsisInclude/mainSectionFuncs.nsh +++ b/PowerEditor/installer/nsisInclude/mainSectionFuncs.nsh @@ -230,14 +230,15 @@ Function removeUnstablePlugins MessageBox MB_OK "Due to NppSaveAsAdmin plugin's incompatibility issue in version $R0, NppSaveAsAdmin.dll will be deleted. Use Plugins Admin to add back (the latest version of) NppSaveAsAdmin." /SD IDOK Rename "$INSTDIR\plugins\NppSaveAsAdmin\NppSaveAsAdmin.dll" "$INSTDIR\plugins\disabled\NppSaveAsAdmin.dll" Delete "$INSTDIR\plugins\NppSaveAsAdmin\NppSaveAsAdmin.dll" - NppSaveAsAdminTestEnd: - - ; https://github.com/chcg/NPP_HexEdit/issues/51 - IfFileExists "$INSTDIR\plugins\HexEditor\HexEditor.dll" 0 HexEditorTestEnd - MessageBox MB_OK "Due to HexEditor plugin's crash issue on Notepad++ v8 (and later versions), HexEditor.dll will be removed." /SD IDOK - Rename "$INSTDIR\plugins\HexEditor\HexEditor.dll" "$INSTDIR\plugins\disabled\HexEditor.dll" - Delete "$INSTDIR\plugins\HexEditor\HexEditor.dll" - HexEditorTestEnd: +NppSaveAsAdminTestEnd: + + ; https://github.com/chcg/NPP_HexEdit/issues/51 + IfFileExists "$INSTDIR\plugins\HexEditor\HexEditor.dll" 0 noDeleteHEPlugin + MessageBox MB_YESNO "HexEditor plugin is unstable, we suggest you to remove it.$\nRemove HexEditor plugin?" /SD IDYES IDYES doDeleteHEPlugin IDNO noDeleteHEPlugin ;IDYES remove +doDeleteHEPlugin: + Rename "$INSTDIR\plugins\HexEditor\HexEditor.dll" "$INSTDIR\plugins\disabled\HexEditor.dll" + Delete "$INSTDIR\plugins\HexEditor\HexEditor.dll" +noDeleteHEPlugin: FunctionEnd