tyler.durden
/
notepad-plus-plus
mirror of https://github.com/notepad-plus-plus/notepad-plus-plus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Improve contributing guidelines by excluding not, and, or. 

Reference: https://github.com/notepad-plus-plus/notepad-plus-plus/pull/9534#discussion_r579588184

Close #9544
This commit is contained in:
Scott Sumner 2021-02-20 07:02:31 -05:00 committed by Don HO
parent dbac42edd0
commit 41cfc7e1d1
No known key found for this signature in database
GPG Key ID: 6C429F1D8D84F46E
1 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
CONTRIBUTING.md
View File

@ -32,7 +32,7 @@ Opening a issue beforehand allows the administrators and the community to discus
### Guidelines for pull requests ### Guidelines for pull requests
1. Respect Notepad++ coding style. 1. Respect existing Notepad++ coding style. Observe the code near your intended change, and attempt to preserve the style of that code with the changes you make.
2. Create a new branch for each PR. **Make sure your branch name wasn't used before** - you can add date (for example `patch3_20200528`) to ensure its uniqueness. 2. Create a new branch for each PR. **Make sure your branch name wasn't used before** - you can add date (for example `patch3_20200528`) to ensure its uniqueness.
3. Single feature or bug-fix per PR. 3. Single feature or bug-fix per PR.
4. Create a PR with a single commit to make the review process easier. 4. Create a PR with a single commit to make the review process easier.
@ -192,6 +192,17 @@ In short: The easier the code review is, the better the chance your pull request
char aChar = (char)_pEditView->execute(SCI_GETCHARAT, j); char aChar = (char)_pEditView->execute(SCI_GETCHARAT, j);
``` ```
13. ##### Use `!` instead of `not`, `&&` instead of `and`, `||` instead of `or`.
* ###### Good:
```cpp
if (!::PathFileExists(dir2Search))
```
* ###### Bad:
```cpp
if (not ::PathFileExists(dir2Search))
```
#### NAMING CONVENTIONS #### NAMING CONVENTIONS