From e30a4d6788c814f91d625ce00fa535354fb6517e Mon Sep 17 00:00:00 2001 From: Randy Fellmy Date: Sat, 29 Nov 2025 12:42:13 -0700 Subject: [PATCH] Fix context menu truncated regression on localization change Don't skip preliminary switch to English when changing Localization to English -- it breaks NppParameters::getContextMenuFromXmlTree. Regression was introduced by: https://github.com/notepad-plus-plus/notepad-plus-plus/commit/446cc980e871d04885f13055bb56acee820636c8#diff-686f6d3c1ec15b51f312bb5a68130dfa62292a8d19594fb0f3621c179970fa1fR816 Fix #17249, close #17250 --- PowerEditor/src/WinControls/Preference/preferenceDlg.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/PowerEditor/src/WinControls/Preference/preferenceDlg.cpp b/PowerEditor/src/WinControls/Preference/preferenceDlg.cpp index 8256003ee..c08b2fd32 100644 --- a/PowerEditor/src/WinControls/Preference/preferenceDlg.cpp +++ b/PowerEditor/src/WinControls/Preference/preferenceDlg.cpp @@ -859,8 +859,8 @@ intptr_t CALLBACK GeneralSubDlg::run_dlgProc(UINT message, WPARAM wParam, LPARAM ::SendDlgItemMessage(_hSelf, IDC_COMBO_LOCALIZATION, CB_GETLBTEXT, index, reinterpret_cast(langName)); if (langName[0]) { - // Make English as basic language, but if we switch from another language to English, we can skip it - if ((lstrcmpW(langName, L"English") != 0) && localizationSwitcher.switchToLang(L"English")) + // Make English as basic language + if (localizationSwitcher.switchToLang(L"English")) { ::SendMessage(::GetParent(_hParent), NPPM_INTERNAL_RELOADNATIVELANG, FALSE, 0); }