From e719c567084cc7b58108a665f129491b3ee374d8 Mon Sep 17 00:00:00 2001 From: Don Ho Date: Sat, 3 May 2025 18:16:31 +0200 Subject: [PATCH] Fix Find in files progress bar visual regression (from v8.8) Regression is introduce by: https://github.com/notepad-plus-plus/notepad-plus-plus/commit/a23955742cd4422b2365d6fde7a82b4ff0311bd2 Ref: https://github.com/notepad-plus-plus/notepad-plus-plus/pull/16387#issuecomment-2848676406 Fix #16504 --- PowerEditor/src/ScintillaComponent/FindReplaceDlg.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/PowerEditor/src/ScintillaComponent/FindReplaceDlg.cpp b/PowerEditor/src/ScintillaComponent/FindReplaceDlg.cpp index d88ea12c4..0418d483f 100644 --- a/PowerEditor/src/ScintillaComponent/FindReplaceDlg.cpp +++ b/PowerEditor/src/ScintillaComponent/FindReplaceDlg.cpp @@ -6630,7 +6630,9 @@ LRESULT APIENTRY Progress::wndProc(HWND hwnd, UINT umsg, WPARAM wparam, LPARAM l ::FillRect(reinterpret_cast(wparam), &rc, NppDarkMode::getDlgBackgroundBrush()); return TRUE; } - break; + // With "break;" here it will cause the visual regression: https://community.notepad-plus-plus.org/topic/26815/notepad-v8-8-release/4?_=1746285454720 + // Use "return TRUE;" instead. + return TRUE; } case WM_SETFOCUS: