child_set_eng: verify both env pointer and count.
If child_set env was called with a NULL env pointer and a non-zero count it would end up in a null deref, although we don't currently do this. Prompted by Coverity CID 291850, tweak & ok djm@
This commit is contained in:
parent
28f1b8ef9b
commit
05b8e88ebe
2
misc.c
2
misc.c
|
@ -2273,6 +2273,8 @@ child_set_env(char ***envp, u_int *envsizep, const char *name,
|
|||
* If we're passed an uninitialized list, allocate a single null
|
||||
* entry before continuing.
|
||||
*/
|
||||
if ((*envp == NULL) != (*envsizep == 0))
|
||||
fatal_f("environment size mismatch");
|
||||
if (*envp == NULL && *envsizep == 0) {
|
||||
*envp = xmalloc(sizeof(char *));
|
||||
*envp[0] = NULL;
|
||||
|
|
Loading…
Reference in New Issue