- djm@cvs.openbsd.org 2008/12/09 02:58:16
[readconf.c] don't leave junk (free'd) pointers around in Forward *fwd argument on failure; avoids double-free in ~C -L handler when given an invalid forwarding specification; bz#1539 report from adejong AT debian.org via Colin Watson; ok markus@ dtucker@
This commit is contained in:
parent
1be2cc4496
commit
0d772d9d11
|
@ -12,6 +12,12 @@
|
||||||
Deal correctly with failures in remote stat() operation in sftp,
|
Deal correctly with failures in remote stat() operation in sftp,
|
||||||
correcting fail-on-error behaviour in batchmode. bz#1541 report and
|
correcting fail-on-error behaviour in batchmode. bz#1541 report and
|
||||||
fix from anedvedicky AT gmail.com; ok markus@
|
fix from anedvedicky AT gmail.com; ok markus@
|
||||||
|
- djm@cvs.openbsd.org 2008/12/09 02:58:16
|
||||||
|
[readconf.c]
|
||||||
|
don't leave junk (free'd) pointers around in Forward *fwd argument on
|
||||||
|
failure; avoids double-free in ~C -L handler when given an invalid
|
||||||
|
forwarding specification; bz#1539 report from adejong AT debian.org
|
||||||
|
via Colin Watson; ok markus@ dtucker@
|
||||||
|
|
||||||
20081208
|
20081208
|
||||||
- (djm) [configure.ac] bz#1538: better test for ProPolice/SSP: actually
|
- (djm) [configure.ac] bz#1538: better test for ProPolice/SSP: actually
|
||||||
|
@ -4979,5 +4985,5 @@
|
||||||
OpenServer 6 and add osr5bigcrypt support so when someone migrates
|
OpenServer 6 and add osr5bigcrypt support so when someone migrates
|
||||||
passwords between UnixWare and OpenServer they will still work. OK dtucker@
|
passwords between UnixWare and OpenServer they will still work. OK dtucker@
|
||||||
|
|
||||||
$Id: ChangeLog,v 1.5153 2008/12/09 03:11:49 djm Exp $
|
$Id: ChangeLog,v 1.5154 2008/12/09 03:12:05 djm Exp $
|
||||||
|
|
||||||
|
|
10
readconf.c
10
readconf.c
|
@ -1,4 +1,4 @@
|
||||||
/* $OpenBSD: readconf.c,v 1.172 2008/11/04 19:18:00 stevesk Exp $ */
|
/* $OpenBSD: readconf.c,v 1.173 2008/12/09 02:58:16 djm Exp $ */
|
||||||
/*
|
/*
|
||||||
* Author: Tatu Ylonen <ylo@cs.hut.fi>
|
* Author: Tatu Ylonen <ylo@cs.hut.fi>
|
||||||
* Copyright (c) 1995 Tatu Ylonen <ylo@cs.hut.fi>, Espoo, Finland
|
* Copyright (c) 1995 Tatu Ylonen <ylo@cs.hut.fi>, Espoo, Finland
|
||||||
|
@ -1293,9 +1293,13 @@ parse_forward(Forward *fwd, const char *fwdspec, int dynamicfwd)
|
||||||
return (i);
|
return (i);
|
||||||
|
|
||||||
fail_free:
|
fail_free:
|
||||||
if (fwd->connect_host != NULL)
|
if (fwd->connect_host != NULL) {
|
||||||
xfree(fwd->connect_host);
|
xfree(fwd->connect_host);
|
||||||
if (fwd->listen_host != NULL)
|
fwd->connect_host = NULL;
|
||||||
|
}
|
||||||
|
if (fwd->listen_host != NULL) {
|
||||||
xfree(fwd->listen_host);
|
xfree(fwd->listen_host);
|
||||||
|
fwd->listen_host = NULL;
|
||||||
|
}
|
||||||
return (0);
|
return (0);
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in New Issue