- (djm) [openbsd-compat/arc4random.c] Zero seed after keying PRNG

2014-09-04 03:46:05 +10:00 · 2014-09-04 03:46:05 +10:00 · 2a8699f37c
parent 44988defb1
commit 2a8699f37c
2 changed files with 4 additions and 1 deletions
--- a/3
+++ b/3
@ -1,3 +1,6 @@
+20140904
+ - (djm) [openbsd-compat/arc4random.c] Zero seed after keying PRNG
+
 20140903
 - (djm) [defines.h sshbuf.c] Move __predict_true|false to defines.h and
   conditionalise to avoid duplicate definition.
--- a/openbsd-compat/arc4random.c
+++ b/openbsd-compat/arc4random.c
@ -87,7 +87,7 @@ _rs_stir(void)
 		_rs_init(rnd, sizeof(rnd));
 	} else
 		_rs_rekey(rnd, sizeof(rnd));
-	memset(rnd, 0, sizeof(rnd));
+	explicit_bzero(rnd, sizeof(rnd));

 	/* invalidate rs_buf */
 	rs_have = 0;