upstream commit

Plug descriptor leaks of auth_sock.  From jjelen at
redhat.com via bz#2687, ok djm@

Upstream-ID: 248acb99a5ed2fdca37d1aa33c0fcee7be286d88
This commit is contained in:
dtucker@openbsd.org 2017-03-10 03:22:40 +00:00 committed by Darren Tucker
parent 8a2834454c
commit 566b3a46e8

View File

@ -1,4 +1,4 @@
/* $OpenBSD: sshconnect.c,v 1.272 2016/09/12 01:22:38 deraadt Exp $ */ /* $OpenBSD: sshconnect.c,v 1.273 2017/03/10 03:22:40 dtucker Exp $ */
/* /*
* Author: Tatu Ylonen <ylo@cs.hut.fi> * Author: Tatu Ylonen <ylo@cs.hut.fi>
* Copyright (c) 1995 Tatu Ylonen <ylo@cs.hut.fi>, Espoo, Finland * Copyright (c) 1995 Tatu Ylonen <ylo@cs.hut.fi>, Espoo, Finland
@ -1532,6 +1532,7 @@ maybe_add_key_to_agent(char *authfile, Key *private, char *comment,
if (options.add_keys_to_agent == 2 && if (options.add_keys_to_agent == 2 &&
!ask_permission("Add key %s (%s) to agent?", authfile, comment)) { !ask_permission("Add key %s (%s) to agent?", authfile, comment)) {
debug3("user denied adding this key"); debug3("user denied adding this key");
close(auth_sock);
return; return;
} }
@ -1540,4 +1541,5 @@ maybe_add_key_to_agent(char *authfile, Key *private, char *comment,
debug("identity added to agent: %s", authfile); debug("identity added to agent: %s", authfile);
else else
debug("could not add identity to agent: %s (%d)", authfile, r); debug("could not add identity to agent: %s (%d)", authfile, r);
close(auth_sock);
} }