document a PAM spec problem in a frustrated comment

This commit is contained in:
Damien Miller 2020-06-26 16:07:12 +10:00
parent 976c4f8628
commit 598c3a5e38
1 changed files with 5 additions and 1 deletions

View File

@ -375,7 +375,11 @@ import_environments(struct sshbuf *b)
error("PAM: pam_putenv: %s", error("PAM: pam_putenv: %s",
pam_strerror(sshpam_handle, r)); pam_strerror(sshpam_handle, r));
} }
/* XXX leak env? */ /*
* XXX this possibly leaks env because it is not documented
* what pam_putenv() does with it. Does it copy it? Does it
* take ownweship? We don't know, so it's safest just to leak.
*/
} }
#endif #endif
} }