tyler.durden
/
openssh-portable
mirror of https://github.com/PowerShell/openssh-portable.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

- djm@cvs.openbsd.org 2005/11/05 05:01:15 

[bufaux.c]
     Fix leaks in error paths, bz #1109 and #1110 reported by kremenek AT
     cs.stanford.edu; ok dtucker@
This commit is contained in:
Damien Miller 2005-11-05 16:04:36 +11:00
parent 19bb3a57f8
commit 5fd8b02b44
2 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
ChangeLog
View File

@ -98,6 +98,10 @@
remove hardcoded hash lengths in key exchange code, allowing remove hardcoded hash lengths in key exchange code, allowing
implementation of KEX methods with different hashes (e.g. SHA-256); implementation of KEX methods with different hashes (e.g. SHA-256);
ok markus@ dtucker@ stevesk@ ok markus@ dtucker@ stevesk@
- djm@cvs.openbsd.org 2005/11/05 05:01:15
[bufaux.c]
Fix leaks in error paths, bz #1109 and #1110 reported by kremenek AT
cs.stanford.edu; ok dtucker@
20051102 20051102
- (dtucker) [openbsd-compat/bsd-misc.c] Bug #1108: fix broken strdup(). - (dtucker) [openbsd-compat/bsd-misc.c] Bug #1108: fix broken strdup().
@ -3231,4 +3235,4 @@
- (djm) Trim deprecated options from INSTALL. Mention UsePAM - (djm) Trim deprecated options from INSTALL. Mention UsePAM
- (djm) Fix quote handling in sftp; Patch from admorten AT umich.edu - (djm) Fix quote handling in sftp; Patch from admorten AT umich.edu
$Id: ChangeLog,v 1.3951 2005/11/05 04:19:35 djm Exp $ $Id: ChangeLog,v 1.3952 2005/11/05 05:04:36 djm Exp $

5
bufaux.c
View File

@ -37,7 +37,7 @@
*/ */
#include "includes.h" #include "includes.h"
RCSID("$OpenBSD: bufaux.c,v 1.36 2005/06/17 02:44:32 djm Exp $"); RCSID("$OpenBSD: bufaux.c,v 1.37 2005/11/05 05:01:15 djm Exp $");
#include <openssl/bn.h> #include <openssl/bn.h>
#include "bufaux.h" #include "bufaux.h"
@ -63,6 +63,7 @@ buffer_put_bignum_ret(Buffer *buffer, const BIGNUM *value)
if (oi != bin_size) { if (oi != bin_size) {
error("buffer_put_bignum_ret: BN_bn2bin() failed: oi %d != bin_size %d", error("buffer_put_bignum_ret: BN_bn2bin() failed: oi %d != bin_size %d",
oi, bin_size); oi, bin_size);
xfree(buf);
return (-1); return (-1);
} }
@ -187,10 +188,12 @@ buffer_get_bignum2_ret(Buffer *buffer, BIGNUM *value)
if (len > 0 && (bin[0] & 0x80)) { if (len > 0 && (bin[0] & 0x80)) {
error("buffer_get_bignum2_ret: negative numbers not supported"); error("buffer_get_bignum2_ret: negative numbers not supported");
xfree(bin);
return (-1); return (-1);
} }
if (len > 8 * 1024) { if (len > 8 * 1024) {
error("buffer_get_bignum2_ret: cannot handle BN of size %d", len); error("buffer_get_bignum2_ret: cannot handle BN of size %d", len);
xfree(bin);
return (-1); return (-1);
} }
BN_bin2bn(bin, len, value); BN_bin2bn(bin, len, value);