tyler.durden
/
openssh-portable
mirror of https://github.com/PowerShell/openssh-portable.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix signedness bug in Cygwin code 

The Cygwin-specific pattern match code has a bug.  It checks
the size_t value returned by mbstowcs for being < 0.  The right
thing to do is to check against (size_t) -1.  Fix that.

Signed-off-by: Corinna Vinschen <vinschen@redhat.com>
This commit is contained in:
Corinna Vinschen 2022-01-21 03:22:56 +11:00 committed by Damien Miller
parent 2e5cfed513
commit 68085066b6
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
openbsd-compat/bsd-cygwin_util.c
View File

@ -194,11 +194,11 @@ _match_pattern(const char *s, const char *pattern)
size_t len; size_t len;
int ret; int ret;
if ((len = mbstowcs(NULL, s, 0)) < 0) if ((len = mbstowcs(NULL, s, 0)) == (size_t) -1)
return 0; return 0;
ws = (wchar_t *) xcalloc(len + 1, sizeof (wchar_t)); ws = (wchar_t *) xcalloc(len + 1, sizeof (wchar_t));
mbstowcs(ws, s, len + 1); mbstowcs(ws, s, len + 1);
if ((len = mbstowcs(NULL, pattern, 0)) < 0) if ((len = mbstowcs(NULL, pattern, 0)) == (size_t) -1)
return 0; return 0;
wpattern = (wchar_t *) xcalloc(len + 1, sizeof (wchar_t)); wpattern = (wchar_t *) xcalloc(len + 1, sizeof (wchar_t));
mbstowcs(wpattern, pattern, len + 1); mbstowcs(wpattern, pattern, len + 1);