From 6db780e259f985b9c88dff222eb56b4726a5a5e1 Mon Sep 17 00:00:00 2001 From: Damien Miller Date: Sun, 26 Mar 2006 13:52:20 +1100 Subject: [PATCH] - djm@cvs.openbsd.org 2006/03/19 02:23:26 [hostfile.c] FILE* leak detected by Coverity via elad AT netbsd.org; ok deraadt@ --- ChangeLog | 6 +++++- hostfile.c | 4 +++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index c2d2a365a..1093f5453 100644 --- a/ChangeLog +++ b/ChangeLog @@ -22,6 +22,10 @@ [sftp.c] more memory leaks detected by Coverity via elad AT netbsd.org; deraadt@ ok + - djm@cvs.openbsd.org 2006/03/19 02:23:26 + [hostfile.c] + FILE* leak detected by Coverity via elad AT netbsd.org; + ok deraadt@ 20060325 - OpenBSD CVS Sync @@ -4279,4 +4283,4 @@ - (djm) Trim deprecated options from INSTALL. Mention UsePAM - (djm) Fix quote handling in sftp; Patch from admorten AT umich.edu -$Id: ChangeLog,v 1.4247 2006/03/26 02:51:44 djm Exp $ +$Id: ChangeLog,v 1.4248 2006/03/26 02:52:20 djm Exp $ diff --git a/hostfile.c b/hostfile.c index 85fbcf7ce..c80578440 100644 --- a/hostfile.c +++ b/hostfile.c @@ -253,8 +253,10 @@ check_host_in_hostfile_by_key_or_type(const char *filename, if (key == NULL) { /* we found a key of the requested type */ - if (found->type == keytype) + if (found->type == keytype) { + fclose(f); return HOST_FOUND; + } continue; }