tyler.durden/openssh-portable
1
0
Fork 0
mirror of https://github.com/PowerShell/openssh-portable.git synced 2025-07-31 01:35:11 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix false positives when compiled with msan

Browse Source 
Our explicit_bzero successfully confused clang -fsanitize-memory
in to thinking that memset is never called to initialise memory.
Ensure that it is called in a way that the compiler recognises.
This commit is contained in:
Damien Miller 2016-08-16 13:28:23 +10:00
parent 6cb6dcffe1
commit 74433a19bb
1 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
openbsd-compat/explicit_bzero.c
View File

@ -7,6 +7,8 @@
#include "includes.h" #include "includes.h"
#include <string.h>
/* /*
* explicit_bzero - don't let the compiler optimize away bzero * explicit_bzero - don't let the compiler optimize away bzero
*/ */
@ -32,6 +34,17 @@ static void (* volatile ssh_bzero)(void *, size_t) = bzero;
void void
explicit_bzero(void *p, size_t n) explicit_bzero(void *p, size_t n)
{ {
/*
* clang -fsanitize=memory needs to intercept memset-like functions
* to correctly detect memory initialisation. Make sure one is called
* directly since our indirection trick above sucessfully confuses it.
*/
#if defined(__has_feature)
# if __has_feature(memory_sanitizer)
memset(p, 0, n);
# endif
#endif
ssh_bzero(p, n); ssh_bzero(p, n);
} }