tyler.durden
/
openssh-portable
mirror of https://github.com/PowerShell/openssh-portable.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

CreateProcess with CREATE_NO_WINDOW flag (#413) 

* createProcess() should spawn a new process with an invisible console window.
This commit is contained in:
bagajjal 2019-12-09 10:54:18 -08:00 committed by GitHub
parent 4ea214bf8d
commit 8cf6003bac
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
contrib/win32/win32compat/w32fd.c
View File

@ -1067,6 +1067,7 @@ spawn_child_internal(char* cmd, char *const argv[], HANDLE in, HANDLE out, HANDL
si.hStdOutput = out;
si.hStdError = err;
si.dwFlags = STARTF_USESTDHANDLES;
flags |= CREATE_NO_WINDOW;
wchar_t * t = cmdline_utf16;
do {

4
contrib/win32/win32compat/win32_pty.c
View File

@ -73,6 +73,7 @@ int exec_command_with_pty(int * pid, char* cmd, int in, int out, int err, unsign
int ret = -1;
HANDLE ttyh = (HANDLE)w32_fd_to_handle(ttyfd);
wchar_t * cmd_w = NULL;
unsigned long flags = 0;
if ((cmd_w = utf8_to_utf16(cmd)) == NULL) {
errno = ENOMEM;
@ -121,8 +122,9 @@ int exec_command_with_pty(int * pid, char* cmd, int in, int out, int err, unsign
si.hStdError = ttyh;
}
flags = CREATE_NO_WINDOW;
debug3("pty commandline: %ls", pty_cmdline);
if (CreateProcessW(NULL, pty_cmdline, NULL, NULL, TRUE, 0, NULL, NULL, &si, &pi)) {
if (CreateProcessW(NULL, pty_cmdline, NULL, NULL, TRUE, flags, NULL, NULL, &si, &pi)) {
if (register_child(pi.hProcess, pi.dwProcessId) == -1) {
TerminateProcess(pi.hProcess, 0);
CloseHandle(pi.hProcess);

2
regress/pesterTests/README.md
View File

@ -8,7 +8,7 @@ Import-Module .\openssh-portable\contrib\win32\openssh\OpenSSHTestHelper.psm1
Setup-OpenSSHTestEnvironment
```
`Setup-OpenSSHTestEnvironment` contains below parameters:
`Set-OpenSSHTestEnvironment` contains below parameters:
* `-OpenSSHBinPath`: Specify the location where ssh.exe should be picked up. If not specified, the function will prompt to user if he/she want to choose the first ssh.exe found in `$env:path` if exists.
* `-TestDataPath`: Specify the location where the test binaries deploy to. The default is `$env:SystemDrive\OpenSSHTests` if it not specified.
* `-Quiet`: If it is set, the function will do all the changes without prompting to user to confirm.