tyler.durden
/
openssh-portable
mirror of https://github.com/PowerShell/openssh-portable.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

- djm@cvs.openbsd.org 2014/03/12 04:50:32 

[auth-bsdauth.c ssh-keygen.c]
     don't count on things that accept arguments by reference to clear
     things for us on error; most things do, but it's unsafe form.
This commit is contained in:
Damien Miller 2014-04-20 13:00:11 +10:00
parent 1c7ef4be83
commit 8f9cd709c7
3 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ChangeLog
View File

@ -8,6 +8,10 @@
- djm@cvs.openbsd.org 2014/03/12 04:44:58 - djm@cvs.openbsd.org 2014/03/12 04:44:58
[ssh-keyscan.c] [ssh-keyscan.c]
scan for Ed25519 keys by default too scan for Ed25519 keys by default too
- djm@cvs.openbsd.org 2014/03/12 04:50:32
[auth-bsdauth.c ssh-keygen.c]
don't count on things that accept arguments by reference to clear
things for us on error; most things do, but it's unsafe form.
20140401 20140401
- (djm) On platforms that support it, use prctl() to prevent sftp-server - (djm) On platforms that support it, use prctl() to prevent sftp-server

7
auth-bsdauth.c
View File

@ -1,4 +1,4 @@
/* $OpenBSD: auth-bsdauth.c,v 1.11 2007/09/21 08:15:29 djm Exp $ */ /* $OpenBSD: auth-bsdauth.c,v 1.12 2014/03/12 04:50:32 djm Exp $ */
/* /*
* Copyright (c) 2001 Markus Friedl. All rights reserved. * Copyright (c) 2001 Markus Friedl. All rights reserved.
* *
@ -54,6 +54,11 @@ bsdauth_query(void *ctx, char **name, char **infotxt,
Authctxt *authctxt = ctx; Authctxt *authctxt = ctx;
char *challenge = NULL; char *challenge = NULL;
*infotxt = NULL;
*numprompts = 0;
*prompts = NULL;
*echo_on = NULL;
if (authctxt->as != NULL) { if (authctxt->as != NULL) {
debug2("bsdauth_query: try reuse session"); debug2("bsdauth_query: try reuse session");
challenge = auth_getitem(authctxt->as, AUTHV_CHALLENGE); challenge = auth_getitem(authctxt->as, AUTHV_CHALLENGE);

4
ssh-keygen.c
View File

@ -1,4 +1,4 @@
/* $OpenBSD: ssh-keygen.c,v 1.241 2014/02/05 20:13:25 naddy Exp $ */ /* $OpenBSD: ssh-keygen.c,v 1.242 2014/03/12 04:50:32 djm Exp $ */
/* /*
* Author: Tatu Ylonen <ylo@cs.hut.fi> * Author: Tatu Ylonen <ylo@cs.hut.fi>
* Copyright (c) 1994 Tatu Ylonen <ylo@cs.hut.fi>, Espoo, Finland * Copyright (c) 1994 Tatu Ylonen <ylo@cs.hut.fi>, Espoo, Finland
@ -408,7 +408,7 @@ do_convert_private_ssh2_from_blob(u_char *blob, u_int blen)
Buffer b; Buffer b;
Key *key = NULL; Key *key = NULL;
char *type, *cipher; char *type, *cipher;
u_char *sig, data[] = "abcde12345"; u_char *sig = NULL, data[] = "abcde12345";
int magic, rlen, ktype, i1, i2, i3, i4; int magic, rlen, ktype, i1, i2, i3, i4;
u_int slen; u_int slen;
u_long e; u_long e;