tyler.durden
/
openssh-portable
mirror of https://github.com/PowerShell/openssh-portable.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

upstream: Plug potential mem leak in process_put. 

It allocates abs_dst inside a loop but only frees it on exit, so free
inside the loop if necessary.  Coverity CID 291837, ok djm@

OpenBSD-Commit-ID: a01616503a185519b16f00dde25d34ceaf4ae1a3
This commit is contained in:
dtucker@openbsd.org 2023-03-29 00:59:08 +00:00 committed by Darren Tucker
parent 13ae327eae
commit c3da05d959
No known key found for this signature in database
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
sftp.c
View File

@ -1,4 +1,4 @@
/* $OpenBSD: sftp.c,v 1.230 2023/03/28 07:44:32 dtucker Exp $ */ /* $OpenBSD: sftp.c,v 1.231 2023/03/29 00:59:08 dtucker Exp $ */
/* /*
* Copyright (c) 2001-2004 Damien Miller <djm@openbsd.org> * Copyright (c) 2001-2004 Damien Miller <djm@openbsd.org>
* *
@ -769,6 +769,8 @@ process_put(struct sftp_conn *conn, const char *src, const char *dst,
goto out; goto out;
} }
free(abs_dst);
abs_dst = NULL;
if (g.gl_matchc == 1 && tmp_dst) { if (g.gl_matchc == 1 && tmp_dst) {
/* If directory specified, append filename */ /* If directory specified, append filename */
if (dst_is_dir) if (dst_is_dir)