- djm@cvs.openbsd.org 2013/05/10 04:08:01

[key.c]
     memleak in cert_free(), wasn't actually freeing the struct;
     bz#2096 from shm AT digitalsun.pl
This commit is contained in:
Darren Tucker 2013-05-16 20:26:18 +10:00
parent 7e831edbf7
commit caf0010934
2 changed files with 6 additions and 1 deletions

View File

@ -15,6 +15,10 @@
[sshconnect2.c] [sshconnect2.c]
fix bzero(ptr_to_struct, sizeof(ptr_to_struct)); bz#2100 from fix bzero(ptr_to_struct, sizeof(ptr_to_struct)); bz#2100 from
Colin Watson Colin Watson
- djm@cvs.openbsd.org 2013/05/10 04:08:01
[key.c]
memleak in cert_free(), wasn't actually freeing the struct;
bz#2096 from shm AT digitalsun.pl
20130510 20130510
- (dtucker) [configure.ac] Enable -Wsizeof-pointer-memaccess if the compiler - (dtucker) [configure.ac] Enable -Wsizeof-pointer-memaccess if the compiler

3
key.c
View File

@ -1,4 +1,4 @@
/* $OpenBSD: key.c,v 1.101 2013/04/19 01:06:50 djm Exp $ */ /* $OpenBSD: key.c,v 1.102 2013/05/10 04:08:01 djm Exp $ */
/* /*
* read_bignum(): * read_bignum():
* Copyright (c) 1995 Tatu Ylonen <ylo@cs.hut.fi>, Espoo, Finland * Copyright (c) 1995 Tatu Ylonen <ylo@cs.hut.fi>, Espoo, Finland
@ -195,6 +195,7 @@ cert_free(struct KeyCert *cert)
xfree(cert->principals); xfree(cert->principals);
if (cert->signature_key != NULL) if (cert->signature_key != NULL)
key_free(cert->signature_key); key_free(cert->signature_key);
xfree(cert);
} }
void void