From d1d41b318117258bd25f2eb2789ba3b91408bd16 Mon Sep 17 00:00:00 2001 From: Darren Tucker Date: Mon, 22 Sep 2003 21:01:27 +1000 Subject: [PATCH] - markus@cvs.openbsd.org 2003/09/18 07:56:05 [authfile.c] missing buffer_free(&encrypted); #662; zardoz at users.sf.net --- ChangeLog | 5 ++++- authfile.c | 3 ++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index ff1df7ab3..118f96c41 100644 --- a/ChangeLog +++ b/ChangeLog @@ -36,6 +36,9 @@ - markus@cvs.openbsd.org 2003/09/18 07:54:48 [buffer.c] protect against double free; #660; zardoz at users.sf.net + - markus@cvs.openbsd.org 2003/09/18 07:56:05 + [authfile.c] + missing buffer_free(&encrypted); #662; zardoz at users.sf.net 20030919 - (djm) Bug #683: Remove reference to --with-ipv4-default from INSTALL; @@ -1172,4 +1175,4 @@ - Fix sshd BindAddress and -b options for systems using fake-getaddrinfo. Report from murple@murple.net, diagnosis from dtucker@zip.com.au -$Id: ChangeLog,v 1.3025 2003/09/22 11:00:19 dtucker Exp $ +$Id: ChangeLog,v 1.3026 2003/09/22 11:01:27 dtucker Exp $ diff --git a/authfile.c b/authfile.c index 1f46093e3..83ddd635f 100644 --- a/authfile.c +++ b/authfile.c @@ -36,7 +36,7 @@ */ #include "includes.h" -RCSID("$OpenBSD: authfile.c,v 1.54 2003/05/24 09:30:39 djm Exp $"); +RCSID("$OpenBSD: authfile.c,v 1.55 2003/09/18 07:56:05 markus Exp $"); #include #include @@ -143,6 +143,7 @@ key_save_private_rsa1(Key *key, const char *filename, const char *passphrase, fd = open(filename, O_WRONLY | O_CREAT | O_TRUNC, 0600); if (fd < 0) { error("open %s failed: %s.", filename, strerror(errno)); + buffer_free(&encrypted); return 0; } if (write(fd, buffer_ptr(&encrypted), buffer_len(&encrypted)) !=