tyler.durden
/
openssh-portable
mirror of https://github.com/PowerShell/openssh-portable.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

upstream: Replace TAILQ concatenation loops with TAILQ_CONCAT 

OK djm@

OpenBSD-Commit-ID: 454b40e09a117ddb833794358970a65b14c431ef
This commit is contained in:
bket@openbsd.org 2020-06-27 13:39:09 +00:00 committed by Damien Miller
parent 14beca57ac
commit e1c401109b
1 changed files with 3 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
sshconnect2.c
View File

@ -1,4 +1,4 @@
/* $OpenBSD: sshconnect2.c,v 1.323 2020/06/05 03:24:16 djm Exp $ */ /* $OpenBSD: sshconnect2.c,v 1.324 2020/06/27 13:39:09 bket Exp $ */
/* /*
* Copyright (c) 2000 Markus Friedl. All rights reserved. * Copyright (c) 2000 Markus Friedl. All rights reserved.
* Copyright (c) 2008 Damien Miller. All rights reserved. * Copyright (c) 2008 Damien Miller. All rights reserved.
@ -1671,10 +1671,7 @@ pubkey_prepare(Authctxt *authctxt)
} }
ssh_free_identitylist(idlist); ssh_free_identitylist(idlist);
/* append remaining agent keys */ /* append remaining agent keys */
for (id = TAILQ_FIRST(&agent); id; id = TAILQ_FIRST(&agent)) { TAILQ_CONCAT(preferred, &agent, next);
TAILQ_REMOVE(&agent, id, next);
TAILQ_INSERT_TAIL(preferred, id, next);
}
authctxt->agent_fd = agent_fd; authctxt->agent_fd = agent_fd;
} }
/* Prefer PKCS11 keys that are explicitly listed */ /* Prefer PKCS11 keys that are explicitly listed */
@ -1700,10 +1697,7 @@ pubkey_prepare(Authctxt *authctxt)
} }
} }
/* append remaining keys from the config file */ /* append remaining keys from the config file */
for (id = TAILQ_FIRST(&files); id; id = TAILQ_FIRST(&files)) { TAILQ_CONCAT(preferred, &files, next);
TAILQ_REMOVE(&files, id, next);
TAILQ_INSERT_TAIL(preferred, id, next);
}
/* finally, filter by PubkeyAcceptedKeyTypes */ /* finally, filter by PubkeyAcceptedKeyTypes */
TAILQ_FOREACH_SAFE(id, preferred, next, id2) { TAILQ_FOREACH_SAFE(id, preferred, next, id2) {
if (id->key != NULL && !key_type_allowed_by_config(id->key)) { if (id->key != NULL && !key_type_allowed_by_config(id->key)) {