tyler.durden
/
openssh-portable
mirror of https://github.com/PowerShell/openssh-portable.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

memleak of buffer in sshpam_query 

coverity report via Ed Maste; ok dtucker@
This commit is contained in:
Damien Miller 2019-09-13 13:14:39 +10:00
parent c17e4638e5
commit ec0e624366
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
auth-pam.c
View File

@ -851,6 +851,7 @@ sshpam_query(void *ctx, char **name, char **info,
plen += mlen; plen += mlen;
**echo_on = (type == PAM_PROMPT_ECHO_ON); **echo_on = (type == PAM_PROMPT_ECHO_ON);
free(msg); free(msg);
sshbuf_free(buffer);
return (0); return (0);
case PAM_ERROR_MSG: case PAM_ERROR_MSG:
case PAM_TEXT_INFO: case PAM_TEXT_INFO:
@ -879,6 +880,7 @@ sshpam_query(void *ctx, char **name, char **info,
**echo_on = 0; **echo_on = 0;
ctxt->pam_done = -1; ctxt->pam_done = -1;
free(msg); free(msg);
sshbuf_free(buffer);
return 0; return 0;
} }
/* FALLTHROUGH */ /* FALLTHROUGH */
@ -905,6 +907,7 @@ sshpam_query(void *ctx, char **name, char **info,
**echo_on = 0; **echo_on = 0;
ctxt->pam_done = 1; ctxt->pam_done = 1;
free(msg); free(msg);
sshbuf_free(buffer);
return (0); return (0);
} }
error("PAM: %s for %s%.100s from %.100s", msg, error("PAM: %s for %s%.100s from %.100s", msg,
@ -916,9 +919,11 @@ sshpam_query(void *ctx, char **name, char **info,
**echo_on = 0; **echo_on = 0;
free(msg); free(msg);
ctxt->pam_done = -1; ctxt->pam_done = -1;
sshbuf_free(buffer);
return (-1); return (-1);
} }
} }
sshbuf_free(buffer);
return (-1); return (-1);
} }