tyler.durden
/
openssh-portable
mirror of https://github.com/PowerShell/openssh-portable.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

- markus@cvs.openbsd.org 2004/01/19 21:25:15 

[auth2-hostbased.c auth2-pubkey.c serverloop.c ssh-keysign.c sshconnect2.c]
     fix mem leaks; some fixes from Pete Flugstad; tested dtucker@
This commit is contained in:
Damien Miller 2004-01-21 11:02:50 +11:00
parent a04ad496f6
commit fb1310eded
6 changed files with 22 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
ChangeLog
View File

@ -20,6 +20,9 @@
fake consumption for half closed channels since the peer is waiting for fake consumption for half closed channels since the peer is waiting for
window adjust messages; bugzilla #790 Matthew Dillon; test + ok dtucker@ window adjust messages; bugzilla #790 Matthew Dillon; test + ok dtucker@
reproduce with sh -c 'ulimit -f 10; ssh host -n od /bsd | cat > foo' reproduce with sh -c 'ulimit -f 10; ssh host -n od /bsd | cat > foo'
- markus@cvs.openbsd.org 2004/01/19 21:25:15
[auth2-hostbased.c auth2-pubkey.c serverloop.c ssh-keysign.c sshconnect2.c]
fix mem leaks; some fixes from Pete Flugstad; tested dtucker@
20040114 20040114
- (dtucker) [auth-pam.c] Have monitor die if PAM authentication thread exits - (dtucker) [auth-pam.c] Have monitor die if PAM authentication thread exits
@ -1689,4 +1692,4 @@
- Fix sshd BindAddress and -b options for systems using fake-getaddrinfo. - Fix sshd BindAddress and -b options for systems using fake-getaddrinfo.
Report from murple@murple.net, diagnosis from dtucker@zip.com.au Report from murple@murple.net, diagnosis from dtucker@zip.com.au
$Id: ChangeLog,v 1.3174 2004/01/21 00:02:09 djm Exp $ $Id: ChangeLog,v 1.3175 2004/01/21 00:02:50 djm Exp $

4
auth2-hostbased.c
View File

@ -23,7 +23,7 @@
*/ */
#include "includes.h" #include "includes.h"
RCSID("$OpenBSD: auth2-hostbased.c,v 1.5 2003/06/24 08:23:46 markus Exp $"); RCSID("$OpenBSD: auth2-hostbased.c,v 1.6 2004/01/19 21:25:15 markus Exp $");
#include "ssh2.h" #include "ssh2.h"
#include "xmalloc.h" #include "xmalloc.h"
@ -114,7 +114,7 @@ userauth_hostbased(Authctxt *authctxt)
buffer_len(&b))) == 1) buffer_len(&b))) == 1)
authenticated = 1; authenticated = 1;
buffer_clear(&b); buffer_free(&b);
done: done:
debug2("userauth_hostbased: authenticated %d", authenticated); debug2("userauth_hostbased: authenticated %d", authenticated);
if (key != NULL) if (key != NULL)

4
auth2-pubkey.c
View File

@ -23,7 +23,7 @@
*/ */
#include "includes.h" #include "includes.h"
RCSID("$OpenBSD: auth2-pubkey.c,v 1.5 2003/11/04 08:54:09 djm Exp $"); RCSID("$OpenBSD: auth2-pubkey.c,v 1.6 2004/01/19 21:25:15 markus Exp $");
#include "ssh2.h" #include "ssh2.h"
#include "xmalloc.h" #include "xmalloc.h"
@ -125,7 +125,7 @@ userauth_pubkey(Authctxt *authctxt)
PRIVSEP(key_verify(key, sig, slen, buffer_ptr(&b), PRIVSEP(key_verify(key, sig, slen, buffer_ptr(&b),
buffer_len(&b))) == 1) buffer_len(&b))) == 1)
authenticated = 1; authenticated = 1;
buffer_clear(&b); buffer_free(&b);
xfree(sig); xfree(sig);
} else { } else {
debug("test whether pkalg/pkblob are acceptable"); debug("test whether pkalg/pkblob are acceptable");

14
serverloop.c
View File

@ -35,7 +35,7 @@
*/ */
#include "includes.h" #include "includes.h"
RCSID("$OpenBSD: serverloop.c,v 1.114 2003/12/09 15:28:43 markus Exp $"); RCSID("$OpenBSD: serverloop.c,v 1.115 2004/01/19 21:25:15 markus Exp $");
#include "xmalloc.h" #include "xmalloc.h"
#include "packet.h" #include "packet.h"
@ -850,7 +850,7 @@ server_input_window_size(int type, u_int32_t seq, void *ctxt)
} }
static Channel * static Channel *
server_request_direct_tcpip(char *ctype) server_request_direct_tcpip(void)
{ {
Channel *c; Channel *c;
int sock; int sock;
@ -872,14 +872,14 @@ server_request_direct_tcpip(char *ctype)
xfree(originator); xfree(originator);
if (sock < 0) if (sock < 0)
return NULL; return NULL;
c = channel_new(ctype, SSH_CHANNEL_CONNECTING, c = channel_new("direct-tcpip", SSH_CHANNEL_CONNECTING,
sock, sock, -1, CHAN_TCP_WINDOW_DEFAULT, sock, sock, -1, CHAN_TCP_WINDOW_DEFAULT,
CHAN_TCP_PACKET_DEFAULT, 0, "direct-tcpip", 1); CHAN_TCP_PACKET_DEFAULT, 0, "direct-tcpip", 1);
return c; return c;
} }
static Channel * static Channel *
server_request_session(char *ctype) server_request_session(void)
{ {
Channel *c; Channel *c;
@ -891,7 +891,7 @@ server_request_session(char *ctype)
* SSH_CHANNEL_LARVAL. Additionally, a callback for handling all * SSH_CHANNEL_LARVAL. Additionally, a callback for handling all
* CHANNEL_REQUEST messages is registered. * CHANNEL_REQUEST messages is registered.
*/ */
c = channel_new(ctype, SSH_CHANNEL_LARVAL, c = channel_new("session", SSH_CHANNEL_LARVAL,
-1, -1, -1, /*window size*/0, CHAN_SES_PACKET_DEFAULT, -1, -1, -1, /*window size*/0, CHAN_SES_PACKET_DEFAULT,
0, "server-session", 1); 0, "server-session", 1);
if (session_open(the_authctxt, c->self) != 1) { if (session_open(the_authctxt, c->self) != 1) {
@ -920,9 +920,9 @@ server_input_channel_open(int type, u_int32_t seq, void *ctxt)
ctype, rchan, rwindow, rmaxpack); ctype, rchan, rwindow, rmaxpack);
if (strcmp(ctype, "session") == 0) { if (strcmp(ctype, "session") == 0) {
c = server_request_session(ctype); c = server_request_session();
} else if (strcmp(ctype, "direct-tcpip") == 0) { } else if (strcmp(ctype, "direct-tcpip") == 0) {
c = server_request_direct_tcpip(ctype); c = server_request_direct_tcpip();
} }
if (c != NULL) { if (c != NULL) {
debug("server_input_channel_open: confirm %s", ctype); debug("server_input_channel_open: confirm %s", ctype);

3
ssh-keysign.c
View File

@ -22,7 +22,7 @@
* THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/ */
#include "includes.h" #include "includes.h"
RCSID("$OpenBSD: ssh-keysign.c,v 1.14 2003/11/17 09:45:39 djm Exp $"); RCSID("$OpenBSD: ssh-keysign.c,v 1.15 2004/01/19 21:25:15 markus Exp $");
#include <openssl/evp.h> #include <openssl/evp.h>
#include <openssl/rand.h> #include <openssl/rand.h>
@ -126,6 +126,7 @@ valid_request(struct passwd *pw, char *host, Key **ret, u_char *data,
/* end of message */ /* end of message */
if (buffer_len(&b) != 0) if (buffer_len(&b) != 0)
fail++; fail++;
buffer_free(&b);
debug3("valid_request: fail %d", fail); debug3("valid_request: fail %d", fail);

8
sshconnect2.c
View File

@ -23,7 +23,7 @@
*/ */
#include "includes.h" #include "includes.h"
RCSID("$OpenBSD: sshconnect2.c,v 1.133 2003/11/21 11:57:03 djm Exp $"); RCSID("$OpenBSD: sshconnect2.c,v 1.134 2004/01/19 21:25:15 markus Exp $");
#include "openbsd-compat/sys-queue.h" #include "openbsd-compat/sys-queue.h"
@ -1267,7 +1267,7 @@ ssh_keysign(Key *key, u_char **sigp, u_int *lenp,
if (ssh_msg_recv(from[0], &b) < 0) { if (ssh_msg_recv(from[0], &b) < 0) {
error("ssh_keysign: no reply"); error("ssh_keysign: no reply");
buffer_clear(&b); buffer_free(&b);
return -1; return -1;
} }
close(from[0]); close(from[0]);
@ -1279,11 +1279,11 @@ ssh_keysign(Key *key, u_char **sigp, u_int *lenp,
if (buffer_get_char(&b) != version) { if (buffer_get_char(&b) != version) {
error("ssh_keysign: bad version"); error("ssh_keysign: bad version");
buffer_clear(&b); buffer_free(&b);
return -1; return -1;
} }
*sigp = buffer_get_string(&b, lenp); *sigp = buffer_get_string(&b, lenp);
buffer_clear(&b); buffer_free(&b);
return 0; return 0;
} }