f61f29afda
make unittests pass for no-openssl case
2019-09-08 10:37:17 +10:00
1268f0bcd8
upstream: Check for RSA support before using it for the user key,
...
otherwise use ed25519 which is supported when built without OpenSSL.
OpenBSD-Regress-ID: 3d23ddfe83c5062f00ac845d463f19a2ec78c0f7
2019-09-06 14:37:23 +10:00
8b57337c1c
update fuzzing makefile to more recent clang
2019-09-05 15:46:39 +10:00
ae631ad77d
fuzzer for sshsig allowed_signers option parsing
2019-09-05 15:46:11 +10:00
f4846dfc6a
Fuzzer harness for sshsig
2019-09-05 14:26:39 +10:00
b08a6bc1cc
oops; missed including the actual file
2019-09-03 18:45:42 +10:00
6d6427d013
upstream: regress test for sshsig; feedback and ok markus@
...
OpenBSD-Regress-ID: 74c0974f2cdae8d9599b9d76a09680bae55d8a8b
2019-09-03 18:42:22 +10:00
59650f0eaf
upstream: only add plain keys to prevent any certs laying around
...
from confusing the test.
OpenBSD-Regress-ID: b8f1508f822bc560b98dea910e61ecd76f34100f
2019-09-03 18:42:14 +10:00
e50f808712
upstream: Use ed25519 for most hostkey rotation tests since it's
...
supported even when built without OpenSSL. Use RSA for the secondary type
test if supported, otherwise skip it. Fixes this test for !OpenSSL builds.
OpenBSD-Regress-ID: 101cb34a84fd974c623bdb2e496f25a6e91be109
2019-08-30 15:56:42 +10:00
c4ffb72593
upstream: fix some memleaks in test_helper code
...
bz#3037 from Jitendra Sharma
OpenBSD-Regress-ID: 71440fa9186f5842a65ce9a27159385c6cb6f751
2019-08-02 11:42:26 +10:00
d31e7c937b
upstream: Restrict limit-keytype to types supported by build. This
...
means we have to skip a couple tests when only one key type is supported.
OpenBSD-Regress-ID: 22d05befb9c7ce21ce8dc22acf1ffe9e2ef2e95e
2019-07-26 14:51:25 +10:00
0967a233b8
Remove override disabling DH-GEX.
...
The DH-GEX override doesn't work when build without OpenSSL, and
we'll prefer curve25519 these days, removing the need for it.
2019-07-25 20:11:45 +10:00
061407efc1
upstream: Only use supported key types during KRL test, preferring
...
ed25519 since it's supported by both OpenSSL and non-OpenSSL builds.
OpenBSD-Regress-ID: 9f2bb3eadd50fcc8245b1bd8fd6f0e53602f71aa
2019-07-25 20:09:06 +10:00
47f8ff1fa5
upstream: Switch keys-command test from rsa to ed25519 since it's
...
supported for both OpenSSL and non-OpenSSL builds.
OpenBSD-Regress-ID: 174be4be876edd493e4a5c851e5bc579885e7a0a
2019-07-25 20:01:19 +10:00
1e94afdfa8
upstream: Make certificate tests work with the supported key
...
algorithms. Allows tests to pass when built without OpenSSL.
OpenBSD-Regress-ID: 617169a6dd9d06db3697a449d9a26c284eca20fc
2019-07-25 20:01:19 +10:00
26bf693661
upstream: Construct list of key types to test based on the types
...
supported by the binaries.
OpenBSD-Regress-ID: fcbd115efacec8ab0ecbdb3faef79ac696cb1d62
2019-07-24 16:51:17 +10:00
773c55b3d1
upstream: Only use DSA key type in tests if binaries support it.
...
OpenBSD-Regress-ID: 770e31fe61dc33ed8eea9c04ce839b33ddb4dc96
2019-07-24 16:47:58 +10:00
159e987a54
Split test targets further.
...
Splits test into file-tests, t-exec, unit and interop-tests and their
respective dependencies. Should allow running any set individually
without having to build the other dependencies that are not needed
for that specific test.
2019-07-24 14:21:19 +10:00
7cdf9fdcf1
upstream: Skip DH group generation test if binaries don't support
...
DH-GEX.
OpenBSD-Regress-ID: 7c918230d969ecf7656babd6191a74526bffbffd
2019-07-23 22:51:22 +10:00
3a3eab8bb0
upstream: Only test conversion of key types supported by the
...
binaries.
OpenBSD-Regress-ID: e3f0938a0a7407e2dfbb90abc3ec979ab6e8eeea
2019-07-23 22:51:22 +10:00
7e66b7d98c
upstream: Only add ssh-dss to allowed key types if it's supported
...
by the binary.
OpenBSD-Regress-ID: 395a54cab16e9e4ece9aec047ab257954eebd413
2019-07-23 22:51:22 +10:00
2e6035b900
Rename valgrind "errors" to "failures".
...
When valgrind is enabled, test-exec.sh counts the number of invocations
that valgrind detects failures in, not the total number of errors detected.
This makes the name to be more accurate.
2019-07-23 08:11:22 +10:00
e82c9bb9ff
Skip running sftp-chroot under Valgrind.
2019-07-20 22:14:46 +10:00
41e22c2e05
upstream: Remove the sleeps and thus races from the forwarding
...
test. They were originally required to work with Protocol 1, but now we can
use ssh -N and the control socket without the sleeps. While there, suppress
output fro the control exit commands.
OpenBSD-Regress-ID: 4c51a1d651242f12c90074c18c61008a74c1c790
2019-07-20 22:13:40 +10:00
0423043c5e
upstream: Allow SLEEPTIME to be overridden.
...
OpenBSD-Regress-ID: 1596ab168729954be3d219933b2d01cc93687e76
2019-07-20 22:12:24 +10:00
d466b6a5cf
upstream: Move sleep time into a variable so that we can increase
...
it for platforms or configurations that are much slower then usual.
OpenBSD-Regress-ID: 88586cabc800062c260d0b876bdcd4ca3f58a872
2019-07-20 22:11:00 +10:00
b4a7c9d2b5
upstream: add regression tests for scp for out-of-destination path file
...
creation by Harry Sintonen via Jakub Jelen in bz3007
OpenBSD-Regress-ID: 01ae5fbc6ce400b2df5a84dc3152a9e31f354c07
2019-07-19 13:53:27 +10:00
65333f7454
Show when skipping valgrind for a test.
2019-07-19 13:16:11 +10:00
fccb7eb343
Enable connect-privsep test with valgrind.
...
connect-privsep seems to work OK with valgrind now so don't skip
valgrind on it.
2019-07-19 10:41:56 +10:00
d742301726
Show valgrind results and error counts.
2019-07-19 07:43:07 +10:00
a192021fed
Fail tests if Valgrind enabled and reports errors.
...
Also dump the failing valgrind report to stdout (not the cleanest
solution, but better than nothing).
2019-07-18 11:09:38 +10:00
d1c491ecb9
Allow low-priv tests to write to pipe dir.
...
When running regression tests with Valgrind and SUDO, the low-priv agent
tests need to be able to create pipes in the appropriate directory.
2019-07-18 10:17:54 +10:00
8a5bb3e781
Put valgrind vgdb files to a specific directory.
...
Valgrind by default puts vgdb files and pipes under /tmp, however it
is not always able to clean them up, which can cause test failures when
there's a pid/file collision. Using a specific directory ensures that
we can clean up and start clean.
2019-07-17 21:24:55 +10:00
f8829fe57f
upstream: adapt to sshbuf_dtob64() change
...
OpenBSD-Regress-ID: 82374a83edf0955fd1477169eee3f5d6467405a6
2019-07-17 11:04:25 +10:00
1254fcbb2f
upstream: Remove ssh1 files from CLEANFILES since ssh1 no longer
...
supported.
OpenBSD-Regress-ID: 5b9ae869dc669bac05939b4a2fdf44ee067acfa0
2019-07-17 11:04:25 +10:00
9dc81a5ada
upstream: Update names of host key files in CLEANFILES to match
...
recent changes to the tests.
OpenBSD-Regress-ID: 28743052de3acf70b06f18333561497cd47c4ecf
2019-07-17 11:02:42 +10:00
477e2a3be8
upstream: unit tests for sshbuf_cmp() and sshbuf_find(); ok markus
...
OpenBSD-Regress-ID: b52d36bc3ab6dc158c1e59a9a4735f821cf9e1fd
2019-07-15 23:21:18 +10:00
bc551dfebb
Clear valgrind-out dir to prevent collisions.
2019-07-15 12:52:45 +10:00
5db9ba718e
Allow agent tests to write to valgrind dir.
2019-07-15 12:02:27 +10:00
121e48fa53
upstream: unit tests for sshbuf_peek/poke bounds-checked random access
...
functions. ok markus@
OpenBSD-Regress-ID: 034c4284b1da6b12e25c762a6b958efacdafbaef
2019-07-15 09:39:42 +10:00
e187b1d460
upstream: Add (recently added) rsa_oldfmt to CLEANFILES.
...
OpenBSD-Regress-ID: 405beda94e32aa6cc9c80969152fab91f7c54bd3
2019-07-05 15:08:14 +10:00
74b541bfab
upstream: Adapt the PuTTY/Conch tests to new key names.
...
A recent regress change (2a9b3a2ce4
2019-07-05 15:07:55 +10:00
de08335a4c
upstream: Add a sleep to allow forwards to come up.
...
Currently when the multiplex client requests a forward it returns
once the request has been sent but not necessarily when the forward
is up. This causes intermittent text failures due to this race,
so add some sleeps to mitigate this until we can fix it properly.
OpenBSD-Regress-ID: 384c7d209d2443d25ea941d7f677e932621fb253
2019-07-05 15:06:04 +10:00
4d24928472
Remove nc stderr redirection to resync w/OpenBSD.
2019-07-05 14:58:57 +10:00
58ceacdcba
Update README doc to include missing test cases
...
Readme regress document is missing various individual tests,
which are supported currently. Update README to
include those test cases.
2019-06-27 20:54:14 +10:00
1dfadb9b57
upstream: adapt for key shielding API changes (const removal)
...
OpenBSD-Regress-ID: 298890bc52f0cd09dba76dc1022fabe89bc0ded6
2019-06-21 14:24:44 +10:00
99bcbbc77f
upstream: check for convtime() refusing to accept times that
...
resolve to LONG_MAX Reported by Kirk Wolf bz2977; ok dtucker
OpenBSD-Regress-ID: 15c9fe87be1ec241d24707006a31123d3a3117e0
2019-06-19 12:21:40 +10:00
e5cccb2410
upstream: Add unit tests for user@host and URI parsing.
...
OpenBSD-Regress-ID: 69d5b6f278e04ed32377046f7692c714c2d07a68
2019-06-19 12:21:40 +10:00
0bb7e38834
upstream: Add tests for sshd -T -C with Match.
...
OpenBSD-Regress-ID: d4c34916fe20d717692f10ef50b5ae5a271c12c7
2019-06-19 12:21:23 +10:00
342d6e5158
Adjust softhsm2 path on Fedora Linux for regress
...
The SoftHSM lives in Fedora in /usr/lib64/pkcs11/libsofthsm2.so
2019-03-29 22:37:15 +11:00
786cd4c183
drop old Cygwin considerations
...
- Cygwin supports non-DOS characters in filenames
- Cygwin does not support Windows XP anymore
Signed-off-by: Corinna Vinschen <vinschen@redhat.com>
2019-03-28 09:23:46 +11:00
19a0f0529d
upstream: The test sshd_config in in $OBJ.
...
OpenBSD-Regress-ID: 1e5d908a286d8e7de3a15a0020c8857f3a7c9172
2019-01-28 19:01:01 +11:00
8fe2544020
upstream: Remove leftover debugging.
...
OpenBSD-Regress-ID: 3d86c3d4867e46b35af3fd2ac8c96df0ffdcfeb9
2019-01-28 14:41:11 +11:00
e30d32364d
upstream: Enable ssh-dss for the agent test. Disable it for the
...
certificate test.
OpenBSD-Regress-ID: 388c1e03e1def539d350f139b37d69f12334668d
2019-01-28 11:34:22 +11:00
ffdde469ed
upstream: Count the number of key types instead of assuming there
...
are only two.
OpenBSD-Regress-ID: 0998702c41235782cf0beee396ec49b5056eaed9
2019-01-28 11:34:22 +11:00
2a9b3a2ce4
upstream: Generate all key supported key types and enable for keyscan
...
test.
OpenBSD-Regress-ID: 72f72ff49946c61bc949e1692dd9e3d71370891b
2019-01-27 17:40:42 +11:00
49d8c8e214
upstream: adapt to changes in KEX APIs and file removals
...
OpenBSD-Regress-ID: 54d6857e7c58999c7a6d40942ab0fed3529f43ca
2019-01-21 23:51:29 +11:00
35ecc53a83
upstream: adapt to changes in KEX API and file removals
...
OpenBSD-Regress-ID: 92cad022d3b0d11e08f3e0055d6a14b8f994c0d7
2019-01-21 23:41:21 +11:00
7d69aae64c
upstream: adapt to bignum1 API removal and bignum2 API change
...
OpenBSD-Regress-ID: cea6ff270f3d560de86b355a87a2c95b55a5ca63
2019-01-21 23:38:30 +11:00
beab553f0a
upstream: remove hack to use non-system libcrypto
...
OpenBSD-Regress-ID: ce72487327eee4dfae1ab0212a1f33871fe0809f
2019-01-21 23:38:10 +11:00
ba58a529f4
make agent-pkcs11 search harder for softhsm2.so
2019-01-21 13:09:23 +11:00
3c0c657ed7
upstream: allow override of ssh-pkcs11-helper binary via
...
$TEST_SSH_SSHPKCS11HELPER from markus@
OpenBSD-Regress-ID: 7382a3d76746f5a792d106912a5819fd5e49e469
2019-01-21 11:51:54 +11:00
760ae37b45
upstream: adapt agent-pkcs11.sh test to softhsm2 and add support
...
for ECDSA keys
work by markus@, ok djm@
OpenBSD-Regress-ID: 1ebc2be0e88eff1b6d8be2f9c00cdc60723509fe
2019-01-21 11:51:54 +11:00
b2ce8b31a1
upstream: add "extra:" target to run some extra tests that are not
...
enabled by default (currently includes agent-pkcs11.sh); from markus@
OpenBSD-Regress-ID: 9a969e1adcd117fea174d368dcb9c61eb50a2a3c
2019-01-21 11:51:54 +11:00
9b655dc9c9
last bits of old packet API / active_state global
2019-01-20 14:55:27 +11:00
609644027d
upstream: regress bits for banner processing refactor (this test was
...
depending on ssh returning a particular error message for banner parsing
failure)
reminded by bluhm@
OpenBSD-Regress-ID: f24fc303d40931157431df589b386abf5e1be575
2019-01-17 16:27:05 +11:00
eb347d086c
upstream: ssh_packet_set_state() now frees ssh->kex implicitly, so
...
don't do explicit kex_free() beforehand
OpenBSD-Regress-ID: f2f73bad47f62a2040ccba0a72cadcb12eda49cf
2018-12-27 14:39:53 +11:00
bb542f0cf6
upstream: remove unused and problematic sudo clean. ok espie
...
OpenBSD-Regress-ID: ca90c20a15a85b661e13e98b80c10e65cd662f7b
2018-12-27 14:39:53 +11:00
4da58d5873
upstream: Remove now-unneeded ifdef SIGINFO around handler since it is
...
now always used for SIGUSR1 even when SIGINFO is not defined. This will make
things simpler in -portable.
OpenBSD-Regress-ID: 4ff0265b335820b0646d37beb93f036ded0dc43f
2018-11-23 14:42:07 +11:00
deb51552c3
Resync with OpenBSD by pulling in an ifdef SIGINFO.
2018-11-23 11:34:21 +11:00
42c5ec4b97
refactor libcrypto initialisation
...
Don't call OpenSSL_add_all_algorithms() unless OpenSSL actually
supports it.
Move all libcrypto initialisation to a single function, and call that
from seed_rng() that is called early in each tool's main().
Prompted by patch from Rosen Penev
2018-11-23 10:42:05 +11:00
5b60b6c020
upstream: Output info on SIGUSR1 as well as
...
SIGINFO to resync with portable. (ID sync only).
OpenBSD-Regress-ID: 699d153e2de22dce51a1b270c40a98472d1a1b16
2018-11-22 21:01:01 +11:00
e4ae345dc7
upstream: Append pid to temp files in /var/run and set a cleanup
...
trap for them. This allows multiple instances of tests to run without
colliding.
OpenBSD-Regress-ID: 57add105ecdfc54752d8003acdd99eb68c3e0b4c
2018-11-22 20:58:27 +11:00
f72d0f52ef
upstream: UsePrivilegeSeparation no is deprecated
...
test "yes" and "sandbox".
OpenBSD-Regress-ID: 80e685ed8990766527dc629b1affc09a75bfe2da
2018-11-22 16:24:20 +11:00
35d0e5fefc
upstream: add some knobs:
...
UNITTEST_FAST?= no # Skip slow tests (e.g. less intensive fuzzing).
UNITTEST_SLOW?= no # Include slower tests (e.g. more intensive fuzzing).
UNITTEST_VERBOSE?= no # Verbose test output (inc. per-test names).
useful if you want to run the tests as a smoke test to exercise the
functionality without waiting for all the fuzzers to run.
OpenBSD-Regress-ID: e04d82ebec86068198cd903acf1c67563c57315e
2018-11-22 16:14:31 +11:00
c1941293d9
Resync Makefile.inc with upstream.
...
It's unused in -portable, but having it out of sync makes other syncs
fail to apply.
2018-11-22 16:02:46 +11:00
4488ae1a69
really add source for authopt_fuzz this time
2018-09-15 19:36:55 +10:00
9201784b4a
remove accidentally checked-in authopt_fuzz binary
2018-09-15 19:35:40 +10:00
6bc5a24ac8
fuzzer harness for authorized_keys option parsing
2018-09-14 15:17:08 +10:00
0aa1f23084
allow SIGUSR1 as synonym for SIGINFO
...
Lets users on those unfortunate operating systems that lack SIGINFO
still be able to obtain progress information from unit tests :)
2018-09-14 10:31:47 +10:00
d64e785265
add compat header
2018-09-13 19:05:48 +10:00
a3fd8074e2
upstream: missed a bit of openssl-1.0.x API in this unittest
...
OpenBSD-Regress-ID: a73a54d7f7381856a3f3a2d25947bee7a9a5dbc9
2018-09-13 19:04:10 +10:00
86e0a9f3d2
upstream: use only openssl-1.1.x API here too
...
OpenBSD-Regress-ID: ae877064597c349954b1b443769723563cecbc8f
2018-09-13 15:08:27 +10:00
86112951d6
forgot to stage these test files in commit d70d061
2018-09-13 12:12:42 +10:00
d70d061828
upstream: Include certs with multiple RSA signature variants in
...
test data Ensure that cert->signature_key is populated correctly
OpenBSD-Regress-ID: 56e68f70fe46cb3a193ca207385bdb301fd6603a
2018-09-12 16:51:36 +10:00
f803b26829
upstream: test revocation by explicit hash and by fingerprint
...
OpenBSD-Regress-ID: 079c18a9ab9663f4af419327c759fc1e2bc78fd8
2018-09-12 16:51:14 +10:00
2de78bc7da
upstream: s/sshkey_demote/sshkey_from_private/g
...
OpenBSD-Regress-ID: 782bde7407d94a87aa8d1db7c23750e09d4443c4
2018-09-12 16:51:14 +10:00
9617816dbe
document some more regress control env variables
...
Specifically SKIP_UNIT, USE_VALGRING and LTESTS. Sort the list of
environment variables.
Based on patch from Jakub Jelen
2018-08-27 13:08:01 +10:00
71508e06fa
shorten temporary SSH_REGRESS_TMP path
...
Previous path was exceeding max socket length on at least one platform (OSX)
2018-08-23 15:41:42 +10:00
829fc28a9c
Missing unistd.h for regress/mkdtemp.c
2018-08-20 15:57:29 +10:00
2f4766ceef
upstream: The script that cooks up PuTTY format host keys does not
...
understand the new key format so convert back to old format to create the
PuTTY key and remove it once done.
OpenBSD-Regress-ID: 2a449a18846c3a144bc645135b551ba6177e38d3
2018-08-10 11:40:21 +10:00
149cab325a
Include stdarg.h in mkdtemp for va_list.
2018-07-27 13:46:06 +10:00
c59aca8adb
Create control sockets in clean temp directories
...
Adds a regress/mkdtemp tool and uses it to create empty temp
directories for tests needing control sockets.
Patch from Colin Watson via bz#2660; ok dtucker
2018-07-20 14:55:29 +10:00
2f131e1b34
upstream: memleak in unittest; found by valgrind
...
OpenBSD-Regress-ID: 168c23b0fb09fc3d0b438628990d3fd9260a8a5e
2018-07-16 13:12:28 +10:00
7449c178e9
upstream: make this use ssh_proxy rather than starting/stopping a
...
daemon for each testcase
OpenBSD-Regress-ID: 608b7655ea65b1ba8fff5a13ce9caa60ef0c8166
2018-07-13 12:14:38 +10:00
dbab02f920
upstream: fix leaks in unit test; with this, all unit tests are
...
leak free (as far as valgrind can spot anyway)
OpenBSD-Regress-ID: b824d8b27998365379963440e5d18b95ca03aa17
2018-07-13 12:14:38 +10:00
2f6accff50
Enable leak checks for unit tests with valgrind
...
Leave the leak checking on unconditionally when running with valgrind.
The unit tests are leak-free and I want them to stay that way.
2018-07-13 11:41:33 +10:00
e46cfbd9db
increase timeout to match cfgmatch.sh
...
lets test pass under valgrind (on my workstation at least)
2018-07-13 11:41:33 +10:00
fccfa239de
VALGRIND_CHECK_LEAKS logic was backwards :(
2018-07-11 10:19:56 +10:00
d20720d373
disable valgrind memleak checking by default
...
Add VALGRIND_CHECK_LEAKS knob to turn it back on.
2018-07-11 09:57:44 +10:00
Damien Miller
dtucker@openbsd.org
djm@openbsd.org
Darren Tucker
Jitendra Sharma
Jakub Jelen
Corinna Vinschen
tedu@openbsd.org