Commit Graph

4991 Commits

Author SHA1 Message Date
Damien Miller 03c618afa3 - otto@cvs.openbsd.org 2005/11/25 08:06:25
[openbsd-compat/sys-queue.h]
     Introduce debugging aid for queue macros. Disabled by default; but
     developers are encouraged to run with this enabled.
     ok krw@ fgsch@ deraadt@
2007-10-26 16:45:32 +10:00
Damien Miller 300f95fccb - otto@cvs.openbsd.org 2005/10/25 06:37:47
[openbsd-compat/sys-queue.h]
     Some uvm problem is being exposed with the more strict macros.
     Revert until we've found out what's causing the panics.
2007-10-26 16:44:27 +10:00
Damien Miller 0b6a21d468 - otto@cvs.openbsd.org 2005/10/24 20:25:14
[openbsd-compat/sys-queue.h]
     Partly backout. NOLIST, used in LISTs is probably interfering.
     requested by deraadt@
2007-10-26 16:43:22 +10:00
Damien Miller 9aeef6b50d - otto@cvs.openbsd.org 2005/10/17 20:19:42
[openbsd-compat/sys-queue.h]
     Performing certain operations on queue.h data structurs produced
     funny results.  An example is calling  LIST_REMOVE on the same
     element twice. This will not fail, but result in a data structure
     referencing who knows what. Prevent these accidents by NULLing some
     fields on remove and replace. This way, either a panic or segfault
     will be produced on the faulty operation.
2007-10-26 16:42:18 +10:00
Damien Miller d129ecb0f9 - deraadt@cvs.openbsd.org 2005/02/25 13:29:30
[openbsd-compat/sys-queue.h]
     minor white spacing
2007-10-26 16:41:14 +10:00
Damien Miller b99f5f714b - grange@cvs.openbsd.org 2004/05/04 16:59:32
[openbsd-compat/sys-queue.h]
     Remove useless ``elm'' argument from the SIMPLEQ_REMOVE_HEAD macro.
     This matches our SLIST behaviour and NetBSD's SIMPLEQ as well.
     ok millert krw deraadt
2007-10-26 16:40:20 +10:00
Damien Miller 0afeae426c - tdeval@cvs.openbsd.org 2004/11/24 18:10:42
[openbsd-compat/sys-tree.h]
     typo
2007-10-26 16:39:05 +10:00
Damien Miller 88aa4e3d61 - frantzen@@cvs.openbsd.org 2004/04/24 18:11:46
[openbsd-compat/tree.h]
     sync to Niels Provos' version.  avoid unused variable warning in
     RB_NEXT()
2007-10-26 16:37:43 +10:00
Damien Miller 2f715eeb5c - jakob@cvs.openbsd.org 2007/10/11 18:36:41
[openbsd-compat/getrrsetbyname.c openbsd-compat/getrrsetbyname.h]
     use RRSIG instead of SIG for DNSSEC. ok djm@
2007-10-26 16:26:46 +10:00
Damien Miller 1651f6c40e - otto@cvs.openbsd.org 2006/10/21 09:55:03
[openbsd-compat/base64.c]
     remove calls to abort(3) that can't happen anyway; from
     <bret dot lambert at gmail.com>; ok millert@ deraadt@
2007-10-26 16:17:24 +10:00
Damien Miller a97529fa2e - (djm) [openbsd-compat/bindresvport.c]
Sync RCS ID after irrelevant (for portable OpenSSH) header shuffling
2007-10-26 16:16:09 +10:00
Damien Miller 9ed5643491 - jakob@cvs.openbsd.org 2007/10/11 18:36:41
[openbsd-compat/getrrsetbyname.c]
     use RRSIG instead of SIG for DNSSEC. ok djm@
2007-10-26 16:14:46 +10:00
Damien Miller 9c51c8d81a - deraadt@cvs.openbsd.org 2005/11/28 17:50:12
[openbsd-compat/glob.c]
     unused arg in internal static API
2007-10-26 16:13:39 +10:00
Damien Miller 89437edafd - (djm) [regress/sftp-cmds.sh]
Use more restrictive glob to pick up test files from /bin - some platforms
   ship broken symlinks there which could spoil the test.
2007-10-26 15:37:50 +10:00
Damien Miller da1e4bd3bf - djm@cvs.openbsd.org 2007/10/26 05:30:01
[regress/sftp-glob.sh regress/test-exec.sh]
     remove "echo -E" crap that I added in last commit and use printf(1) for
     cases where we strictly require echo not to reprocess escape characters.
2007-10-26 15:35:54 +10:00
Damien Miller ce0e60ee57 - djm@cvs.openbsd.org 2007/10/24 03:32:35
[regress/sftp-cmds.sh regress/sftp-glob.sh regress/test-exec.sh]
     comprehensive tests for sftp escaping its interaction with globbing;
     ok dtucker@
2007-10-26 14:54:12 +10:00
Damien Miller 47d7dc8530 - pvalchev@cvs.openbsd.org 2007/06/07 19:41:46
[regress/cipher-speed.sh regress/try-ciphers.sh]
     test umac-64@openssh.com
     ok djm@
2007-10-26 14:45:57 +10:00
Damien Miller 80ba1300e2 - dtucker@cvs.openbsd.org 2006/12/13 08:36:36
[regress/cfgmatch.sh]
     Additional test for multiple PermitOpen entries.  ok djm@
2007-10-26 14:45:13 +10:00
Damien Miller 99ad35352a - markus@cvs.openbsd.org 2006/11/06 09:27:43
[regress/cfgmatch.sh]
     fix quoting for non-(c)sh login shells.
2007-10-26 14:44:34 +10:00
Damien Miller fa66aa739f - djm@cvs.openbsd.org 2006/08/29 09:44:00
[regress/sftp-cmds.sh]
     clean up our mess
2007-10-26 14:43:50 +10:00
Damien Miller 77d57b06a4 - djm@cvs.openbsd.org 2007/10/24 03:44:02
[scp.c]
     factor out network read/write into an atomicio()-like function, and
     use it to handle short reads, apply bandwidth limits and update
     counters. make network IO non-blocking, so a small trickle of
     reads/writes has a chance of updating the progress meter; bz #799
     ok dtucker@
2007-10-26 14:28:01 +10:00
Damien Miller 1cbc292bc0 - djm@cvs.openbsd.org 2007/10/24 03:30:02
[sftp.c]
     rework argument splitting and parsing to cope correctly with common
     shell escapes and make handling of escaped characters consistent
     with sh(1) and between sftp commands (especially between ones that
     glob their arguments and ones that don't).
     parse command flags using getopt(3) rather than hand-rolled parsers.
     ok dtucker@
2007-10-26 14:27:45 +10:00
Damien Miller 5a4456c6a5 - markus@cvs.openbsd.org 2007/10/22 19:10:24
[readconf.c]
     make sure that both the local and remote port are correct when
     parsing -L; Jan Pechanec (bz #1378)
2007-10-26 14:27:22 +10:00
Damien Miller 3dddab3b95 - chl@cvs.openbsd.org 2007/10/02 17:49:58
[ssh-keygen.c]
     handles zero-sized strings that fgets can return
     properly removes trailing newline
     removes an unused variable
     correctly counts line number
     "looks ok" ray@ markus@
2007-10-26 14:27:02 +10:00
Damien Miller 0f4ed693d6 - chl@cvs.openbsd.org 2007/10/02 17:49:58
[ssh-keygen.c]
     handles zero-sized strings that fgets can return
2007-10-26 14:26:32 +10:00
Damien Miller b8c9807628 - dtucker@cvs.openbsd.org 2007/09/29 00:25:51
[auth2.c]
     Remove unused prototype.  ok djm@
2007-10-26 14:26:15 +10:00
Damien Miller 603077ab4c - ray@cvs.openbsd.org 2007/09/27 00:15:57
[dh.c]
     Don't return -1 on error in dh_pub_is_valid(), since it evaluates
     to true.
     Also fix a typo.
     Initial diff from Matthew Dempsky, input from djm.
     OK djm, markus.
2007-10-26 14:25:55 +10:00
Damien Miller 4c7728c651 - canacar@cvs.openbsd.org 2007/09/25 23:48:57
[ssh-agent.c]
     When adding a key that already exists, update the properties
     (time, confirm, comment) instead of discarding them. ok djm@ markus@
2007-10-26 14:25:31 +10:00
Damien Miller 733124b5dd - djm@cvs.openbsd.org 2007/09/21 08:15:29
[auth-bsdauth.c auth-passwd.c auth.c auth.h auth1.c auth2-chall.c]
     [monitor.c monitor_wrap.c]
     unifdef -DBSD_AUTH
     unifdef -USKEY
     These options have been in use for some years;
     ok markus@ "no objection" millert@
     (NB. RCD ID sync only for portable)
2007-10-26 14:25:12 +10:00
Damien Miller cfb606cd5f - djm@cvs.openbsd.org 2007/09/21 03:05:23
[ssh_config.5]
     document KbdInteractiveAuthentication in ssh_config.5;
     patch from dkg AT fifthhorseman.net
2007-10-26 14:24:48 +10:00
Damien Miller 32a9dba66d - stevesk@cvs.openbsd.org 2007/09/11 23:49:09
[sshpty.c]
     remove #if defined block not needed; ok markus@ dtucker@
     (NB. RCD ID sync only for portable)
2007-10-26 14:24:30 +10:00
Darren Tucker bc1bd9dbe3 - (dtucker) [configure.ac defines.h] Shadow expiry does not work on QNX6
so disable it for that platform.  From bacon at cs nyu edu.
2007-09-27 07:03:20 +10:00
Darren Tucker 7c92a65a1d - (dtucker) [configure.ac atomicio.c] Fall back to <sys/poll.h> if we don't
have <poll.h> (eq QNX).  From bacon at cs nyu edu.
2007-09-27 07:00:09 +10:00
Damien Miller ed626b42cc - (djm) [atomicio.c] Fix spin avoidance for platforms that define
EWOULDBLOCK; patch from ben AT psc.edu
2007-09-21 13:12:49 +10:00
Tim Rice 6ebefac25a - (tim) [defines.h] Fix regression in long password support on OpenServer 6.
Problem report and additional testing rac AT tenzing.org.
2007-09-17 08:32:32 -07:00
Damien Miller 8b3fdfb6af - djm@cvs.openbsd.org 2007/09/16 00:55:52
[sftp-client.c]
     use off_t instead of u_int64_t for file offsets, matching what the
     progressmeter code expects; bz #842
2007-09-17 16:12:03 +10:00
Damien Miller 35e18dba89 - djm@cvs.openbsd.org 2007/09/13 04:39:04
[sftp-server.c]
     fix incorrect test when setting syslog facility; from Jan Pechanec
2007-09-17 16:11:33 +10:00
Damien Miller 83e04f2023 - stevesk@cvs.openbsd.org 2007/09/12 19:39:19
[umac.c]
     use xmalloc() and xfree(); ok markus@ pvalchev@
2007-09-17 16:11:01 +10:00
Damien Miller 1235cd387e - stevesk@cvs.openbsd.org 2007/09/11 23:49:09
[sshpty.c]
     remove #if defined block not needed; ok markus@ dtucker@
     NB. RCS ID sync only
2007-09-17 16:10:21 +10:00
Damien Miller 14b017d6f2 - gilles@cvs.openbsd.org 2007/09/11 15:47:17
[session.c ssh-keygen.c sshlogin.c]
     use strcspn to properly overwrite '\n' in fgets returned buffer
     ok pyr@, ray@, millert@, moritz@, chl@
2007-09-17 16:09:15 +10:00
Damien Miller 9c89c837cc - stevesk@cvs.openbsd.org 2007/09/11 04:36:29
[sshpty.c]
     sort #include
     NB. RCS ID sync only
2007-09-17 16:07:32 +10:00
Damien Miller 5cbe7ca18d - sobrado@cvs.openbsd.org 2007/09/09 11:38:01
[ssh-add.c ssh-agent.1 ssh-agent.c ssh-keygen.c]
     sort synopsis and options in ssh-agent(1); usage is lowercase
     ok jmc@
2007-09-17 16:05:50 +10:00
Damien Miller 67bd062b27 - djm@cvs.openbsd.org 2007/09/04 11:15:56
[ssh.c sshconnect.c sshconnect.h]
     make ssh(1)'s ConnectTimeout option apply to both the TCP connection and
     SSH banner exchange (previously it just covered the TCP connection).
     This allows callers of ssh(1) to better detect and deal with stuck servers
     that accept a TCP connection but don't progress the protocol, and also
     makes ConnectTimeout useful for connections via a ProxyCommand;
     feedback and "looks ok" markus@
2007-09-17 12:06:57 +10:00
Damien Miller 54fd7cf2db - djm@cvs.openbsd.org 2007/09/04 03:21:03
[clientloop.c monitor.c monitor_fdpass.c monitor_fdpass.h]
     [monitor_wrap.c ssh.c]
     make file descriptor passing code return an error rather than call fatal()
     when it encounters problems, and use this to make session multiplexing
     masters survive slaves failing to pass all stdio FDs; ok markus@
2007-09-17 12:04:08 +10:00
Damien Miller 1d824ab2e7 - djm@cvs.openbsd.org 2007/08/23 03:23:26
[sshconnect.c]
     Execute ProxyCommands with $SHELL rather than /bin/sh unconditionally
2007-09-17 11:58:04 +10:00
Damien Miller 4890e53977 - djm@cvs.openbsd.org 2007/08/23 03:22:16
[auth2-none.c sshd_config sshd_config.5]
     Support "Banner=none" to disable displaying of the pre-login banner;
     ok dtucker@ deraadt@
2007-09-17 11:57:38 +10:00
Damien Miller 6f40204c44 - djm@cvs.openbsd.org 2007/08/23 03:06:10
[auth.h]
     login_cap.h doesn't belong here
     NB. RCS ID sync only for portable
2007-09-17 11:55:25 +10:00
Damien Miller 6ef50134c2 - djm@cvs.openbsd.org 2007/08/23 02:55:51
[auth-passwd.c auth.c session.c]
     missed include bits from last commit
     NB. RCS ID sync only for portable
2007-09-17 11:54:24 +10:00
Damien Miller 6572db28fd - djm@cvs.openbsd.org 2007/08/23 02:49:43
[auth-passwd.c auth.c session.c]
     unifdef HAVE_LOGIN_CAP; ok deraadt@ millert@
     NB. RCS ID sync only for portable
2007-09-17 11:52:59 +10:00
Darren Tucker 84287b831e - (dtucker) [openbsd-compat/bsd-asprintf.c] Plug mem leak in error path.
Patch from Jan.Pechanec at sun com.
2007-09-14 10:04:15 +10:00
Tim Rice 0eeaf127b5 - (tim) [configure.ac] Autoconf didn't define HAVE_LIBIAF because we
did a AC_CHECK_FUNCS within the AC_CHECK_LIB test.
2007-09-10 16:24:17 -07:00
Darren Tucker e296d58dcf - (dtucker) [openbsd-compat/regress/closefromtest.c] Bug #1358: Always
return 0 on successful test.  From David.Leonard at quest com.
2007-09-10 13:20:14 +10:00
Damien Miller ac4ee1eb0f don't say it twice 2007-09-04 16:49:39 +10:00
Damien Miller 6c3d7035a1 credit Jan Pechanec 2007-09-04 14:26:32 +10:00
Darren Tucker ef15482d87 Mention Jan Pechanec 2007-09-04 14:05:24 +10:00
Darren Tucker fb206ded16 - (dtucker) [INSTALL] Link to tcpwrappers. 2007-08-17 22:52:05 +10:00
Darren Tucker 8ea84561c4 - (dtucker) [INSTALL] Give PAM its own heading. 2007-08-17 22:12:14 +10:00
Darren Tucker ea43c49650 - (dtucker) [INSTALL] the pid file is sshd.pid not ssh.pid. 2007-08-17 22:10:10 +10:00
Darren Tucker 1a32953e48 - (dtucker) [INSTALL] Group the parts describing random options and PAM
implementations together which is hopefully more coherent.
2007-08-17 22:03:09 +10:00
Darren Tucker 1a9176bf22 - (dtucker) [sshd.8] Many Linux variants use a single "!" to denote locked
accounts and that's what the code looks for, so make man page and code
   agree.  Pointed out by Roumen Petrov.
2007-08-17 09:42:32 +10:00
Darren Tucker 9142e1c66d - (dtucker) [session.c] Call PAM cleanup functions for unauthenticated
connections too.  Based on a patch from Sandro Wefel, with & ok djm@
2007-08-16 23:28:04 +10:00
Darren Tucker fc5d188b34 - stevesk@cvs.openbsd.org 2007/08/15 12:13:41
[ssh_config.5]
     tun device forwarding now honours ExitOnForwardFailure; ok markus@
2007-08-15 22:20:22 +10:00
Darren Tucker 9d81fdc664 - (dtucker) [README contrib/caldera/openssh.spec contrib/redhat/openssh.spec
contrib/suse/openssh.spec] Crank version.
2007-08-15 19:22:20 +10:00
Darren Tucker 794f97026e - (dtucker) [openbsd-compat/bsd-cray.c] Remove debug from signal handler.
ok djm@
2007-08-15 19:17:43 +10:00
Darren Tucker 69fe0e1398 - markus@cvs.openbsd.org 2007/08/15 08:16:49
[version.h]
     openssh 4.7
2007-08-15 19:14:52 +10:00
Darren Tucker 513d13accd - markus@cvs.openbsd.org 2007/08/15 08:14:46
[clientloop.c]
     do NOT fall back to the trused x11 cookie if generation of an untrusted
     cookie fails; from security-alert at sun.com; ok dtucker
2007-08-15 19:13:41 +10:00
Darren Tucker 2d9636471b - (dtucker) [session.c] Bug #1339: ensure that pam_setcred() is always
called with PAM_ESTABLISH_CRED at least once, which resolves a problem
   with pam_dhkeys.  Patch from David Leonard, ok djm@
2007-08-13 23:11:56 +10:00
Darren Tucker 8acb3b665b - (dtucker) [configure.ac] Bug #1343: Set DISABLE_FD_PASSING for QNX6. From.
Matt Kraai, ok djm@.
2007-08-10 14:36:12 +10:00
Darren Tucker 57d4ca9681 - (dtucker) [auth-pam.c] Use sigdie here too. ok djm@ 2007-08-10 14:32:34 +10:00
Darren Tucker 7015e9667a Credit Bernhard Simon who also reported this. 2007-08-09 15:03:23 +10:00
Darren Tucker a5b6f72a52 - (dtucker) [defines.h] Remove _PATH_{CSHELL,SHELLS} which aren't
used anywhere and are a potential source of warnings.
2007-08-09 14:37:52 +10:00
Darren Tucker 6f6b27d515 - (dtucker) [README.platform] Document the interaction between PermitRootLogin
and the AIX native login restrictions.
2007-08-09 14:31:53 +10:00
Darren Tucker 863cfa0e6f - (dtucker) [openbsd-compat/port-aix.c] Comment typo. 2007-08-09 14:29:47 +10:00
Damien Miller b3ce9fec30 - djm@cvs.openbsd.org 2007/08/07 07:32:53
[clientloop.c clientloop.h ssh.c]
     bz#1232: ensure that any specified LocalCommand is executed after the
     tunnel device is opened. Also, make failures to open a tunnel device
     fatal when ExitOnForwardFailure is active.
     Reported by h.goebel AT goebel-consult.de; ok dtucker markus reyk deraadt
2007-08-08 14:32:41 +10:00
Damien Miller 647d97b1ab - sobrado@cvs.openbsd.org 2007/08/06 19:16:06
[scp.1 scp.c]
     the ellipsis is not an optional argument; while here, sync the usage
     and synopsis of commands
     lots of good ideas by jmc@
     ok jmc@
2007-08-08 14:29:58 +10:00
Damien Miller 932040285f - ray@cvs.openbsd.org 2007/07/12 05:48:05
[key.c]
     Delint: remove some unreachable statements, from Bret Lambert.
     OK markus@ and dtucker@.
2007-08-08 14:28:26 +10:00
Tim Rice cd22d30f32 - (tim) [buildpkg.sh.in] s|$FAKE_ROOT/${sysconfdir}|$FAKE_ROOT${sysconfdir}| 2007-07-24 21:40:59 -07:00
Tim Rice ffe3a8ec7e - (tim) [buildpkg.sh.in openssh.xml.in] Allow more flexibility where smf(5)
files are installed.
2007-07-24 21:16:07 -07:00
Tim Rice bf0212d1b7 - (tim) [openbsd-compat/regress/closefromtest.c] Bug 1345: fix open() call.
Report/patch by David.Leonard AT quest.com
2007-07-24 20:54:09 -07:00
Tim Rice 947fd59f7a - (tim) [openssh.xml.in] make FMRI match what package scripts use. 2007-07-24 13:13:42 -07:00
Damien Miller 0d7b93473c - (djm) bz#1325: Fix SELinux in permissive mode where it would
incorrectly fatal() on errors. patch from cjwatson AT debian.org;
   ok dtucker
2007-06-28 08:48:02 +10:00
Darren Tucker febf0f5668 - (dtucker) [atomicio.c configure.ac openbsd-compat/Makefile.in
openbsd-compat/bsd-poll.{c,h} openbsd-compat/openbsd-compat.h]
   Add an implementation of poll() built on top of select(2).  Code from
   OpenNTPD with changes suggested by djm.  ok djm@
2007-06-25 22:15:12 +10:00
Darren Tucker dc4a779fbb - dtucker@cvs.openbsd.org 2007/06/25 12:02:27
[atomicio.c]
     Include <poll.h> like the man page says rather than <sys/poll.h>.  ok djm@
2007-06-25 22:08:10 +10:00
Darren Tucker 9e223240ac - (dtucker) [atomicio.c] Test for EWOULDBLOCK in atomiciov to match
atomicio.
2007-06-25 19:06:53 +10:00
Darren Tucker ae09cb8a71 - dtucker@cvs.openbsd.org 2007/06/25 08:20:03
[channels.c]
     Correct test for window updates every three packets; prevents sending
     window updates for every single packet.  ok markus@
2007-06-25 19:04:46 +10:00
Darren Tucker ab17f7d67b - djm@cvs.openbsd.org 2007/06/19 02:04:43
[atomicio.c]
     if the fd passed to atomicio/atomiciov() is non blocking, then poll() to
     avoid a spin if it is not yet ready for reading/writing; ok dtucker@
2007-06-25 19:04:12 +10:00
Darren Tucker 132367f76f - djm@cvs.openbsd.org 2007/06/14 22:48:05
[ssh.c]
     when waiting for the multiplex exit status, read until the master end
     writes an entire int of data *and* closes the client_fd; fixes mux
     regression spotted by dtucker, ok dtucker@
2007-06-25 18:59:17 +10:00
Darren Tucker d989adadd3 - djm@cvs.openbsd.org 2007/06/14 21:43:25
[ssh.c]
     handle EINTR when waiting for mux exit status properly
2007-06-25 18:34:43 +10:00
Darren Tucker 067263e848 - djm@cvs.openbsd.org 2007/06/13 00:21:27
[scp.c]
     don't ftruncate() non-regular files; bz#1236 reported by wood AT
     xmission.com; ok dtucker@
2007-06-25 18:32:33 +10:00
Darren Tucker 7dae3d296e - (dtucker) [openbsd-compat/openssl-compat.h] Remove redundant definition
of USE_BUILTIN_RIJNDAEL since the <0.9.6 test is covered by the
   subsequent <0.9.7 test.
2007-06-14 23:47:31 +10:00
Darren Tucker a2ed75582f - (dtucker) [openbsd-compat/openssl-compat.h] Merge USE_BUILTIN_RIJNDAEL
sections.  Fixes builds with early OpenSSL 0.9.6 versions.
2007-06-14 23:38:39 +10:00
Darren Tucker cb52017ad9 - (dtucker) [cipher-ctr.c umac.c openbsd-compat/openssl-compat.h] Move the
USE_BUILTIN_RIJNDAEL compat goop to openssl-compat.h so it can be
   shared with umac.c.  Allows building with OpenSSL 0.9.5 again including
   umac support.  With tim@ djm@, ok djm.
2007-06-14 23:21:32 +10:00
Darren Tucker bed63112f5 - dtucker@cvs.openbsd.org 2007/06/12 13:54:28
[scp.c]
     Encode filename with strnvis if the name contains a newline (which can't
     be represented in the scp protocol), from bz #891.  ok markus@
2007-06-13 00:02:07 +10:00
Darren Tucker 0409e15078 - jmc@cvs.openbsd.org 2007/06/12 13:43:55
[ssh.1]
     add -K to SYNOPSIS;
2007-06-13 00:00:58 +10:00
Darren Tucker 930cb0b718 - jmc@cvs.openbsd.org 2007/06/12 13:41:03
[ssh-add.1]
     identies -> identities;
2007-06-13 00:00:27 +10:00
Darren Tucker b1e128f75a - dtucker@cvs.openbsd.org 2007/06/12 11:56:15
[gss-genr.c]
     Pass GSS OID to gss_display_status to provide better information in
     error messages.  Patch from Simon Wilkinson via bz 1220.  ok djm@
2007-06-12 23:44:36 +10:00
Darren Tucker 2604749651 - djm@cvs.openbsd.org 2007/06/12 11:45:27
[ssh.c]
     improved exit message from multiplex slave sessions; bz #1262
     reported by alexandre.nunes AT gmail.com; ok dtucker@
2007-06-12 23:44:10 +10:00
Darren Tucker 415bddc1bd - djm@cvs.openbsd.org 2007/06/12 11:15:17
[ssh.c ssh.1]
     Add "-K" flag for ssh to set GSSAPIAuthentication=yes and
     GSSAPIDelegateCredentials=yes. This is symmetric with -k (disable GSSAPI)
     and is useful for hosts with /home on Kerberised NFS; bz #1312
     patch from Markus.Kuhn AT cl.cam.ac.uk; ok dtucker@ markus@
2007-06-12 23:43:16 +10:00
Darren Tucker 2cbec749d7 - djm@cvs.openbsd.org 2007/06/12 11:11:08
[ssh.c]
     fix slave exit value when a control master goes away without passing the
     full exit status by ensuring that the slave reads a full int. bz#1261
     reported by frekko AT gmail.com; ok markus@ dtucker@
2007-06-12 23:41:33 +10:00
Darren Tucker 43ce902449 - djm@cvs.openbsd.org 2007/06/12 08:24:20
[scp.c]
     make scp try to skip FIFOs rather than blocking when nothing is listening.
     depends on the platform supporting sane O_NONBLOCK semantics for open
     on FIFOs (apparently POSIX does not mandate this), which OpenBSD does.
     bz #856; report by cjwatson AT debian.org; ok markus@
2007-06-12 23:41:06 +10:00
Darren Tucker 8f6d0ed60e - djm@cvs.openbsd.org 2007/06/12 08:20:00
[ssh-gss.h gss-serv.c gss-genr.c]
     relocate server-only GSSAPI code from libssh to server; bz #1225
     patch from simon AT sxw.org.uk; ok markus@ dtucker@
2007-06-12 23:40:39 +10:00
Darren Tucker 29a5707acc - djm@cvs.openbsd.org 2007/06/12 07:41:00
[ssh-add.1]
     better document ssh-add's -d option (delete identies from agent), bz#1224
     new text based on some provided by andrewmc-debian AT celt.dias.ie;
     ok dtucker@
2007-06-12 23:39:52 +10:00
Darren Tucker 395ecc2bde - markus@cvs.openbsd.org 2007/06/11 09:14:00
[channels.h]
     increase default channel windows; ok djm
2007-06-12 23:38:53 +10:00
Damien Miller 3191a8e8ba - markus@cvs.openbsd.org 2007/06/11 08:04:44
[channels.c]
     send 'window adjust' messages every tree packets and do not wait
     until 50% of the window is consumed.  ok djm dtucker
2007-06-11 18:33:15 +10:00
Darren Tucker 725286e223 - (dtucker) [includes.h] Bug #1243: HAVE_PATHS -> HAVE_PATHS_H. Should
prevent warnings about redefinitions of various things in paths.h.
   Spotted by cartmanltd at hotmail.com.
2007-06-11 14:44:02 +10:00
Darren Tucker 1534fa41e0 - (dtucker) [openbsd-compat/bsd-misc.c] According to the spec the "remainder"
argument to nanosleep may be NULL.  Currently this never happens in OpenSSH,
   but check anyway in case this changes or the code gets used elsewhere.
2007-06-11 14:34:53 +10:00
Damien Miller 34a176995f - (djm) [configure.ac umac.c] If platform doesn't provide swap32(3), then
fallback to provided bit-swizzing functions
2007-06-11 14:15:42 +10:00
Damien Miller 22b7b49331 - jmc@cvs.openbsd.org 2007/06/08 07:48:09
[sshd_config.5]
     oops, here too: put the MAC list into a display, like we do for
     ciphers, since groff has trouble with wide lines;
2007-06-11 14:07:12 +10:00
Damien Miller 5e7c30bdf1 - jmc@cvs.openbsd.org 2007/06/08 07:43:46
[ssh_config.5]
     put the MAC list into a display, like we do for ciphers,
     since groff has trouble handling wide lines;
2007-06-11 14:06:32 +10:00
Damien Miller 4de545a6fb - pvalchev@cvs.openbsd.org 2007/06/08 04:40:40
[ssh_config]
     Add a "MACs" line after "Ciphers" with the default MAC algorithms,
     to ease people who want to tweak both (eg. for performance reasons).
     ok deraadt@ djm@ dtucker@
2007-06-11 14:04:42 +10:00
Damien Miller e45796f7b4 - pvalchev@cvs.openbsd.org 2007/06/07 19:37:34
[kex.h mac.c mac.h monitor_wrap.c myproposal.h packet.c ssh.1]
     [ssh_config.5 sshd.8 sshd_config.5]
     Add a new MAC algorithm for data integrity, UMAC-64 (not default yet,
     must specify umac-64@openssh.com). Provides about 20% end-to-end speedup
     compared to hmac-md5. Represents a different approach to message
     authentication to that of HMAC that may be beneficial if HMAC based on
     one of its underlying hash algorithms is found to be vulnerable to a
     new attack.  http://www.ietf.org/rfc/rfc4418.txt
     in conjunction with and OK djm@
2007-06-11 14:01:42 +10:00
Damien Miller 835284b74c - (djm) Bugzilla #1306: silence spurious error messages from hang-on-exit
fix; tested by dtucker@ and jochen.kirn AT gmail.com
2007-06-11 13:03:16 +10:00
Darren Tucker 0c0dc49bd1 - (dtucker) [mdoc2man.awk] Add support for %R references, used for RFCs. 2007-06-05 20:01:16 +10:00
Darren Tucker 88bca0641d - (dtucker) [mdoc2man.awk] Remove trailing "$" from Mdocdate regex so
mindrot's cvs doesn't expand it on us.
2007-06-05 19:30:47 +10:00
Darren Tucker 51e5ab06d3 - (dtucker) [mdoc2man.awk] Teach it to deal with $Mdocdate tags that
OpenBSD's cvs now adds.
2007-06-05 19:16:59 +10:00
Darren Tucker 5f3d5be52f - djm@cvs.openbsd.org 2007/06/05 06:52:37
[kex.c monitor_wrap.c packet.c mac.h kex.h mac.c]
     Preserve MAC ctx between packets, saving 2xhash calls per-packet.
     Yields around a 12-16% end-to-end speedup for arcfour256/hmac-md5
     patch from markus@ tested dtucker@ and myself, ok markus@ and me (I'm
     committing at his request)
2007-06-05 18:30:18 +10:00
Darren Tucker 7b21cb5bdc - djm@cvs.openbsd.org 2007/06/02 09:04:58
[bufbn.c]
     memory leak on error path; from arnaud.lacombe.1 AT ulaval.ca
2007-06-05 18:29:35 +10:00
Darren Tucker a394f9913c - djm@cvs.openbsd.org 2007/05/31 23:34:29
[packet.c]
     gc unreachable code; spotted by Tavis Ormandy
2007-06-05 18:28:20 +10:00
Darren Tucker aa4d5eda10 - jmc@cvs.openbsd.org 2007/05/31 19:20:16
[scp.1 ssh_config.5 sftp-server.8 ssh-agent.1 sshd_config.5 sftp.1
     ssh-keygen.1 ssh-keyscan.1 ssh-add.1 sshd.8 ssh.1 ssh-keysign.8]
     convert to new .Dd format;
     (We will need to teach mdoc2man.awk to understand this too.)
2007-06-05 18:27:13 +10:00
Darren Tucker 0d0d195969 - djm@cvs.openbsd.org 2007/05/30 05:58:13
[kex.c]
     tidy: KNF, ARGSUSED and u_int
2007-06-05 18:23:28 +10:00
Darren Tucker 4a40ae28c3 - djm@cvs.openbsd.org 2007/05/22 10:18:52
[sshd.c]
     zap double include; from p_nowaczyk AT o2.pl
     (not required in -portable, Id sync only)
2007-06-05 18:22:32 +10:00
Darren Tucker 2216471510 - (dtucker) [auth-pam.c] Return empty string if fgets fails in
sshpam_tty_conv.  Patch from ldv at altlinux.org.
2007-05-20 15:26:07 +10:00
Darren Tucker 29171e9f5c - (dtucker) [auth-pam.c] malloc+memset -> calloc. Patch from
ldv at altlinux.org.
2007-05-20 15:20:08 +10:00
Darren Tucker f520ea1567 - jolan@cvs.openbsd.org 2007/05/17 23:53:41
[sshconnect2.c]
     djm owes me a vb and a tism cd for breaking ssh compilation
2007-05-20 15:11:33 +10:00
Darren Tucker 7fa339bb7c - djm@cvs.openbsd.org 2007/05/17 20:52:13
[monitor.c]
     pass received SIGINT from monitor to postauth child so it can clean
     up properly. bz#1196, patch from senthilkumar_sen AT hotpop.com;
     ok markus@
2007-05-20 15:10:16 +10:00
Darren Tucker 26c6662834 - djm@cvs.openbsd.org 2007/05/17 20:48:13
[sshconnect2.c]
     fall back to gethostname() when the outgoing connection is not
     on a socket, such as is the case when ProxyCommand is used.
     Gives hostbased auth an opportunity to work; bz#616, report
     and feedback stuart AT kaloram.com; ok markus@
2007-05-20 15:09:42 +10:00
Darren Tucker e9405983dc - djm@cvs.openbsd.org 2007/05/17 07:55:29
[sftp-server.c]
     bz#1286 stop reading and processing commands when input or output buffer
     is nearly full, otherwise sftp-server would happily try to grow the
     input/output buffers past the maximum supported by the buffer API and
     promptly fatal()
     based on patch from Thue Janus Kristensen; feedback & ok dtucker@
2007-05-20 15:09:04 +10:00
Darren Tucker 36b78000a7 - djm@cvs.openbsd.org 2007/05/17 07:50:31
[log.c]
     save and restore errno when logging; ok deraadt@
2007-05-20 15:08:15 +10:00
Darren Tucker f78bb41772 - dtucker@cvs.openbsd.org 2007/04/23 10:15:39
[servconf.c]
     Remove debug() left over from development.  ok deraadt@
2007-05-20 15:03:15 +10:00
Darren Tucker 86473c57a8 - stevesk@cvs.openbsd.org 2007/04/18 01:12:43
[sftp-server.c]
     cast "%llu" format spec to (unsigned long long); do not assume a
     u_int64_t arg is the same as 'unsigned long long'.
     from Dmitry V. Levin <ldv@altlinux.org>
     ok markus@ 'Yes, that looks correct' millert@
2007-05-20 14:59:32 +10:00
Darren Tucker 208ac57c30 - stevesk@cvs.openbsd.org 2007/04/14 22:01:58
[auth2.c]
     remove unused macro; from Dmitry V. Levin <ldv@altlinux.org>
2007-05-20 14:58:41 +10:00
Tim Rice aa8954f1d9 20070509
- (tim) [configure.ac] Bug #1287: Add missing test for ucred.h.
2007-05-09 15:57:43 -07:00
Darren Tucker d0adab5a12 trim pasto 2007-04-29 17:14:48 +10:00
Darren Tucker dca0edff2f - (dtucker) [configure.ac defines.h] Have configure check for offsetof
to prevent redefinition warnings.
2007-04-29 15:06:44 +10:00
Darren Tucker 391de5c023 - (dtucker) [configure.ac defines.h] Prevent warnings about __attribute__
__nonnull__ for versions of GCC that don't support it.
2007-04-29 14:49:21 +10:00
Darren Tucker 6d862a50db - (dtucker) [configure.ac defines.h] Have configure check for MAXSYMLINKS
so we don't get redefinition warnings.
2007-04-29 14:39:02 +10:00
Darren Tucker 2ac529b505 - (dtucker) [openbsd-compat/xmmap.c] Include stdlib.h for mkstemp prototype. 2007-04-29 14:02:43 +10:00
Darren Tucker cc40d5ecdf - (dtucker) [configure.ac openbsd-compat/getrrsetbyname.c] Bug #1299: Use the
platform's _res if it has one.  Should fix problem of DNSSEC record lookups
   on NetBSD as reported by Curt Sampson.
2007-04-29 13:58:06 +10:00
Darren Tucker d757e69cda - (dtucker) [auth-shadow.c loginrec.c] Include time.h for time(2) prototype. 2007-04-29 12:10:57 +10:00
Darren Tucker 781e7a28d0 - (dtucker) [openbsd-compat/bsd-misc.c] Include unistd.h and sys/types.h
for select(2) prototype.
2007-04-29 12:06:55 +10:00
Darren Tucker 2a3868589b - (dtucker) [INSTALL] prngd lives at sourceforge these days. 2007-04-06 12:25:08 +10:00
Darren Tucker 62995c1f1e - (dtucker) [INSTALL] Update the systems that have PAM as standard. Link
to OpenPAM too.
2007-04-06 12:21:47 +10:00
Tim Rice 99203ec48b 20070326
- (tim) [auth.c configure.ac defines.h session.c openbsd-compat/port-uw.c
   openbsd-compat/port-uw.h openbsd-compat/xcrypt.c] Rework libiaf test/defines
   to account for IRIX having libiaf but not set_id(). Patch with & ok dtucker@
2007-03-26 09:35:28 -07:00
Darren Tucker 20e9f976c1 - (dtucker) [Makefile.in configure.ac] Replace single-purpose LIBSELINUX,
LIBWRAP and LIBPAM variables in Makefile with the general-purpose
   SSHDLIBS.  "I like" djm@
2007-03-25 18:26:01 +10:00
Darren Tucker 9869ab3557 - (dtucker) [regress/agent-getpeereid.sh] Do peereid test if we have
HAVE_GETPEERUCRED too.  Also from Jan Pechanec.
2007-03-21 21:45:48 +11:00
Darren Tucker 164aa30e46 - (dtucker) [configure.ac openbsd-compat/bsd-getpeereid.c] Bug #1287: Use
getpeerucred to implement getpeereid (currently only Solaris 10 and up).
   Patch by Jan.Pechanec at Sun.
2007-03-21 21:39:57 +11:00
Darren Tucker 04354b97dc - jmc@cvs.openbsd.org 2007/03/20 15:57:15
[sshd.8]
     - let synopsis and description agree for -f
     - sort FILES
     - +.Xr ssh-keyscan 1 ,
     from Igor Sobrado
2007-03-21 20:46:54 +11:00
Darren Tucker 03b1cdbb44 - tedu@cvs.openbsd.org 2007/03/20 03:56:12
[readconf.c clientloop.c]
     remove some bogus *p tests from charles longeau
     ok deraadt millert
2007-03-21 20:46:03 +11:00
Darren Tucker 2812dc9285 - dtucker@cvs.openbsd.org 2007/03/19 12:16:42
[ssh-agent.c]
     Remove the signal handler that checks if the agent's parent process
     has gone away, instead check when the select loop returns.  Record when
     the next key will expire when scanning for expired keys.  Set the select
     timeout to whichever of these two things happens next.  With djm@, with &
     ok deraadt@ markus@
2007-03-21 20:45:06 +11:00
Darren Tucker 506ed88cef - djm@cvs.openbsd.org 2007/03/19 01:01:29
[sshd_config]
     Disable the legacy SSH protocol 1 for new installations via
     a configuration override. In the future, we will change the
     server's default itself so users who need the legacy protocol
     will need to turn it on explicitly
2007-03-21 20:42:24 +11:00
Darren Tucker 97b1bb568c - dtucker@cvs.openbsd.org 2007/03/09 05:20:06
[servconf.c sshd.c]
     Move C/R -> kbdint special case to after the defaults have been
     loaded, which makes ChallengeResponse default to yes again.  This
     was broken by the Match changes and not fixed properly subsequently.
     Found by okan at demirmen.com, ok djm@ "please do it" deraadt@
2007-03-21 20:38:53 +11:00
Darren Tucker 5548e8cf2e - (dtucker) [README.platform] Info about blibpath on AIX. 2007-03-13 21:00:45 +11:00
Darren Tucker da05f48739 - (dtucker) [cipher-3des1.c cipher-bf1.c] The OpenSSL 0.9.8e problem in
bug #1291 also affects Protocol 1 3des.  While at it, use compat-openssl.h
   in cipher-bf1.c.  Patch from Juan Gallego.
2007-03-13 18:50:04 +11:00
Darren Tucker b9fe6a337a - (dtucker) [LICENCE] Add Daniel Walsh as a copyright holder for the
selinux bits in -portable.
2007-03-13 07:37:49 +11:00
Darren Tucker a8d51ee307 - (dtucker) [entropy.c scard-opensc.c ssh-rand-helper.c] Bug #1294: include
string.h to prevent warnings, from vapier at gentoo.org.
2007-03-13 07:35:38 +11:00
Damien Miller c49dd34a3e - (djm) [README] correct link to release notes 2007-03-08 20:13:39 +11:00
Damien Miller f0ffec906c - (djm) Release 4.6p1 2007-03-06 21:24:00 +11:00
Damien Miller d91cfab088 - (djm) [contrib/caldera/openssh.spec contrib/redhat/openssh.spec]
[contrib/suse/openssh.spec] crank spec files for release
2007-03-06 21:23:24 +11:00
Damien Miller 2dbab87386 - djm@cvs.openbsd.org 2007/03/06 10:13:14
[version.h]
     openssh-4.6; "please" deraadt@
2007-03-06 21:21:37 +11:00
Damien Miller 5737e363c5 - OpenBSD CVS Sync
- jmc@cvs.openbsd.org 2007/03/01 16:19:33
     [sshd_config.5]
     sort the `match' keywords;
2007-03-06 21:21:18 +11:00
Darren Tucker fd30986c92 - (dtucker) [openbsd-compat/openssl-compat.h] Bug #1291: Work around a
bug in OpenSSL 0.9.8e that prevents aes256-ctr, aes192-ctr and arcfour256
   ciphers from working correctly (disconnects with "Bad packet length"
   errors) as found by Ben Harris.  ok djm@
2007-03-05 18:25:20 +11:00
Damien Miller 9975e48349 - (djm) [configure.ac] add a --without-openssl-header-check option to
configure, as some platforms (OS X) ship OpenSSL headers whose version
   does not match that of the shipping library. ok dtucker@
2007-03-05 11:51:27 +11:00
Darren Tucker 90a58fdf22 - (dtucker) [regress/agent-ptrace.sh] Make ttrace gdb error a little more
general to cover newer gdb versions on HP-UX.
2007-03-03 09:42:23 +11:00
Darren Tucker aef5beef12 - (dtucker) [INSTALL] Update to autoconf-2.61. 2007-03-02 17:53:41 +11:00
Darren Tucker 573e3878b8 - (dtucker) [configure.ac] For Cygwin, read files in textmode (which allows
CRLF as well as LF lineendings) and write in binary mode.  Patch from
   vinschen at redhat.com.
2007-03-02 17:50:03 +11:00
Tim Rice c3af6d4d13 - (tim) [buildpkg.sh.in openssh.xml.in] Clean up Solaris 10 smf(5) bits.
"Looks sane" dtucker@
2007-03-01 09:34:52 -08:00
Darren Tucker 1d75f22c5d - dtucker@cvs.openbsd.org 2007/03/01 10:28:02
[auth2.c sshd_config.5 servconf.c]
     Remove ChallengeResponseAuthentication support inside a Match
     block as its interaction with KbdInteractive makes it difficult to
     support.  Also, relocate the CR/kbdint option special-case code into
     servconf.  "please commit" djm@, ok markus@ for the relocation.
2007-03-01 21:31:28 +11:00
Darren Tucker cf0d2db2fa - dtucker@cvs.openbsd.org 2007/02/28 00:55:30
[ssh-agent.c]
     Remove expired keys periodically so they don't remain in memory when
     the agent is entirely idle, as noted by David R. Piegdon.  This is the
     simple fix, a more efficient one will be done later.  With markus,
     deraadt, with & ok djm.
2007-02-28 21:19:58 +11:00
Darren Tucker 90aaed4397 - ray@cvs.openbsd.org 2007/02/24 03:30:11
[moduli.c]
     - strlen returns size_t, not int.
     - Pass full buffer size to fgets.
     OK djm@, millert@, and moritz@.
2007-02-25 20:38:55 +11:00
Darren Tucker 82347a8fd6 - dtucker@cvs.openbsd.org 2007/02/22 12:58:40
[servconf.c]
     Check activep so Match and GatewayPorts work together; ok markus@
2007-02-25 20:37:52 +11:00
Darren Tucker ed623966e3 - dtucker@cvs.openbsd.org 2007/02/21 11:00:05
[sshd.c]
     Clear alarm() before restarting sshd on SIGHUP.  Without this, if there's
     a SIGALRM pending (for SSH1 key regeneration) when sshd is SIGHUP'ed, the
     newly exec'ed sshd will get the SIGALRM and not have a handler for it,
     and the default action will terminate the listening sshd.  Analysis and
     patch from andrew at gaul.org.
2007-02-25 20:37:21 +11:00
Darren Tucker d04188e70e - djm@cvs.openbsd.org 2007/02/20 10:25:14
[clientloop.c]
     set maximum packet and window sizes the same for multiplexed clients
     as normal connections; ok markus@
2007-02-25 20:36:49 +11:00
Darren Tucker 89ee69e3c6 - (dtucker) [openbsd-compat/getrrsetbyname.c] Don't attempt to calloc
an array for signatures when there are none since "calloc(0, n) returns
   NULL on some platforms (eg Tru64), which is explicitly permitted by
   POSIX.  Diagnosis and patch by svallet genoscope.cns.fr.
2007-02-19 22:56:55 +11:00
Darren Tucker 53ced25d61 - (dtucker) [contrib/findssl.sh] Add "which" as a shell function since some
platforms don't have it.  Patch from dleonard at vintela.com.
2007-02-19 22:44:25 +11:00
Darren Tucker 1629c07c07 - dtucker@cvs.openbsd.org 2007/02/19 10:45:58
[monitor_wrap.c servconf.c servconf.h monitor.c sshd_config.5]
     Teach Match how handle config directives that are used before
     authentication.  This allows configurations such as permitting password
     authentication from the local net only while requiring pubkey from
     offsite.  ok djm@, man page bits ok jmc@
2007-02-19 22:25:37 +11:00
Darren Tucker 591322ae38 - stevesk@cvs.openbsd.org 2007/02/14 14:32:00
[bufbn.c]
     typos in comments; ok jmc@
2007-02-19 22:17:28 +11:00
Darren Tucker 6ec2fbec8b - djm@cvs.openbsd.org 2007/01/22 13:06:21
[scp.c]
     fix detection of whether we should show progress meter or not: scp
     tested isatty(stderr) but wrote the progress meter to stdout. This patch
     makes it test stdout. bz#1265 reported by junkmail AT bitsculpture.com;
     of dtucker@
2007-02-19 22:14:11 +11:00
Darren Tucker 0aa3dbb508 - djm@cvs.openbsd.org 2007/01/22 11:32:50
[sftp-client.c]
     return error from do_upload() when a write fails. fixes bz#1252: zero
     exit status from sftp when uploading to a full device. report from
     jirkat AT atlas.cz; ok dtucker@
2007-02-19 22:13:39 +11:00
Darren Tucker cb0e1753c7 - stevesk@cvs.openbsd.org 2007/01/21 01:45:35
[readconf.c]
     spaces
2007-02-19 22:12:53 +11:00
Darren Tucker c58b5b0742 ChangeLog entries for previous 2 commits 2007-02-19 22:12:23 +11:00
Darren Tucker 26dc3e656a - jmc@cvs.openbsd.org 2007/01/12 20:20:41
[ssh-keygen.1 ssh-keygen.c]
     more secsh -> rfc 4716 updates;
     spotted by wiz@netbsd
     ok markus
2007-02-19 22:09:06 +11:00
Darren Tucker bf6b328f27 - jmc@cvs.openbsd.org 2007/01/10 13:23:22
[ssh_config.5]
     do not use a list for SYNOPSIS;
     this is actually part of a larger report sent by eric s. raymond
     and forwarded by brad, but i only read half of it. spotted by brad.
2007-02-19 22:08:17 +11:00
Damien Miller e42bd24b22 - (djm) [channels.c serverloop.c] Fix so-called "hang on exit" (bz #52)
when closing a tty session when a background process still holds tty
   fds open. Great detective work and patch by Marc Aurele La France,
   slightly tweaked by me; ok dtucker@
2007-01-29 10:16:28 +11:00
Darren Tucker 07877ca680 - (dtucker) [openbsd-compat/bsd-snprintf.c] Static declarations for public
library interfaces aren't very helpful. Fix up the DOPR_OUTCH macro
   so it works properly and modify its callers so that they don't pre or
   post decrement arguments that are conditionally evaluated. While there,
   put SNPRINTF_CONST back as it prevents build failures in some
   configurations.  ok djm@ (for most of it)
2007-01-24 00:07:29 +11:00
Damien Miller 9f74105289 - (djm) [ssh-rand-helper.8] manpage nits;
from dleonard AT vintela.com (bz#1529)
2007-01-22 12:44:53 +11:00
Darren Tucker eae5fa1b58 - (dtucker) [packet.c] Re-remove in_systm.h since it's already in includes.h
and multiple including it causes problems on old IRIXes.  (It snuck back
   in during a sync.)  Found (again) by Georg Schwarz.
2007-01-17 11:00:13 +11:00
Damien Miller 742cc1c194 - (djm) [openbsd-compat/bsd-snprintf.c] Fix integer overflow in return
value of snprintf replacement, similar to bugs in various libc
   implementations. This overflow is not exploitable in OpenSSH.
   While I'm fiddling with it, make it a fair bit faster by inlining the
   append-char routine; ok dtucker@
2007-01-14 21:20:30 +11:00
Darren Tucker e67ac00b9b typo 2007-01-14 10:26:25 +11:00
Darren Tucker 9ac56e945b - (dtucker) [ssh-keygen.c] ac -> argv to match earlier sync. 2007-01-14 10:19:59 +11:00
Damien Miller e2334d600b - stevesk@cvs.openbsd.org 2007/01/03 07:22:36
[sftp-server.c]
     spaces
2007-01-05 16:31:02 +11:00
Damien Miller b6c85fcf37 - stevesk@cvs.openbsd.org 2007/01/03 04:09:15
[sftp.c]
     ARGSUSED for lint
2007-01-05 16:30:41 +11:00
Damien Miller 80163907ed - stevesk@cvs.openbsd.org 2007/01/03 03:01:40
[auth2-chall.c channels.c dns.c sftp.c ssh-keygen.c ssh.c]
     spaces
2007-01-05 16:30:16 +11:00
Damien Miller 6c7439f963 - stevesk@cvs.openbsd.org 2007/01/03 00:53:38
[ssh-keygen.c]
     remove small dead code; arnaud.lacombe.1@ulaval.ca via Coverity scan
2007-01-05 16:29:55 +11:00
Damien Miller d94fc72bcd - jmc@cvs.openbsd.org 2007/01/02 09:57:25
[sshd_config.5]
     do not use lists for SYNOPSIS;
     from eric s. raymond via brad
2007-01-05 16:29:30 +11:00
Damien Miller 9fc6a56204 - dtucker@cvs.openbsd.org 2006/12/14 10:01:14
[servconf.c]
     Make "PermitOpen all" first-match within a block to match the way other
     options work.  ok markus@ djm@
2007-01-05 16:29:02 +11:00
Damien Miller a29b95ec3a - dtucker@cvs.openbsd.org 2006/12/13 08:34:39
[servconf.c]
     Make PermitOpen work with multiple values like the man pages says.
     bz #1267 with details from peter at dmtz.com, with & ok djm@
2007-01-05 16:28:36 +11:00
Damien Miller 1ec462658e - djm@cvs.openbsd.org 2006/12/12 03:58:42
[channels.c compat.c compat.h]
     bz #1019: some ssh.com versions apparently can't cope with the
     remote port forwarding bind_address being a hostname, so send
     them an address for cases where they are not explicitly
     specified (wildcard or localhost bind).  reported by daveroth AT
     acm.org; ok dtucker@ deraadt@
2007-01-05 16:26:45 +11:00
Damien Miller c0367fb0d2 - markus@cvs.openbsd.org 2006/12/11 21:25:46
[ssh-keygen.1 ssh.1]
     add rfc 4716 (public key format); ok jmc
2007-01-05 16:25:46 +11:00
Damien Miller 3ca8b77179 - ray@cvs.openbsd.org 2006/11/23 01:35:11
[misc.c sftp.c]
     Don't access buf[strlen(buf) - 1] for zero-length strings.
     ``ok by me'' djm@.
2007-01-05 16:24:47 +11:00
Damien Miller df8b7db16e - (djm) OpenBSD CVS Sync
- deraadt@cvs.openbsd.org 2006/11/14 19:41:04
     [ssh-keygen.c]
     use argc and argv not some made up short form
2007-01-05 16:22:57 +11:00
Damien Miller be6db83462 - (djm) [bsd-asprintf.c] Better test for bad vsnprintf lengths; ok dtucker@ 2006-12-05 22:58:09 +11:00
Damien Miller 143c2ef1ce - (djm) [auth.c] Fix NULL pointer dereference in fakepw(). Crash would
occur if the server did not have the privsep user and an invalid user
   tried to login and both privsep and krb5 auth are disabled.
2006-12-05 09:08:54 +11:00
Darren Tucker b0781f79db - markus@cvs.openbsd.org 2006/11/07 13:02:07
[dh.c]
     BN_hex2bn returns int; from dtucker@
2006-11-08 10:01:36 +11:00
Darren Tucker 14ea86391b - (dtucker) Release 4.5p1. 2006-11-07 23:27:34 +11:00
Darren Tucker c2820c5822 - (dtucker) [README contrib/{caldera,redhat,contrib}/openssh.spec] Bump
versions.
2006-11-07 23:25:45 +11:00
Darren Tucker fbba735aa3 - markus@cvs.openbsd.org 2006/11/07 10:31:31
[monitor.c version.h]
     correctly check for bad signatures in the monitor, otherwise the monitor
     and the unpriv process can get out of sync. with dtucker@, ok djm@,
     dtucker@
2006-11-07 23:16:08 +11:00
Darren Tucker 0bc85579a9 - markus@cvs.openbsd.org 2006/11/06 21:25:28
[auth-rsa.c kexgexc.c kexdhs.c key.c ssh-dss.c sshd.c kexgexs.c
     ssh-keygen.c bufbn.c moduli.c scard.c kexdhc.c sshconnect1.c dh.c rsa.c]
     add missing checks for openssl return codes; with & ok djm@
2006-11-07 23:14:41 +11:00
Darren Tucker df0e438a2e - (dtucker) [sshd.c] Use privsep_pw if we have it, but only require it
if we absolutely need it.  Pointed out by Corinna, ok djm@
2006-11-07 11:28:40 +11:00
Damien Miller 570c2ab1b6 - markus@cvs.openbsd.org 2006/10/31 16:33:12
[kexdhc.c kexdhs.c kexgexc.c kexgexs.c]
     check DH_compute_key() for -1 even if it should not happen because of
     earlier calls to dh_pub_is_valid(); report krahmer at suse.de; ok djm
2006-11-05 05:32:02 +11:00
Damien Miller 3975ee2c3c - (djm) OpenBSD CVS Sync
- otto@cvs.openbsd.org 2006/10/28 18:08:10
     [ssh.1]
     correct/expand example of usage of -w; ok jmc@ stevesk@
2006-11-05 05:31:33 +11:00
Darren Tucker 4d13ecea54 - (dtucker) [openbsd-compat/port-solaris.c] Bug #1255: Make only hwerr
events fatal in Solaris process contract support and tell it to signal
   only processes in the same process group when something happens.
   Based on information from andrew.benham at thus.net and similar to
   a patch from Chad Mynhier.  ok djm@
2006-11-01 10:28:49 +11:00
Damien Miller 796c6c693d - (djm) [auth.c] gc some dead code 2006-10-28 01:10:15 +10:00
Tim Rice bcf8be356f - (tim) [Makefile.in scard/Makefile.in] Add datarootdir= lines to keep
autoconf 2.60 from complaining.
2006-10-23 14:44:47 -07:00
Damien Miller 50455890f3 - djm@cvs.openbsd.org 2006/10/22 02:25:50
[sftp-client.c]
     cancel progress meter when upload write fails; ok deraadt@
2006-10-24 03:03:02 +10:00
Damien Miller 985a4485f5 - markus@cvs.openbsd.org 2006/10/11 12:38:03
[clientloop.c serverloop.c]
     exit instead of doing a blocking tcp send if we detect a client/server
     timeout, since the tcp sendqueue might be already full (of alive
     requests); ok dtucker, report mpf
2006-10-24 03:02:41 +10:00
Damien Miller f4bcd10c4c - markus@cvs.openbsd.org 2006/10/10 10:12:45
[sshconnect.c]
     sleep before retrying (not after) since sleep changes errno; fixes
     pr 5250; rad@twig.com; ok dtucker djm
2006-10-24 03:02:23 +10:00
Damien Miller 990b1a80b5 - djm@cvs.openbsd.org 2006/10/09 23:36:11
[session.c]
     xmalloc -> xcalloc that was missed previously, from portable
     (NB. Id sync only for portable, obviously)
2006-10-24 03:01:56 +10:00
Damien Miller 952dce6593 - djm@cvs.openbsd.org 2006/10/06 02:29:19
[ssh-agent.c ssh-keyscan.c ssh.c]
     sys/resource.h needs sys/time.h; prompted by brad@
     (NB. Id sync only for portable)
2006-10-24 03:01:16 +10:00
Damien Miller e7658a50f0 - (djm) OpenBSD CVS Sync
- ray@cvs.openbsd.org 2006/09/30 17:48:22
     [sftp.c]
     Clear errno before calling the strtol functions.
     From Paul Stoeber <x0001 at x dot de1 dot cc>.
     OK deraadt@.
2006-10-24 03:00:12 +10:00
Darren Tucker 78802f0af3 - (dtucker) [sshd.c] Reshuffle storing of pw struct; prevents warnings
on older versions of OS X.  ok djm@
2006-10-18 22:51:31 +10:00
Darren Tucker ffe88e15af - ray@cvs.openbsd.org 2006/09/25 04:55:38
[ssh-keyscan.1 ssh.1]
     Change "a SSH" to "an SSH".  Hurray, I'm not the only one who
     pronounces "SSH" as "ess-ess-aich".
     OK jmc@ and stevesk@.
2006-10-18 07:53:06 +10:00
Darren Tucker a43c005825 - (dtucker) [monitor_fdpass.c] Include sys/in.h, required for cmsg macros
on older (2.0) Linuxes.  Based on patch from thmo-13 at gmx de.
2006-10-16 19:49:12 +10:00
Tim Rice 77674b1efa - (tim) [buildpkg.sh.in] Some systems have really limited nawk (OpenServer).
Allow setting alternate awk in openssh-config.local.
2006-10-06 18:49:36 -07:00
Darren Tucker adc947d5a5 - (dtucker) [configure.ac] Set put -lselinux into $LIBS while testing for
SELinux functions so they're detected correctly.  Patch from pebenito at
   gentoo.org.
2006-10-07 09:07:20 +10:00
Tim Rice 09f1093a29 20061006
- (tim) [buildpkg.sh.in] Use uname -r instead of -v in OS_VER for Solaris.
   Differentiate between OpenServer 5 and OpenServer 6
2006-10-06 14:58:38 -07:00
Tim Rice 1cfab23b7f - (tim) [configure.ac] Move CHECK_HEADERS test before platform specific
section so additional platform specific CHECK_HEADER tests will work
   correctly. Fixes "<net/if_tap.h> on FreeBSD" problem report by des AT des.no
   Feedback and "seems like a good idea" dtucker@
2006-10-03 09:34:35 -07:00
Darren Tucker 47bda1ff83 - (dtucker) [audit-bsm.c] Include errno.h. Pointed out by des at des.no. 2006-10-01 08:09:50 +10:00
Darren Tucker 5e8381ee86 - (dtucker) [configure.ac] Bug #1239: Fix configure test for OpenSSH engine
support.  Patch from andrew.benham at thus net.
2006-09-29 20:16:51 +10:00
Darren Tucker 23dd658e57 - (dtucker) [entropy.c] Bug #1238: include signal.h to fix compilation error
on Solaris 8 w/out /dev/random or prngd.  Patch from rl at
   math.technion.ac.il.
2006-09-28 19:40:20 +10:00
Darren Tucker b4b2f9a6c9 Marker for 4.4p1 release 2006-09-28 19:08:32 +10:00
Darren Tucker 25bd3c0612 - (dtucker) [sftp-server.8] Resync; spotted by djm@ 2006-09-26 20:14:28 +10:00
Darren Tucker 822d3a6fc1 - (dtucker) [bufaux.h] nuke bufaux.h; it's already gone from OpenBSD and not
referenced any more.  ok djm@
2006-09-26 18:59:34 +10:00
Darren Tucker f2ae7bf4a8 Trim ChangeLog Prior to 4.2p1 2006-09-26 18:57:28 +10:00
Tim Rice 983b35b281 20060924
- (tim) [configure.ac] Remove CFLAGS hack for UnixWare 1.x/2.x (added
   to rev 1.308) to work around broken gcc 2.x header file.
2006-09-24 12:08:59 -07:00
Darren Tucker 0ee3cbfc51 - (dtucker) [configure.ac] Bug #1234: Put opensc libs into $LIBS rather than
$LDFLAGS.  Patch from vapier at gentoo org.
2006-09-23 16:25:19 +10:00
Darren Tucker dace233d70 - (dtucker) [packet.c canohost.c] Include arpa/inet.h for htonl macros on
some platforms (eg HP-UX 11.00).  From santhi.amirta at gmail com.
2006-09-22 19:22:17 +10:00
Darren Tucker 0dc5484ca6 - (dtucker) [defines.h] Include unistd.h before defining getpgrp; fixes
build error on Ultrix.  From Bernhard Simon.
2006-09-21 23:13:30 +10:00
Darren Tucker 4aa665b71c - markus@cvs.openbsd.org 2006/09/19 21:14:08
[packet.c]
     client NULL deref on protocol error; Tavis Ormandy, Google Security Team
2006-09-21 13:00:25 +10:00
Darren Tucker 1e80e4023b - otto@cvs.openbsd.org 2006/09/19 05:52:23
[sftp.c]
     Use S_IS* macros insted of masking with S_IF* flags. The latter may
     have multiple bits set, which lead to surprising results. Spotted by
     Paul Stoeber, more to come. ok millert@ pedro@ jaredy@ djm@
2006-09-21 12:59:33 +10:00
Darren Tucker c70ce7b09d - (dtucker) [openbsd-compat/port-aix.{c,h}] Reduce scope of includes.
Prevents macro redefinition warnings of "RDONLY".
2006-09-18 23:54:32 +10:00
Darren Tucker 9216c37d60 - (dtucker) [configure.ac] On AIX, check to see if the compiler will allow
macro redefinitions, and if not, remove "-qlanglvl=ansi" from the flags.
   Allows build out of the box with older VAC and XLC compilers.  Found by
   David Bronder and Bernhard Simon.
2006-09-18 23:17:40 +10:00
Darren Tucker 83bbb03e52 - (dtucker) [INSTALL] Add info about audit support. 2006-09-17 22:55:52 +10:00
Damien Miller 1f062ca339 - (djm) [sshd.c] Fix warning/API abuse; ok dtucker@ 2006-09-17 14:04:46 +10:00
Darren Tucker 5965ae13e0 - (dtucker) [monitor.c] Correctly handle auditing of single commands when
using Protocol 1.  From jhb at freebsd.
2006-09-17 12:00:13 +10:00
Darren Tucker 54e1b2291c - (dtucker) [auth-pam.c] Propogate TZ environment variable to PAM auth
process so that any logging it does is with the right timezone.  From
   Scott Strickler, ok djm@.
2006-09-17 11:57:46 +10:00
Damien Miller dd1f9b307e - (djm) Add openssh.xml to .cvsignore and sort it 2006-09-17 08:05:03 +10:00
Damien Miller 3c9c1fbd21 - djm@cvs.openbsd.org 2006/09/16 19:53:37
[deattack.c deattack.h packet.c]
     limit maximum work performed by the CRC compensation attack detector,
     problem reported by Tavis Ormandy, Google Security Team;
     ok markus@ deraadt@
2006-09-17 06:08:53 +10:00
Damien Miller 223897a01a - (djm) [Makefile.in buildpkg.sh.in configure.ac openssh.xml.in]
Support SMF in Solaris Packages if enabled by configure. Patch from
   Chad Mynhier, tested by dtucker@
2006-09-12 21:54:10 +10:00
Darren Tucker 5d8a9acef0 - (dtucker) [cipher-aes.c] Include string.h for memcpy and friends. Noted
by Pekka Savola.
2006-09-11 20:46:13 +10:00
Darren Tucker 57b2920ad8 - (dtucker) [configure.ac] Add -lcrypt to let DragonFly build OOTB. 2006-09-10 20:25:51 +10:00