From 2b50837603a4aa00d7b33a30809316d2214d50f5 Mon Sep 17 00:00:00 2001
From: ivan <ivan@opensupports.com>
Date: Tue, 4 Oct 2016 18:42:47 -0300
Subject: [PATCH] Ivan - Add CustomResponse tests [skip ci]

---
 server/data/ERRORS.php         | 30 +++++++++++++++---------------
 tests/ticket/comment.rb        | 10 +++++-----
 tests/ticket/create.rb         | 12 ++++++------
 tests/user/edit-email.rb       |  4 ++--
 tests/user/edit-password.rb    |  6 +++---
 tests/user/login.rb            |  2 +-
 tests/user/recover-password.rb |  6 +++---
 tests/user/signup.rb           | 14 +++++++-------
 8 files changed, 42 insertions(+), 42 deletions(-)

diff --git a/server/data/ERRORS.php b/server/data/ERRORS.php
index e5b33417..a4ef80d2 100644
--- a/server/data/ERRORS.php
+++ b/server/data/ERRORS.php
@@ -1,20 +1,20 @@
 <?php
 class ERRORS {
-    const INVALID_CREDENTIALS = 'User or password is not defined';
-    const SESSION_EXISTS = 'User is already logged in';
-    const USER_EXISTS = 'Email already exists';
-    const NO_PERMISSION = 'You have no permission to access';
-    const INVALID_TITLE = 'Invalid title';
-    const INVALID_CONTENT = 'Invalid content';
-    const INVALID_EMAIL = 'Invalid email';
-    const INVALID_PASSWORD = 'Invalid password';
-    const INVALID_NAME = 'Invalid name';
-    const INVALID_SETTING = 'Invalid setting';
-    const INVALID_DEPARTMENT = 'Invalid department';
-    const INVALID_TICKET = 'Invalid ticket';
-    const INIT_SETTINGS_DONE = 'Settings already initialized';
-    const INVALID_OLD_PASSWORD = 'Invalid old password';
-    const INVALID_CAPTCHA = 'Invalid captcha';
+    const INVALID_CREDENTIALS = 'INVALID_CREDENTIALS';
+    const SESSION_EXISTS = 'SESSION_EXISTS';
+    const USER_EXISTS = 'USER_EXISTS';
+    const NO_PERMISSION = 'NO_PERMISSION';
+    const INVALID_TITLE = 'INVALID_TITLE';
+    const INVALID_CONTENT = 'INVALID_CONTENT';
+    const INVALID_EMAIL = 'INVALID_EMAIL';
+    const INVALID_PASSWORD = 'INVALID_PASSWORD';
+    const INVALID_NAME = 'INVALID_NAME';
+    const INVALID_SETTING = 'INVALID_SETTING';
+    const INVALID_DEPARTMENT = 'INVALID_DEPARTMENT';
+    const INVALID_TICKET = 'INVALID_TICKET';
+    const INIT_SETTINGS_DONE = 'INIT_SETTINGS_DONE';
+    const INVALID_OLD_PASSWORD = 'INVALID_OLD_PASSWORD';
+    const INVALID_CAPTCHA = 'INVALID_CAPTCHA';
     const INVALID_TICKET_EVENT = 'INVALID_TICKET_EVENT';
     const INVALID_LANGUAGE = 'INVALID_LANGUAGE';
 }
diff --git a/tests/ticket/comment.rb b/tests/ticket/comment.rb
index 422c2244..c05790cb 100644
--- a/tests/ticket/comment.rb
+++ b/tests/ticket/comment.rb
@@ -15,7 +15,7 @@ describe '/ticket/comment/' do
         })
 
         (result['status']).should.equal('fail')
-        (result['message']).should.equal('You have no permission to access')
+        (result['message']).should.equal('NO_PERMISSION')
     end
 
     it 'should fail if content is too short' do
@@ -27,7 +27,7 @@ describe '/ticket/comment/' do
         })
 
         (result['status']).should.equal('fail')
-        (result['message']).should.equal('Invalid content')
+        (result['message']).should.equal('INVALID_CONTENT')
     end
 
     it 'should fail if content is very long' do
@@ -42,7 +42,7 @@ describe '/ticket/comment/' do
         })
 
         (result['status']).should.equal('fail')
-        (result['message']).should.equal('Invalid content')
+        (result['message']).should.equal('INVALID_CONTENT')
     end
 
     it 'should fail if ticket does not exist' do
@@ -54,7 +54,7 @@ describe '/ticket/comment/' do
         })
 
         (result['status']).should.equal('fail')
-        (result['message']).should.equal('Invalid ticket')
+        (result['message']).should.equal('INVALID_TICKET')
     end
 
     it 'should add comment to ticket' do
@@ -86,7 +86,7 @@ describe '/ticket/comment/' do
         })
 
         (result['status']).should.equal('fail')
-        (result['message']).should.equal('You have no permission to access')
+        (result['message']).should.equal('NO_PERMISSION')
     end
 
     #it 'should add comment if logged as ticket owner' do
diff --git a/tests/ticket/create.rb b/tests/ticket/create.rb
index 9bde8203..d670f03d 100644
--- a/tests/ticket/create.rb
+++ b/tests/ticket/create.rb
@@ -12,7 +12,7 @@ describe '/ticket/create' do
         })
 
         (result['status']).should.equal('fail')
-        (result['message']).should.equal('You have no permission to access')
+        (result['message']).should.equal('NO_PERMISSION')
 
     end
 
@@ -25,7 +25,7 @@ describe '/ticket/create' do
         })
 
         (result['status']).should.equal('fail')
-        (result['message']).should.equal('Invalid title')
+        (result['message']).should.equal('INVALID_TITLE')
     end
 
     it 'should fail if title is very long' do
@@ -37,7 +37,7 @@ describe '/ticket/create' do
         })
 
         (result['status']).should.equal('fail')
-        (result['message']).should.equal('Invalid title')
+        (result['message']).should.equal('INVALID_TITLE')
     end
 
     it 'should fail if content is too short' do
@@ -50,7 +50,7 @@ describe '/ticket/create' do
         })
 
         (result['status']).should.equal('fail')
-        (result['message']).should.equal('Invalid content')
+        (result['message']).should.equal('INVALID_CONTENT')
     end
 
     it 'should fail if content is very long' do
@@ -66,7 +66,7 @@ describe '/ticket/create' do
         })
 
         (result['status']).should.equal('fail')
-        (result['message']).should.equal('Invalid content')
+        (result['message']).should.equal('INVALID_CONTENT')
 
     end
 
@@ -80,7 +80,7 @@ describe '/ticket/create' do
         })
 
         (result['status']).should.equal('fail')
-        (result['message']).should.equal('Invalid department')
+        (result['message']).should.equal('INVALID_DEPARTMENT')
 
     end
 
diff --git a/tests/user/edit-email.rb b/tests/user/edit-email.rb
index 63e4b1d4..b322f0c2 100644
--- a/tests/user/edit-email.rb
+++ b/tests/user/edit-email.rb
@@ -17,7 +17,7 @@ describe '/user/edit-email' do
             csrf_token: $csrf_token
         })
         (result['status']).should.equal('fail')
-        (result['message']).should.equal('Invalid email')
+        (result['message']).should.equal('INVALID_EMAIL')
 
         result = request('/user/edit-email', {
             newEmail: 'newemailjobs.com',
@@ -25,7 +25,7 @@ describe '/user/edit-email' do
             csrf_token: $csrf_token
         })
         (result['status']).should.equal('fail')
-        (result['message']).should.equal('Invalid email')
+        (result['message']).should.equal('INVALID_EMAIL')
     end
 
     it 'should change email' do
diff --git a/tests/user/edit-password.rb b/tests/user/edit-password.rb
index 88aeb72e..d9767e1b 100644
--- a/tests/user/edit-password.rb
+++ b/tests/user/edit-password.rb
@@ -18,7 +18,7 @@ describe '/user/edit-password' do
             csrf_token: $csrf_token
         })
         (result['status']).should.equal('fail')
-        (result['message']).should.equal('Invalid password')
+        (result['message']).should.equal('INVALID_PASSWORD')
 
         long_text = ''
         250.times {long_text << 'a'}
@@ -30,7 +30,7 @@ describe '/user/edit-password' do
             csrf_token: $csrf_token
         })
         (result['status']).should.equal('fail')
-        (result['message']).should.equal('Invalid password')
+        (result['message']).should.equal('INVALID_PASSWORD')
     end
 
     it 'should fail if old password is not same than old password ' do
@@ -41,7 +41,7 @@ describe '/user/edit-password' do
             csrf_token: $csrf_token
         })
         (result['status']).should.equal('fail')
-        (result['message']).should.equal('Invalid old password')
+        (result['message']).should.equal('INVALID_OLD_PASSWORD')
     end
 
     it 'should change password' do
diff --git a/tests/user/login.rb b/tests/user/login.rb
index 870cbc1f..0dc60c4a 100644
--- a/tests/user/login.rb
+++ b/tests/user/login.rb
@@ -29,7 +29,7 @@ describe '/user/login' do
         })
 
         (result['status']).should.equal('fail')
-        (result['message']).should.equal('User is already logged in')
+        (result['message']).should.equal('SESSION_EXISTS')
     end
 
     it 'should login staff member' do
diff --git a/tests/user/recover-password.rb b/tests/user/recover-password.rb
index a072f74a..168b2fcb 100644
--- a/tests/user/recover-password.rb
+++ b/tests/user/recover-password.rb
@@ -9,7 +9,7 @@ describe '/user/recover-password' do
         })
 
         (result['status']).should.equal('fail')
-        (result['message']).should.equal('Invalid email')
+        (result['message']).should.equal('INVALID_EMAIL')
 
         result = request('/user/recover-password', {
             email: 'loginos4.com',
@@ -17,7 +17,7 @@ describe '/user/recover-password' do
         })
 
         (result['status']).should.equal('fail')
-        (result['message']).should.equal('Invalid email')
+        (result['message']).should.equal('INVALID_EMAIL')
     end
 
     it 'should fail if password is incorrect' do
@@ -47,6 +47,6 @@ describe '/user/recover-password' do
         })
 
         (result['status']).should.equal('fail')
-        (result['message']).should.equal('You have no permission to access')
+        (result['message']).should.equal('NO_PERMISSION')
     end
 end
diff --git a/tests/user/signup.rb b/tests/user/signup.rb
index bebf131d..b3e0978b 100644
--- a/tests/user/signup.rb
+++ b/tests/user/signup.rb
@@ -23,7 +23,7 @@ describe '/user/signup' do
         })
 
         (result['status']).should.equal('fail')
-        (result['message']).should.equal('Invalid name')
+        (result['message']).should.equal('INVALID_NAME')
 
         result = request('/user/signup', {
             name: long_text,
@@ -32,7 +32,7 @@ describe '/user/signup' do
         })
 
         (result['status']).should.equal('fail')
-        (result['message']).should.equal('Invalid name')
+        (result['message']).should.equal('INVALID_NAME')
 
         result = request('/user/signup', {
             name: 'tyri0n',
@@ -41,7 +41,7 @@ describe '/user/signup' do
         })
 
         (result['status']).should.equal('fail')
-        (result['message']).should.equal('Invalid name')
+        (result['message']).should.equal('INVALID_NAME')
     end
 
     it 'should fail if email is invalid' do
@@ -52,7 +52,7 @@ describe '/user/signup' do
         })
 
         (result['status']).should.equal('fail')
-        (result['message']).should.equal('Invalid email')
+        (result['message']).should.equal('INVALID_EMAIL')
 
         result = request('/user/signup', {
             name: 'tyrion',
@@ -61,7 +61,7 @@ describe '/user/signup' do
         })
 
         (result['status']).should.equal('fail')
-        (result['message']).should.equal('Invalid email')
+        (result['message']).should.equal('INVALID_EMAIL')
     end
 
     it 'should fail if password is invalid' do
@@ -72,7 +72,7 @@ describe '/user/signup' do
         })
 
         (result['status']).should.equal('fail')
-        (result['message']).should.equal('Invalid password')
+        (result['message']).should.equal('INVALID_PASSWORD')
 
         long_text = ''
         250.times {long_text << 'a'}
@@ -84,7 +84,7 @@ describe '/user/signup' do
         })
 
         (result['status']).should.equal('fail')
-        (result['message']).should.equal('Invalid password')
+        (result['message']).should.equal('INVALID_PASSWORD')
     end
 
 end