From f0e1afc1ac552f993bd3c9b2a046650b732ad3ec Mon Sep 17 00:00:00 2001 From: Maxi Redigonda Date: Thu, 18 Jan 2018 20:11:49 -0300 Subject: [PATCH 1/4] Fixes title validations --- client/src/lib-app/validations/validations-factory.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/client/src/lib-app/validations/validations-factory.js b/client/src/lib-app/validations/validations-factory.js index 637a9401..fdd63284 100644 --- a/client/src/lib-app/validations/validations-factory.js +++ b/client/src/lib-app/validations/validations-factory.js @@ -7,7 +7,7 @@ import ListValidator from 'lib-app/validations/list-validator'; let validators = { 'DEFAULT': new Validator(), 'NAME': new LengthValidator(2, 'ERROR_NAME'), - 'TITLE': new LengthValidator(10, 'ERROR_TITLE'), + 'TITLE': new LengthValidator(1, 'ERROR_TITLE'), 'EMAIL': new EmailValidator(), 'TEXT_AREA': new LengthValidator(10, 'ERROR_CONTENT_SHORT'), 'PASSWORD': new LengthValidator(6, 'ERROR_PASSWORD'), @@ -23,4 +23,4 @@ class ValidatorFactory { } } -export default ValidatorFactory; \ No newline at end of file +export default ValidatorFactory; From 39fd45dced2408f04219e7e85a6d32791b8da837 Mon Sep 17 00:00:00 2001 From: Maxi Redigonda Date: Thu, 18 Jan 2018 20:24:44 -0300 Subject: [PATCH 2/4] Fixes minimum length in add article backend --- server/controllers/article/add.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/server/controllers/article/add.php b/server/controllers/article/add.php index c37b824f..ccd697a9 100755 --- a/server/controllers/article/add.php +++ b/server/controllers/article/add.php @@ -37,7 +37,7 @@ class AddArticleController extends Controller { 'permission' => 'staff_2', 'requestData' => [ 'title' => [ - 'validation' => DataValidator::length(3, 100), + 'validation' => DataValidator::length(1, 100), 'error' => ERRORS::INVALID_NAME ], 'content' => [ @@ -71,4 +71,4 @@ class AddArticleController extends Controller { 'articleId' => $article->store() ]); } -} \ No newline at end of file +} From 5460e5ad49e2de3f17545b0145d353ed3ea2c138 Mon Sep 17 00:00:00 2001 From: Maxi Redigonda Date: Thu, 18 Jan 2018 20:35:56 -0300 Subject: [PATCH 3/4] Modifies the export of validations-factory, so that it now matches the import from form.js --- client/src/lib-app/validations/validations-factory.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/client/src/lib-app/validations/validations-factory.js b/client/src/lib-app/validations/validations-factory.js index fdd63284..fbd51097 100644 --- a/client/src/lib-app/validations/validations-factory.js +++ b/client/src/lib-app/validations/validations-factory.js @@ -23,4 +23,4 @@ class ValidatorFactory { } } -export default ValidatorFactory; +export default ValidationFactory; From 9e3b6ef47f62af182fd9360c79205ee76177b72d Mon Sep 17 00:00:00 2001 From: Maxi Redigonda Date: Thu, 8 Feb 2018 12:11:19 -0300 Subject: [PATCH 4/4] Renames validation-factory to validator-factory and updates --- client/src/core-components/__tests__/form-test.js | 2 +- client/src/core-components/form.js | 2 +- .../{validations-factory.js => validator-factory.js} | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) rename client/src/lib-app/validations/{validations-factory.js => validator-factory.js} (96%) diff --git a/client/src/core-components/__tests__/form-test.js b/client/src/core-components/__tests__/form-test.js index f8d31de3..016ed26e 100644 --- a/client/src/core-components/__tests__/form-test.js +++ b/client/src/core-components/__tests__/form-test.js @@ -5,7 +5,7 @@ const FormField = ReactMock(); // COMPONENT const Form = requireUnit('core-components/form', { - 'lib-app/validations/validations-factory': ValidationFactoryMock, + 'lib-app/validations/validator-factory': ValidationFactoryMock, 'core-components/form-field': FormField, 'core-components/text-editor': TextEditorMock }); diff --git a/client/src/core-components/form.js b/client/src/core-components/form.js index e7387e03..cd1a6642 100644 --- a/client/src/core-components/form.js +++ b/client/src/core-components/form.js @@ -3,7 +3,7 @@ import _ from 'lodash'; import classNames from 'classnames'; import {reactDFS, renderChildrenWithProps} from 'lib-core/react-dfs'; -import ValidationFactory from 'lib-app/validations/validations-factory'; +import ValidationFactory from 'lib-app/validations/validator-factory'; import FormField from 'core-components/form-field'; import TextEditor from 'core-components/text-editor'; diff --git a/client/src/lib-app/validations/validations-factory.js b/client/src/lib-app/validations/validator-factory.js similarity index 96% rename from client/src/lib-app/validations/validations-factory.js rename to client/src/lib-app/validations/validator-factory.js index fbd51097..fdd63284 100644 --- a/client/src/lib-app/validations/validations-factory.js +++ b/client/src/lib-app/validations/validator-factory.js @@ -23,4 +23,4 @@ class ValidatorFactory { } } -export default ValidationFactory; +export default ValidatorFactory;