Merge pull request #379 from ivandiazwm/v4.3.1

Fix ticket number collision #378
This commit is contained in:
Ivan Diaz 2018-11-15 16:19:11 -03:00 committed by GitHub
commit c436365c07
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -96,15 +96,15 @@ class Ticket extends DataStore {
public function generateUniqueTicketNumber() {
$linearCongruentialGenerator = new LinearCongruentialGenerator();
$ticketQuantity = Ticket::count();
if ($ticketQuantity === 0) {
if (Ticket::count() === 0) {
$ticketNumber = Setting::getSetting('ticket-first-number')->value;
} else {
$lastTicketId = Ticket::findOne(' ORDER BY id DESC')->id;
$linearCongruentialGenerator->setGap(Setting::getSetting('ticket-gap')->value);
$linearCongruentialGenerator->setFirst(Setting::getSetting('ticket-first-number')->value);
$ticketNumber = $linearCongruentialGenerator->generate($ticketQuantity);
$ticketNumber = $linearCongruentialGenerator->generate($lastTicketId + 1);
}
return $ticketNumber;