From 04cb80614d3d3309f0a0a84bb632dd2c8102cf84 Mon Sep 17 00:00:00 2001
From: santimunin <noreply@pandorafms.org>
Date: Fri, 1 Jun 2012 13:48:48 +0000
Subject: [PATCH] =?UTF-8?q?2012-06-01=20Santiago=20Mun=C3=ADn=20<burnin1@g?=
 =?UTF-8?q?mail.com>=20=09*=20Little=20changes=20on=20the=20whole=20app:?=
 =?UTF-8?q?=20Fixed=20some=20Lint=20errors.?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

git-svn-id: https://svn.code.sf.net/p/pandora/code/trunk@6404 c3f86ba8-e40f-0410-aaad-9ba5e7f4b01f
---
 extras/pandroid_event_viewer/ChangeLog                   | 3 +++
 extras/pandroid_event_viewer/res/layout/about.xml        | 7 ++++---
 extras/pandroid_event_viewer/res/layout/info.xml         | 9 +++++----
 extras/pandroid_event_viewer/res/values/strings.xml      | 3 +++
 .../src/pandroid_event_viewer/pandorafms/Main.java       | 2 +-
 .../pandorafms/PandroidEventviewerService.java           | 2 +-
 .../pandorafms/PopupValidationEvent.java                 | 2 +-
 7 files changed, 18 insertions(+), 10 deletions(-)

diff --git a/extras/pandroid_event_viewer/ChangeLog b/extras/pandroid_event_viewer/ChangeLog
index 49010025a8..c17bef9b41 100644
--- a/extras/pandroid_event_viewer/ChangeLog
+++ b/extras/pandroid_event_viewer/ChangeLog
@@ -1,3 +1,6 @@
+2012-06-01 Santiago Munín <burnin1@gmail.com>
+	* Little changes on the whole app: Fixed some Lint errors.
+
 2012-06-01 Santiago Munín <burnin1@gmail.com>
 	* src/pandroid_event_viewer/pandorafms/Core.java: Added image setting methods.
 	* src/pandroid_event_viewer/pandorafms/EventList.java: Removed image setting methods.
diff --git a/extras/pandroid_event_viewer/res/layout/about.xml b/extras/pandroid_event_viewer/res/layout/about.xml
index 45655bbb9f..a21499de93 100644
--- a/extras/pandroid_event_viewer/res/layout/about.xml
+++ b/extras/pandroid_event_viewer/res/layout/about.xml
@@ -23,17 +23,18 @@
 >
 	<ImageView
 		android:layout_weight="0"
+		android:contentDescription="@string/pandorafms_logo_description"
 		android:id="@+id/img_logo_about"
 		android:layout_width="wrap_content"
-   		android:layout_height="wrap_content"
+   		android:layout_height="0dp"
    		android:layout_gravity="center"
-   		android:padding="5px"
+   		android:padding="5dp"
    		android:src="@drawable/pandorafms_logo"
 	/>
 	<TextView
 		android:layout_width="wrap_content"
 		android:layout_height="wrap_content"
-		android:text="Copyright (c) 2011 Artica"
+		android:text="@string/artica_copyright"
 	/>
 	<TextView
 		android:layout_width="wrap_content"
diff --git a/extras/pandroid_event_viewer/res/layout/info.xml b/extras/pandroid_event_viewer/res/layout/info.xml
index 76d7363e82..2353d034ad 100644
--- a/extras/pandroid_event_viewer/res/layout/info.xml
+++ b/extras/pandroid_event_viewer/res/layout/info.xml
@@ -23,11 +23,12 @@
 >
 	<ImageView
 		android:layout_weight="0"
+		android:contentDescription="@string/pandorafms_logo_description"
 		android:id="@+id/img_logo_about"
 		android:layout_width="wrap_content"
-   		android:layout_height="wrap_content"
+   		android:layout_height="0dp"
    		android:layout_gravity="center"
-   		android:padding="5px"
+   		android:padding="5dp"
    		android:src="@drawable/pandorafms_logo"
 	/>
 	<TextView
@@ -53,9 +54,9 @@
 	    android:layout_height="wrap_content"
 	>
 		<TextView
-		    android:layout_width="wrap_content"
+		    android:layout_width="0dp"
 		    android:layout_height="wrap_content"
-		    android:text="Don't show again"
+		    android:text="@string/dont_show_again"
 		    android:layout_weight="2"
 		/>
 		<CheckBox
diff --git a/extras/pandroid_event_viewer/res/values/strings.xml b/extras/pandroid_event_viewer/res/values/strings.xml
index a39de4ffc1..95fd59ae5e 100644
--- a/extras/pandroid_event_viewer/res/values/strings.xml
+++ b/extras/pandroid_event_viewer/res/values/strings.xml
@@ -102,4 +102,7 @@
 	<string name="img_severity">Severity image</string>
 	<string name="img_group">Group image</string>
 	<string name="img_type">Type image</string>
+	<string name="artica_copyright">Copyright (&#169;) 2011 Artica</string>
+	<string name="dont_show_again">Don\'t show again</string>
+	<string name="pandorafms_logo_description">PandoraFMS\'s logo</string>
 </resources>
\ No newline at end of file
diff --git a/extras/pandroid_event_viewer/src/pandroid_event_viewer/pandorafms/Main.java b/extras/pandroid_event_viewer/src/pandroid_event_viewer/pandorafms/Main.java
index cd583dc4fe..ac1f7184d0 100644
--- a/extras/pandroid_event_viewer/src/pandroid_event_viewer/pandorafms/Main.java
+++ b/extras/pandroid_event_viewer/src/pandroid_event_viewer/pandorafms/Main.java
@@ -216,7 +216,7 @@ public class Main extends Activity {
 			for (int i = 0; i < lines.length; i++) {
 				String[] groups = lines[i].split(";", 21);
 
-				this.pandoraGroups.put(new Integer(groups[0]), groups[1]);
+				this.pandoraGroups.put(Integer.valueOf(groups[0]), groups[1]);
 
 				array.add(groups[1]);
 			}
diff --git a/extras/pandroid_event_viewer/src/pandroid_event_viewer/pandorafms/PandroidEventviewerService.java b/extras/pandroid_event_viewer/src/pandroid_event_viewer/pandorafms/PandroidEventviewerService.java
index bf136da2de..538ecf96d2 100644
--- a/extras/pandroid_event_viewer/src/pandroid_event_viewer/pandorafms/PandroidEventviewerService.java
+++ b/extras/pandroid_event_viewer/src/pandroid_event_viewer/pandorafms/PandroidEventviewerService.java
@@ -121,7 +121,7 @@ public class PandroidEventviewerService extends IntentService {
 						serializeParams2Api(context, false, true, true)));
 				return_api = Core.httpGet(getApplicationContext(), parameters);
 				return_api = return_api.replace("\n", "");
-				this.more_criticity = new Integer(return_api).intValue();
+				this.more_criticity = Integer.valueOf(return_api).intValue();
 				notificationEvent(context);
 			} else {
 				this.more_criticity = -1;
diff --git a/extras/pandroid_event_viewer/src/pandroid_event_viewer/pandorafms/PopupValidationEvent.java b/extras/pandroid_event_viewer/src/pandroid_event_viewer/pandorafms/PopupValidationEvent.java
index a77230d08d..9d808c49b2 100644
--- a/extras/pandroid_event_viewer/src/pandroid_event_viewer/pandorafms/PopupValidationEvent.java
+++ b/extras/pandroid_event_viewer/src/pandroid_event_viewer/pandorafms/PopupValidationEvent.java
@@ -97,7 +97,7 @@ public class PopupValidationEvent extends Activity {
 		parameters = new ArrayList<NameValuePair>();
 		parameters.add(new BasicNameValuePair("op", "set"));
 		parameters.add(new BasicNameValuePair("op2", "validate_events"));
-		parameters.add(new BasicNameValuePair("id", new Integer(this.id_event)
+		parameters.add(new BasicNameValuePair("id", Integer.valueOf(this.id_event)
 				.toString()));
 		parameters.add(new BasicNameValuePair("other", this.comment));
 		String return_api = Core.httpGet(getApplicationContext(), parameters);