From b7bd2894576ff4a79aeb1cf98cabfe4209460983 Mon Sep 17 00:00:00 2001
From: Ramon Novoa <ramon.novoa@pandorafms.com>
Date: Thu, 25 Jan 2024 12:06:27 +0100
Subject: [PATCH 01/26] Generate an event when there are too many XML data
 files queued for an agent.

---
 pandora_server/conf/pandora_server.conf.new |  3 ++
 pandora_server/lib/PandoraFMS/Config.pm     |  5 ++++
 pandora_server/lib/PandoraFMS/DataServer.pm | 31 +++++++++++++++++++++
 3 files changed, 39 insertions(+)

diff --git a/pandora_server/conf/pandora_server.conf.new b/pandora_server/conf/pandora_server.conf.new
index bddb11a293..15095c78be 100644
--- a/pandora_server/conf/pandora_server.conf.new
+++ b/pandora_server/conf/pandora_server.conf.new
@@ -816,3 +816,6 @@ madeserver_autofit 7d
 # Model sensitivity. A lower value triggers less anomalies (PANDORA FMS ENTERPRISE ONLY).
 madeserver_sensitivity 0.1
 
+# If greater than 0, generate an event when more than the specified number of XML data files are queued for an agent.
+too_many_xml 10
+
diff --git a/pandora_server/lib/PandoraFMS/Config.pm b/pandora_server/lib/PandoraFMS/Config.pm
index eb23fcce89..2f48005c2f 100644
--- a/pandora_server/lib/PandoraFMS/Config.pm
+++ b/pandora_server/lib/PandoraFMS/Config.pm
@@ -589,6 +589,8 @@ sub pandora_load_config {
 
 	$pa_config->{"madeserver"} = 0; # 774.
 
+	$pa_config->{"too_many_xml"} = 10; # 776.
+
 	# Check for UID0
 	if ($pa_config->{"quiet"} != 0){
 		if ($> == 0){
@@ -1412,6 +1414,9 @@ sub pandora_load_config {
 		elsif ($parametro =~ m/^madeserver\s+([0-1])/i){
 			$pa_config->{'madeserver'}= clean_blank($1);
 		}
+		elsif ($parametro =~ m/^too_many_xml\s+([0-9]*)/i){
+			$pa_config->{'too_many_xml'}= clean_blank($1);
+		}
 	} # end of loop for parameter #
 
 	# The DB host was overridden by pandora_ha.
diff --git a/pandora_server/lib/PandoraFMS/DataServer.pm b/pandora_server/lib/PandoraFMS/DataServer.pm
index 80e8bb4bd3..d771d511c2 100644
--- a/pandora_server/lib/PandoraFMS/DataServer.pm
+++ b/pandora_server/lib/PandoraFMS/DataServer.pm
@@ -56,6 +56,7 @@ our @ISA = qw(PandoraFMS::ProducerConsumerServer);
 my @TaskQueue :shared;
 my %PendingTasks :shared;
 my %Agents :shared;
+my %AgentCounts;
 my $Sem :shared;
 my $TaskSem :shared;
 my $AgentSem :shared;
@@ -73,6 +74,7 @@ sub new ($$;$) {
 	@TaskQueue = ();
 	%PendingTasks = ();
 	%Agents = ();
+	%AgentCounts = ();
 	$Sem = Thread::Semaphore->new;
 	$TaskSem = Thread::Semaphore->new (0);
 	$AgentSem = Thread::Semaphore->new (1);
@@ -142,6 +144,9 @@ sub data_producer ($) {
 	opendir (DIR, $pa_config->{'incomingdir'})
 		|| die "[FATAL] Cannot open Incoming data directory at " . $pa_config->{'incomingdir'} . ": $!";
 
+	# Reset agent XML file counts 
+	%AgentCounts = ();
+
 	# Do not read more than max_queue_files files
  	my $file_count = 0;
  	while (my $file = readdir (DIR)) {
@@ -177,11 +182,21 @@ sub data_producer ($) {
 		next if ($file !~ /^(.*)[\._]\d+\.data$/);
 		my $agent_name = $1;
 
+		$AgentCounts{$agent_name} = defined($AgentCounts{$agent_name}) ? $AgentCounts{$agent_name} + 1 : 1;
 		next if (agent_lock($pa_config, $dbh, $agent_name) == 0);
 			
 		push (@tasks, $file);
 	}
 
+	# Generate an event if there are too many XML files for a given agent.
+	if ($pa_config->{'too_many_xml'} > 0) {
+		while (my ($agent_name, $xml_count) = each(%AgentCounts)) {
+			if ($xml_count > $pa_config->{'too_many_xml'}) {
+				pandora_timed_event(300, $pa_config, "Too many XML files for agent $agent_name ($xml_count)", 0, 0, 0, 0, 0, 'warning', 0, $dbh);
+			}
+		}
+	}
+
 	return @tasks;
 }
 
@@ -200,6 +215,9 @@ sub data_producer_smart_queue ($) {
 	opendir (DIR, $pa_config->{'incomingdir'})
 		|| die "[FATAL] Cannot open Incoming data directory at " . $pa_config->{'incomingdir'} . ": $!";
 
+	# Reset agent XML file counts 
+	%AgentCounts = ();
+
 	# Do not read more than max_queue_files files
 	my $smart_queue = {};
  	while (my $file = readdir (DIR)) {
@@ -209,6 +227,9 @@ sub data_producer_smart_queue ($) {
 		next if ($file !~ /^(.*)[\._]\d+\.data$/);
 		my $agent_name = $1;
 
+		# Update per agent XML counts.
+		$AgentCounts{$agent_name} = defined($AgentCounts{$agent_name}) ? $AgentCounts{$agent_name} + 1 : 1;
+
 		# Queue a new file.
 		if (!defined($smart_queue->{$agent_name})) {
 			$smart_queue->{$agent_name} = $file;
@@ -229,6 +250,16 @@ sub data_producer_smart_queue ($) {
 		push (@tasks, $file);
 	}
 
+	# Generate an event if there are too many XML files for a given agent.
+	if ($pa_config->{'too_many_xml'} > 0) {
+		while (my ($agent_name, $xml_count) = each(%AgentCounts)) {
+			print ">>> AGENT: $agent_name COUNT: $xml_count\n";
+			if ($xml_count > $pa_config->{'too_many_xml'}) {
+				pandora_timed_event(300, $pa_config, "Too many XML files for agent $agent_name ($xml_count)", 0, 0, 0, 0, 0, 'warning', 0, $dbh);
+			}
+		}
+	}
+
 	return @tasks;
 }
 

From f2a15061f0bcb2b8ecf2e1afb9b646c825c38930 Mon Sep 17 00:00:00 2001
From: Daniel Cebrian <daniel.cebrian@pandorafms.com>
Date: Wed, 7 Feb 2024 15:39:23 +0100
Subject: [PATCH 02/26] #12783 check if module is use by agent for safe mode
 before delete

---
 .../godmode/agentes/configurar_agente.php     |  6 +++++
 pandora_console/include/functions_modules.php | 25 +++++++++++++++++++
 2 files changed, 31 insertions(+)

diff --git a/pandora_console/godmode/agentes/configurar_agente.php b/pandora_console/godmode/agentes/configurar_agente.php
index c2e3a2f4f6..a2372a66f0 100644
--- a/pandora_console/godmode/agentes/configurar_agente.php
+++ b/pandora_console/godmode/agentes/configurar_agente.php
@@ -2318,6 +2318,12 @@ if ($delete_module) {
         exit;
     }
 
+    // Check if module is used by agent for Safe mode.
+    $is_safe_mode_module = modules_check_safe_mode($id_borrar_modulo);
+    if ($is_safe_mode_module === true) {
+        db_process_sql_update('tagente', ['safe_mode_module' => '0'], ['id_agente' => $id_agente]);
+    }
+
     // Before delete the main module, check and delete the childrens from the original module.
     module_check_childrens_and_delete($id_borrar_modulo);
 
diff --git a/pandora_console/include/functions_modules.php b/pandora_console/include/functions_modules.php
index 2d3b5676ec..91f6ffc5d1 100755
--- a/pandora_console/include/functions_modules.php
+++ b/pandora_console/include/functions_modules.php
@@ -5074,3 +5074,28 @@ function modules_made_compatible($id_tipo_modulo)
         return true;
     }
 }
+
+
+/**
+ * Check if module is used by agent for Safe mode.
+ *
+ * @param integer $id_module Id for module to check
+ *
+ * @return boolean
+ */
+function modules_check_safe_mode($id_module)
+{
+    $id_agent = modules_give_agent_id_from_module_id($id_module);
+    if ($id_agent === 0) {
+        // No exist agent with this id.
+        return false;
+    }
+
+    $agent = agents_get_agent($id_agent);
+
+    if (isset($agent['safe_mode_module']) === true && (int) $agent['safe_mode_module'] === (int) $id_module) {
+        return true;
+    } else {
+        return false;
+    }
+}

From 2246fd8049e9e1781d8d273f8782f5a41697c4b9 Mon Sep 17 00:00:00 2001
From: Jonathan <jonathan.leon@pandorafms.com>
Date: Wed, 7 Feb 2024 16:39:33 +0100
Subject: [PATCH 03/26] #12695 WIP warnings

---
 pandora_console/general/header.php            |  4 +
 pandora_console/general/noaccess.php          |  8 +-
 pandora_console/godmode/menu.php              | 10 ++-
 .../wizards/ManageExtensions.class.php        |  3 +-
 .../class/ExtensionsDiscovery.class.php       |  3 +-
 .../include/class/WelcomeWindow.class.php     | 12 ++-
 pandora_console/include/functions_graph.php   | 12 +--
 .../include/functions_register.php            |  2 +-
 pandora_console/include/functions_reports.php |  2 +-
 pandora_console/include/functions_ui.php      | 26 +++---
 pandora_console/include/graphs/fgraph.php     |  6 +-
 .../lib/TacticalView/GeneralTacticalView.php  |  8 +-
 .../lib/TacticalView/elements/Agents.php      |  1 +
 .../lib/TacticalView/elements/Events.php      |  3 +-
 .../lib/TacticalView/elements/Groups.php      |  3 +
 .../elements/MonitoringElements.php           | 15 ++--
 .../elements/ScheduledDowntime.php            | 82 ++++++++++---------
 pandora_console/index.php                     |  4 +
 pandora_console/operation/events/events.php   | 13 ++-
 .../views/dashboard/tipsWindow.php            |  6 +-
 20 files changed, 135 insertions(+), 88 deletions(-)

diff --git a/pandora_console/general/header.php b/pandora_console/general/header.php
index 35b994fead..0110e745ae 100644
--- a/pandora_console/general/header.php
+++ b/pandora_console/general/header.php
@@ -161,6 +161,10 @@ echo sprintf('<div id="header_table" class="header_table_%s">', $menuTypeClass);
             'code'         => false,
         ];
 
+        if (isset($_GET['sec']) === false) {
+            $_GET['sec'] = '';
+        }
+
         if (!isset($_GET['sec2'])) {
             $_GET['sec2'] = '';
         }
diff --git a/pandora_console/general/noaccess.php b/pandora_console/general/noaccess.php
index b2fe4515a2..9299489864 100644
--- a/pandora_console/general/noaccess.php
+++ b/pandora_console/general/noaccess.php
@@ -152,9 +152,11 @@
                 echo __('Access to this page is restricted to authorized users only, please contact system administrator if you need assistance.');
                 echo '<br/> <br/>';
                 echo __('Please know that all attempts to access this page are recorded in security logs of %s System Database', get_product_name());
-                if ($config['logged'] == false) {
-                    if (session_status() === PHP_SESSION_ACTIVE) {
-                        session_destroy();
+                if (isset($config['logged']) === true) {
+                    if ($config['logged'] == false) {
+                        if (session_status() === PHP_SESSION_ACTIVE) {
+                            session_destroy();
+                        }
                     }
                 }
                 ?>
diff --git a/pandora_console/godmode/menu.php b/pandora_console/godmode/menu.php
index 3505e7cf2c..db8d1132c3 100644
--- a/pandora_console/godmode/menu.php
+++ b/pandora_console/godmode/menu.php
@@ -521,10 +521,12 @@ if ($access_console_node === true) {
 if ((bool) check_acl($config['id_user'], 0, 'AW') === true) {
     $show_ipam = false;
     $ipam = db_get_all_rows_sql('SELECT users_operator FROM tipam_network');
-    foreach ($ipam as $row) {
-        if (str_contains($row['users_operator'], '-1') || str_contains($row['users_operator'], $config['id_user'])) {
-            $show_ipam = true;
-            break;
+    if ($ipam !== false) {
+        foreach ($ipam as $row) {
+            if (str_contains($row['users_operator'], '-1') || str_contains($row['users_operator'], $config['id_user'])) {
+                $show_ipam = true;
+                break;
+            }
         }
     }
 }
diff --git a/pandora_console/godmode/wizards/ManageExtensions.class.php b/pandora_console/godmode/wizards/ManageExtensions.class.php
index 34c9950bc6..deb2a4dbf5 100644
--- a/pandora_console/godmode/wizards/ManageExtensions.class.php
+++ b/pandora_console/godmode/wizards/ManageExtensions.class.php
@@ -214,7 +214,8 @@ class ManageExtensions extends HTML
                 break;
 
                 default:
-                continue;
+                    // Nothing.
+                break;
             }
         }
 
diff --git a/pandora_console/include/class/ExtensionsDiscovery.class.php b/pandora_console/include/class/ExtensionsDiscovery.class.php
index b9b5d0ebf2..f132cc160f 100644
--- a/pandora_console/include/class/ExtensionsDiscovery.class.php
+++ b/pandora_console/include/class/ExtensionsDiscovery.class.php
@@ -2190,7 +2190,8 @@ class ExtensionsDiscovery extends Wizard
                 break;
 
                 default:
-                continue;
+                    // Nothing.
+                break;
             }
 
             if ($value !== false) {
diff --git a/pandora_console/include/class/WelcomeWindow.class.php b/pandora_console/include/class/WelcomeWindow.class.php
index 4a157540c5..ba9c89e350 100644
--- a/pandora_console/include/class/WelcomeWindow.class.php
+++ b/pandora_console/include/class/WelcomeWindow.class.php
@@ -376,10 +376,6 @@ class WelcomeWindow extends Wizard
             'class'    => 'modal',
         ];
 
-        if (enterprise_installed() === true) {
-            $logo_url = ENTERPRISE_DIR.'/'.$logo_url;
-        }
-
         if (check_acl($config['id_user'], 0, 'PM')) {
             $flag_um = false;
             $flag_cm = false;
@@ -768,6 +764,10 @@ class WelcomeWindow extends Wizard
                 ],
                 true
             );
+            if (isset($agents_num) === false) {
+                $agents_num = '';
+            }
+
             echo html_print_label_input_block(
                 __('Number of agents to be created'),
                 html_print_div(
@@ -893,6 +893,10 @@ class WelcomeWindow extends Wizard
                 __('Agent'),
                 ui_print_agent_autocomplete_input($params)
             );
+            if (isset($modules) === false) {
+                $modules = '';
+            }
+
             echo html_print_label_input_block(
                 __('Module'),
                 html_print_select(
diff --git a/pandora_console/include/functions_graph.php b/pandora_console/include/functions_graph.php
index f713f68ee0..ce8a10527c 100644
--- a/pandora_console/include/functions_graph.php
+++ b/pandora_console/include/functions_graph.php
@@ -4701,11 +4701,13 @@ function graph_nodata_image($options)
 {
     global $config;
 
-    if ($options['base64'] === true) {
-        $dataImg = file_get_contents(
-            $config['homedir'].'/images/image_problem_area_150.png'
-        );
-        return base64_encode($dataImg);
+    if (isset($options['base64']) === true) {
+        if ($options['base64'] === true) {
+            $dataImg = file_get_contents(
+                $config['homedir'].'/images/image_problem_area_150.png'
+            );
+            return base64_encode($dataImg);
+        }
     }
 
     $style = '';
diff --git a/pandora_console/include/functions_register.php b/pandora_console/include/functions_register.php
index db1bc8bf21..6b1d6ec0a7 100644
--- a/pandora_console/include/functions_register.php
+++ b/pandora_console/include/functions_register.php
@@ -144,7 +144,7 @@ function config_wiz_modal(
         'UTC'        => __('UTC'),
     ];
 
-    if ($zone_selected == '') {
+    if (isset($zone_selected) === false) {
         if ($config['timezone'] != '') {
             $zone_array = explode('/', $config['timezone']);
             $zone_selected = $zone_array[0];
diff --git a/pandora_console/include/functions_reports.php b/pandora_console/include/functions_reports.php
index bb9f57f5c3..c8e774acc7 100755
--- a/pandora_console/include/functions_reports.php
+++ b/pandora_console/include/functions_reports.php
@@ -1435,7 +1435,7 @@ function custom_fields_macros_report($macro, $key_macro)
                         $macro['server_id']
                     );
                     if (metaconsole_connect($server) != NOERR) {
-                        continue;
+                        break;
                     }
                 }
 
diff --git a/pandora_console/include/functions_ui.php b/pandora_console/include/functions_ui.php
index 09803c43c6..bcf23c6d71 100755
--- a/pandora_console/include/functions_ui.php
+++ b/pandora_console/include/functions_ui.php
@@ -4004,19 +4004,21 @@ function ui_print_datatable(array $parameters)
     $parameters['order']['order'] = $order;
     $parameters['order']['direction'] = $direction;
 
-    foreach ($parameters['no_sortable_columns'] as $key => $find) {
-        $found = array_search(
-            $parameters['no_sortable_columns'][$key],
-            $columns_tmp
-        );
+    if (isset($parameters['no_sortable_columns']) === true) {
+        foreach ($parameters['no_sortable_columns'] as $key => $find) {
+            $found = array_search(
+                $parameters['no_sortable_columns'][$key],
+                $columns_tmp
+            );
 
-        if ($found !== false) {
-            unset($parameters['no_sortable_columns'][$key]);
-            array_push($parameters['no_sortable_columns'], $found);
-        }
+            if ($found !== false) {
+                unset($parameters['no_sortable_columns'][$key]);
+                array_push($parameters['no_sortable_columns'], $found);
+            }
 
-        if (is_int($parameters['no_sortable_columns'][$key]) === false) {
-            unset($parameters['no_sortable_columns'][$key]);
+            if (is_int($parameters['no_sortable_columns'][$key]) === false) {
+                unset($parameters['no_sortable_columns'][$key]);
+            }
         }
     }
 
@@ -4234,7 +4236,7 @@ function ui_print_datatable(array $parameters)
     }
 
     $parameters['phpDate'] = date('Y-m-d');
-    $parameters['dataElements'] = json_encode($parameters['data_element']);
+    $parameters['dataElements'] = (isset($parameters['data_element']) === true) ? json_encode($parameters['data_element']) : '';
 
     // * START JAVASCRIPT.
     $file_path = $config['homedir'].'/include/javascript/datatablesFunction.js';
diff --git a/pandora_console/include/graphs/fgraph.php b/pandora_console/include/graphs/fgraph.php
index d8db7d64d9..5861f67033 100644
--- a/pandora_console/include/graphs/fgraph.php
+++ b/pandora_console/include/graphs/fgraph.php
@@ -1355,12 +1355,12 @@ function get_build_setup_charts($type, $options, $data)
                 $chart->labels()->exchangeArray($options['labels']);
                 foreach ($data as $key => $dataset) {
                     $dataSet = $chart->createDataSet();
-                    $dataSet->setLabel($dataset['label']);
+                    $dataSet->setLabel((isset($dataset['label']) === true) ? $dataset['label'] : '');
                     $dataSet->setBackgroundColor($dataset['backgroundColor']);
                     $dataSet->setBorderColor($dataset['borderColor']);
                     $dataSet->setPointBackgroundColor($dataset['pointBackgroundColor']);
-                    $dataSet->setPointBorderColor($dataset['pointBorderColor']);
-                    $dataSet->setPointHoverBackgroundColor($dataset['pointHoverBackgroundColor']);
+                    $dataSet->setPointBorderColor((isset($dataset['pointBorderColor']) === true) ? $dataset['pointBorderColor'] : '');
+                    $dataSet->setPointHoverBackgroundColor((isset($dataset['pointHoverBackgroundColor']) === true) ? $dataset['pointHoverBackgroundColor'] : '');
                     $dataSet->setPointHoverBorderColor($dataset['pointHoverBorderColor']);
                     $dataSet->data()->exchangeArray($dataset['data']);
                     $chart->addDataSet($dataSet);
diff --git a/pandora_console/include/lib/TacticalView/GeneralTacticalView.php b/pandora_console/include/lib/TacticalView/GeneralTacticalView.php
index 06e27e4fd6..02f60f8252 100644
--- a/pandora_console/include/lib/TacticalView/GeneralTacticalView.php
+++ b/pandora_console/include/lib/TacticalView/GeneralTacticalView.php
@@ -144,9 +144,11 @@ class GeneralTacticalView
     {
         $js = '<script>';
         foreach ($this->elements as $key => $element) {
-            if ($element->interval > 0) {
-                foreach ($element->refreshConfig as $key => $conf) {
-                    $js .= 'autoRefresh('.$element->interval.',"'.$conf['id'].'", "'.$conf['method'].'", "'.$element->nameClass().'");';
+            if (isset($element->interval) === true) {
+                if ($element->interval > 0) {
+                    foreach ($element->refreshConfig as $key => $conf) {
+                        $js .= 'autoRefresh('.$element->interval.',"'.$conf['id'].'", "'.$conf['method'].'", "'.$element->nameClass().'");';
+                    }
                 }
             }
         }
diff --git a/pandora_console/include/lib/TacticalView/elements/Agents.php b/pandora_console/include/lib/TacticalView/elements/Agents.php
index bb2df62eb4..171a31f580 100644
--- a/pandora_console/include/lib/TacticalView/elements/Agents.php
+++ b/pandora_console/include/lib/TacticalView/elements/Agents.php
@@ -34,6 +34,7 @@ class Agents extends Element
      */
     public function __construct()
     {
+        global $config;
         parent::__construct();
         include_once $config['homedir'].'/include/graphs/fgraph.php';
         include_once $config['homedir'].'/include/functions_graph.php';
diff --git a/pandora_console/include/lib/TacticalView/elements/Events.php b/pandora_console/include/lib/TacticalView/elements/Events.php
index 1c87f4cc9e..de38641fe8 100644
--- a/pandora_console/include/lib/TacticalView/elements/Events.php
+++ b/pandora_console/include/lib/TacticalView/elements/Events.php
@@ -391,7 +391,8 @@ class Events extends Element
                 break;
 
                 default:
-                continue;
+                    // Nothing.
+                break;
             }
 
             $labels[] = $this->controlSizeText($label);
diff --git a/pandora_console/include/lib/TacticalView/elements/Groups.php b/pandora_console/include/lib/TacticalView/elements/Groups.php
index 7a691d6b7c..d1bfda4e77 100644
--- a/pandora_console/include/lib/TacticalView/elements/Groups.php
+++ b/pandora_console/include/lib/TacticalView/elements/Groups.php
@@ -73,6 +73,9 @@ class Groups extends Element
     public function getStatusHeatMap():string
     {
         global $config;
+        if (isset($config['id_group']) === false) {
+            $config['id_group'] = false;
+        }
 
         $groups = users_get_groups($config['id_group'], 'AR', false);
         if (is_array($groups) === true && count($groups) >= 10) {
diff --git a/pandora_console/include/lib/TacticalView/elements/MonitoringElements.php b/pandora_console/include/lib/TacticalView/elements/MonitoringElements.php
index 8a572219bd..b5722e5646 100644
--- a/pandora_console/include/lib/TacticalView/elements/MonitoringElements.php
+++ b/pandora_console/include/lib/TacticalView/elements/MonitoringElements.php
@@ -34,6 +34,7 @@ class MonitoringElements extends Element
      */
     public function __construct()
     {
+        global $config;
         parent::__construct();
         include_once $config['homedir'].'/include/graphs/fgraph.php';
         include_once $config['homedir'].'/include/functions_graph.php';
@@ -58,13 +59,15 @@ class MonitoringElements extends Element
 
         $labels = [];
         $data = [];
-        foreach ($rows as $key => $row) {
-            if (empty($row['name']) === true) {
-                continue;
-            }
+        if ($rows !== false) {
+            foreach ($rows as $key => $row) {
+                if (empty($row['name']) === true) {
+                    continue;
+                }
 
-            $labels[] = $this->controlSizeText($row['name']);
-            $data[] = $row['total'];
+                $labels[] = $this->controlSizeText($row['name']);
+                $data[] = $row['total'];
+            }
         }
 
         $options = [
diff --git a/pandora_console/include/lib/TacticalView/elements/ScheduledDowntime.php b/pandora_console/include/lib/TacticalView/elements/ScheduledDowntime.php
index 563e59b0f2..2947180b12 100644
--- a/pandora_console/include/lib/TacticalView/elements/ScheduledDowntime.php
+++ b/pandora_console/include/lib/TacticalView/elements/ScheduledDowntime.php
@@ -156,6 +156,10 @@ class ScheduledDowntime extends Element
                 'cron_interval_from',
                 'cron_interval_to',
             ];
+            if (isset($config['user']) === false) {
+                $config['user'] = '';
+            }
+
             $groups = implode(',', array_keys(users_get_groups($config['user'])));
             $columns_str = implode(',', $columns);
             $sql = sprintf(
@@ -170,49 +174,51 @@ class ScheduledDowntime extends Element
             );
 
             $sql_count = 'SELECT COUNT(id) AS num
-                          FROM tplanned_downtime';
+                            FROM tplanned_downtime';
 
             $downtimes = db_get_all_rows_sql($sql);
-            foreach ($downtimes as $key => $downtime) {
-                if ((int) $downtime['executed'] === 0) {
-                    $downtimes[$key]['running'] = html_print_div(
+            if ($downtimes !== false) {
+                foreach ($downtimes as $key => $downtime) {
+                    if ((int) $downtime['executed'] === 0) {
+                        $downtimes[$key]['running'] = html_print_div(
+                            [
+                                'content' => '',
+                                'class'   => 'square stop',
+                                'title'   => 'Not running',
+                            ],
+                            true
+                        );
+                    } else {
+                        $downtimes[$key]['running'] = html_print_div(
+                            [
+                                'content' => '',
+                                'class'   => 'square running',
+                                'title'   => 'Running',
+                            ],
+                            true
+                        );
+                    }
+
+                    $downtimes[$key]['configuration'] = reporting_format_planned_downtime_dates($downtime);
+
+                    $settings = [
+                        'url'         => ui_get_full_url('ajax.php', false, false, false),
+                        'loadingText' => __('Loading, this operation might take several minutes...'),
+                        'title'       => __('Elements affected'),
+                        'id'          => $downtime['id'],
+                    ];
+
+                    $downtimes[$key]['affected'] = '<a style="margin-left: 22px;" href="javascript:" onclick=\'dialogAgentModulesAffected('.json_encode($settings).')\'>';
+                    $downtimes[$key]['affected'] .= html_print_image(
+                        'images/details.svg',
+                        true,
                         [
-                            'content' => '',
-                            'class'   => 'square stop',
-                            'title'   => 'Not running',
-                        ],
-                        true
-                    );
-                } else {
-                    $downtimes[$key]['running'] = html_print_div(
-                        [
-                            'content' => '',
-                            'class'   => 'square running',
-                            'title'   => 'Running',
-                        ],
-                        true
+                            'title' => __('Agents and modules affected'),
+                            'class' => 'main_menu_icon invert_filter',
+                        ]
                     );
+                    $downtimes[$key]['affected'] .= '</a>';
                 }
-
-                $downtimes[$key]['configuration'] = reporting_format_planned_downtime_dates($downtime);
-
-                $settings = [
-                    'url'         => ui_get_full_url('ajax.php', false, false, false),
-                    'loadingText' => __('Loading, this operation might take several minutes...'),
-                    'title'       => __('Elements affected'),
-                    'id'          => $downtime['id'],
-                ];
-
-                $downtimes[$key]['affected'] = '<a style="margin-left: 22px;" href="javascript:" onclick=\'dialogAgentModulesAffected('.json_encode($settings).')\'>';
-                $downtimes[$key]['affected'] .= html_print_image(
-                    'images/details.svg',
-                    true,
-                    [
-                        'title' => __('Agents and modules affected'),
-                        'class' => 'main_menu_icon invert_filter',
-                    ]
-                );
-                $downtimes[$key]['affected'] .= '</a>';
             }
 
             $downtimes_number_res = db_get_all_rows_sql($sql_count);
diff --git a/pandora_console/index.php b/pandora_console/index.php
index 96d4ed6bb6..244778a75b 100755
--- a/pandora_console/index.php
+++ b/pandora_console/index.php
@@ -1462,6 +1462,10 @@ if ($searchPage) {
                 // Make file path absolute to prevent accessing remote files.
                 $file = __DIR__.'/'.$file;
                 // Translate some secs.
+                if (isset($_GET['sec']) === false) {
+                    $_GET['sec'] = '';
+                }
+
                 $main_sec = get_sec($_GET['sec']);
                 $_GET['sec'] = ($main_sec == false) ? $_GET['sec'] : $main_sec;
 
diff --git a/pandora_console/operation/events/events.php b/pandora_console/operation/events/events.php
index 8da1863bf4..f42d889c5f 100644
--- a/pandora_console/operation/events/events.php
+++ b/pandora_console/operation/events/events.php
@@ -130,10 +130,15 @@ $severity = get_parameter(
     'filter[severity]',
     ($filter['severity'] ?? '')
 );
-$regex = get_parameter(
-    'filter[regex]',
-    (io_safe_output($filter['regex']) ?? '')
-);
+if (isset($filter['regex']) === true) {
+    $regex = get_parameter(
+        'filter[regex]',
+        (io_safe_output($filter['regex']) ?? '')
+    );
+} else {
+    $regex = '';
+}
+
 unset($filter['regex']);
 $status = get_parameter(
     'filter[status]',
diff --git a/pandora_console/views/dashboard/tipsWindow.php b/pandora_console/views/dashboard/tipsWindow.php
index d2714ae1f2..3d5b284f3f 100644
--- a/pandora_console/views/dashboard/tipsWindow.php
+++ b/pandora_console/views/dashboard/tipsWindow.php
@@ -26,6 +26,10 @@
  * ============================================================================
  */
 
+if (isset($preview) === false) {
+    $preview = '';
+}
+
 $output = '';
 $output .= '<script>var idTips = ['.$id.'];</script>';
 $output .= '<div class="window">';
@@ -58,7 +62,7 @@ if ($files !== false) {
     }
 }
 
-if ($files64 !== false) {
+if (isset($files64) === true) {
     foreach ($files64 as $key => $file) {
         $output .= '<img src="'.$file.'" />';
     }

From 9084a34514c4738b3791e559b8f33f30ba38ef12 Mon Sep 17 00:00:00 2001
From: Jonathan <jonathan.leon@pandorafms.com>
Date: Thu, 8 Feb 2024 12:31:55 +0100
Subject: [PATCH 04/26] #12695 wip removing warnings

---
 pandora_console/extensions/quick_shell.php    | 39 +++++++++++++++++++
 .../godmode/agentes/agent_manager.php         |  1 +
 pandora_console/godmode/setup/setup.php       | 16 +++++---
 pandora_console/godmode/setup/setup_ITSM.php  |  4 ++
 pandora_console/godmode/setup/setup_auth.php  |  4 +-
 .../godmode/setup/setup_ehorus.php            | 12 ++++++
 .../godmode/setup/setup_general.php           | 12 ++++++
 .../godmode/setup/welcome_tips.php            |  2 +
 .../godmode/snmpconsole/snmp_filters.php      |  6 ++-
 .../godmode/users/configure_user.php          | 13 ++++++-
 .../godmode/users/user_management.php         | 24 ++++++------
 .../include/class/TipsWindow.class.php        |  4 +-
 .../include/functions_filemanager.php         |  6 ++-
 pandora_console/include/lib/ITSM/ITSM.php     |  3 ++
 .../lib/TacticalView/elements/Database.php    |  8 ++++
 pandora_console/index.php                     |  4 ++
 .../views/dashboard/tipsWindow.php            | 10 ++++-
 17 files changed, 140 insertions(+), 28 deletions(-)

diff --git a/pandora_console/extensions/quick_shell.php b/pandora_console/extensions/quick_shell.php
index 9ea79ba364..2f45e19606 100644
--- a/pandora_console/extensions/quick_shell.php
+++ b/pandora_console/extensions/quick_shell.php
@@ -273,6 +273,14 @@ function buildConnectionURL($method)
 {
     global $config;
 
+    if (isset($config['gotty_ssh_use_ssl']) === false) {
+        $config['gotty_ssh_use_ssl'] = '';
+    }
+
+    if (isset($config['gotty_telnet_use_ssl']) === false) {
+        $config['gotty_telnet_use_ssl'] = '';
+    }
+
     $address = (empty($config['gotty_addr']) === true) ? $_SERVER['SERVER_ADDR'] : $config['gotty_addr'];
     $use_ssl = ($method === 'ssh') ? $config['gotty_ssh_use_ssl'] : $config['gotty_telnet_use_ssl'];
     $protocol = ((bool) $use_ssl === true) ? 'https://' : 'http://';
@@ -353,6 +361,18 @@ function quickShellSettings()
             config_update_value('gotty_telnet_enabled', $gotty_telnet_enabled);
         }
 
+        if (isset($config['gotty_addr']) === false) {
+            $config['gotty_addr'] = '';
+        }
+
+        if (isset($config['gotty_ssh_use_ssl']) === false) {
+            $config['gotty_ssh_use_ssl'] = '';
+        }
+
+        if (isset($config['gotty_telnet_use_ssl']) === false) {
+            $config['gotty_telnet_use_ssl'] = '';
+        }
+
         if ($config['gotty_addr'] != $gotty_addr) {
             config_update_value('gotty_addr', $gotty_addr);
         }
@@ -389,6 +409,25 @@ function quickShellSettings()
     $general_table->data = [];
     $general_table->style = [];
     $general_table->style[0] = 'width: 50%;';
+    if (isset($config['gotty_addr']) === false) {
+        $config['gotty_addr'] = '';
+    }
+
+    if (isset($config['gotty_ssh_enabled']) === false) {
+        $config['gotty_ssh_enabled'] = '';
+    }
+
+    if (isset($config['gotty_ssh_use_ssl']) === false) {
+        $config['gotty_ssh_use_ssl'] = '';
+    }
+
+    if (isset($disable_agentaccess) === false) {
+        $disable_agentaccess = '';
+    }
+
+    if (isset($config['gotty_telnet_use_ssl']) === false) {
+        $config['gotty_telnet_use_ssl'] = '';
+    }
 
     $general_table->data[0][] = html_print_label_input_block(
         __('Address'),
diff --git a/pandora_console/godmode/agentes/agent_manager.php b/pandora_console/godmode/agentes/agent_manager.php
index 283610e06a..fe44b479a9 100644
--- a/pandora_console/godmode/agentes/agent_manager.php
+++ b/pandora_console/godmode/agentes/agent_manager.php
@@ -246,6 +246,7 @@ if ($new_agent === true) {
 
 
 // QR Code table.
+$CodeQRContent = '';
 if ($new_agent === false) {
     $CodeQRContent .= html_print_div(['id' => 'qr_container_image'], true);
     $CodeQRContent .= html_print_anchor(
diff --git a/pandora_console/godmode/setup/setup.php b/pandora_console/godmode/setup/setup.php
index df6dcc1eb6..1db1d922e3 100644
--- a/pandora_console/godmode/setup/setup.php
+++ b/pandora_console/godmode/setup/setup.php
@@ -413,15 +413,19 @@ if (isset($config['error_config_update_config'])) {
         ui_print_success_message(__('Correct update the setup options'));
     }
 
-    if (is_array($config['error_config_update_config']['errors']) === true) {
-        foreach ($config['error_config_update_config']['errors'] as $msg) {
-            ui_print_error_message($msg);
+    if (isset($config['error_config_update_config']['errors']) === true) {
+        if (is_array($config['error_config_update_config']['errors']) === true) {
+            foreach ($config['error_config_update_config']['errors'] as $msg) {
+                ui_print_error_message($msg);
+            }
         }
     }
 
-    if (is_array($config['error_config_update_config']['warnings']) === true) {
-        foreach ($config['error_config_update_config']['warnings'] as $msg) {
-            ui_print_warning_message($msg);
+    if (isset($config['error_config_update_config']['warnings']) === true) {
+        if (is_array($config['error_config_update_config']['warnings']) === true) {
+            foreach ($config['error_config_update_config']['warnings'] as $msg) {
+                ui_print_warning_message($msg);
+            }
         }
     }
 
diff --git a/pandora_console/godmode/setup/setup_ITSM.php b/pandora_console/godmode/setup/setup_ITSM.php
index 313e6763c0..899a73a985 100644
--- a/pandora_console/godmode/setup/setup_ITSM.php
+++ b/pandora_console/godmode/setup/setup_ITSM.php
@@ -137,6 +137,10 @@ $row['hostname'] = html_print_label_input_block(
     ['div_class' => 'ITSM-remote-setup-ITSM_hostname']
 );
 
+if (isset($config['ITSM_token']) === false) {
+    $config['ITSM_token'] = '';
+}
+
 // ITSM token.
 $row['password'] = html_print_label_input_block(
     __('Token'),
diff --git a/pandora_console/godmode/setup/setup_auth.php b/pandora_console/godmode/setup/setup_auth.php
index f9f2afcd14..df4d75d6aa 100644
--- a/pandora_console/godmode/setup/setup_auth.php
+++ b/pandora_console/godmode/setup/setup_auth.php
@@ -390,7 +390,7 @@ if (is_ajax() === true) {
         set_unless_defined($config['double_auth_enabled'], false);
         $row = [];
         $row['name'] = __('Double authentication');
-        $row['control'] .= html_print_checkbox_switch(
+        $row['control'] = html_print_checkbox_switch(
             'double_auth_enabled',
             1,
             $config['double_auth_enabled'],
@@ -405,7 +405,7 @@ if (is_ajax() === true) {
         set_unless_defined($config['2FA_all_users'], false);
         $row = [];
         $row['name'] = __('Force 2FA for all users is enabled');
-        $row['control'] .= html_print_checkbox_switch(
+        $row['control'] = html_print_checkbox_switch(
             '2FA_all_users',
             1,
             $config['2FA_all_users'],
diff --git a/pandora_console/godmode/setup/setup_ehorus.php b/pandora_console/godmode/setup/setup_ehorus.php
index 6f4879a4ac..5f0d258082 100644
--- a/pandora_console/godmode/setup/setup_ehorus.php
+++ b/pandora_console/godmode/setup/setup_ehorus.php
@@ -78,6 +78,18 @@ $table_remote->class = 'databox filters filter-table-adv';
 $table_remote->size['ehorus_hostname'] = '50%';
 $table_remote->size['ehorus_port'] = '50%';
 
+if (isset($config['ehorus_user_level_conf']) === false) {
+    $config['ehorus_user_level_conf'] = '';
+}
+
+if (isset($config['ehorus_user']) === false) {
+    $config['ehorus_user'] = '';
+}
+
+if (isset($config['ehorus_pass']) === false) {
+    $config['ehorus_pass'] = '';
+}
+
 // Enable eHorus user configuration.
 $row = [];
 $row['ehorus_user_level_conf'] = html_print_label_input_block(
diff --git a/pandora_console/godmode/setup/setup_general.php b/pandora_console/godmode/setup/setup_general.php
index 3366fcc6f8..f9ea0ece51 100644
--- a/pandora_console/godmode/setup/setup_general.php
+++ b/pandora_console/godmode/setup/setup_general.php
@@ -488,6 +488,10 @@ $table->data[$i][] = html_print_label_input_block(
     )
 );
 
+if (isset($config['force_public_url']) === false) {
+    $config['force_public_url'] = '';
+}
+
 $table->data[$i++][] = html_print_label_input_block(
     __('Force use Public URL'),
     html_print_switch(
@@ -498,6 +502,10 @@ $table->data[$i++][] = html_print_label_input_block(
     )
 );
 
+if (isset($config['public_url_exclusions']) === false) {
+    $config['public_url_exclusions'] = '';
+}
+
 $table->data[$i++][] = html_print_label_input_block(
     __('Public URL host exclusions'),
     html_print_textarea(
@@ -919,6 +927,10 @@ echo '<legend>'.__('Mail configuration').'</legend>';
     $table_ncm_config->size[0] = '50%';
     $table_ncm_config->data = [];
 
+    if (isset($config['tftp_server_ip']) === false) {
+        $config['tftp_server_ip'] = '';
+    }
+
     $table_ncm_config->data[0][] = html_print_label_input_block(
         __('FTP server IP').ui_print_help_tip(__('This value will be used by TFTP_SERVER_IP macro in NCM scripts.'), true),
         html_print_input_text(
diff --git a/pandora_console/godmode/setup/welcome_tips.php b/pandora_console/godmode/setup/welcome_tips.php
index 1a62aa857b..ae669029d3 100644
--- a/pandora_console/godmode/setup/welcome_tips.php
+++ b/pandora_console/godmode/setup/welcome_tips.php
@@ -74,6 +74,8 @@ if ($view === 'create' || $view === 'edit') {
                 if (count($errors) === 0) {
                     if (count($files) > 0) {
                         $uploadImages = $tipsWindow->uploadImages($files);
+                    } else {
+                        $uploadImages = '';
                     }
 
                     $response = $tipsWindow->createTip($id_lang, $id_profile, $title, $text, $url, $enable, $uploadImages);
diff --git a/pandora_console/godmode/snmpconsole/snmp_filters.php b/pandora_console/godmode/snmpconsole/snmp_filters.php
index d4fc275122..fb8987431d 100644
--- a/pandora_console/godmode/snmpconsole/snmp_filters.php
+++ b/pandora_console/godmode/snmpconsole/snmp_filters.php
@@ -377,11 +377,15 @@ if ($edit_filter > -2) {
 
     echo '</form></div>';
 }
+
+if (isset($index) === false) {
+    $index = 0;
+}
 ?>
 
 <script type="text/javascript">
     // +1 because there is already a defined 'filter' field.
-    var id = parseInt("<?php echo $index; ?>")+1; 
+    var id = parseInt("<?php echo $index; ?>")+1;
     var homeurl = "<?php echo $config['homeurl']; ?>";
 
     $(document).ready (function () {
diff --git a/pandora_console/godmode/users/configure_user.php b/pandora_console/godmode/users/configure_user.php
index 668216d330..3754df5e12 100644
--- a/pandora_console/godmode/users/configure_user.php
+++ b/pandora_console/godmode/users/configure_user.php
@@ -1113,11 +1113,15 @@ if (!$new_user) {
 
     $user_id .= $apiTokenContent;
 
-    $CodeQRContent .= html_print_div(['id' => 'qr_container_image', 'class' => 'scale-0-8'], true);
+    $CodeQRContent = html_print_div(['id' => 'qr_container_image', 'class' => 'scale-0-8'], true);
     $CodeQRContent .= html_print_anchor(
         ['id' => 'qr_code_agent_view'],
         true
     );
+    if (isset($custom_id_div) === false) {
+        $custom_id_div = '';
+    }
+
     $CodeQRContent .= '<br/>'.$custom_id_div;
 
     // QR code div.
@@ -1581,7 +1585,12 @@ $autorefresh_list_out['operation/events/events'] = 'Events';
 
 if (isset($autorefresh_list) === false || empty($autorefresh_list) === true || empty($autorefresh_list[0]) === true) {
     $select = db_process_sql("SELECT autorefresh_white_list FROM tusuario WHERE id_user = '".$id."'");
-    $autorefresh_list = json_decode($select[0]['autorefresh_white_list']);
+    if (isset($select[0]['autorefresh_white_list']) === true) {
+        $autorefresh_list = json_decode($select[0]['autorefresh_white_list']);
+    } else {
+        $autorefresh_list = 0;
+    }
+
     if ($autorefresh_list === null || $autorefresh_list === 0) {
         $autorefresh_list = [];
         $autorefresh_list[0] = __('None');
diff --git a/pandora_console/godmode/users/user_management.php b/pandora_console/godmode/users/user_management.php
index 4fa30a253e..92fa41eb84 100644
--- a/pandora_console/godmode/users/user_management.php
+++ b/pandora_console/godmode/users/user_management.php
@@ -64,6 +64,16 @@ if ($dashboards === false) {
     }
 }
 
+$layouts = visual_map_get_user_layouts($config['id_user'], true);
+$layouts_aux = [];
+if ($layouts === false) {
+    $layouts_aux = ['None' => 'None'];
+} else {
+    foreach ($layouts as $layout) {
+        $layouts_aux[$layout] = $layout;
+    }
+}
+
 // Custom Home Screen controls.
 $customHomeScreenAddition = [];
 // Home screen. Dashboard.
@@ -81,21 +91,12 @@ $customHomeScreenAddition[HOME_SCREEN_DASHBOARD] = html_print_select(
     false,
     'width: 100%'
 );
+
 // Home screen. Visual consoles.
 $customHomeScreenAddition[HOME_SCREEN_VISUAL_CONSOLE] = html_print_select($layouts_aux, 'visual_console', $user_info['data_section'], '', '', '', true, false, true, 'w100p', false, 'width: 100%');
 // Home screen. External link and Other.
 $customHomeScreenAddition[HOME_SCREEN_EXTERNAL_LINK] = html_print_input_text('data_section', $user_info['data_section'], '', 60, 400, true);
 
-$layouts = visual_map_get_user_layouts($config['id_user'], true);
-$layouts_aux = [];
-if ($layouts === false) {
-    $layouts_aux = ['None' => 'None'];
-} else {
-    foreach ($layouts as $layout) {
-        $layouts_aux[$layout] = $layout;
-    }
-}
-
 // Home screen. Visual consoles.
 $customHomeScreenAddition[HOME_SCREEN_VISUAL_CONSOLE] = html_print_select(
     $layouts_aux,
@@ -889,7 +890,7 @@ if (users_is_admin($config['id_user']) === true || (bool) check_acl($config['id_
         true
     );
 
-    $userManagementTable->data['fields_addSettings'][1] .= html_print_div(
+    $userManagementTable->data['fields_addSettings'][1] = html_print_div(
         [
             'class'   => 'edit_user_allowed_ip '.(((int) $user_info['allowed_ip_active'] === 1) ? '' : 'invisible'),
             'content' => html_print_textarea(
@@ -914,6 +915,7 @@ if (users_is_admin($config['id_user']) === true || (bool) check_acl($config['id_
     );
 }
 
+$ITSM_host = '';
 if ($config['ITSM_enabled'] && $config['ITSM_user_level_conf']) {
     // Pandora ITSM user remote login.
     $table_ITSM = new StdClass();
diff --git a/pandora_console/include/class/TipsWindow.class.php b/pandora_console/include/class/TipsWindow.class.php
index d787e7ddea..c139e78353 100644
--- a/pandora_console/include/class/TipsWindow.class.php
+++ b/pandora_console/include/class/TipsWindow.class.php
@@ -646,7 +646,7 @@ class TipsWindow
                     ['class' => 'main_menu_icon']
                 );
                 $data[$key]['edit'] .= '</a>';
-                $data[$key]['delete'] .= '<form name="grupo" method="post" class="rowPair table_action_buttons" action="index.php?sec=gsetup&sec2=godmode/setup/setup&section=welcome_tips&action=delete">';
+                $data[$key]['delete'] = '<form name="grupo" method="post" class="rowPair table_action_buttons" action="index.php?sec=gsetup&sec2=godmode/setup/setup&section=welcome_tips&action=delete">';
                 $data[$key]['delete'] .= html_print_input_image(
                     'button_delete_tip',
                     'images/delete.svg',
@@ -1087,7 +1087,7 @@ class TipsWindow
             return false;
         }
 
-        if ($images !== null) {
+        if ($images !== '') {
             foreach ($images as $key => $image) {
                 $res = db_process_sql_insert(
                     'twelcome_tip_file',
diff --git a/pandora_console/include/functions_filemanager.php b/pandora_console/include/functions_filemanager.php
index a390ee2c1a..fa5b3f2eab 100644
--- a/pandora_console/include/functions_filemanager.php
+++ b/pandora_console/include/functions_filemanager.php
@@ -1065,8 +1065,10 @@ function filemanager_file_explorer(
             $modal_real_path = "<div><b>Real path to plugin execution is:</b></div>
                                 <div id='real_path'></div>";
 
-            if (isset($_SERVER['HTTPS']) || $_SERVER['HTTPS'] == 'on' || $_SERVER['SERVER_NAME'] == 'localhost' || $_SERVER['SERVER_NAME'] == '127.0.0.1') {
-                $modal_real_path .= "<div style='float:right;margin: 5em 0 0 auto';>".html_print_submit_button(__('Copy'), 'submit', false, ['icon' => 'wand', 'mode' => 'mini'], true).'</div>';
+            if (isset($_SERVER['HTTPS']) === true) {
+                if ($_SERVER['HTTPS'] == 'on' || $_SERVER['SERVER_NAME'] == 'localhost' || $_SERVER['SERVER_NAME'] == '127.0.0.1') {
+                    $modal_real_path .= "<div style='float:right;margin: 5em 0 0 auto';>".html_print_submit_button(__('Copy'), 'submit', false, ['icon' => 'wand', 'mode' => 'mini'], true).'</div>';
+                }
             }
 
             html_print_div(
diff --git a/pandora_console/include/lib/ITSM/ITSM.php b/pandora_console/include/lib/ITSM/ITSM.php
index 4879ac9f39..14792e99ee 100644
--- a/pandora_console/include/lib/ITSM/ITSM.php
+++ b/pandora_console/include/lib/ITSM/ITSM.php
@@ -43,6 +43,9 @@ class ITSM
 
         $this->userLevelConf = (bool) $config['ITSM_user_level_conf'];
         $this->url = ($host ?? $config['ITSM_hostname']);
+        if (isset($config['ITSM_token']) === false) {
+            $config['ITSM_token'] = '';
+        }
 
         $this->userBearer = ($token ?? $config['ITSM_token']);
         if ($this->userLevelConf === true) {
diff --git a/pandora_console/include/lib/TacticalView/elements/Database.php b/pandora_console/include/lib/TacticalView/elements/Database.php
index 4c0d3a5368..c329f062bf 100644
--- a/pandora_console/include/lib/TacticalView/elements/Database.php
+++ b/pandora_console/include/lib/TacticalView/elements/Database.php
@@ -197,6 +197,10 @@ class Database extends Element
         $string_reads = [];
         $total = 0;
         foreach ($reads as $key => $read) {
+            if (isset($read['utimestamp']) === false) {
+                $read['utimestamp'] = '';
+            }
+
             $dates[] = date('d-m-Y H:i:s', $read['utimestamp']);
             $string_reads[] = $read['datos'];
             $total += $read['datos'];
@@ -272,6 +276,10 @@ class Database extends Element
         $string_writes = [];
         $total = 0;
         foreach ($writes as $key => $write) {
+            if (isset($write['utimestamp']) === false) {
+                $write['utimestamp'] = '';
+            }
+
             $dates[] = date('d-m-Y H:i:s', $write['utimestamp']);
             $string_writes[] = $write['datos'];
             $total += $write['datos'];
diff --git a/pandora_console/index.php b/pandora_console/index.php
index 244778a75b..1a70cbcd48 100755
--- a/pandora_console/index.php
+++ b/pandora_console/index.php
@@ -1570,6 +1570,10 @@ echo '</html>';
 $run_time = format_numeric((microtime(true) - $config['start_time']), 3);
 echo "\n<!-- Page generated in ".$run_time." seconds -->\n";
 
+if (isset($_GET['logged']) === false) {
+    $_GET['logged'] = '';
+}
+
 // Values from PHP to be recovered from JAVASCRIPT.
 require 'include/php_to_js_values.php';
 ?>
diff --git a/pandora_console/views/dashboard/tipsWindow.php b/pandora_console/views/dashboard/tipsWindow.php
index 3d5b284f3f..1f56d545e9 100644
--- a/pandora_console/views/dashboard/tipsWindow.php
+++ b/pandora_console/views/dashboard/tipsWindow.php
@@ -30,6 +30,10 @@ if (isset($preview) === false) {
     $preview = '';
 }
 
+if (isset($id) === false) {
+    $id = '';
+}
+
 $output = '';
 $output .= '<script>var idTips = ['.$id.'];</script>';
 $output .= '<div class="window">';
@@ -63,8 +67,10 @@ if ($files !== false) {
 }
 
 if (isset($files64) === true) {
-    foreach ($files64 as $key => $file) {
-        $output .= '<img src="'.$file.'" />';
+    if ($files64 !== false) {
+        foreach ($files64 as $key => $file) {
+            $output .= '<img src="'.$file.'" />';
+        }
     }
 }
 

From 56e26ab3d52fa27ee1574649696871a59d18d0b0 Mon Sep 17 00:00:00 2001
From: Jonathan <jonathan.leon@pandorafms.com>
Date: Thu, 8 Feb 2024 13:42:02 +0100
Subject: [PATCH 05/26] #12695 wip removing warnings

---
 .../include/lib/TacticalView/elements/Database.php            | 4 ++--
 pandora_console/include/lib/TacticalView/elements/Groups.php  | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/pandora_console/include/lib/TacticalView/elements/Database.php b/pandora_console/include/lib/TacticalView/elements/Database.php
index c329f062bf..033783cc25 100644
--- a/pandora_console/include/lib/TacticalView/elements/Database.php
+++ b/pandora_console/include/lib/TacticalView/elements/Database.php
@@ -198,7 +198,7 @@ class Database extends Element
         $total = 0;
         foreach ($reads as $key => $read) {
             if (isset($read['utimestamp']) === false) {
-                $read['utimestamp'] = '';
+                $read['utimestamp'] = 0;
             }
 
             $dates[] = date('d-m-Y H:i:s', $read['utimestamp']);
@@ -277,7 +277,7 @@ class Database extends Element
         $total = 0;
         foreach ($writes as $key => $write) {
             if (isset($write['utimestamp']) === false) {
-                $write['utimestamp'] = '';
+                $write['utimestamp'] = 0;
             }
 
             $dates[] = date('d-m-Y H:i:s', $write['utimestamp']);
diff --git a/pandora_console/include/lib/TacticalView/elements/Groups.php b/pandora_console/include/lib/TacticalView/elements/Groups.php
index d1bfda4e77..860d10c130 100644
--- a/pandora_console/include/lib/TacticalView/elements/Groups.php
+++ b/pandora_console/include/lib/TacticalView/elements/Groups.php
@@ -101,8 +101,8 @@ class Groups extends Element
     public function getStatusHeatMapModules():string
     {
         global $config;
-        $width = get_parameter('width', 350);
-        $height = get_parameter('height', 275);
+        $width = (int) get_parameter('width', 350);
+        $height = (int) get_parameter('height', 275);
 
         $id_groups = array_keys(users_get_groups($config['id_user'], 'AR', false));
 

From 6e1fb2f0613a1cd2b1f4d223d0784bdf37560929 Mon Sep 17 00:00:00 2001
From: Jonathan <jonathan.leon@pandorafms.com>
Date: Thu, 8 Feb 2024 17:17:17 +0100
Subject: [PATCH 06/26] #12695 wip removing warnings

---
 .../godmode/agentes/configure_field.php       |  6 ++-
 pandora_console/godmode/setup/demo.php        |  4 ++
 .../include/ajax/demo_data.ajax.php           | 40 ++++++++++++++++---
 pandora_console/include/class/Tree.class.php  | 16 ++++++++
 .../include/class/TreeGroup.class.php         |  4 ++
 .../include/functions_groupview.php           |  2 +-
 pandora_console/include/functions_modules.php |  8 ++++
 pandora_console/include/functions_ui.php      |  4 ++
 .../operation/agentes/estado_agente.php       |  4 ++
 .../operation/agentes/group_view.php          |  7 +++-
 pandora_console/operation/events/events.php   | 24 ++++++-----
 11 files changed, 98 insertions(+), 21 deletions(-)

diff --git a/pandora_console/godmode/agentes/configure_field.php b/pandora_console/godmode/agentes/configure_field.php
index 904b807bbd..44332487ce 100755
--- a/pandora_console/godmode/agentes/configure_field.php
+++ b/pandora_console/godmode/agentes/configure_field.php
@@ -55,7 +55,7 @@ if ($id_field) {
     $display_on_front = $field['display_on_front'];
     $is_password_type = $field['is_password_type'];
     $combo_values = $field['combo_values'] ? $field['combo_values'] : '';
-    $is_combo_enable = $config['is_combo_enable'];
+    $is_combo_enable = (isset($config['is_combo_enable']) === true) ? $config['is_combo_enable'] : false;
     $is_link_enabled = $field['is_link_enabled'];
     $header_title = __('Update agent custom field');
 } else {
@@ -162,6 +162,10 @@ $table->data[2][0] = html_print_label_input_block(
     )
 );
 
+if (isset($config['is_combo_enable']) === false) {
+    $config['is_combo_enable'] = false;
+}
+
 $table->data[2][1] = html_print_label_input_block(
     __('Enabled combo'),
     html_print_checkbox_switch_extended(
diff --git a/pandora_console/godmode/setup/demo.php b/pandora_console/godmode/setup/demo.php
index 62446d48a2..b64a6d7f6d 100644
--- a/pandora_console/godmode/setup/demo.php
+++ b/pandora_console/godmode/setup/demo.php
@@ -116,6 +116,10 @@ if ($display_loading === true || $running_create === true || $running_delete) {
     $table_load->size = [];
     $table_load->size[0] = '50%';
     $table_load->size[1] = '50%';
+    $list_mkup = '';
+    if (isset($operation['id']) === false) {
+        $operation['id'] = 0;
+    }
 
     $table_load->data['row0'][] = progress_bar(
         0,
diff --git a/pandora_console/include/ajax/demo_data.ajax.php b/pandora_console/include/ajax/demo_data.ajax.php
index 5d9e1ee6b8..6d6e7eccd4 100644
--- a/pandora_console/include/ajax/demo_data.ajax.php
+++ b/pandora_console/include/ajax/demo_data.ajax.php
@@ -186,9 +186,9 @@ if ($action === 'create_demo_data') {
                     }
 
                     $modules_data = $ini_agent_data['modules'];
-                    $inventory = $ini_agent_data['inventory'];
-                    $inventory_values = $ini_agent_data['inventory_values'];
-                    $traps = $ini_agent_data['traps'];
+                    $inventory = (isset($ini_agent_data['inventory']) === true) ? $ini_agent_data['inventory'] : '';
+                    $inventory_values = (isset($ini_agent_data['inventory_values']) === true) ? $ini_agent_data['inventory_values'] : '';
+                    $traps = (isset($ini_agent_data['traps']) === true) ? $ini_agent_data['traps'] : '';
 
                     $address_network = $agent_data['address_network'];
 
@@ -435,11 +435,15 @@ if ($action === 'create_demo_data') {
                             $module_description = '';
 
                             if (isset($modules_array['description']) === true && is_string($modules_array['description']) === true) {
+                                if (isset($mac) === false) {
+                                    $mac = '';
+                                }
+
                                 $module_description = str_replace('_mac_', $mac, $modules_array['description']);
                             }
 
                             $values = [
-                                'unit'            => $modules_array['unit'],
+                                'unit'            => (isset($modules_array['unit']) === true) ? $modules_array['unit'] : '',
                                 'descripcion'     => $module_description,
                                 'id_tipo_modulo'  => $id_tipo,
                                 'id_module_group' => ($modules_array['group'] ?? 0),
@@ -597,8 +601,12 @@ if ($action === 'create_demo_data') {
                         while (1) {
                             // Insert in tmodule_inventory.
                             $modules_array = [];
-                            foreach ($inventory as $key => $value) {
-                                $modules_array[$key] = ($value[$module_access_idx] ?? null);
+                            if (isset($inventory) === true) {
+                                if ($inventory !== '') {
+                                    foreach ($inventory as $key => $value) {
+                                        $modules_array[$key] = ($value[$module_access_idx] ?? null);
+                                    }
+                                }
                             }
 
                             $module_access_idx++;
@@ -3307,6 +3315,26 @@ if ($action === 'create_demo_data') {
                     $module_values['module_interval'] = $interval;
                     $module_values['id_modulo'] = 4;
                     $module_values['id_plugin'] = $created_plugin_id;
+                    if (isset($traps_target_ip) === false) {
+                        $traps_target_ip = '';
+                    }
+
+                    if (isset($traps_community) === false) {
+                        $traps_community = '';
+                    }
+
+                    if (isset($tentacle_target_ip) === false) {
+                        $tentacle_target_ip = '';
+                    }
+
+                    if (isset($tentacle_port) === false) {
+                        $tentacle_port = '';
+                    }
+
+                    if (isset($tentacle_extra_options) === false) {
+                        $tentacle_extra_options = '';
+                    }
+
                     $module_values['macros'] = '{"1":{"macro":"_field1_","desc":"Agents&#x20;files&#x20;folder&#x20;path","help":"","value":"/usr/share/pandora_server/util/plugin/demodata_agents","hide":""},"2":{"macro":"_field2_","desc":"Number&#x20;of&#x20;agents","help":"","value":"'.$total_agents_to_create.'","hide":""},"3":{"macro":"_field3_","desc":"Traps&#x20;target&#x20;IP","help":"","value":"'.$traps_target_ip.'","hide":""},"4":{"macro":"_field4_","desc":"Traps&#x20;community","help":"","value":"'.$traps_community.'","hide":""},"5":{"macro":"_field5_","desc":"Tentacle&#x20;target&#x20;IP","help":"","value":"'.$tentacle_target_ip.'","hide":""},"6":{"macro":"_field6_","desc":"Tentacle&#x20;port","help":"","value":"'.$tentacle_port.'","hide":""},"7":{"macro":"_field7_","desc":"Tentacle&#x20;extra&#x20;options","help":"","value":"'.$tentacle_extra_options.'","hide":""}}';
 
                     $id_plugin_module = modules_create_agent_module(
diff --git a/pandora_console/include/class/Tree.class.php b/pandora_console/include/class/Tree.class.php
index ed515dee87..e7481fb5f7 100644
--- a/pandora_console/include/class/Tree.class.php
+++ b/pandora_console/include/class/Tree.class.php
@@ -738,6 +738,22 @@ class Tree
 
         if ($module['showGraphs']) {
             $tresholds = true;
+            if (isset($module['min_warning']) === false) {
+                $module['min_warning'] = '';
+            }
+
+            if (isset($module['max_warning']) === false) {
+                $module['max_warning'] = '';
+            }
+
+            if (isset($module['min_critical']) === false) {
+                $module['min_critical'] = '';
+            }
+
+            if (isset($module['max_critical']) === false) {
+                $module['max_critical'] = '';
+            }
+
             if (empty((float) $module['min_warning']) === true
                 && empty((float) $module['max_warning']) === true
                 && empty($module['warning_inverse']) === true
diff --git a/pandora_console/include/class/TreeGroup.class.php b/pandora_console/include/class/TreeGroup.class.php
index 55536fe279..520748bb69 100644
--- a/pandora_console/include/class/TreeGroup.class.php
+++ b/pandora_console/include/class/TreeGroup.class.php
@@ -621,6 +621,10 @@ class TreeGroup extends Tree
 
     protected function getDisplayHierarchy()
     {
+        if (isset($this->filter['searchHirearchy']) === false) {
+            $this->filter['searchHirearchy'] = '';
+        }
+
         return $this->filter['searchHirearchy'] ||
             (empty($this->filter['searchAgent']) && empty($this->filter['searchModule']));
     }
diff --git a/pandora_console/include/functions_groupview.php b/pandora_console/include/functions_groupview.php
index b96701ab28..7ababa9b95 100644
--- a/pandora_console/include/functions_groupview.php
+++ b/pandora_console/include/functions_groupview.php
@@ -196,7 +196,7 @@ function groupview_get_groups_list($id_user=false, $access='AR', $is_not_paginat
         $list[$id_group]['_monitors_not_init_'] = (int) $modules_counters[$id_group]['total_module_not_init'];
         $list[$id_group]['_monitors_ok_'] = (int) $modules_counters[$id_group]['total_module_normal'];
         $list[$id_group]['_monitor_checks_'] = (int) $modules_counters[$id_group]['total_module'];
-        $list[$id_group]['_monitor_not_normal_'] = ($list[$group['id_grupo']]['_monitor_checks_'] - $list[$group['id_grupo']]['_monitors_ok_']);
+        $list[$id_group]['_monitor_not_normal_'] = ($modules_counters[$id_group]['total_module'] - $modules_counters[$id_group]['total_module_normal']);
         $list[$id_group]['_monitors_alerts_fired_'] = (int) $modules_counters[$id_group]['total_module_alerts'];
     }
 
diff --git a/pandora_console/include/functions_modules.php b/pandora_console/include/functions_modules.php
index 2d3b5676ec..0ab26ed1c1 100755
--- a/pandora_console/include/functions_modules.php
+++ b/pandora_console/include/functions_modules.php
@@ -2700,6 +2700,14 @@ function modules_get_agentmodule_data_for_humans($module)
         if ($data_macro !== false) {
             $salida = $data_macro;
         } else {
+            if (isset($module['current_interval']) === false) {
+                $module['current_interval'] = 0;
+            }
+
+            if (isset($module['module_name']) === false) {
+                $module['module_name'] = 0;
+            }
+
             $salida = ui_print_module_string_value(
                 $module['datos'],
                 empty($module['id']) ? $module['id_agente_modulo'] : $module['id'],
diff --git a/pandora_console/include/functions_ui.php b/pandora_console/include/functions_ui.php
index bcf23c6d71..3c89cdda6a 100755
--- a/pandora_console/include/functions_ui.php
+++ b/pandora_console/include/functions_ui.php
@@ -6764,6 +6764,10 @@ function ui_print_module_string_value(
         $value = io_safe_input($value);
     }
 
+    if (isset($module) === false) {
+        $module['datos'] = '';
+    }
+
     $is_snapshot = is_snapshot_data($module['datos']);
     $is_large_image = is_text_to_black_string($module['datos']);
     if (($config['command_snapshot']) && ($is_snapshot || $is_large_image)) {
diff --git a/pandora_console/operation/agentes/estado_agente.php b/pandora_console/operation/agentes/estado_agente.php
index d3543b0a7c..8a392f1306 100644
--- a/pandora_console/operation/agentes/estado_agente.php
+++ b/pandora_console/operation/agentes/estado_agente.php
@@ -206,6 +206,10 @@ if ($load_filter_id > 0) {
     $loaded_filter = db_get_row_sql($sql);
 }
 
+if (isset($loaded_filter) === false) {
+    $loaded_filter['id_filter'] = 0;
+}
+
 if ($loaded_filter['id_filter'] > 0) {
     $query_filter['id_filter'] = $load_filter_id;
     $filter = db_get_row_filter('tagent_filter', $query_filter, false);
diff --git a/pandora_console/operation/agentes/group_view.php b/pandora_console/operation/agentes/group_view.php
index c7bca5635a..d9b7b04368 100644
--- a/pandora_console/operation/agentes/group_view.php
+++ b/pandora_console/operation/agentes/group_view.php
@@ -80,8 +80,7 @@ if ($config['realtimestats'] == 0) {
     $updated_time .= __('Last update').' : '.ui_print_timestamp(db_get_sql('SELECT min(utimestamp) FROM tgroup_stat'), true);
     $updated_time .= '</a>';
 } else {
-    // $updated_info = __("Updated at realtime");
-    $updated_info = '';
+    $updated_time = '';
 }
 
 // Header.
@@ -211,6 +210,10 @@ if ($count == 1) {
     }
 }
 
+if (isset($offset) === false) {
+    $offset = 0;
+}
+
 if (empty($result_groups) === false) {
     $pagination = ui_pagination(
         $count,
diff --git a/pandora_console/operation/events/events.php b/pandora_console/operation/events/events.php
index f42d889c5f..192a89b539 100644
--- a/pandora_console/operation/events/events.php
+++ b/pandora_console/operation/events/events.php
@@ -962,17 +962,19 @@ if (is_ajax() === true) {
                             $tmp->id_grupo = $tmp->group_name;
                         }
 
-                        if (strlen($tmp->id_grupo) >= 10) {
-                            $tmp->id_grupo = ui_print_truncate_text(
-                                $tmp->id_grupo,
-                                10,
-                                false,
-                                true,
-                                false,
-                                '&hellip;',
-                                true,
-                                true,
-                            );
+                        if (isset($tmp->id_grupo) === true) {
+                            if (strlen($tmp->id_grupo) >= 10) {
+                                $tmp->id_grupo = ui_print_truncate_text(
+                                    $tmp->id_grupo,
+                                    10,
+                                    false,
+                                    true,
+                                    false,
+                                    '&hellip;',
+                                    true,
+                                    true,
+                                );
+                            }
                         }
 
                         // Module name.

From d590961e69506067033b50ff62de75aee170eba5 Mon Sep 17 00:00:00 2001
From: Jonathan <jonathan.leon@pandorafms.com>
Date: Fri, 9 Feb 2024 13:51:56 +0100
Subject: [PATCH 07/26] #12695 wip removing warnings

---
 pandora_console/extensions/agents_modules.php        |  4 ++++
 pandora_console/extensions/module_groups.php         |  8 ++++++--
 pandora_console/include/ajax/alert_list.ajax.php     |  8 ++++++++
 pandora_console/include/functions_agents.php         |  2 +-
 pandora_console/include/functions_graph.php          | 12 ++++++++++++
 pandora_console/include/functions_ui.php             | 12 +++++++-----
 pandora_console/include/graphs/functions_flot.php    |  8 ++++++++
 pandora_console/include/graphs/functions_utils.php   |  6 +++++-
 .../operation/agentes/alerts_status.functions.php    |  2 +-
 pandora_console/operation/agentes/alerts_status.php  |  5 +++++
 .../operation/agentes/interface_view.functions.php   |  1 +
 pandora_console/operation/agentes/interface_view.php |  4 ++++
 pandora_console/operation/agentes/status_monitor.php |  8 ++++++++
 13 files changed, 70 insertions(+), 10 deletions(-)

diff --git a/pandora_console/extensions/agents_modules.php b/pandora_console/extensions/agents_modules.php
index 90c9527e55..0b43ce0bba 100644
--- a/pandora_console/extensions/agents_modules.php
+++ b/pandora_console/extensions/agents_modules.php
@@ -496,6 +496,10 @@ function mainAgentsModules()
         $agents = [];
     }
 
+    if (isset($agents_id) === false) {
+        $agents_id = '';
+    }
+
     $filter_agents = html_print_label_input_block(
         __('Agents'),
         html_print_select(
diff --git a/pandora_console/extensions/module_groups.php b/pandora_console/extensions/module_groups.php
index 957d3a17a1..15c9e614ee 100644
--- a/pandora_console/extensions/module_groups.php
+++ b/pandora_console/extensions/module_groups.php
@@ -91,7 +91,7 @@ function mainModuleGroups()
     $module_group_search = get_parameter('module_group_search', '');
 
     // Check the user's group permissions.
-    $user_groups = users_get_groups($config['user'], 'AR');
+    $user_groups = users_get_groups($config['id_user'], 'AR');
     $info = array_filter(
         $info,
         function ($v) use ($user_groups) {
@@ -112,7 +112,7 @@ function mainModuleGroups()
     );
 
     if (empty($info) === false) {
-        $groups_view = ($is_not_paginated) ? $info : array_slice(
+        $groups_view = (isset($is_not_paginated) === true) ? $info : array_slice(
             $info,
             $offset,
             $config['block_size']
@@ -374,6 +374,10 @@ function mainModuleGroups()
                 '&hellip;'
             );
             $j = 1;
+            if (isset($background_color) === false) {
+                $background_color = 'none';
+            }
+
             if (isset($array_data[$key])) {
                 foreach ($value['gm'] as $k => $v) {
                     if (isset($array_data[$key][$k])) {
diff --git a/pandora_console/include/ajax/alert_list.ajax.php b/pandora_console/include/ajax/alert_list.ajax.php
index 6ed1d582cb..23b8197297 100644
--- a/pandora_console/include/ajax/alert_list.ajax.php
+++ b/pandora_console/include/ajax/alert_list.ajax.php
@@ -431,6 +431,10 @@ if ($get_agent_alerts_datatable === true) {
     if (empty($filter_alert['free_search']) === false) {
         $free_search_alert = $filter_alert['free_search'];
     } else {
+        if (isset($filter_alert['free_search_alert']) === false) {
+            $filter_alert['free_search_alert'] = '';
+        }
+
         $free_search_alert = $filter_alert['free_search_alert'];
     }
 
@@ -635,6 +639,10 @@ if ($get_agent_alerts_datatable === true) {
         }
 
         $alerts = [];
+        if (isset($agent_view_page) === false) {
+            $agent_view_page = false;
+        }
+
         if ($agent_view_page === true) {
             $options_simple = ['order' => $order];
         } else {
diff --git a/pandora_console/include/functions_agents.php b/pandora_console/include/functions_agents.php
index 293f140ad6..a9e1b77c1f 100644
--- a/pandora_console/include/functions_agents.php
+++ b/pandora_console/include/functions_agents.php
@@ -1279,7 +1279,7 @@ function agents_get_group_agents(
     }
 
     if (is_array($search) === true) {
-        if (!$search['all_agents']) {
+        if (isset($search['all_agents']) === false) {
             $filter['disabled'] = 0;
             if (isset($search['disabled']) === true) {
                 $filter['disabled'] = (int) $search['disabled'];
diff --git a/pandora_console/include/functions_graph.php b/pandora_console/include/functions_graph.php
index ce8a10527c..d81e2bc1d6 100644
--- a/pandora_console/include/functions_graph.php
+++ b/pandora_console/include/functions_graph.php
@@ -737,6 +737,10 @@ function grafico_modulo_sparse($params)
         $params['backgroundColor'] = 'white';
     }
 
+    if (isset($params['vconsole']) === false) {
+        $params['vconsole'] = false;
+    }
+
     if (isset($params['only_image']) === true && $params['vconsole'] !== true) {
         $params['backgroundColor'] = 'transparent';
     }
@@ -903,6 +907,10 @@ function grafico_modulo_sparse($params)
 
     // Format of the graph.
     if (empty($params['unit']) === true) {
+        if (isset($module_data['unit']) === false) {
+            $module_data['unit'] = '';
+        }
+
         $params['unit'] = $module_data['unit'];
         if (modules_is_unit_macro($params['unit'])) {
             $params['unit'] = '';
@@ -1008,6 +1016,10 @@ function grafico_modulo_sparse($params)
         $data_module_graph = [];
     }
 
+    if (isset($series_suffix) === false) {
+        $series_suffix = '';
+    }
+
     $data_module_graph['series_suffix'] = $series_suffix;
 
     // Check available data.
diff --git a/pandora_console/include/functions_ui.php b/pandora_console/include/functions_ui.php
index 3c89cdda6a..d145393c19 100755
--- a/pandora_console/include/functions_ui.php
+++ b/pandora_console/include/functions_ui.php
@@ -4082,11 +4082,13 @@ function ui_print_datatable(array $parameters)
 
         $filter .= '<ul class="datatable_filter content filter_table no_border">';
 
-        foreach ($parameters['form']['inputs'] as $input) {
-            if ($input['type'] === 'date_range') {
-                $filter .= '<li><label>'.$input['label'].'</label>'.html_print_select_date_range('date', true).'</li>';
-            } else {
-                $filter .= html_print_input(($input + ['return' => true]), 'li');
+        if (isset($parameters['form']['inputs']) === true) {
+            foreach ($parameters['form']['inputs'] as $input) {
+                if ($input['type'] === 'date_range') {
+                    $filter .= '<li><label>'.$input['label'].'</label>'.html_print_select_date_range('date', true).'</li>';
+                } else {
+                    $filter .= html_print_input(($input + ['return' => true]), 'li');
+                }
             }
         }
 
diff --git a/pandora_console/include/graphs/functions_flot.php b/pandora_console/include/graphs/functions_flot.php
index c51e3283df..40530a49be 100644
--- a/pandora_console/include/graphs/functions_flot.php
+++ b/pandora_console/include/graphs/functions_flot.php
@@ -205,6 +205,14 @@ function flot_area_graph(
             $red_inverse    = false;
         }
     } else if (isset($params['combined']) === false || !$params['combined']) {
+        if (isset($data_module_graph['w_min']) === false) {
+            $data_module_graph['w_min'] = '';
+        }
+
+        if (isset($data_module_graph['c_min']) === false) {
+            $data_module_graph['c_min'] = '';
+        }
+
         $yellow_threshold = $data_module_graph['w_min'];
         $red_threshold    = $data_module_graph['c_min'];
         // Get other required module datas to draw warning and critical.
diff --git a/pandora_console/include/graphs/functions_utils.php b/pandora_console/include/graphs/functions_utils.php
index a96cf8f4c2..e217e25034 100644
--- a/pandora_console/include/graphs/functions_utils.php
+++ b/pandora_console/include/graphs/functions_utils.php
@@ -43,7 +43,11 @@ function unserialize_in_temp($serial_id=null, $delete=true, $ttl=1)
         }
     }
 
-    $content = file_get_contents($file_path);
+    if (file_exists($file_path) === false) {
+        return false;
+    } else {
+        $content = file_get_contents($file_path);
+    }
 
     if ($content === false) {
         return false;
diff --git a/pandora_console/operation/agentes/alerts_status.functions.php b/pandora_console/operation/agentes/alerts_status.functions.php
index 8b95c50b30..f33ec03163 100755
--- a/pandora_console/operation/agentes/alerts_status.functions.php
+++ b/pandora_console/operation/agentes/alerts_status.functions.php
@@ -211,7 +211,7 @@ function printFormFilterAlert(
         )
     );
 
-    $data .= html_print_table($table, true);
+    $data = html_print_table($table, true);
 
     if ($return) {
         return $data;
diff --git a/pandora_console/operation/agentes/alerts_status.php b/pandora_console/operation/agentes/alerts_status.php
index 68988900bc..9a564eb15f 100755
--- a/pandora_console/operation/agentes/alerts_status.php
+++ b/pandora_console/operation/agentes/alerts_status.php
@@ -358,6 +358,9 @@ if (is_metaconsole() === true) {
 }
 
 ob_start();
+if (isset($agent_view_page) === false) {
+    $agent_view_page = false;
+}
 
 if ($agent_view_page === true) {
     ui_print_datatable(
@@ -550,6 +553,8 @@ if (isset($id_agente)) {
     }
 
     echo '<div id="system_higher" class="invisible_important agent_details_agent_data flex_important"><img src="images/alert-yellow@svg.svg" width="10%" class="mrgn_right_20px">'.__('Your system has a much higher rate of modules per agent than recommended (200 modules per agent). This implies performance problems in the system, please consider reducing the number of modules in this agent.').'</div>';
+} else {
+    $system_higher = false;
 }
 
 ?>
diff --git a/pandora_console/operation/agentes/interface_view.functions.php b/pandora_console/operation/agentes/interface_view.functions.php
index 00211d23f0..dd7bb5eddc 100644
--- a/pandora_console/operation/agentes/interface_view.functions.php
+++ b/pandora_console/operation/agentes/interface_view.functions.php
@@ -464,6 +464,7 @@ function print_table(
     $url_if_bandwidth_usage_out .= $selected_agents_query_str.'&'.$selected_interfaces_query_str;
     $last_data .= $selected_agents_query_str.'&'.$selected_interfaces_query_str;
 
+    $recursion = get_parameter_switch('recursion', '');
     $url_if_agent_name .= '&recursion='.$recursion;
     $url_if_name .= '&recursion='.$recursion;
     $url_if_speed .= '&recursion='.$recursion;
diff --git a/pandora_console/operation/agentes/interface_view.php b/pandora_console/operation/agentes/interface_view.php
index a4e936ba18..3799e4816e 100644
--- a/pandora_console/operation/agentes/interface_view.php
+++ b/pandora_console/operation/agentes/interface_view.php
@@ -58,6 +58,10 @@ $autosearch = false;
 $sec = (string) get_parameter('sec', 'view');
 $agent_id = (int) get_parameter('id_agente', 0);
 
+if (isset($subpage) === false) {
+    $subpage = '';
+}
+
 if ($sec === 'view') {
     ui_print_standard_header(
         __('Interface view').$subpage,
diff --git a/pandora_console/operation/agentes/status_monitor.php b/pandora_console/operation/agentes/status_monitor.php
index ab655d518b..8d54063ee3 100644
--- a/pandora_console/operation/agentes/status_monitor.php
+++ b/pandora_console/operation/agentes/status_monitor.php
@@ -228,6 +228,10 @@ if ($load_filter_id > 0) {
     $loaded_filter = db_get_row_sql($sql);
 }
 
+if (isset($loaded_filter['id_filter']) === false) {
+    $loaded_filter['id_filter'] = 0;
+}
+
 if ($loaded_filter['id_filter'] > 0) {
     $query_filter['id_filter'] = $load_filter_id;
     $filter = db_get_row_filter('tmonitor_filter', $query_filter, false);
@@ -2370,6 +2374,10 @@ if (empty($result) === false) {
     ui_print_info_message(['no_close' => true, 'message' => __('Please apply a filter to display the data')]);
 }
 
+if (isset($tablePagination) === false) {
+    $tablePagination = '';
+}
+
 if (is_metaconsole() !== true) {
     html_print_action_buttons(
         '',

From a860338f31ebcb3dcfdfa413cbd3c7f8aa778c58 Mon Sep 17 00:00:00 2001
From: alejandro <alejandro.sanchez@pandorafms.com>
Date: Mon, 12 Feb 2024 15:39:01 +0100
Subject: [PATCH 08/26] upload web_check_lwp.pl

---
 pandora_plugins/web_check/web_check_lwp.pl | 24 ++++++++++++++++++++++
 1 file changed, 24 insertions(+)
 create mode 100644 pandora_plugins/web_check/web_check_lwp.pl

diff --git a/pandora_plugins/web_check/web_check_lwp.pl b/pandora_plugins/web_check/web_check_lwp.pl
new file mode 100644
index 0000000000..73b1c0a028
--- /dev/null
+++ b/pandora_plugins/web_check/web_check_lwp.pl
@@ -0,0 +1,24 @@
+use strict;
+use warnings;
+
+use LWP::UserAgent ();
+use Data::Dumper;
+
+die "Usage: $0 <URL> <username> <password>\n" unless @ARGV == 3;
+
+my ($URL, $username, $password) = @ARGV;
+
+my $ua = LWP::UserAgent->new(timeout => 10);
+$ua->protocols_allowed( ['http', 'https'] );
+$ua->ssl_opts("verify_hostname" => 0);
+
+$ua->credentials($URL, "", $username, $password);
+
+my $response = $ua->get($URL);
+
+if ($response->is_success) {
+    print $response->decoded_content;
+}
+else {
+    die print(Dumper($response));
+}

From 0dcced8b53f5523f6bbe5b284031e0b5106a36b4 Mon Sep 17 00:00:00 2001
From: Jonathan <jonathan.leon@pandorafms.com>
Date: Mon, 12 Feb 2024 17:59:27 +0100
Subject: [PATCH 09/26] #12695 wip removing warnings

---
 .../extensions/users_connected.php            |  2 +-
 pandora_console/godmode/reporting/graphs.php  |  9 ++++-
 .../reporting/visual_console_builder.data.php |  8 ++++
 .../reporting/visual_console_builder.php      |  6 ++-
 .../godmode/wizards/Applications.class.php    |  3 +-
 .../godmode/wizards/Custom.class.php          |  3 +-
 .../wizards/DiscoveryTaskList.class.php       |  6 ++-
 .../include/ajax/custom_fields.php            |  4 ++
 .../include/class/Diagnostics.class.php       |  4 ++
 .../class/ExtensionsDiscovery.class.php       |  8 ++--
 pandora_console/include/class/HTML.class.php  |  4 ++
 .../include/class/SnmpConsole.class.php       |  4 ++
 .../include/functions_custom_fields.php       | 13 +++++++
 pandora_console/include/functions_html.php    |  3 +-
 .../include/functions_inventory.php           | 30 ++++++++-------
 .../include/functions_snmp_browser.php        |  2 +-
 .../operation/agentes/pandora_networkmap.php  |  4 +-
 .../custom_fields/custom_fields_view.php      |  2 +-
 pandora_console/operation/events/events.php   | 23 ++++++++---
 .../operation/events/sound_events.php         |  6 ++-
 .../operation/inventory/inventory.php         | 38 ++++++++++++-------
 .../operation/messages/message_list.php       |  6 ++-
 .../operation/reporting/graph_analytics.php   |  4 ++
 .../operation/snmpconsole/snmp_browser.php    |  4 ++
 pandora_console/views/dashboard/list.php      |  8 ++++
 25 files changed, 155 insertions(+), 49 deletions(-)

diff --git a/pandora_console/extensions/users_connected.php b/pandora_console/extensions/users_connected.php
index 4b76957344..712dcd014d 100644
--- a/pandora_console/extensions/users_connected.php
+++ b/pandora_console/extensions/users_connected.php
@@ -229,7 +229,7 @@ function users_extension_main_god($god=true)
 
             $data = [];
             $data[0] = '<a href="index.php?sec=gusuarios&amp;sec2=godmode/users/configure_user&amp;id='.$row['id_user'].'">'.$row['id_user'].'</a>';
-            $data[1] = $last_login_data['ip_origin'];
+            $data[1] = $last_login_data['ip_origen'];
             $data[2] = date($config['date_format'], $last_login_data['utimestamp']);
             $data[3] = date($config['date_format'], $row['last_connect']);
             array_push($table->data, $data);
diff --git a/pandora_console/godmode/reporting/graphs.php b/pandora_console/godmode/reporting/graphs.php
index 1a5fbb4283..e072b0f28a 100644
--- a/pandora_console/godmode/reporting/graphs.php
+++ b/pandora_console/godmode/reporting/graphs.php
@@ -221,6 +221,9 @@ $search = trim(get_parameter('search', ''));
 $graphs = custom_graphs_get_user($config['id_user'], false, true, $access);
 $offset = (int) get_parameter('offset');
 $table_aux = new stdClass();
+if (isset($strict_user) === false) {
+    $strict_user = false;
+}
 
 $table_aux->width = '100%';
 if (is_metaconsole() === true) {
@@ -273,7 +276,11 @@ if (is_metaconsole() === true) {
         html_print_input_text('search', $search, '', 30, '', true)
     );
 
-    $searchForm .= '<form action="index.php?sec=reporting&sec2=godmode/reporting/graphs&id_group='.$id_group.'&pure='.$pure.'"method="post">';
+    if (isset($pure) === false) {
+        $pure = '';
+    }
+
+    $searchForm = '<form action="index.php?sec=reporting&sec2=godmode/reporting/graphs&id_group='.$id_group.'&pure='.$pure.'"method="post">';
     $searchForm .= html_print_table($table_aux, true);
 
     $searchForm .= html_print_div(
diff --git a/pandora_console/godmode/reporting/visual_console_builder.data.php b/pandora_console/godmode/reporting/visual_console_builder.data.php
index f5cc8d059c..a1e49d7206 100644
--- a/pandora_console/godmode/reporting/visual_console_builder.data.php
+++ b/pandora_console/godmode/reporting/visual_console_builder.data.php
@@ -130,6 +130,14 @@ if ($action === 'new') {
 
 $backgroundPreviewImages[] = html_print_image('', true, ['id' => 'imagen', 'class' => 'invisible']);
 
+if (isset($formAction) === false) {
+    $formAction = 'POST';
+}
+
+if (isset($formHidden) === false) {
+    $formHidden = '';
+}
+
 // Form.
 echo '<form id="back" class="max_floating_element_size" method="POST" action="'.$formAction.'" enctype="multipart/form-data">';
 echo $formHidden;
diff --git a/pandora_console/godmode/reporting/visual_console_builder.php b/pandora_console/godmode/reporting/visual_console_builder.php
index c49acaf80d..cdba62419a 100755
--- a/pandora_console/godmode/reporting/visual_console_builder.php
+++ b/pandora_console/godmode/reporting/visual_console_builder.php
@@ -285,7 +285,11 @@ switch ($activeTab) {
                 }
 
                 // If the background is changed the size is reseted
-                $background_now = $visualConsole['background'];
+                if (isset($visualConsole['background']) === true) {
+                    $background_now = $visualConsole['background'];
+                } else {
+                    $background_now = '';
+                }
 
                 $values['width'] = $width;
                 $values['height'] = $height;
diff --git a/pandora_console/godmode/wizards/Applications.class.php b/pandora_console/godmode/wizards/Applications.class.php
index 680630f86b..7bdbe13ee9 100644
--- a/pandora_console/godmode/wizards/Applications.class.php
+++ b/pandora_console/godmode/wizards/Applications.class.php
@@ -66,7 +66,8 @@ class Applications extends Wizard
         int $page=0,
         string $msg='Default message. Not set.',
         string $icon='images/wizard/applications.png',
-        string $label='Applications'
+        string $label='Applications',
+        string $class_style='',
     ) {
         $this->setBreadcrum([]);
 
diff --git a/pandora_console/godmode/wizards/Custom.class.php b/pandora_console/godmode/wizards/Custom.class.php
index f721e76aa7..a164c8f666 100644
--- a/pandora_console/godmode/wizards/Custom.class.php
+++ b/pandora_console/godmode/wizards/Custom.class.php
@@ -66,7 +66,8 @@ class Custom extends Wizard
         int $page=0,
         string $msg='Default message. Not set.',
         string $icon='/images/wizard/Custom_apps@svg.svg',
-        string $label='Custom'
+        string $label='Custom',
+        string $class_style='',
     ) {
         $this->setBreadcrum([]);
 
diff --git a/pandora_console/godmode/wizards/DiscoveryTaskList.class.php b/pandora_console/godmode/wizards/DiscoveryTaskList.class.php
index 4cebdfec9f..799917c590 100644
--- a/pandora_console/godmode/wizards/DiscoveryTaskList.class.php
+++ b/pandora_console/godmode/wizards/DiscoveryTaskList.class.php
@@ -629,7 +629,7 @@ class DiscoveryTaskList extends HTML
             // Updated at.
             $table->headstyle[8] .= 'min-width: 50px; width: 150px;';
             // Operations.
-            $table->headstyle[9] .= 'min-width: 150px; width: 250px;';
+            $table->headstyle[9] = 'min-width: 150px; width: 250px;';
 
             if (check_acl($config['id_user'], 0, 'AW')) {
                 $table->head[0] = __('Force');
@@ -1135,6 +1135,10 @@ class DiscoveryTaskList extends HTML
                 array_push($table->data, $data);
             }
 
+            if (isset($server_name) === false) {
+                $server_name = '';
+            }
+
             if (empty($table->data)) {
                 $content = '<div class="nf">'.__('Server').' '.$server_name.' '.__('has no discovery tasks assigned').'</div>';
                 $return = false;
diff --git a/pandora_console/include/ajax/custom_fields.php b/pandora_console/include/ajax/custom_fields.php
index f247c2e51e..fa01ef7f59 100644
--- a/pandora_console/include/ajax/custom_fields.php
+++ b/pandora_console/include/ajax/custom_fields.php
@@ -58,6 +58,10 @@ if (check_login()) {
 
     if ($check_csv_button) {
         if (check_acl($config['id_user'], 0, 'PM')) {
+            if (isset($permission) === false) {
+                $permission = '';
+            }
+
             echo json_encode($permission);
             return;
         } else {
diff --git a/pandora_console/include/class/Diagnostics.class.php b/pandora_console/include/class/Diagnostics.class.php
index 714a6a707f..4cbf4094ba 100644
--- a/pandora_console/include/class/Diagnostics.class.php
+++ b/pandora_console/include/class/Diagnostics.class.php
@@ -1059,6 +1059,10 @@ class Diagnostics extends Wizard
             $tFragmentationStatus = 1;
         }
 
+        if (isset($config['thousand_separator']) === false) {
+            $config['thousand_separator'] = '';
+        }
+
         $result = [
             'error' => false,
             'data'  => [
diff --git a/pandora_console/include/class/ExtensionsDiscovery.class.php b/pandora_console/include/class/ExtensionsDiscovery.class.php
index f132cc160f..c48a644cb3 100644
--- a/pandora_console/include/class/ExtensionsDiscovery.class.php
+++ b/pandora_console/include/class/ExtensionsDiscovery.class.php
@@ -186,9 +186,11 @@ class ExtensionsDiscovery extends Wizard
     private function loadConfig()
     {
         $row = db_get_row('tdiscovery_apps', 'short_name', $this->mode);
-        $this->id = $row['id_app'];
-        $this->name = $row['name'];
-        $this->description = $row['description'];
+        if ($row !== false) {
+            $this->id = $row['id_app'];
+            $this->name = $row['name'];
+            $this->description = $row['description'];
+        }
     }
 
 
diff --git a/pandora_console/include/class/HTML.class.php b/pandora_console/include/class/HTML.class.php
index b019b2c59e..f2bae706ce 100644
--- a/pandora_console/include/class/HTML.class.php
+++ b/pandora_console/include/class/HTML.class.php
@@ -208,6 +208,10 @@ class HTML
         $i = 0;
 
         foreach ($urls as $url) {
+            if (isset($url['selected']) === false) {
+                $url['selected'] = 0;
+            }
+
             if ($url['selected'] == 1) {
                 $class = 'selected';
             } else {
diff --git a/pandora_console/include/class/SnmpConsole.class.php b/pandora_console/include/class/SnmpConsole.class.php
index 6945d9b1fb..160e020e07 100644
--- a/pandora_console/include/class/SnmpConsole.class.php
+++ b/pandora_console/include/class/SnmpConsole.class.php
@@ -199,6 +199,10 @@ class SnmpConsole extends HTML
         ).'</a>';
         $list['active'] = true;
 
+        if (isset($screen) === false) {
+            $screen = '';
+        }
+
         // Header.
         ui_print_standard_header(
             __('SNMP Console'),
diff --git a/pandora_console/include/functions_custom_fields.php b/pandora_console/include/functions_custom_fields.php
index 9ce92a0c78..aae86ab40e 100644
--- a/pandora_console/include/functions_custom_fields.php
+++ b/pandora_console/include/functions_custom_fields.php
@@ -289,6 +289,10 @@ function agent_counters_custom_fields($filters)
         }
     }
 
+    if (isset($groups_and) === false) {
+        $groups_and = '';
+    }
+
     // Filter by status module.
     $empty_agents_count = "UNION ALL
 		SELECT ta.id_agente,
@@ -616,6 +620,10 @@ function agent_counters_custom_fields($filters)
         $result_meta = [];
         $data = [];
 
+        if (isset($and_module_search) === false) {
+            $and_module_search = '';
+        }
+
         $query = sprintf(
             "SELECT tcd.description AS name_data,
                 SUM(IF($agent_state_total, 1, 0)) AS a_agents,
@@ -677,6 +685,11 @@ function agent_counters_custom_fields($filters)
 
         $result_meta[] = db_get_all_rows_sql($query);
 
+        if (isset($server_data) === false) {
+            $server_data = [];
+            $server_data['id'] = '';
+        }
+
         $query_data = sprintf(
             "SELECT
                 tcd.description,
diff --git a/pandora_console/include/functions_html.php b/pandora_console/include/functions_html.php
index 3a4ca01ebb..402f0c71a2 100644
--- a/pandora_console/include/functions_html.php
+++ b/pandora_console/include/functions_html.php
@@ -7415,8 +7415,9 @@ function html_print_select_date_range(
     $output .= '</div>';
     $output .= '<div id="'.$name.'_range" class="inline_flex" '.$display_range.'>';
         $table = new stdClass();
+        $table->data = [];
         $table->class = 'table-adv-filter';
-        $table->data[0][0] .= '<div><div><div><span class="font-title-font">'.__('From').':</span></div>';
+        $table->data[0][0] = '<div><div><div><span class="font-title-font">'.__('From').':</span></div>';
             $table->data[0][0] .= html_print_input_text('date_init', $date_init, '', 12, 10, true).' ';
             $table->data[0][0] .= html_print_input_text('time_init', $time_init, '', 10, 7, true).' ';
         $table->data[0][0] .= '</div>';
diff --git a/pandora_console/include/functions_inventory.php b/pandora_console/include/functions_inventory.php
index afa61c3811..38d5b49b81 100644
--- a/pandora_console/include/functions_inventory.php
+++ b/pandora_console/include/functions_inventory.php
@@ -788,22 +788,24 @@ function inventory_get_datatable(
     $rows = db_get_all_rows_sql($sql);
     if ($order_by_agent === false) {
         $modules = [];
-        foreach ($rows as $row) {
-            if ($row['utimestamp'] !== $row['last_update']) {
-                $row['timestamp'] = $row['last_update_timestamp'];
-            }
-
-            $data_rows = explode(PHP_EOL, $row['data_inventory']);
-            foreach ($data_rows as $data_key => $data_value) {
-                if (empty($inventory_search_string) !== true) {
-                    $search_check = strpos(str_replace('&#x20;', ' ', $data_value), $inventory_search_string);
-                } else {
-                    $search_check = true;
+        if ($rows !== false) {
+            foreach ($rows as $row) {
+                if ($row['utimestamp'] !== $row['last_update']) {
+                    $row['timestamp'] = $row['last_update_timestamp'];
                 }
 
-                if (empty($data_value) === false && $search_check !== false) {
-                    $row['data'] = $data_value;
-                    $modules[$row['name']][$row['name_agent'].'-'.$data_key.'-'.$data_value] = $row;
+                $data_rows = explode(PHP_EOL, $row['data_inventory']);
+                foreach ($data_rows as $data_key => $data_value) {
+                    if (empty($inventory_search_string) !== true) {
+                        $search_check = strpos(str_replace('&#x20;', ' ', $data_value), $inventory_search_string);
+                    } else {
+                        $search_check = true;
+                    }
+
+                    if (empty($data_value) === false && $search_check !== false) {
+                        $row['data'] = $data_value;
+                        $modules[$row['name']][$row['name_agent'].'-'.$data_key.'-'.$data_value] = $row;
+                    }
                 }
             }
         }
diff --git a/pandora_console/include/functions_snmp_browser.php b/pandora_console/include/functions_snmp_browser.php
index 99a0b07612..6d553b1ca3 100644
--- a/pandora_console/include/functions_snmp_browser.php
+++ b/pandora_console/include/functions_snmp_browser.php
@@ -741,7 +741,7 @@ function snmp_browser_print_container(
         )
     );
 
-    $table->data[0][1] .= html_print_label_input_block(
+    $table->data[0][1] = html_print_label_input_block(
         __('Port'),
         html_print_input(
             [
diff --git a/pandora_console/operation/agentes/pandora_networkmap.php b/pandora_console/operation/agentes/pandora_networkmap.php
index 52c376b4f7..94e2cb51e6 100644
--- a/pandora_console/operation/agentes/pandora_networkmap.php
+++ b/pandora_console/operation/agentes/pandora_networkmap.php
@@ -711,7 +711,9 @@ switch ($tab) {
             ]
         );
 
-        echo $result_txt;
+        if (isset($result_txt) === true) {
+            echo $result_txt;
+        }
 
         $table = new stdClass();
         $table->width = '100%';
diff --git a/pandora_console/operation/custom_fields/custom_fields_view.php b/pandora_console/operation/custom_fields/custom_fields_view.php
index 83d35533c7..f05ee93c93 100644
--- a/pandora_console/operation/custom_fields/custom_fields_view.php
+++ b/pandora_console/operation/custom_fields/custom_fields_view.php
@@ -779,7 +779,7 @@ $(document).ready (function () {
     });
 
     var filters = '<?php echo json_encode($filters); ?>';
-    var indexed_descriptions = '<?php echo json_encode($indexed_descriptions); ?>';
+    var indexed_descriptions = '<?php echo json_encode((isset($indexed_descriptions) === true) ? $indexed_descriptions : ''); ?>';
     var processing = '<?php echo $processing; ?>';
 
     table_datatables(filters, indexed_descriptions, processing);
diff --git a/pandora_console/operation/events/events.php b/pandora_console/operation/events/events.php
index 192a89b539..d1e995f25d 100644
--- a/pandora_console/operation/events/events.php
+++ b/pandora_console/operation/events/events.php
@@ -1995,7 +1995,7 @@ $data = html_print_checkbox_switch(
     true
 );
 
-$in_sec_group .= $data;
+$in_sec_group = $data;
 $in_sec_group .= '<label class="vert-align-bottom">';
 $in_sec_group .= __('Search in secondary groups');
 $in_sec_group .= ui_print_help_tip(
@@ -2133,6 +2133,10 @@ $in .= '</div>';
 $inputs[] = $in;
 
 // User private filter.
+if (isset($private_filter_event) === false) {
+    $private_filter_event = '';
+}
+
 $inputs[] = html_print_input_hidden('private_filter_event', $private_filter_event, true);
 // Trick view in table.
 $inputs[] = '<div class="w100p pdd_t_15px"></div>';
@@ -2774,12 +2778,13 @@ try {
     $form_id = 'events_form';
 
     $show_hide_filters = '';
-    if ((int) $_GET['pure'] === 1) {
-        $show_hide_filters = 'invisible';
+    if (isset($_GET['pure']) === true) {
+        if ((int) $_GET['pure'] === 1) {
+            $show_hide_filters = 'invisible';
+        }
     }
 
-
-    // Print graphs
+    // Print graphs.
     $graph_background = '';
     if ($config['style'] === 'pandora') {
         $graph_background = ' background-color: #fff;';
@@ -3038,6 +3043,14 @@ echo '<div id="load-modal-filter" style="display:none"></div>';
 echo '<div id="save-modal-filter" style="display:none"></div>';
 
 $autorefresh_draw = false;
+if (isset($_GET['refr']) === false) {
+    $_GET['refr'] = 0;
+}
+
+if (isset($config['refr']) === false) {
+    $config['refr'] = $_GET['refr'];
+}
+
 if ($_GET['refr'] || (bool) ($do_refresh ?? false) === true) {
     $autorefresh_draw = true;
 }
diff --git a/pandora_console/operation/events/sound_events.php b/pandora_console/operation/events/sound_events.php
index 4ff12e02f4..2107ca2de2 100644
--- a/pandora_console/operation/events/sound_events.php
+++ b/pandora_console/operation/events/sound_events.php
@@ -207,8 +207,10 @@ $output = '<div id="tabs-sound-modal">';
         ];
 
         $eventsounds = db_get_all_rows_sql('SELECT * FROM tevent_sound WHERE active = 1');
-        foreach ($eventsounds as $key => $row) {
-            $sounds[$row['sound']] = $row['name'];
+        if ($eventsounds !== false) {
+            foreach ($eventsounds as $key => $row) {
+                $sounds[$row['sound']] = $row['name'];
+            }
         }
 
         $inputs[] = [
diff --git a/pandora_console/operation/inventory/inventory.php b/pandora_console/operation/inventory/inventory.php
index a841c53266..5f812f67e9 100755
--- a/pandora_console/operation/inventory/inventory.php
+++ b/pandora_console/operation/inventory/inventory.php
@@ -181,6 +181,10 @@ if (is_ajax() === true) {
         $id_agent = (int) get_parameter('id_agent', 0);
         $id_group = (int) get_parameter('id_group', 0);
 
+        if (isset($filter['value']) === false) {
+            $filter['value'] = '';
+        }
+
         $params = [
             'search'     => $filter['value'],
             'start'      => $start,
@@ -275,23 +279,25 @@ if (is_ajax() === true) {
 
                     $custom_fields_names = '';
                     $custom_fields_values = '';
-                    foreach ($field_result as $field) {
-                        $field_name = str_replace(' ', '&nbsp;', io_safe_output($field['name']));
-                        $custom_fields_names .= '<span class="right" style="height: 1.3em !important">'.$field_name.'</span>';
+                    if ($field_result !== false) {
+                        foreach ($field_result as $field) {
+                            $field_name = str_replace(' ', '&nbsp;', io_safe_output($field['name']));
+                            $custom_fields_names .= '<span class="right" style="height: 1.3em !important">'.$field_name.'</span>';
 
-                        $description = $field['description'];
-                        $password_length = strlen(io_safe_output($field['description']));
-                        $asterisks = '';
+                            $description = $field['description'];
+                            $password_length = strlen(io_safe_output($field['description']));
+                            $asterisks = '';
 
-                        if ((int) $field['is_password_type'] === 1) {
-                            for ($i = 0; $i < $password_length; $i++) {
-                                $asterisks .= '&#9679;';
+                            if ((int) $field['is_password_type'] === 1) {
+                                for ($i = 0; $i < $password_length; $i++) {
+                                    $asterisks .= '&#9679;';
+                                }
+
+                                $description = $asterisks;
                             }
 
-                            $description = $asterisks;
+                            $custom_fields_values .= '<span class="left" style="height: 1.3em !important">'.$description.'</span>';
                         }
-
-                        $custom_fields_values .= '<span class="left" style="height: 1.3em !important">'.$description.'</span>';
                     }
 
                     $tmp->description = $agent['comentarios'];
@@ -546,6 +552,10 @@ $table->size[2] = '33%';
 $table->class = 'filter-table-adv';
 $table->data = [];
 
+if (isset($filteringFunction) === false) {
+    $filteringFunction = '';
+}
+
 if ($is_metaconsole === true) {
     // Node select.
     $nodes = [];
@@ -739,7 +749,7 @@ $table->data[1][1] = html_print_label_input_block(
 
 // Date filter. In Metaconsole has not reason for show.
 if (is_metaconsole() === false) {
-    $table->data[1][2] .= html_print_label_input_block(
+    $table->data[1][2] = html_print_label_input_block(
         __('Date').':<br>',
         html_print_select_date_range(
             'utimestamp',
@@ -1388,7 +1398,7 @@ ui_require_jquery_file('ui.datepicker-'.get_user_language(), 'include/javascript
 
         // Change chevron for node icon.
         let toggle = document.querySelectorAll('.toggle-inventory-nodo');
-        let src = '<?php echo $nodo_image_url; ?>';
+        let src = '<?php echo (isset($nodo_image_url) === false) ? '' : $nodo_image_url; ?>';
 
         toggle.forEach(img => {
             img.parentElement.parentElement.style = 'cursor: pointer; border: 0';
diff --git a/pandora_console/operation/messages/message_list.php b/pandora_console/operation/messages/message_list.php
index 26ffbc5bfe..705b17f771 100644
--- a/pandora_console/operation/messages/message_list.php
+++ b/pandora_console/operation/messages/message_list.php
@@ -245,6 +245,10 @@ if (empty($messages) === true) {
 
             $data[1] = $dest_user;
         } else {
+            if (isset($message['sender']) === false) {
+                $message['sender'] = 0;
+            }
+
             $orig_user = get_user_fullname($message['sender']);
             if (!$orig_user) {
                 $orig_user = $message['sender'];
@@ -265,7 +269,7 @@ if (empty($messages) === true) {
             $contentSubject = '<strong>'.$contentSubject.'</strong>';
         }
 
-        $data[2] .= html_print_anchor(
+        $data[2] = html_print_anchor(
             [
                 'href'    => $pathSubject,
                 'content' => $contentSubject,
diff --git a/pandora_console/operation/reporting/graph_analytics.php b/pandora_console/operation/reporting/graph_analytics.php
index ff6272bdd6..9a85b81043 100644
--- a/pandora_console/operation/reporting/graph_analytics.php
+++ b/pandora_console/operation/reporting/graph_analytics.php
@@ -670,6 +670,10 @@ $data[0] .= html_print_select(
     'width:'.$filter_id_width.';'
 );
 
+if (isset($config['user']) === false) {
+    $config['user'] = false;
+}
+
 $user_groups = users_get_groups($config['user'], 'RW');
 $data[1] = __('Group');
 $data[1] .= html_print_select(
diff --git a/pandora_console/operation/snmpconsole/snmp_browser.php b/pandora_console/operation/snmpconsole/snmp_browser.php
index 0fa30148ed..8b3e8acc38 100644
--- a/pandora_console/operation/snmpconsole/snmp_browser.php
+++ b/pandora_console/operation/snmpconsole/snmp_browser.php
@@ -76,6 +76,10 @@ if ($config['pure']) {
 $type = get_parameter('moduletype', false);
 $page = get_parameter('page', false);
 
+if (isset($moduletype) === false) {
+    $moduletype = 0;
+}
+
 if (empty($page) && $type !== 'networkserver' && $moduletype !== 2) {
     // Header.
     ui_print_standard_header(
diff --git a/pandora_console/views/dashboard/list.php b/pandora_console/views/dashboard/list.php
index aaf675e64a..6282280867 100644
--- a/pandora_console/views/dashboard/list.php
+++ b/pandora_console/views/dashboard/list.php
@@ -170,6 +170,10 @@ if ($writeDashboards === 1) {
         true
     );
 
+    if (isset($output) === false) {
+        $output = '<div>';
+    }
+
     $output .= '</div>';
 
     echo $output;
@@ -178,6 +182,10 @@ if ($writeDashboards === 1) {
     echo '<div id="modal-update-dashboard" class="invisible"></div>';
 }
 
+if (isset($tablePagination) === false) {
+    $tablePagination = '';
+}
+
 html_print_action_buttons(
     $input_button,
     [

From 66f8e31824f7be90cd3ebe6570a361e9d89091f1 Mon Sep 17 00:00:00 2001
From: Daniel Cebrian <daniel.cebrian@pandorafms.com>
Date: Tue, 13 Feb 2024 16:55:46 +0100
Subject: [PATCH 10/26] #12783 enabled correct modules when safe mode module is
 active in agent

---
 .../godmode/agentes/configurar_agente.php           | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/pandora_console/godmode/agentes/configurar_agente.php b/pandora_console/godmode/agentes/configurar_agente.php
index a2372a66f0..7e9f566e17 100644
--- a/pandora_console/godmode/agentes/configurar_agente.php
+++ b/pandora_console/godmode/agentes/configurar_agente.php
@@ -2320,8 +2320,19 @@ if ($delete_module) {
 
     // Check if module is used by agent for Safe mode.
     $is_safe_mode_module = modules_check_safe_mode($id_borrar_modulo);
-    if ($is_safe_mode_module === true) {
+    if ($is_safe_mode_module === true && isset($id_agente) === true) {
         db_process_sql_update('tagente', ['safe_mode_module' => '0'], ['id_agente' => $id_agente]);
+        db_process_sql_update(
+            'tagente_modulo',
+            [
+                'disabled'              => 0,
+                'disabled_by_safe_mode' => 0,
+            ],
+            [
+                'id_agente'             => $id_agente,
+                'disabled_by_safe_mode' => 1,
+            ]
+        );
     }
 
     // Before delete the main module, check and delete the childrens from the original module.

From da2bef45f25bfffdb7b59570fddb8a9986db40a2 Mon Sep 17 00:00:00 2001
From: Jonathan <jonathan.leon@pandorafms.com>
Date: Tue, 13 Feb 2024 17:06:48 +0100
Subject: [PATCH 11/26] #12695 wip removing warnings

---
 .../godmode/wizards/HostDevices.class.php     |  32 ++-
 .../godmode/wizards/Wizard.main.php           |  18 ++
 .../include/class/CustomNetScan.class.php     |  16 +-
 pandora_console/include/class/HTML.class.php  | 182 +++++++++++++++---
 pandora_console/include/functions_cron.php    |   8 +-
 pandora_console/include/functions_html.php    |   6 +-
 6 files changed, 221 insertions(+), 41 deletions(-)

diff --git a/pandora_console/godmode/wizards/HostDevices.class.php b/pandora_console/godmode/wizards/HostDevices.class.php
index 08a47b12f8..6c9820bb11 100755
--- a/pandora_console/godmode/wizards/HostDevices.class.php
+++ b/pandora_console/godmode/wizards/HostDevices.class.php
@@ -784,8 +784,36 @@ class HostDevices extends Wizard
 
                 // Interval and schedules.
                 $interv_manual = 0;
-                if ((int) $this->task['interval_sweep'] == 0) {
-                    $interv_manual = 1;
+                if (isset($this->task['interval_sweep']) === true) {
+                    if ((int) $this->task['interval_sweep'] == 0) {
+                        $interv_manual = 1;
+                    }
+                } else {
+                    $this->task['interval_sweep'] = '';
+                }
+
+                if (isset($this->task['name']) === false) {
+                    $this->task['name'] = '';
+                }
+
+                if (isset($this->task['id_recon_server']) === false) {
+                    $this->task['id_recon_server'] = '';
+                }
+
+                if (isset($this->task['subnet_csv']) === false) {
+                    $this->task['subnet_csv'] = '';
+                }
+
+                if (isset($this->task['subnet']) === false) {
+                    $this->task['subnet'] = '';
+                }
+
+                if (isset($this->task['id_group']) === false) {
+                    $this->task['id_group'] = 0;
+                }
+
+                if (isset($this->task['description']) === false) {
+                    $this->task['description'] = '';
                 }
 
                 $form['rows'][0]['new_form_block'] = true;
diff --git a/pandora_console/godmode/wizards/Wizard.main.php b/pandora_console/godmode/wizards/Wizard.main.php
index 9eb223e744..f54ded4662 100644
--- a/pandora_console/godmode/wizards/Wizard.main.php
+++ b/pandora_console/godmode/wizards/Wizard.main.php
@@ -104,6 +104,20 @@ class Wizard
      */
     public $rootUrl;
 
+    /**
+     * Task.
+     *
+     * @var mixed
+     */
+    public $task;
+
+    /**
+     * Max pages net scan.
+     *
+     * @var mixed
+     */
+    public $maxPagesNetScan;
+
 
     /**
      * Setter for breadcrum
@@ -221,6 +235,10 @@ class Wizard
         $i = 0;
 
         foreach ($urls as $url) {
+            if (isset($url['selected']) === false) {
+                $url['selected'] = 0;
+            }
+
             if ($url['selected'] == 1) {
                 $class = 'selected';
             } else {
diff --git a/pandora_console/include/class/CustomNetScan.class.php b/pandora_console/include/class/CustomNetScan.class.php
index ec4351e831..24d261bc9c 100644
--- a/pandora_console/include/class/CustomNetScan.class.php
+++ b/pandora_console/include/class/CustomNetScan.class.php
@@ -452,7 +452,7 @@ class CustomNetScan extends Wizard
                     'label'     => __('Task name'),
                     'arguments' => [
                         'name'  => 'taskname',
-                        'value' => $this->task['name'],
+                        'value' => (isset($this->task['name']) === true) ? $this->task['name'] : '',
                         'type'  => 'text',
                         'size'  => 50,
                     ],
@@ -474,7 +474,7 @@ class CustomNetScan extends Wizard
                     'label'     => __('Comment'),
                     'arguments' => [
                         'name'  => 'comment',
-                        'value' => $this->task['description'],
+                        'value' => (isset($this->task['description']) === true) ? $this->task['description'] : '',
                         'type'  => 'text',
                         'size'  => 50,
                     ],
@@ -496,7 +496,7 @@ class CustomNetScan extends Wizard
                             SERVER_TYPE_DISCOVERY
                         ),
                         'name'     => 'id_recon_server',
-                        'selected' => $this->task['id_recon_server'],
+                        'selected' => (isset($this->task['id_recon_server']) === true) ? $this->task['id_recon_server'] : '',
                         'return'   => true,
                     ],
                 ];
@@ -509,7 +509,7 @@ class CustomNetScan extends Wizard
                         'returnAllGroup' => false,
                         'privilege'      => $this->access,
                         'type'           => 'select_groups',
-                        'selected'       => $this->task['id_group'],
+                        'selected'       => (isset($this->task['id_group']) === true) ? $this->task['id_group'] : '',
                         'return'         => true,
                         'size'           => '400px',
                     ],
@@ -517,8 +517,10 @@ class CustomNetScan extends Wizard
 
                 // Interval and schedules.
                 $interv_manual = 0;
-                if ((int) $this->task['interval_sweep'] == 0) {
-                    $interv_manual = 1;
+                if (isset($this->task['interval_sweep']) === true) {
+                    if ((int) $this->task['interval_sweep'] == 0) {
+                        $interv_manual = 1;
+                    }
                 }
 
                 // Schedule.
@@ -541,7 +543,7 @@ class CustomNetScan extends Wizard
                     ],
                     'extra'           => '<span id="interval_manual_container">'.html_print_extended_select_for_time(
                         'interval',
-                        $this->task['interval_sweep'],
+                        (isset($this->task['interval_sweep']) === true) ? $this->task['interval_sweep'] : '',
                         'check_period_warning(this, \''.__('Warning').'\', \''.__('Displaying items with extended historical data can have an impact on system performance. We do not recommend that you use intervals longer than 30 days, especially if you combine several of them in a report, dashboard or visual console.').'\')',
                         '',
                         '0',
diff --git a/pandora_console/include/class/HTML.class.php b/pandora_console/include/class/HTML.class.php
index f2bae706ce..b8d41b0dce 100644
--- a/pandora_console/include/class/HTML.class.php
+++ b/pandora_console/include/class/HTML.class.php
@@ -622,6 +622,10 @@ class HTML
     public static function printBlockAsGrid(array $input, bool $return=false)
     {
         $output = '';
+        if (isset($input['hidden']) === false) {
+            $input['hidden'] = 0;
+        }
+
         if ($input['hidden'] == 1) {
             $class = ' hidden';
         } else {
@@ -632,6 +636,14 @@ class HTML
             $class = $input['class'].$class;
         }
 
+        if (isset($input['block_content']) === false) {
+            $input['block_content'] = '';
+        }
+
+        if (isset($input['block_class']) === false) {
+            $input['block_class'] = '';
+        }
+
         if (is_array($input['block_content']) === true) {
             if (empty($input['label']) === false) {
                 $output .= '<div class="label_select">';
@@ -648,6 +660,18 @@ class HTML
 
             $output .= '</ul></li>';
         } else {
+            if (isset($input['arguments']['inline']) === false) {
+                $input['arguments']['inline'] = '';
+            }
+
+            if (isset($input['extra']) === false) {
+                $input['extra'] = '';
+            }
+
+            if (isset($input['arguments']) === false) {
+                $input['arguments'] = '';
+            }
+
             if ($input['arguments']['type'] != 'hidden'
                 && $input['arguments']['type'] != 'hidden_extended'
             ) {
@@ -733,6 +757,10 @@ class HTML
     public static function printBlockAsList(array $input, bool $return=false)
     {
         $output = '';
+        if (isset($input['hidden']) === false) {
+            $input['hidden'] = 0;
+        }
+
         if ($input['hidden'] == 1) {
             $class = ' hidden';
         } else {
@@ -743,6 +771,10 @@ class HTML
             $class = $input['class'].$class;
         }
 
+        if (isset($input['block_content']) === false) {
+            $input['block_content'] = '';
+        }
+
         if (is_array($input['block_content']) === true) {
             // Print independent block of inputs.
             $output .= '<li id="'.$input['block_id'].'" class="'.$class.'">';
@@ -753,6 +785,14 @@ class HTML
 
             $output .= '</ul></li>';
         } else {
+            if (isset($input['id']) === false) {
+                $input['id'] = '';
+            }
+
+            if (isset($input['extra']) === false) {
+                $input['extra'] = '';
+            }
+
             if ($input['arguments']['type'] != 'hidden'
                 && $input['arguments']['type'] != 'hidden_extended'
             ) {
@@ -953,6 +993,42 @@ class HTML
     {
         $form = $data['form'];
 
+        if (isset($data['rows']) === false) {
+            $data['rows'] = '';
+        }
+
+        if (isset($data['rawInputs']) === false) {
+            $data['rawInputs'] = '';
+        }
+
+        if (isset($data['js']) === false) {
+            $data['js'] = '';
+        }
+
+        if (isset($data['js_block']) === false) {
+            $data['js_block'] = '';
+        }
+
+        if (isset($data['cb_function']) === false) {
+            $data['cb_function'] = null;
+        }
+
+        if (isset($data['cb_args']) === false) {
+            $data['cb_args'] = [];
+        }
+
+        if (isset($form['class']) === false) {
+            $form['class'] = '';
+        }
+
+        if (isset($form['onsubmit']) === false) {
+            $form['onsubmit'] = '';
+        }
+
+        if (isset($form['extra']) === false) {
+            $form['extra'] = '';
+        }
+
         $rows = $data['rows'];
         $rawInputs = $data['rawInputs'];
         $js = $data['js'];
@@ -991,7 +1067,15 @@ class HTML
 
         if (is_array($rows)) {
             foreach ($rows as $row) {
-                if ($row['new_form_block'] == true) {
+                if (isset($row['class']) === false) {
+                    $row['class'] = '';
+                }
+
+                if (isset($row['style']) === false) {
+                    $row['style'] = '';
+                }
+
+                if (isset($row['new_form_block']) === true) {
                     if ($first_block_printed === true) {
                         // If first form block has been placed, then close it before starting a new one.
                         $output .= '</div>';
@@ -1019,30 +1103,38 @@ class HTML
                     // Toggle option.
                     foreach ($column['inputs'] as $input) {
                         if (is_array($input)) {
-                            if ($input['arguments']['type'] != 'submit') {
-                                if ($input['toggle'] === true) {
-                                    $output .= ui_print_toggle(
-                                        [
-                                            'name'            => (isset($input['toggle_name']) ? $input['toggle_name'] : 'toggle_'.uniqid()),
-                                            'title'           => $input['toggle_title'],
-                                            'id'              => $input['toggle_id'],
-                                            'hidden_default'  => $input['toggle_hidden_default'],
-                                            'content'         => self::printBlockAsGrid(
-                                                $input,
-                                                true
-                                            ),
-                                            'return'          => true,
-                                            'name'            => (isset($input['toggle_name']) ? $input['toggle_name'] : 'toggle_'.uniqid()),
-                                            'toggle_class'    => $input['toggle_toggle_class'],
-                                            'main_class'      => $input['toggle_main_class'],
-                                            'container_class' => $input['toggle_container_class'],
-                                            'img_a'           => $input['toggle_img_a'],
-                                            'img_b'           => $input['toggle_img_b'],
-                                            'clean'           => (isset($input['toggle_clean']) ? $input['toggle_clean'] : true),
-                                        ]
-                                    );
+                            if (isset($input['arguments']) === true) {
+                                if ($input['arguments']['type'] != 'submit') {
+                                    if (isset($input['toggle']) === true) {
+                                        if ($input['toggle'] === true) {
+                                            $output .= ui_print_toggle(
+                                                [
+                                                    'name'            => (isset($input['toggle_name']) ? $input['toggle_name'] : 'toggle_'.uniqid()),
+                                                    'title'           => $input['toggle_title'],
+                                                    'id'              => $input['toggle_id'],
+                                                    'hidden_default'  => $input['toggle_hidden_default'],
+                                                    'content'         => self::printBlockAsGrid(
+                                                        $input,
+                                                        true
+                                                    ),
+                                                    'return'          => true,
+                                                    'name'            => (isset($input['toggle_name']) ? $input['toggle_name'] : 'toggle_'.uniqid()),
+                                                    'toggle_class'    => $input['toggle_toggle_class'],
+                                                    'main_class'      => $input['toggle_main_class'],
+                                                    'container_class' => $input['toggle_container_class'],
+                                                    'img_a'           => $input['toggle_img_a'],
+                                                    'img_b'           => $input['toggle_img_b'],
+                                                    'clean'           => (isset($input['toggle_clean']) ? $input['toggle_clean'] : true),
+                                                ]
+                                            );
+                                        } else {
+                                            $output .= self::printBlockAsGrid($input, true);
+                                        }
+                                    } else {
+                                        $output .= self::printBlockAsGrid($input, true);
+                                    }
                                 } else {
-                                    $output .= self::printBlockAsGrid($input, true);
+                                    $output_submit .= self::printBlockAsGrid($input, true);
                                 }
                             } else {
                                 $output_submit .= self::printBlockAsGrid($input, true);
@@ -1093,6 +1185,34 @@ class HTML
      */
     public static function printFormAsList(array $data, bool $return=false)
     {
+        if (isset($data['rows']) === false) {
+            $data['rows'] = '';
+        }
+
+        if (isset($data['rawInputs']) === false) {
+            $data['rawInputs'] = '';
+        }
+
+        if (isset($data['js']) === false) {
+            $data['js'] = '';
+        }
+
+        if (isset($data['js_block']) === false) {
+            $data['js_block'] = '';
+        }
+
+        if (isset($data['cb_function']) === false) {
+            $data['cb_function'] = null;
+        }
+
+        if (isset($data['cb_args']) === false) {
+            $data['cb_args'] = [];
+        }
+
+        if (isset($form['class']) === false) {
+            $form['class'] = '';
+        }
+
         $form = $data['form'];
         $inputs = $data['inputs'];
         $rawInputs = $data['rawInputs'];
@@ -1101,6 +1221,18 @@ class HTML
         $cb_function = $data['cb_function'];
         $cb_args = $data['cb_args'];
 
+        if (isset($form['onsubmit']) === false) {
+            $form['onsubmit'] = '';
+        }
+
+        if (isset($form['extra']) === false) {
+            $form['extra'] = '';
+        }
+
+        if (isset($form['enctype']) === false) {
+            $form['enctype'] = '';
+        }
+
         $output_head = '<form class="discovery max_floating_element_size" id="'.$form['id'].'" onsubmit="'.$form['onsubmit'].'" enctype="'.$form['enctype'].'" action="'.$form['action'].'" method="'.$form['method'];
         $output_head .= '" '.$form['extra'].'>';
 
@@ -1121,7 +1253,7 @@ class HTML
 
         $output = '<div class="white_box pdd_15px">';
         $output .= '<ul class="wizard">';
-
+        $output_submit = '';
         foreach ($inputs as $input) {
             if ($input['arguments']['type'] != 'submit') {
                 $output .= self::printBlockAsList($input, true);
diff --git a/pandora_console/include/functions_cron.php b/pandora_console/include/functions_cron.php
index 711ed7f6ba..f3755fd383 100644
--- a/pandora_console/include/functions_cron.php
+++ b/pandora_console/include/functions_cron.php
@@ -593,7 +593,7 @@ function cron_list_table()
 
                     // Check ACL in reports_get_report return false.
                     if ($report === false) {
-                        continue;
+                        break;
                     }
 
                     $email = ui_print_truncate_text($args[1], 120);
@@ -656,7 +656,7 @@ function cron_list_table()
 
                     // Check ACL in reports_get_report return false.
                     if ($template === false) {
-                        continue;
+                        break;
                     }
 
                     if (empty($args[1]) === false && (string) $args[1] !== '0') {
@@ -777,7 +777,7 @@ function cron_list_table()
 
                     // Check ACL in reports_get_report return false.
                     if ($report === false) {
-                        continue;
+                        break;
                     }
 
                     $path = $args[1];
@@ -817,7 +817,7 @@ function cron_list_table()
 
                     // Check ACL in reports_get_report return false.
                     if ($report === false) {
-                        continue;
+                        break;
                     }
 
                     $path = $args[1];
diff --git a/pandora_console/include/functions_html.php b/pandora_console/include/functions_html.php
index 402f0c71a2..8fb8e3dcd0 100644
--- a/pandora_console/include/functions_html.php
+++ b/pandora_console/include/functions_html.php
@@ -5858,9 +5858,9 @@ function html_print_input($data, $wrapper='div', $input_only=false)
 
         case 'textarea':
             $output .= html_print_textarea(
-                $data['name'],
-                $data['rows'],
-                $data['columns'],
+                (isset($data['name']) === true) ? $data['name'] : '',
+                (isset($data['rows']) === true) ? $data['rows'] : '',
+                (isset($data['columns']) === true) ? $data['columns'] : '',
                 ((isset($data['value']) === true) ? $data['value'] : ''),
                 ((isset($data['attributes']) === true) ? $data['attributes'] : ''),
                 ((isset($data['return']) === true) ? $data['return'] : false),

From b00bb507b6fd833ddb00932d6b5ffa1620ff4778 Mon Sep 17 00:00:00 2001
From: "alejandro.campos@artica.es" <alejandro.campos@artica.es>
Date: Wed, 14 Feb 2024 14:02:31 +0100
Subject: [PATCH 12/26] fix entities

---
 pandora_console/include/lib/Dashboard/Widgets/maps_status.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pandora_console/include/lib/Dashboard/Widgets/maps_status.php b/pandora_console/include/lib/Dashboard/Widgets/maps_status.php
index 2e59af771c..d3f5bfd625 100755
--- a/pandora_console/include/lib/Dashboard/Widgets/maps_status.php
+++ b/pandora_console/include/lib/Dashboard/Widgets/maps_status.php
@@ -253,7 +253,7 @@ class MapsStatusWidget extends Widget
         $fields = array_reduce(
             $dataVc,
             function ($carry, $item) {
-                $carry[$item['id']] = $item['name'];
+                $carry[$item['id']] = io_safe_output($item['name']);
                 return $carry;
             },
             []

From 5dbf868460e2b6db542880d254a45911c009afb0 Mon Sep 17 00:00:00 2001
From: "alejandro.campos@artica.es" <alejandro.campos@artica.es>
Date: Wed, 14 Feb 2024 17:37:10 +0100
Subject: [PATCH 13/26] fix entities

---
 pandora_console/include/lib/Dashboard/Widgets/maps_status.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pandora_console/include/lib/Dashboard/Widgets/maps_status.php b/pandora_console/include/lib/Dashboard/Widgets/maps_status.php
index d3f5bfd625..12d0ef9461 100755
--- a/pandora_console/include/lib/Dashboard/Widgets/maps_status.php
+++ b/pandora_console/include/lib/Dashboard/Widgets/maps_status.php
@@ -350,7 +350,7 @@ class MapsStatusWidget extends Widget
 
                 // This will give us the group name.
                 $data[0] = '<a href="'.$url.'">';
-                $data[0] .= $user_layouts[$id_layout]['name'];
+                $data[0] .= io_safe_output($user_layouts[$id_layout]['name']);
                 $data[0] .= '</a>';
 
                 // Status 0 is OK.

From 42975c79670e52c8c98bc0dfc49d6d6809ae06d5 Mon Sep 17 00:00:00 2001
From: Jonathan <jonathan.leon@pandorafms.com>
Date: Wed, 14 Feb 2024 17:43:20 +0100
Subject: [PATCH 14/26] #12695 wip removing warnings

---
 .../godmode/alerts/alert_commands.php         |  2 +-
 .../godmode/alerts/alert_list.list.php        |  4 +-
 pandora_console/godmode/category/category.php |  1 +
 pandora_console/godmode/extensions.php        | 10 ++--
 pandora_console/godmode/groups/group_list.php |  6 +--
 .../modules/manage_network_components.php     |  8 +++-
 .../godmode/servers/modificar_server.php      |  4 +-
 pandora_console/godmode/servers/plugin.php    |  4 ++
 .../godmode/servers/plugin_registration.php   | 38 ++++++++-------
 .../godmode/servers/servers.build_table.php   |  4 +-
 .../godmode/setup/file_manager.php            | 11 ++++-
 pandora_console/godmode/setup/license.php     |  8 ++--
 pandora_console/godmode/setup/news.php        |  4 ++
 pandora_console/godmode/setup/os.list.php     |  5 +-
 .../godmode/snmpconsole/snmp_alert.php        | 44 ++++++++---------
 .../update_manager/update_manager.setup.php   |  2 +-
 .../godmode/wizards/Cloud.class.php           |  8 ++--
 .../include/ajax/consoles.ajax.php            |  2 +-
 .../include/class/Diagnostics.class.php       |  8 +++-
 .../include/class/EventSound.class.php        | 48 ++++++++++---------
 .../class/ExtensionsDiscovery.class.php       |  5 +-
 pandora_console/include/class/HTML.class.php  |  4 ++
 .../include/class/ModuleTemplates.class.php   |  9 +++-
 .../include/functions_filemanager.php         |  6 ++-
 pandora_console/include/functions_html.php    |  4 +-
 pandora_console/include/functions_menu.php    |  4 +-
 .../operation/agentes/exportdata.php          | 10 +++-
 27 files changed, 157 insertions(+), 106 deletions(-)

diff --git a/pandora_console/godmode/alerts/alert_commands.php b/pandora_console/godmode/alerts/alert_commands.php
index a5b4de7c80..b242e41e29 100644
--- a/pandora_console/godmode/alerts/alert_commands.php
+++ b/pandora_console/godmode/alerts/alert_commands.php
@@ -109,7 +109,7 @@ if (is_ajax()) {
         for ($i = 1; $i <= $config['max_macro_fields']; $i++) {
             $field_description = $fields_descriptions[($i - 1)];
             $field_value = $fields_values[($i - 1)];
-            $field_hidden = $fields_hidden_checked[($i - 1)];
+            $field_hidden = (isset($fields_hidden_checked[($i - 1)]) === true) ? $fields_hidden_checked[($i - 1)] : '';
 
 
             if (!empty($field_description)) {
diff --git a/pandora_console/godmode/alerts/alert_list.list.php b/pandora_console/godmode/alerts/alert_list.list.php
index 5d71895ecd..fe0790f71b 100644
--- a/pandora_console/godmode/alerts/alert_list.list.php
+++ b/pandora_console/godmode/alerts/alert_list.list.php
@@ -253,7 +253,7 @@ if (is_metaconsole() === true) {
     echo '<br>';
 }
 
-if (!$id_cluster) {
+if (isset($id_cluster) === false) {
     ui_toggle(
         $form_filter,
         '<span class="subsection_header_title">'.__('Alert control filter').'</span>',
@@ -1115,7 +1115,7 @@ if (isset($dont_display_alert_create_bttn)) {
     }
 }
 
-if ($display_create && (check_acl($config['id_user'], 0, 'LW') || check_acl($config['id_user'], $template_group, 'LM')) && !$id_cluster) {
+if ($display_create && (check_acl($config['id_user'], 0, 'LW') || check_acl($config['id_user'], $template_group, 'LM')) && isset($id_cluster) === false) {
     echo '<form method="post" action="index.php?sec='.$sec.'&sec2=godmode/alerts/alert_list&tab=builder&pure='.$pure.'">';
     $actionButtons = html_print_submit_button(
         __('Create'),
diff --git a/pandora_console/godmode/category/category.php b/pandora_console/godmode/category/category.php
index 46095b6efb..02a221fee8 100755
--- a/pandora_console/godmode/category/category.php
+++ b/pandora_console/godmode/category/category.php
@@ -242,6 +242,7 @@ if (empty($result) === false) {
     html_print_table($table);
     $tablePagination = ui_pagination($total_categories, $url, $offset, 0, true, 'offset', false);
 } else {
+    $tablePagination = '';
     // No categories available or selected.
     ui_print_info_message(['no_close' => true, 'message' => __('No categories found') ]);
 }
diff --git a/pandora_console/godmode/extensions.php b/pandora_console/godmode/extensions.php
index 3ff09273c6..3db36f71a9 100644
--- a/pandora_console/godmode/extensions.php
+++ b/pandora_console/godmode/extensions.php
@@ -195,13 +195,13 @@ foreach ($extensions as $file => $extension) {
         $data[] = '<i class="grey">'.$file.'</i>';
 
         // Get version of this extensions
-        if ($config['extensions'][$file]['operation_menu']) {
+        if (isset($config['extensions'][$file]['operation_menu']) === true) {
             $data[] = $config['extensions'][$file]['operation_menu']['version'];
-        } else if ($config['extensions'][$file]['godmode_menu']) {
+        } else if (isset($config['extensions'][$file]['godmode_menu']) === true) {
             $data[] = $config['extensions'][$file]['godmode_menu']['version'];
-        } else if ($config['extensions'][$file]['extension_ope_tab']) {
+        } else if (isset($config['extensions'][$file]['extension_ope_tab']) === true) {
             $data[] = $config['extensions'][$file]['extension_ope_tab']['version'];
-        } else if ($config['extensions'][$file]['extension_god_tab']) {
+        } else if (isset($config['extensions'][$file]['extension_god_tab']) === true) {
             $data[] = $config['extensions'][$file]['extension_god_tab']['version'];
         } else {
             $data[] = __('N/A');
@@ -216,7 +216,7 @@ foreach ($extensions as $file => $extension) {
             $data[] = $config['extensions'][$file]['godmode_menu']['version'];
         } else if (isset($config['extensions'][$file]['extension_ope_tab'])) {
             $data[] = $config['extensions'][$file]['extension_ope_tab']['version'];
-        } else if ($config['extensions'][$file]['extension_god_tab']) {
+        } else if (isset($config['extensions'][$file]['extension_god_tab']) === true) {
             $data[] = $config['extensions'][$file]['extension_god_tab']['version'];
         } else {
             $data[] = __('N/A');
diff --git a/pandora_console/godmode/groups/group_list.php b/pandora_console/godmode/groups/group_list.php
index 66717bc35b..f17f115b9d 100644
--- a/pandora_console/godmode/groups/group_list.php
+++ b/pandora_console/godmode/groups/group_list.php
@@ -1183,9 +1183,9 @@ $tab = 'group_edition';
 
 <script type="text/javascript">
 
-    let show_full_hirearchy = "<?php echo $show_full_hirearchy; ?>";
-    let show_not_init_agents = "<?php echo $show_not_init_agents; ?>";
-    let show_not_init_modules = "<?php echo $show_not_init_modules; ?>";
+    let show_full_hirearchy = "<?php echo (isset($show_full_hirearchy) === true) ? $show_full_hirearchy : ''; ?>";
+    let show_not_init_agents = "<?php echo (isset($show_not_init_agents) === true) ? $show_not_init_agents : ''; ?>";
+    let show_not_init_modules = "<?php echo (isset($show_not_init_modules) === true) ? $show_not_init_modules : ''; ?>";
 
     $('#checkbox-show_full_hirearchy').on("change", function() { 
         if (show_full_hirearchy == 1) {
diff --git a/pandora_console/godmode/modules/manage_network_components.php b/pandora_console/godmode/modules/manage_network_components.php
index d1d5f5687f..c04a66b549 100644
--- a/pandora_console/godmode/modules/manage_network_components.php
+++ b/pandora_console/godmode/modules/manage_network_components.php
@@ -686,6 +686,12 @@ $table->data[0][] = html_print_label_input_block(
     )
 );
 
+if (isset($component) === false) {
+    $component = [];
+    $component['id'] = '';
+    $component['id_nc'] = '';
+}
+
 $filter_action_url = 'index.php?sec='.$sec.'&sec2=godmode/modules/manage_network_components&id='.$component['id_nc'].'&search_string='.urlencode(io_safe_output($search_string)).'&search_id_group'.$search_id_group.'&pure='.$pure;
 $toggleFilters = '<form class="filters_form" method="POST" action="'.$filter_action_url.'">';
 $toggleFilters .= html_print_table($table, true);
@@ -824,7 +830,7 @@ foreach ($components as $component) {
         $data[0] = io_safe_output($component['name']);
     }
 
-    $data[1] .= ui_print_servertype_icon((int) $component['id_modulo']);
+    $data[1] = ui_print_servertype_icon((int) $component['id_modulo']);
 
     $data[2] = ui_print_moduletype_icon($component['type'], true);
     $data[3] = "<span class='font_8px'>".mb_strimwidth(io_safe_output($component['description']), 0, 60, '...').'</span>';
diff --git a/pandora_console/godmode/servers/modificar_server.php b/pandora_console/godmode/servers/modificar_server.php
index 8a78de9592..e4c5d7aa09 100644
--- a/pandora_console/godmode/servers/modificar_server.php
+++ b/pandora_console/godmode/servers/modificar_server.php
@@ -496,8 +496,8 @@ if (isset($_GET['server']) === true) {
 <script language="javascript" type="text/javascript">
 
 $(document).ready (function () {
-    var id_server = '<?php echo $id_server; ?>';
-    var server_type = '<?php echo $row['server_type']; ?>';
+    var id_server = '<?php echo ($id_server ?? ''); ?>';
+    var server_type = '<?php echo ($row['server_type'] ?? ''); ?>';
     $("#check_exec_server img").on("click", function () {
         $("#check_exec_server img").attr("src", "images/spinner.gif");
 
diff --git a/pandora_console/godmode/servers/plugin.php b/pandora_console/godmode/servers/plugin.php
index 991ed52855..22808f8053 100644
--- a/pandora_console/godmode/servers/plugin.php
+++ b/pandora_console/godmode/servers/plugin.php
@@ -1172,6 +1172,10 @@ if (empty($create) === false || empty($view) === false) {
 }
 
 ui_require_javascript_file('pandora_modules');
+
+if (isset($locked) === false) {
+    $locked = '';
+}
 ?>
 
 <script type="text/javascript">
diff --git a/pandora_console/godmode/servers/plugin_registration.php b/pandora_console/godmode/servers/plugin_registration.php
index e7f8709346..8394ae8980 100644
--- a/pandora_console/godmode/servers/plugin_registration.php
+++ b/pandora_console/godmode/servers/plugin_registration.php
@@ -523,27 +523,29 @@ if ($error === null) {
     }
 }
 
-if (file_exists($uploaded_filename) === true) {
-    if (is_metaconsole() === true && is_management_allowed() === true) {
-        // Keep uploaded file to be transferred to nodes.
-        if (is_dir($config['attachment_store'].'/downloads/') === false) {
-            mkdir($config['attachment_store'].'/downloads/');
-        }
+if (isset($uploaded_filename) === true) {
+    if (file_exists($uploaded_filename) === true) {
+        if (is_metaconsole() === true && is_management_allowed() === true) {
+            // Keep uploaded file to be transferred to nodes.
+            if (is_dir($config['attachment_store'].'/downloads/') === false) {
+                mkdir($config['attachment_store'].'/downloads/');
+            }
 
-        $keep = move_uploaded_file(
-            $uploaded_filename,
-            $config['attachment_store'].'/downloads/'.$filename
-        );
-
-        if ($keep === false) {
-            $error = __(
-                'Cannot move uploaded file to %s.',
-                $config['attachment_store'].'/downloads/'
+            $keep = move_uploaded_file(
+                $uploaded_filename,
+                $config['attachment_store'].'/downloads/'.$filename
             );
+
+            if ($keep === false) {
+                $error = __(
+                    'Cannot move uploaded file to %s.',
+                    $config['attachment_store'].'/downloads/'
+                );
+            }
+        } else {
+            // Clean temporary files.
+            unlink($uploaded_filename);
         }
-    } else {
-        // Clean temporary files.
-        unlink($uploaded_filename);
     }
 }
 
diff --git a/pandora_console/godmode/servers/servers.build_table.php b/pandora_console/godmode/servers/servers.build_table.php
index 1589f33fc9..58c9f02a7d 100644
--- a/pandora_console/godmode/servers/servers.build_table.php
+++ b/pandora_console/godmode/servers/servers.build_table.php
@@ -146,9 +146,9 @@ foreach ($servers as $server) {
     // Type.
     $data[2] = '<span class="nowrap">'.$server['img'].'&nbsp;&nbsp;&nbsp;&nbsp;'.$server['server_name'];
     if ($server['master'] == $master) {
-        $data[3] .= __('Yes', true);
+        $data[3] = __('Yes', true);
     } else {
-        $data[3] .= __('-');
+        $data[3] = __('-');
     }
 
     if ((int) $server['exec_proxy'] === 1) {
diff --git a/pandora_console/godmode/setup/file_manager.php b/pandora_console/godmode/setup/file_manager.php
index 211af66cb7..4aac87d770 100644
--- a/pandora_console/godmode/setup/file_manager.php
+++ b/pandora_console/godmode/setup/file_manager.php
@@ -70,6 +70,10 @@ if (isset($config['filemanager']['message']) === true) {
 // Add custom directories here.
 $fallback_directory = 'images';
 // Get directory.
+if (isset($text) === false) {
+    $text = '';
+}
+
 $directory = (string) get_parameter('directory');
 $directory = str_replace('&lt;', '', $text);
 $directory = str_replace('&gt;', '', $text);
@@ -90,7 +94,12 @@ $create_text_file = (bool) get_parameter('create_text_file');
 $default_real_directory = realpath($config['homedir'].'/');
 
 // Remove double dot in filename path.
-$file_name = $_FILES['file']['name'];
+if (isset($_FILES['file']) === true) {
+    $file_name = $_FILES['file']['name'];
+} else {
+    $file_name = '';
+}
+
 $path_parts = explode('/', $file_name);
 
 $stripped_parts = array_filter(
diff --git a/pandora_console/godmode/setup/license.php b/pandora_console/godmode/setup/license.php
index e3e25935f9..2bc556ac62 100644
--- a/pandora_console/godmode/setup/license.php
+++ b/pandora_console/godmode/setup/license.php
@@ -399,7 +399,7 @@ $table->data[0][0] = html_print_label_input_block(
     __('Total Agents'),
     html_print_input_text(
         'total_agents',
-        $total_agents,
+        ($total_agents ?? ''),
         '',
         30,
         255,
@@ -412,7 +412,7 @@ $table->data[0][1] = html_print_label_input_block(
     __('Network & other devices'),
     html_print_input_text(
         'type_network',
-        $network_others,
+        ($network_others ?? ''),
         '',
         30,
         255,
@@ -425,7 +425,7 @@ $table->data[1][0] = html_print_label_input_block(
     __('Workstations'),
     html_print_input_text(
         'type_workstation',
-        $workstations,
+        ($workstations ?? ''),
         '',
         30,
         255,
@@ -438,7 +438,7 @@ $table->data[1][1] = html_print_label_input_block(
     __('Servers'),
     html_print_input_text(
         'type_server',
-        $servers,
+        ($servers ?? ''),
         '',
         30,
         255,
diff --git a/pandora_console/godmode/setup/news.php b/pandora_console/godmode/setup/news.php
index 6ad346586e..c8f16226fd 100644
--- a/pandora_console/godmode/setup/news.php
+++ b/pandora_console/godmode/setup/news.php
@@ -389,6 +389,10 @@ if ((isset($_GET['form_add'])) || (isset($_GET['form_edit']))) {
                 echo '<td>'.__('No').'</b></td>';
             }
 
+            if (isset($tdcolor) === false) {
+                $tdcolor = '';
+            }
+
             echo '<td class="'.$tdcolor.' table_action_buttons"><a href="index.php?sec=gsetup&sec2=godmode/setup/news&id_news='.$row['id_news'].'&borrar='.$row['id_news'].'" onClick="if (!confirm(\' '.__('Are you sure?').'\')) return false;">'.html_print_image('images/delete.svg', true, ['border' => '0', 'class' => 'invert_filter main_menu_icon']).'</a></td></tr>';
         }
 
diff --git a/pandora_console/godmode/setup/os.list.php b/pandora_console/godmode/setup/os.list.php
index 27ae4e82f2..2c722aade0 100644
--- a/pandora_console/godmode/setup/os.list.php
+++ b/pandora_console/godmode/setup/os.list.php
@@ -164,9 +164,8 @@ if (is_metaconsole() === true) {
 html_print_action_buttons(
     $buttons,
     [
-        'type'          => 'data_table',
-        'class'         => 'fixed_action_buttons',
-        'right_content' => $tablePagination,
+        'type'  => 'data_table',
+        'class' => 'fixed_action_buttons',
     ]
 );
 
diff --git a/pandora_console/godmode/snmpconsole/snmp_alert.php b/pandora_console/godmode/snmpconsole/snmp_alert.php
index 5f76fd1f9c..f2aa2b1890 100755
--- a/pandora_console/godmode/snmpconsole/snmp_alert.php
+++ b/pandora_console/godmode/snmpconsole/snmp_alert.php
@@ -2087,7 +2087,7 @@ if ($create_alert || $update_alert) {
                         FROM talert_actions
                         ORDER BY name',
                         'alert_type',
-                        $alert_type,
+                        ($alert_type ?? ''),
                         '',
                         '',
                         0,
@@ -2100,26 +2100,26 @@ if ($create_alert || $update_alert) {
                 echo '</tr>';
 
                 $al = [
-                    'al_field1'  => $al_field1,
-                    'al_field2'  => $al_field2,
-                    'al_field3'  => $al_field3,
-                    'al_field4'  => $al_field4,
-                    'al_field5'  => $al_field5,
-                    'al_field6'  => $al_field6,
-                    'al_field7'  => $al_field7,
-                    'al_field8'  => $al_field8,
-                    'al_field9'  => $al_field9,
-                    'al_field10' => $al_field10,
-                    'al_field11' => $al_field11,
-                    'al_field12' => $al_field12,
-                    'al_field13' => $al_field13,
-                    'al_field14' => $al_field14,
-                    'al_field15' => $al_field15,
-                    'al_field16' => $al_field16,
-                    'al_field17' => $al_field17,
-                    'al_field18' => $al_field18,
-                    'al_field19' => $al_field19,
-                    'al_field20' => $al_field20,
+                    'al_field1'  => ($al_field1 ?? ''),
+                    'al_field2'  => ($al_field2 ?? ''),
+                    'al_field3'  => ($al_field3 ?? ''),
+                    'al_field4'  => ($al_field4 ?? ''),
+                    'al_field5'  => ($al_field5 ?? ''),
+                    'al_field6'  => ($al_field6 ?? ''),
+                    'al_field7'  => ($al_field7 ?? ''),
+                    'al_field8'  => ($al_field8 ?? ''),
+                    'al_field9'  => ($al_field9 ?? ''),
+                    'al_field10' => ($al_field10 ?? ''),
+                    'al_field11' => ($al_field11 ?? ''),
+                    'al_field12' => ($al_field12 ?? ''),
+                    'al_field13' => ($al_field13 ?? ''),
+                    'al_field14' => ($al_field14 ?? ''),
+                    'al_field15' => ($al_field15 ?? ''),
+                    'al_field16' => ($al_field16 ?? ''),
+                    'al_field17' => ($al_field17 ?? ''),
+                    'al_field18' => ($al_field18 ?? ''),
+                    'al_field19' => ($al_field19 ?? ''),
+                    'al_field20' => ($al_field20 ?? ''),
                 ];
 
                 for ($i = 1; $i <= $config['max_macro_fields']; $i++) {
@@ -2287,7 +2287,7 @@ $(document).ready (function () {
         });
         values.push({
             name: "content_type",
-            value: "<?php echo $al_field4; ?>"
+            value: "<?php echo ($al_field4 ?? ''); ?>"
         })
 
         jQuery.post (<?php echo "'".ui_get_full_url('ajax.php', false, false, false)."'"; ?>,
diff --git a/pandora_console/godmode/update_manager/update_manager.setup.php b/pandora_console/godmode/update_manager/update_manager.setup.php
index 6fb56aed15..78c27d54cc 100644
--- a/pandora_console/godmode/update_manager/update_manager.setup.php
+++ b/pandora_console/godmode/update_manager/update_manager.setup.php
@@ -99,7 +99,7 @@ if (!$action_update_url_update_manager) {
     );
     $allow_offline_patches = get_parameter_switch(
         'allow_offline_patches',
-        $config['allow_offline_patches']
+        ($config['allow_offline_patches'] ?? '')
     );
     $lts_updates = get_parameter_switch(
         'lts_updates',
diff --git a/pandora_console/godmode/wizards/Cloud.class.php b/pandora_console/godmode/wizards/Cloud.class.php
index c464c49faa..5ddb4a1d51 100644
--- a/pandora_console/godmode/wizards/Cloud.class.php
+++ b/pandora_console/godmode/wizards/Cloud.class.php
@@ -321,7 +321,7 @@ class Cloud extends Wizard
             ui_print_error_message($this->msg);
         }
 
-        if ($empty_account === true) {
+        if (isset($empty_account) === true) {
             ui_print_error_message($this->msg);
         }
 
@@ -357,7 +357,7 @@ class Cloud extends Wizard
                             'name'     => 'account_identifier',
                             'type'     => 'select',
                             'fields'   => CredentialStore::getKeys($this->keyStoreType),
-                            'selected' => $this->keyIdentifier,
+                            'selected' => (isset($this->keyIdentifier) === true) ? $this->keyIdentifier : '',
                             'return'   => true,
                         ],
                     ],
@@ -419,7 +419,7 @@ class Cloud extends Wizard
             return false;
         }
 
-        if ($this->keyIdentifier === null) {
+        if (isset($this->keyIdentifier) === false) {
             // Ask user for available credentials.
             $this->msg = __('Select a set of credentials from the list');
             $this->status = null;
@@ -496,7 +496,7 @@ class Cloud extends Wizard
      */
     public function getCredentials()
     {
-        return CredentialStore::getKey($this->keyIdentifier);
+        return CredentialStore::getKey((isset($this->keyIdentifier) === true) ? $this->keyIdentifier : '');
     }
 
 
diff --git a/pandora_console/include/ajax/consoles.ajax.php b/pandora_console/include/ajax/consoles.ajax.php
index d060d6f9b6..3b42b15831 100644
--- a/pandora_console/include/ajax/consoles.ajax.php
+++ b/pandora_console/include/ajax/consoles.ajax.php
@@ -71,7 +71,7 @@ if ($get_all_datatables_formatted === true) {
     // Datatables format: RecordsTotal && recordsfiltered.
     echo json_encode(
         [
-            'data'            => $data,
+            'data'            => ($data ?? ''),
             'recordsTotal'    => $count,
             'recordsFiltered' => $count,
         ]
diff --git a/pandora_console/include/class/Diagnostics.class.php b/pandora_console/include/class/Diagnostics.class.php
index 4cbf4094ba..305d56a339 100644
--- a/pandora_console/include/class/Diagnostics.class.php
+++ b/pandora_console/include/class/Diagnostics.class.php
@@ -410,7 +410,7 @@ class Diagnostics extends Wizard
                 ],
             ];
 
-            $return .= '<div class="title-self-monitoring">';
+            $return = '<div class="title-self-monitoring">';
             $return .= __(
                 'Graphs modules that represent the self-monitoring system'
             );
@@ -423,7 +423,7 @@ class Diagnostics extends Wizard
             $return .= '</div>';
         }
 
-        return $return;
+        return ($return ?? '');
     }
 
 
@@ -1848,6 +1848,10 @@ class Diagnostics extends Wizard
             $sizeServerLog = number_format($fileSize);
             $sizeServerLog = (0 + str_replace(',', '', $sizeServerLog));
 
+            if (isset($config['thousand_separator']) === false) {
+                $config['thousand_separator'] = '';
+            }
+
             $value = number_format(($fileSize / $mega), 3, $config['decimal_separator'], $config['thousand_separator']);
             $message = __('You have more than 10 MB of logs');
             $status = 0;
diff --git a/pandora_console/include/class/EventSound.class.php b/pandora_console/include/class/EventSound.class.php
index 5658b44324..a8c94d14af 100644
--- a/pandora_console/include/class/EventSound.class.php
+++ b/pandora_console/include/class/EventSound.class.php
@@ -427,30 +427,32 @@ class EventSound extends HTML
         );
         $data = db_get_all_rows_sql($sql);
 
-        foreach ($data as $key => $row) {
-            if ($row['active'] === '1') {
-                $img = 'images/lightbulb.png';
-                $action = __('Disable sound');
-                $new_action = 0;
-            } else {
-                $img = 'images/lightbulb_off.png';
-                $action = __('Enable sound');
-                $new_action = 1;
+        if ($data !== false) {
+            foreach ($data as $key => $row) {
+                if ($row['active'] === '1') {
+                    $img = 'images/lightbulb.png';
+                    $action = __('Disable sound');
+                    $new_action = 0;
+                } else {
+                    $img = 'images/lightbulb_off.png';
+                    $action = __('Enable sound');
+                    $new_action = 1;
+                }
+
+                $options = '<a href="index.php?sec=eventos&sec2=godmode/events/configuration_sounds';
+                $options .= '&action=change_action&id='.$row['id'].'&set_action='.$new_action.'">';
+                $options .= html_print_image(
+                    $img,
+                    true,
+                    [
+                        'title' => $action,
+                        'class' => 'main_menu_icon invert_filter',
+                    ]
+                );
+                $options .= '</a>';
+
+                $data[$key]['options'] = $options;
             }
-
-            $options = '<a href="index.php?sec=eventos&sec2=godmode/events/configuration_sounds';
-            $options .= '&action=change_action&id='.$row['id'].'&set_action='.$new_action.'">';
-            $options .= html_print_image(
-                $img,
-                true,
-                [
-                    'title' => $action,
-                    'class' => 'main_menu_icon invert_filter',
-                ]
-            );
-            $options .= '</a>';
-
-            $data[$key]['options'] = $options;
         }
 
         echo json_encode(
diff --git a/pandora_console/include/class/ExtensionsDiscovery.class.php b/pandora_console/include/class/ExtensionsDiscovery.class.php
index c48a644cb3..9c9affaf77 100644
--- a/pandora_console/include/class/ExtensionsDiscovery.class.php
+++ b/pandora_console/include/class/ExtensionsDiscovery.class.php
@@ -417,7 +417,10 @@ class ExtensionsDiscovery extends Wizard
     public function loadIni()
     {
         global $config;
-        $iniFile = parse_ini_file($config['homedir'].$this->path.'/'.$this->mode.'/discovery_definition.ini', true, INI_SCANNER_TYPED);
+        $iniFile = false;
+        if (file_exists($config['homedir'].$this->path.'/'.$this->mode.'/discovery_definition.ini') === true) {
+            $iniFile = parse_ini_file($config['homedir'].$this->path.'/'.$this->mode.'/discovery_definition.ini', true, INI_SCANNER_TYPED);
+        }
 
         return $iniFile;
     }
diff --git a/pandora_console/include/class/HTML.class.php b/pandora_console/include/class/HTML.class.php
index b8d41b0dce..7325366b8b 100644
--- a/pandora_console/include/class/HTML.class.php
+++ b/pandora_console/include/class/HTML.class.php
@@ -218,6 +218,10 @@ class HTML
                 $class = '';
             }
 
+            if (isset($url['link']) === false) {
+                $url['link'] = '';
+            }
+
             $bc[$i] = '';
             $bc[$i] .= '<span><a class="breadcrumb_link '.$class.'" href="'.$url['link'].'">';
             $bc[$i] .= $url['label'];
diff --git a/pandora_console/include/class/ModuleTemplates.class.php b/pandora_console/include/class/ModuleTemplates.class.php
index 4c539eec16..28df221f44 100644
--- a/pandora_console/include/class/ModuleTemplates.class.php
+++ b/pandora_console/include/class/ModuleTemplates.class.php
@@ -780,8 +780,13 @@ class ModuleTemplates extends HTML
     private function setNetworkProfile()
     {
         $profileInfo = db_get_row('tnetwork_profile', 'id_np', $this->id_np);
-        $this->name = $profileInfo['name'];
-        $this->description = $profileInfo['description'];
+        if ($profileInfo !== false) {
+            $this->name = $profileInfo['name'];
+            $this->description = $profileInfo['description'];
+        } else {
+            $this->name = '';
+            $this->description = '';
+        }
 
         $penInfo = db_get_all_rows_filter('tnetwork_profile_pen', ['id_np' => $this->id_np]);
         $penList = [];
diff --git a/pandora_console/include/functions_filemanager.php b/pandora_console/include/functions_filemanager.php
index fa5b3f2eab..442c2a2f30 100644
--- a/pandora_console/include/functions_filemanager.php
+++ b/pandora_console/include/functions_filemanager.php
@@ -526,8 +526,10 @@ function filemanager_file_explorer(
     $allowCreateText = (isset($options['all']) === true) || ((isset($options['allowCreateText']) === true) && ($options['allowCreateText'] === true));
     $allowCreateFolder = (isset($options['allowCreateFolder'])) ? false : true;
 
-    if ($options['denyCreateText'] === true) {
-        $allowCreateText = false;
+    if (isset($options['denyCreateText']) === true) {
+        if ($options['denyCreateText'] === true) {
+            $allowCreateText = false;
+        }
     }
 
     if ($homedir_filemanager === false) {
diff --git a/pandora_console/include/functions_html.php b/pandora_console/include/functions_html.php
index 8fb8e3dcd0..e520303c1d 100644
--- a/pandora_console/include/functions_html.php
+++ b/pandora_console/include/functions_html.php
@@ -5578,7 +5578,7 @@ function html_print_input($data, $wrapper='div', $input_only=false)
             $output .= html_print_input_image(
                 ((isset($data['name']) === true) ? $data['name'] : ''),
                 $data['src'],
-                $data['value'],
+                ($data['value'] ?? ''),
                 ((isset($data['style']) === true) ? $data['style'] : ''),
                 ((isset($data['return']) === true) ? $data['return'] : false),
                 ((isset($data['options']) === true) ? $data['options'] : false)
@@ -5818,7 +5818,7 @@ function html_print_input($data, $wrapper='div', $input_only=false)
 
         case 'checkbox':
             $output .= html_print_checkbox(
-                $data['name'],
+                ((isset($data['name']) === true) ? $data['name'] : ''),
                 ($data['value'] ?? null),
                 ((isset($data['checked']) === true) ? $data['checked'] : false),
                 ((isset($data['return']) === true) ? $data['return'] : false),
diff --git a/pandora_console/include/functions_menu.php b/pandora_console/include/functions_menu.php
index aa19f58ded..9e2824f9e4 100644
--- a/pandora_console/include/functions_menu.php
+++ b/pandora_console/include/functions_menu.php
@@ -699,9 +699,9 @@ function menu_get_sec($with_categories=false)
             }
 
             $sec_array[$k]['optgroup'] = $category;
-            $sec_array[$k]['name'] = $v['text'];
+            $sec_array[$k]['name'] = (isset($v['text']) === true) ? $v['text'] : '';
         } else {
-            $sec_array[$k] = $v['text'];
+            $sec_array[$k] = (isset($v['text']) === true) ? $v['text'] : '';
         }
     }
 
diff --git a/pandora_console/operation/agentes/exportdata.php b/pandora_console/operation/agentes/exportdata.php
index 98cf444231..2353fe37bd 100644
--- a/pandora_console/operation/agentes/exportdata.php
+++ b/pandora_console/operation/agentes/exportdata.php
@@ -70,7 +70,12 @@ $agents = agents_get_agents(
     ['nombre LIKE "'.$agentName.'"'],
     ['id_agente']
 );
-$agent = $agents[0]['id_agente'];
+
+if ($agents !== false) {
+    $agent = $agents[0]['id_agente'];
+} else {
+    $agent = '';
+}
 
 $module = (array) get_parameter_post('module_arr', []);
 $start_date = get_parameter_post('start_date', 0);
@@ -292,7 +297,8 @@ if (empty($export_btn) || $show_form) {
                 break;
 
                 default:
-                continue;
+                    // Nothing.
+                break;
             }
 
             $i++;

From 9f000fcc3584bdd25a5efd352168bd0bd5f8abd1 Mon Sep 17 00:00:00 2001
From: Daniel Cebrian <daniel.cebrian@pandorafms.com>
Date: Mon, 19 Feb 2024 12:47:15 +0100
Subject: [PATCH 15/26] #12909 fixed macros plugin in policies

---
 .../agentes/module_manager_editor_plugin.php  | 11 ++---
 pandora_console/include/ajax/module.php       | 44 ++++++++++++++-----
 .../include/javascript/pandora_modules.js     |  3 +-
 3 files changed, 40 insertions(+), 18 deletions(-)

diff --git a/pandora_console/godmode/agentes/module_manager_editor_plugin.php b/pandora_console/godmode/agentes/module_manager_editor_plugin.php
index abbbc4d9c1..affa225969 100644
--- a/pandora_console/godmode/agentes/module_manager_editor_plugin.php
+++ b/pandora_console/godmode/agentes/module_manager_editor_plugin.php
@@ -164,12 +164,13 @@ foreach ($password_fields as $k => $p) {
             return;
         }
 
-        const moduleId = <?php echo $id_agent_module; ?>;
-        
+        const moduleId = <?php echo ($module['id_policy'] > 0) ? $module['id'] : $id_agent_module; ?>;
+        const isPolicy = <?php echo ($module['id_policy'] > 0) ? '1' : '0'; ?>;
+
         load_plugin_description($("#id_plugin").val());
-        
-        load_plugin_macros_fields('simple-macro', moduleId);
-        
+
+        load_plugin_macros_fields('simple-macro', moduleId, isPolicy);
+
         forced_title_callback();
 
         $('select#id_plugin').select2('close');
diff --git a/pandora_console/include/ajax/module.php b/pandora_console/include/ajax/module.php
index 1418024c4d..0e723cafe8 100755
--- a/pandora_console/include/ajax/module.php
+++ b/pandora_console/include/ajax/module.php
@@ -41,6 +41,7 @@ if (check_login()) {
 
     $get_plugin_macros = get_parameter('get_plugin_macros');
     $get_module_macros = get_parameter('get_module_macros');
+    $is_policy = (bool) get_parameter('is_policy', 0);
     $search_modules = get_parameter('search_modules');
     $get_module_detail = get_parameter('get_module_detail', 0);
     $get_module_autocomplete_input = (bool) get_parameter(
@@ -104,12 +105,22 @@ if (check_login()) {
     $id_plugin = get_parameter('id_plugin', 0);
 
     if ($id_plugin !== 0) {
-        $id_module_plugin = db_get_value(
-            'id_plugin',
-            'tagente_modulo',
-            'id_agente_modulo',
-            $get_module_macros
-        );
+        if ($is_policy === true) {
+            $id_module_plugin = db_get_value(
+                'id_plugin',
+                'tpolicy_modules',
+                'id',
+                $get_module_macros
+            );
+        } else {
+            $id_module_plugin = db_get_value(
+                'id_plugin',
+                'tagente_modulo',
+                'id_agente_modulo',
+                $get_module_macros
+            );
+        }
+
         if ($id_plugin !== $id_module_plugin) {
             $get_plugin_macros = true;
             $get_module_macros = 0;
@@ -145,12 +156,21 @@ if (check_login()) {
 
         $module_id = $get_module_macros;
 
-        $module_macros = db_get_value(
-            'macros',
-            'tagente_modulo',
-            'id_agente_modulo',
-            $module_id
-        );
+        if ($is_policy === true) {
+            $module_macros = db_get_value(
+                'macros',
+                'tpolicy_modules',
+                'id',
+                $module_id
+            );
+        } else {
+            $module_macros = db_get_value(
+                'macros',
+                'tagente_modulo',
+                'id_agente_modulo',
+                $module_id
+            );
+        }
 
         $macros = [];
         $macros['base64'] = base64_encode($module_macros);
diff --git a/pandora_console/include/javascript/pandora_modules.js b/pandora_console/include/javascript/pandora_modules.js
index b4445e0877..6b697fc2bb 100644
--- a/pandora_console/include/javascript/pandora_modules.js
+++ b/pandora_console/include/javascript/pandora_modules.js
@@ -1011,7 +1011,7 @@ function add_macro_field(macro, row_model_id, type_copy, k) {
   $("#" + row_id).show();
 }
 
-function load_plugin_macros_fields(row_model_id, moduleId = 0) {
+function load_plugin_macros_fields(row_model_id, moduleId = 0, is_policy = 0) {
   // Get plugin macros when selected and load macros fields
   var id_plugin = $("#id_plugin").val();
 
@@ -1024,6 +1024,7 @@ function load_plugin_macros_fields(row_model_id, moduleId = 0) {
     params.push("get_plugin_macros=1");
   }
   params.push("id_plugin=" + id_plugin);
+  params.push("is_policy=" + is_policy);
 
   jQuery.ajax({
     data: params.join("&"),

From 51e7d2d4233f70a1c37b8d6ed41f2d3896231171 Mon Sep 17 00:00:00 2001
From: Jonathan <jonathan.leon@pandorafms.com>
Date: Tue, 20 Feb 2024 12:54:35 +0100
Subject: [PATCH 16/26] #12497 dots

---
 pandora_console/godmode/setup/setup.php    | 26 ++++++-
 pandora_console/include/functions_html.php | 42 ++++++++++++
 pandora_console/include/functions_ui.php   | 23 +++++--
 pandora_console/include/styles/pandora.css | 80 ++++++++++++++++++++++
 4 files changed, 165 insertions(+), 6 deletions(-)

diff --git a/pandora_console/godmode/setup/setup.php b/pandora_console/godmode/setup/setup.php
index df6dcc1eb6..fb1741ed62 100644
--- a/pandora_console/godmode/setup/setup.php
+++ b/pandora_console/godmode/setup/setup.php
@@ -386,6 +386,28 @@ switch ($section) {
     break;
 }
 
+$menu_tabs = [];
+// Agent details.
+$menu_tab_url = '<a href="index.php?sec=gsetup&sec2=godmode/setup/setup&section=general">'.__('General setup').'</a>';
+array_push($menu_tabs, $menu_tab_url);
+// Agent details.
+$menu_tab_url = '<a href="index.php?sec=view&sec2=operation/agentes/estado_agente">'.__('Agent detail').'</a>';
+array_push($menu_tabs, $menu_tab_url);
+
+// Manage agents.
+$menu_tab_url = '<a href="index.php?sec=gagente&sec2=godmode/agentes/modificar_agente">'.__('Manage agents').'</a>';
+array_push($menu_tabs, $menu_tab_url);
+
+// Events.
+$menu_tab_url = '<a href="index.php?sec=eventos&sec2=operation/events/events">'.__('View events').'</a>';
+array_push($menu_tabs, $menu_tab_url);
+
+// Events.
+$menu_tab_url = '<a href="index.php?sec=reporting&sec2=godmode/reporting/reporting_builder">'.__('Custom reports').'</a>';
+array_push($menu_tabs, $menu_tab_url);
+
+$dots = dot_tab($menu_tabs);
+
 // Header.
 ui_print_standard_header(
     __('Setup').' &raquo; '.$subpage,
@@ -403,7 +425,9 @@ ui_print_standard_header(
             'link'  => '',
             'label' => $subpage,
         ],
-    ]
+    ],
+    [],
+    $dots
 );
 
 if (isset($config['error_config_update_config'])) {
diff --git a/pandora_console/include/functions_html.php b/pandora_console/include/functions_html.php
index 3a4ca01ebb..16ba7204d7 100644
--- a/pandora_console/include/functions_html.php
+++ b/pandora_console/include/functions_html.php
@@ -7740,3 +7740,45 @@ function print_email_test_modal_window($id)
 
     echo '<div id="email_test_'.$id.'" title="'.__('Check mail configuration').'" class="invisible">'.html_print_table($table_mail_test, true).$submitButton.'</div>';
 }
+
+
+function dot_tab(array $tabs=[], array $jump_to=[])
+{
+    $tabs_link = '<div class="dot-tab-link">';
+    if (isset($tabs) === true) {
+        foreach ($tabs as $value) {
+            $tabs_link .= $value;
+        }
+    }
+
+    $tabs_link .= '</div>';
+
+    $tabs_jump_to = '';
+    if (isset($jump_to) === true) {
+        foreach ($jump_to as $value) {
+            $tabs_jump_to .= $value;
+        }
+    }
+
+    $output = '
+		<div class="dot-tab">
+			<div></div>
+			<div></div>
+			<div></div>
+			<div class="dot-tab-menu-overlay">
+				<div class="dot-tab-menu">
+					'.$tabs_link;
+    if ($tabs_jump_to !== '') {
+        $output .= '<div class="dot-tab-jump-to">
+					<span class="muted-text ml15">'.__('Jump to').':</span>
+					'.$tabs_jump_to.'
+					</div>';
+    }
+
+    $output .= '</div>
+			</div>
+		</div>
+	';
+
+    return $output;
+}
\ No newline at end of file
diff --git a/pandora_console/include/functions_ui.php b/pandora_console/include/functions_ui.php
index 45aa64df22..8e95a32a45 100755
--- a/pandora_console/include/functions_ui.php
+++ b/pandora_console/include/functions_ui.php
@@ -5230,7 +5230,8 @@ function ui_print_standard_header(
     bool $godmode=false,
     array $options=[],
     array $breadcrumbs=[],
-    array $fav_menu_config=[]
+    array $fav_menu_config=[],
+    string $dots='',
 ) {
     // For standard breadcrumbs.
     ui_require_css_file('discovery');
@@ -5269,7 +5270,8 @@ function ui_print_standard_header(
         '',
         $headerInformation->printHeader(true),
         false,
-        $fav_menu_config
+        $fav_menu_config,
+        $dots
     );
     if ($return !== true) {
         echo $output;
@@ -5310,7 +5312,8 @@ function ui_print_page_header(
     $alias='',
     $breadcrumbs='',
     $hide_left_small=false,
-    $fav_menu_config=[]
+    $fav_menu_config=[],
+    $dots='',
 ) {
     global $config;
 
@@ -5441,12 +5444,22 @@ function ui_print_page_header(
             }
         }
 
-        $buffer .= '</ul></div>';
+        $buffer .= '</ul>';
+        if (isset($dots) === true) {
+            $buffer .= '<div id="menu_dots">'.$dots.'</div>';
+        }
+
+        $buffer .= '</div>';
     } else {
         if ($options != '') {
             $buffer .= '<div id="menu_tab"><ul class="mn"><li>';
             $buffer .= $options;
-            $buffer .= '</li></ul></div>';
+            $buffer .= '</li></ul>';
+            if (isset($dots) === true) {
+                $buffer .= '<div id="menu_dots">'.$dots.'</div>';
+            }
+
+            $buffer .= '</div>';
         }
     }
 
diff --git a/pandora_console/include/styles/pandora.css b/pandora_console/include/styles/pandora.css
index 2b347fd81a..2ef8ce690e 100644
--- a/pandora_console/include/styles/pandora.css
+++ b/pandora_console/include/styles/pandora.css
@@ -2003,6 +2003,7 @@ div.title_line {
 #menu_tab {
   margin-right: 20px;
   margin-top: 50px;
+  display: flex;
 }
 
 #menu_tab .mn,
@@ -13592,3 +13593,82 @@ button.disabled {
 .ui-draggable-handle {
   z-index: 2 !important;
 }
+
+/* Dot tab */
+#menu_dots {
+  margin-left: 10px;
+}
+
+.dot-tab {
+  width: 24px;
+  height: 24px;
+  margin-top: 12px;
+  display: flex;
+  flex-direction: column;
+  flex-wrap: nowrap;
+  justify-content: space-between;
+  align-items: center;
+  padding: 2px;
+  box-sizing: border-box;
+  cursor: pointer;
+  position: relative;
+}
+
+.dot-tab:hover {
+  background-color: var(--background-main-color);
+}
+
+.dot-tab > div:nth-child(1),
+.dot-tab > div:nth-child(2),
+.dot-tab > div:nth-child(3) {
+  background-color: var(--text-color);
+  width: 4px;
+  height: 4px;
+}
+
+.dot-tab-menu-overlay {
+  position: absolute;
+  top: -5px;
+  right: -5px;
+  padding: 30px 10px 10px 10px;
+}
+
+.dot-tab-menu {
+  background-color: var(--secondary-color);
+  border: 1px solid var(--border-color-4);
+  border-radius: 6px;
+  min-width: 170px;
+  min-height: 20px;
+  box-shadow: 0 3px 6px 0 rgba(0, 0, 0, 0.13);
+  padding: 10px 0px;
+  display: none;
+}
+
+.dot-tab:hover .dot-tab-menu {
+  display: block;
+}
+
+.dot-tab-menu a {
+  font-size: 14px;
+  line-height: 23px;
+  padding: 5px 15px;
+  display: block;
+  white-space: nowrap;
+}
+
+.dot-tab-menu a:hover {
+  background-color: var(--table-hover-background);
+  color: var(--text-color);
+  text-decoration: none;
+}
+
+.dot-tab-menu .dot-tab-link > a {
+  font-weight: 900;
+  color: black;
+}
+
+.dot-tab-menu .dot-tab-jump-to {
+  border-top: 1px solid var(--border-color-4);
+  margin-top: 10px;
+  padding-top: 15px;
+}

From 1bdddac95e14a53700298abaee77f2afde06a81d Mon Sep 17 00:00:00 2001
From: Jonathan <jonathan.leon@pandorafms.com>
Date: Tue, 20 Feb 2024 13:33:36 +0100
Subject: [PATCH 17/26] #12497 dots agent view

---
 .../godmode/agentes/configurar_agente.php     | 25 +++++++++++++++++--
 .../operation/agentes/ver_agente.php          | 24 +++++++++++++++++-
 2 files changed, 46 insertions(+), 3 deletions(-)

diff --git a/pandora_console/godmode/agentes/configurar_agente.php b/pandora_console/godmode/agentes/configurar_agente.php
index c6b5f2b691..b7a27c6c84 100644
--- a/pandora_console/godmode/agentes/configurar_agente.php
+++ b/pandora_console/godmode/agentes/configurar_agente.php
@@ -816,6 +816,23 @@ if ($id_agente) {
 
     $helper = ($help_header === 'main_tab') ? 'main_tab' : '';
     $pure = (int) get_parameter('pure');
+    $menu_tabs = [];
+    // Agent details.
+    $menu_tab_url = '<a href="index.php?sec=gsetup&sec2=godmode/setup/setup&section=general">'.__('General setup').'</a>';
+    array_push($menu_tabs, $menu_tab_url);
+    // Agent details.
+    $menu_tab_url = '<a href="index.php?sec=view&sec2=operation/agentes/estado_agente">'.__('Agent detail').'</a>';
+    array_push($menu_tabs, $menu_tab_url);
+    // Manage agents.
+    $menu_tab_url = '<a href="index.php?sec=gagente&sec2=godmode/agentes/modificar_agente">'.__('Manage agents').'</a>';
+    array_push($menu_tabs, $menu_tab_url);
+    // Events.
+    $menu_tab_url = '<a href="index.php?sec=eventos&sec2=operation/events/events">'.__('View events').'</a>';
+    array_push($menu_tabs, $menu_tab_url);
+    // Events.
+    $menu_tab_url = '<a href="index.php?sec=reporting&sec2=godmode/reporting/reporting_builder">'.__('Custom reports').'</a>';
+    array_push($menu_tabs, $menu_tab_url);
+    $dots = dot_tab($menu_tabs);
     if ($pure === 0) {
         ui_print_standard_header(
             __('Agent setup view').' ( '.strtolower(agents_get_alias($id_agente)).' )',
@@ -837,7 +854,9 @@ if ($id_agente) {
                     'link'  => '',
                     'label' => $tab_name,
                 ],
-            ]
+            ],
+            [],
+            $dots
         );
     }
 } else {
@@ -857,7 +876,9 @@ if ($id_agente) {
                 'link'  => 'index.php?sec=gagente&sec2=godmode/agentes/modificar_agente',
                 'label' => __('Manage agents'),
             ],
-        ]
+        ],
+        [],
+        $dots
     );
 }
 
diff --git a/pandora_console/operation/agentes/ver_agente.php b/pandora_console/operation/agentes/ver_agente.php
index 12a19d0f50..2edbea20f2 100644
--- a/pandora_console/operation/agentes/ver_agente.php
+++ b/pandora_console/operation/agentes/ver_agente.php
@@ -2131,6 +2131,27 @@ switch ($tab) {
 }
 
 if ((bool) $config['pure'] === false) {
+    $menu_tabs = [];
+    // Agent details.
+    $menu_tab_url = '<a href="index.php?sec=gsetup&sec2=godmode/setup/setup&section=general">'.__('General setup').'</a>';
+    array_push($menu_tabs, $menu_tab_url);
+    // Agent details.
+    $menu_tab_url = '<a href="index.php?sec=view&sec2=operation/agentes/estado_agente">'.__('Agent detail').'</a>';
+    array_push($menu_tabs, $menu_tab_url);
+
+    // Manage agents.
+    $menu_tab_url = '<a href="index.php?sec=gagente&sec2=godmode/agentes/modificar_agente">'.__('Manage agents').'</a>';
+    array_push($menu_tabs, $menu_tab_url);
+
+    // Events.
+    $menu_tab_url = '<a href="index.php?sec=eventos&sec2=operation/events/events">'.__('View events').'</a>';
+    array_push($menu_tabs, $menu_tab_url);
+
+    // Events.
+    $menu_tab_url = '<a href="index.php?sec=reporting&sec2=godmode/reporting/reporting_builder">'.__('Custom reports').'</a>';
+    array_push($menu_tabs, $menu_tab_url);
+
+    $dots = dot_tab($menu_tabs);
     ui_print_standard_header(
         __('Agent main view').' ( '.strtolower(agents_get_alias($id_agente)).' )',
         $icon,
@@ -2157,7 +2178,8 @@ if ((bool) $config['pure'] === false) {
             'url'        => 'operation/agentes/ver_agente&id_agente='.$id_agente,
             'label'      => agents_get_alias($id_agente),
             'section'    => 'Agents',
-        ]
+        ],
+        $dots
     );
 }
 

From def083097d85918e4ebc18c33b0154775f79223d Mon Sep 17 00:00:00 2001
From: Ramon Novoa <ramonnovoa@gmail.com>
Date: Wed, 21 Feb 2024 11:14:10 +0100
Subject: [PATCH 18/26] Fix the too_many_xml event to avoid unnecessary
 repetitions.

---
 pandora_server/lib/PandoraFMS/DataServer.pm | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/pandora_server/lib/PandoraFMS/DataServer.pm b/pandora_server/lib/PandoraFMS/DataServer.pm
index fe7945ae03..3235e49559 100644
--- a/pandora_server/lib/PandoraFMS/DataServer.pm
+++ b/pandora_server/lib/PandoraFMS/DataServer.pm
@@ -192,7 +192,7 @@ sub data_producer ($) {
 	if ($pa_config->{'too_many_xml'} > 0) {
 		while (my ($agent_name, $xml_count) = each(%AgentCounts)) {
 			if ($xml_count > $pa_config->{'too_many_xml'}) {
-				pandora_timed_event(300, $pa_config, "Too many XML files for agent $agent_name ($xml_count)", 0, 0, 0, 0, 0, 'warning', 0, $dbh);
+				pandora_timed_event(300, $pa_config, "Too many XML files for agent $agent_name", 0, 0, 0, 0, 0, 'warning', 0, $dbh);
 			}
 		}
 	}
@@ -253,9 +253,8 @@ sub data_producer_smart_queue ($) {
 	# Generate an event if there are too many XML files for a given agent.
 	if ($pa_config->{'too_many_xml'} > 0) {
 		while (my ($agent_name, $xml_count) = each(%AgentCounts)) {
-			print ">>> AGENT: $agent_name COUNT: $xml_count\n";
 			if ($xml_count > $pa_config->{'too_many_xml'}) {
-				pandora_timed_event(300, $pa_config, "Too many XML files for agent $agent_name ($xml_count)", 0, 0, 0, 0, 0, 'warning', 0, $dbh);
+				pandora_timed_event(300, $pa_config, "Too many XML files for agent $agent_name", 0, 0, 0, 0, 0, 'warning', 0, $dbh);
 			}
 		}
 	}

From 04aa25f205c78762dd9cd32caff19ce6a91f6028 Mon Sep 17 00:00:00 2001
From: Ramon Novoa <ramonnovoa@gmail.com>
Date: Wed, 21 Feb 2024 12:27:35 +0100
Subject: [PATCH 19/26] Show the limit for too_many_xml events.

---
 pandora_server/lib/PandoraFMS/DataServer.pm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/pandora_server/lib/PandoraFMS/DataServer.pm b/pandora_server/lib/PandoraFMS/DataServer.pm
index 3235e49559..8a72ef7605 100644
--- a/pandora_server/lib/PandoraFMS/DataServer.pm
+++ b/pandora_server/lib/PandoraFMS/DataServer.pm
@@ -192,7 +192,7 @@ sub data_producer ($) {
 	if ($pa_config->{'too_many_xml'} > 0) {
 		while (my ($agent_name, $xml_count) = each(%AgentCounts)) {
 			if ($xml_count > $pa_config->{'too_many_xml'}) {
-				pandora_timed_event(300, $pa_config, "Too many XML files for agent $agent_name", 0, 0, 0, 0, 0, 'warning', 0, $dbh);
+				pandora_timed_event(300, $pa_config, "More than " . $pa_config->{'too_many_xml'} . " XML files queued for agent $agent_name", 0, 0, 0, 0, 0, 'warning', 0, $dbh);
 			}
 		}
 	}
@@ -254,7 +254,7 @@ sub data_producer_smart_queue ($) {
 	if ($pa_config->{'too_many_xml'} > 0) {
 		while (my ($agent_name, $xml_count) = each(%AgentCounts)) {
 			if ($xml_count > $pa_config->{'too_many_xml'}) {
-				pandora_timed_event(300, $pa_config, "Too many XML files for agent $agent_name", 0, 0, 0, 0, 0, 'warning', 0, $dbh);
+				pandora_timed_event(300, $pa_config, "More than " . $pa_config->{'too_many_xml'} . " XML files queued for agent $agent_name", 0, 0, 0, 0, 0, 'warning', 0, $dbh);
 			}
 		}
 	}

From b6fd64596f496772b5cc13108e23b58d4b1a2774 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix=20Su=C3=A1rez?= <felix.suarez@pandorafms.com>
Date: Wed, 21 Feb 2024 08:43:18 -0600
Subject: [PATCH 20/26] Change CPU Load Module

---
 pandora_agents/pc/Win32/pandora_agent.conf | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/pandora_agents/pc/Win32/pandora_agent.conf b/pandora_agents/pc/Win32/pandora_agent.conf
index 216e3149e3..7c8d826289 100644
--- a/pandora_agents/pc/Win32/pandora_agent.conf
+++ b/pandora_agents/pc/Win32/pandora_agent.conf
@@ -1,6 +1,6 @@
 # Base config file for Pandora FMS Windows Agent
 # (c) 2006-2023 Pandora FMS 
-# Version 7.0NG.775
+# Version 7.0NG.775
 # This program is Free Software, you can redistribute it and/or modify it
 # under the terms of the GNU General Public Licence as published by the Free Software
 # Foundation; either version 2 of the Licence or any later version
@@ -113,15 +113,20 @@ win32_monitoring_lib NT
 module_begin
 module_name CPU Load
 module_type generic_data
-module_wmiquery SELECT LoadPercentage FROM Win32_Processor
-module_wmicolumn LoadPercentage
-module_description CPU Load (%)
-module_min_warning 80
+module_wmiquery SELECT PercentProcessorTime FROM Win32_PerfFormattedData_PerfOS_Processor where name like '_Total'
+module_wmicolumn PercentProcessorTime
+module_max 100
+module_min 0
+module_description User CPU Usage (%)
+module_min_warning 70
 module_max_warning 90
 module_min_critical 91
 module_max_critical 0
+module_unit %
+module_group System
 module_end
 
+
 # Number processes
 module_begin
 module_name Number processes

From 50187a8c15e930c1af48df8c8a41c6aafffa7c09 Mon Sep 17 00:00:00 2001
From: Jonathan <jonathan.leon@pandorafms.com>
Date: Wed, 21 Feb 2024 17:07:25 +0100
Subject: [PATCH 21/26] #12695 wip remove warnings

---
 pandora_console/godmode/wizards/Cloud.class.php     | 2 +-
 pandora_console/include/class/Diagnostics.class.php | 2 +-
 pandora_console/include/class/HTML.class.php        | 6 +++++-
 3 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/pandora_console/godmode/wizards/Cloud.class.php b/pandora_console/godmode/wizards/Cloud.class.php
index 5ddb4a1d51..62191efe3f 100644
--- a/pandora_console/godmode/wizards/Cloud.class.php
+++ b/pandora_console/godmode/wizards/Cloud.class.php
@@ -408,7 +408,7 @@ class Cloud extends Wizard
     {
         global $config;
 
-        $pandora = io_safe_output($config['cloud_util_path']);
+        $pandora = io_safe_output(($config['cloud_util_path'] ?? ''));
 
         if (isset($pandora) === false) {
             config_update_value('cloud_util_path', '/usr/bin/pandora-cm-api');
diff --git a/pandora_console/include/class/Diagnostics.class.php b/pandora_console/include/class/Diagnostics.class.php
index 305d56a339..3e381a811a 100644
--- a/pandora_console/include/class/Diagnostics.class.php
+++ b/pandora_console/include/class/Diagnostics.class.php
@@ -694,7 +694,7 @@ class Diagnostics extends Wizard
             WHERE tagente_estado.estado = 4';
         $notInitAgents = db_get_sql($sqlNotInitAgents);
 
-        $dateDbMantenaince = $config['db_maintance'];
+        $dateDbMantenaince = ($config['db_maintance'] ?? '');
 
         $currentTime = time();
 
diff --git a/pandora_console/include/class/HTML.class.php b/pandora_console/include/class/HTML.class.php
index 7325366b8b..50999ac67b 100644
--- a/pandora_console/include/class/HTML.class.php
+++ b/pandora_console/include/class/HTML.class.php
@@ -657,7 +657,7 @@ class HTML
 
             // Print independent block of inputs.
             $output .= '<ul class="wizard '.$input['block_class'].'">';
-            $output .= '<li id="'.$input['block_id'].'" class="'.$class.'">';
+            $output .= '<li id="'.($input['block_id'] ?? '').'" class="'.$class.'">';
             foreach ($input['block_content'] as $input) {
                 $output .= self::printBlockAsGrid($input, $return);
             }
@@ -1033,6 +1033,10 @@ class HTML
             $form['extra'] = '';
         }
 
+        if (isset($form['enctype']) === false) {
+            $form['enctype'] = '';
+        }
+
         $rows = $data['rows'];
         $rawInputs = $data['rawInputs'];
         $js = $data['js'];

From 887a862783556bb9578cfb0260f8ed6b3b31382d Mon Sep 17 00:00:00 2001
From: artica <artica.devel@gmail.com>
Date: Thu, 22 Feb 2024 01:00:05 +0100
Subject: [PATCH 22/26] Auto-updated build strings.

---
 pandora_agents/unix/DEBIAN/control                    | 2 +-
 pandora_agents/unix/DEBIAN/make_deb_package.sh        | 2 +-
 pandora_agents/unix/pandora_agent                     | 2 +-
 pandora_agents/unix/pandora_agent.redhat.spec         | 2 +-
 pandora_agents/unix/pandora_agent.redhat_bin.el8.spec | 2 +-
 pandora_agents/unix/pandora_agent.redhat_bin.el9.spec | 2 +-
 pandora_agents/unix/pandora_agent.redhat_bin.spec     | 2 +-
 pandora_agents/unix/pandora_agent.spec                | 2 +-
 pandora_agents/unix/pandora_agent_installer           | 2 +-
 pandora_agents/win32/installer/pandora.mpi            | 2 +-
 pandora_agents/win32/pandora.cc                       | 2 +-
 pandora_agents/win32/versioninfo.rc                   | 2 +-
 pandora_console/DEBIAN/control                        | 2 +-
 pandora_console/DEBIAN/make_deb_package.sh            | 2 +-
 pandora_console/include/config_process.php            | 2 +-
 pandora_console/install.php                           | 2 +-
 pandora_console/pandora_console.redhat.spec           | 2 +-
 pandora_console/pandora_console.rhel7.spec            | 2 +-
 pandora_console/pandora_console.spec                  | 2 +-
 pandora_server/DEBIAN/control                         | 2 +-
 pandora_server/DEBIAN/make_deb_package.sh             | 2 +-
 pandora_server/lib/PandoraFMS/Config.pm               | 2 +-
 pandora_server/lib/PandoraFMS/PluginTools.pm          | 2 +-
 pandora_server/pandora_server.redhat.spec             | 2 +-
 pandora_server/pandora_server.spec                    | 2 +-
 pandora_server/pandora_server_installer               | 2 +-
 pandora_server/util/pandora_db.pl                     | 2 +-
 pandora_server/util/pandora_manage.pl                 | 2 +-
 28 files changed, 28 insertions(+), 28 deletions(-)

diff --git a/pandora_agents/unix/DEBIAN/control b/pandora_agents/unix/DEBIAN/control
index 0872a0b459..acf998e94c 100644
--- a/pandora_agents/unix/DEBIAN/control
+++ b/pandora_agents/unix/DEBIAN/control
@@ -1,5 +1,5 @@
 package: pandorafms-agent-unix
-Version: 7.0NG.775-240221
+Version: 7.0NG.775-240222
 Architecture: all
 Priority: optional
 Section: admin
diff --git a/pandora_agents/unix/DEBIAN/make_deb_package.sh b/pandora_agents/unix/DEBIAN/make_deb_package.sh
index 7be602ffea..a3cb485e4b 100644
--- a/pandora_agents/unix/DEBIAN/make_deb_package.sh
+++ b/pandora_agents/unix/DEBIAN/make_deb_package.sh
@@ -14,7 +14,7 @@
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 # GNU General Public License for more details.
 
-pandora_version="7.0NG.775-240221"
+pandora_version="7.0NG.775-240222"
 
 echo "Test if you has the tools for to make the packages."
 whereis dpkg-deb | cut -d":" -f2 | grep dpkg-deb > /dev/null
diff --git a/pandora_agents/unix/pandora_agent b/pandora_agents/unix/pandora_agent
index e1662fe5ee..0947982db3 100755
--- a/pandora_agents/unix/pandora_agent
+++ b/pandora_agents/unix/pandora_agent
@@ -1039,7 +1039,7 @@ my $Sem = undef;
 my $ThreadSem = undef;
 
 use constant AGENT_VERSION => '7.0NG.775';
-use constant AGENT_BUILD => '240221';
+use constant AGENT_BUILD => '240222';
 
 # Agent log default file size maximum and instances
 use constant DEFAULT_MAX_LOG_SIZE => 600000;
diff --git a/pandora_agents/unix/pandora_agent.redhat.spec b/pandora_agents/unix/pandora_agent.redhat.spec
index 89d47ca273..31dcaffaeb 100644
--- a/pandora_agents/unix/pandora_agent.redhat.spec
+++ b/pandora_agents/unix/pandora_agent.redhat.spec
@@ -4,7 +4,7 @@
 %global __os_install_post %{nil}
 %define name        pandorafms_agent_linux
 %define version     7.0NG.775
-%define release     240221
+%define release     240222
 
 Summary:            Pandora FMS Linux agent, PERL version
 Name:               %{name}
diff --git a/pandora_agents/unix/pandora_agent.redhat_bin.el8.spec b/pandora_agents/unix/pandora_agent.redhat_bin.el8.spec
index 6528f85557..2e29ba964f 100644
--- a/pandora_agents/unix/pandora_agent.redhat_bin.el8.spec
+++ b/pandora_agents/unix/pandora_agent.redhat_bin.el8.spec
@@ -5,7 +5,7 @@
 %define name        pandorafms_agent_linux_bin
 %define source_name pandorafms_agent_linux
 %define version     7.0NG.775
-%define release     240221
+%define release     240222
 %define debug_package %{nil}
 
 Summary:            Pandora FMS Linux agent, binary version
diff --git a/pandora_agents/unix/pandora_agent.redhat_bin.el9.spec b/pandora_agents/unix/pandora_agent.redhat_bin.el9.spec
index db4e7db193..7f53a67a6b 100644
--- a/pandora_agents/unix/pandora_agent.redhat_bin.el9.spec
+++ b/pandora_agents/unix/pandora_agent.redhat_bin.el9.spec
@@ -5,7 +5,7 @@
 %define name        pandorafms_agent_linux_bin
 %define source_name pandorafms_agent_linux
 %define version     7.0NG.775
-%define release     240221
+%define release     240222
 %define debug_package %{nil}
 
 Summary:            Pandora FMS Linux agent, binary version
diff --git a/pandora_agents/unix/pandora_agent.redhat_bin.spec b/pandora_agents/unix/pandora_agent.redhat_bin.spec
index 44ed74c612..d018c4679f 100644
--- a/pandora_agents/unix/pandora_agent.redhat_bin.spec
+++ b/pandora_agents/unix/pandora_agent.redhat_bin.spec
@@ -5,7 +5,7 @@
 %define name        pandorafms_agent_linux_bin
 %define source_name pandorafms_agent_linux
 %define version     7.0NG.775
-%define release     240221
+%define release     240222
 
 Summary:            Pandora FMS Linux agent, binary version
 Name:               %{name}
diff --git a/pandora_agents/unix/pandora_agent.spec b/pandora_agents/unix/pandora_agent.spec
index 377b1a26bf..f7cc2a290d 100644
--- a/pandora_agents/unix/pandora_agent.spec
+++ b/pandora_agents/unix/pandora_agent.spec
@@ -4,7 +4,7 @@
 %global __os_install_post %{nil}
 %define name        pandorafms_agent_linux
 %define version     7.0NG.775
-%define release     240221
+%define release     240222
 
 Summary:            Pandora FMS Linux agent, PERL version
 Name:               %{name}
diff --git a/pandora_agents/unix/pandora_agent_installer b/pandora_agents/unix/pandora_agent_installer
index 386f26d550..a275fcfa5c 100755
--- a/pandora_agents/unix/pandora_agent_installer
+++ b/pandora_agents/unix/pandora_agent_installer
@@ -10,7 +10,7 @@
 # **********************************************************************
 
 PI_VERSION="7.0NG.775"
-PI_BUILD="240221"
+PI_BUILD="240222"
 OS_NAME=`uname -s`
 
 FORCE=0
diff --git a/pandora_agents/win32/installer/pandora.mpi b/pandora_agents/win32/installer/pandora.mpi
index 05b006e87e..70c7ecb53b 100644
--- a/pandora_agents/win32/installer/pandora.mpi
+++ b/pandora_agents/win32/installer/pandora.mpi
@@ -186,7 +186,7 @@ UpgradeApplicationID
 {}
 
 Version
-{240221}
+{240222}
 
 ViewReadme
 {Yes}
diff --git a/pandora_agents/win32/pandora.cc b/pandora_agents/win32/pandora.cc
index 323a6555f9..fa9c417123 100644
--- a/pandora_agents/win32/pandora.cc
+++ b/pandora_agents/win32/pandora.cc
@@ -30,7 +30,7 @@ using namespace Pandora;
 using namespace Pandora_Strutils;
 
 #define PATH_SIZE    _MAX_PATH+1
-#define PANDORA_VERSION ("7.0NG.775 Build 240221")
+#define PANDORA_VERSION ("7.0NG.775 Build 240222")
 
 string pandora_path;
 string pandora_dir;
diff --git a/pandora_agents/win32/versioninfo.rc b/pandora_agents/win32/versioninfo.rc
index 3007022b4c..16ec5fe61c 100644
--- a/pandora_agents/win32/versioninfo.rc
+++ b/pandora_agents/win32/versioninfo.rc
@@ -11,7 +11,7 @@ BEGIN
       VALUE "LegalCopyright", "Pandora FMS"
       VALUE "OriginalFilename", "PandoraAgent.exe"
       VALUE "ProductName", "Pandora FMS Windows Agent"
-      VALUE "ProductVersion", "(7.0NG.775(Build 240221))"
+      VALUE "ProductVersion", "(7.0NG.775(Build 240222))"
       VALUE "FileVersion", "1.0.0.0"
     END
   END
diff --git a/pandora_console/DEBIAN/control b/pandora_console/DEBIAN/control
index d51dcca24b..de7e2de6f5 100644
--- a/pandora_console/DEBIAN/control
+++ b/pandora_console/DEBIAN/control
@@ -1,5 +1,5 @@
 package: pandorafms-console
-Version: 7.0NG.775-240221
+Version: 7.0NG.775-240222
 Architecture: all
 Priority: optional
 Section: admin
diff --git a/pandora_console/DEBIAN/make_deb_package.sh b/pandora_console/DEBIAN/make_deb_package.sh
index 34e36f6c53..705993798a 100644
--- a/pandora_console/DEBIAN/make_deb_package.sh
+++ b/pandora_console/DEBIAN/make_deb_package.sh
@@ -14,7 +14,7 @@
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 # GNU General Public License for more details.
 
-pandora_version="7.0NG.775-240221"
+pandora_version="7.0NG.775-240222"
 
 package_pear=0
 package_pandora=1
diff --git a/pandora_console/include/config_process.php b/pandora_console/include/config_process.php
index e7b264e8a6..5c0f37b17a 100644
--- a/pandora_console/include/config_process.php
+++ b/pandora_console/include/config_process.php
@@ -20,7 +20,7 @@
 /**
  * Pandora build version and version
  */
-$build_version = 'PC240221';
+$build_version = 'PC240222';
 $pandora_version = 'v7.0NG.775';
 
 // Do not overwrite default timezone set if defined.
diff --git a/pandora_console/install.php b/pandora_console/install.php
index 295c32f95a..6f9c6c9029 100644
--- a/pandora_console/install.php
+++ b/pandora_console/install.php
@@ -131,7 +131,7 @@
         <div style='padding-bottom: 50px'>
             <?php
             $version = '7.0NG.775';
-            $build = '240221';
+            $build = '240222';
             $banner = "v$version Build $build";
             error_reporting(0);
 
diff --git a/pandora_console/pandora_console.redhat.spec b/pandora_console/pandora_console.redhat.spec
index 56d55e7d9c..a92c929934 100644
--- a/pandora_console/pandora_console.redhat.spec
+++ b/pandora_console/pandora_console.redhat.spec
@@ -6,7 +6,7 @@
 %define debug_package %{nil}
 %define name        pandorafms_console
 %define version     7.0NG.775
-%define release     240221
+%define release     240222
 
 # User and Group under which Apache is running
 %define httpd_name  httpd
diff --git a/pandora_console/pandora_console.rhel7.spec b/pandora_console/pandora_console.rhel7.spec
index c924ac2359..8d4e321369 100644
--- a/pandora_console/pandora_console.rhel7.spec
+++ b/pandora_console/pandora_console.rhel7.spec
@@ -6,7 +6,7 @@
 %define debug_package %{nil}
 %define name        pandorafms_console
 %define version     7.0NG.775
-%define release     240221
+%define release     240222
 
 # User and Group under which Apache is running
 %define httpd_name  httpd
diff --git a/pandora_console/pandora_console.spec b/pandora_console/pandora_console.spec
index 76453975c5..e1a57b0c2a 100644
--- a/pandora_console/pandora_console.spec
+++ b/pandora_console/pandora_console.spec
@@ -3,7 +3,7 @@
 #
 %define name        pandorafms_console
 %define version     7.0NG.775
-%define release     240221
+%define release     240222
 %define httpd_name      httpd
 # User and Group under which Apache is running
 %define httpd_name  apache2
diff --git a/pandora_server/DEBIAN/control b/pandora_server/DEBIAN/control
index a9ee10dc18..e105d01fc0 100644
--- a/pandora_server/DEBIAN/control
+++ b/pandora_server/DEBIAN/control
@@ -1,5 +1,5 @@
 package: pandorafms-server
-Version: 7.0NG.775-240221
+Version: 7.0NG.775-240222
 Architecture: all
 Priority: optional
 Section: admin
diff --git a/pandora_server/DEBIAN/make_deb_package.sh b/pandora_server/DEBIAN/make_deb_package.sh
index b393f9f116..2262ccd93e 100644
--- a/pandora_server/DEBIAN/make_deb_package.sh
+++ b/pandora_server/DEBIAN/make_deb_package.sh
@@ -14,7 +14,7 @@
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 # GNU General Public License for more details.
 
-pandora_version="7.0NG.775-240221"
+pandora_version="7.0NG.775-240222"
 
 package_cpan=0
 package_pandora=1
diff --git a/pandora_server/lib/PandoraFMS/Config.pm b/pandora_server/lib/PandoraFMS/Config.pm
index f6a4170360..89ef89c453 100644
--- a/pandora_server/lib/PandoraFMS/Config.pm
+++ b/pandora_server/lib/PandoraFMS/Config.pm
@@ -46,7 +46,7 @@ our @EXPORT = qw(
 
 # version: Defines actual version of Pandora Server for this module only
 my $pandora_version = "7.0NG.775";
-my $pandora_build = "240221";
+my $pandora_build = "240222";
 our $VERSION = $pandora_version." ".$pandora_build;
 
 # Setup hash
diff --git a/pandora_server/lib/PandoraFMS/PluginTools.pm b/pandora_server/lib/PandoraFMS/PluginTools.pm
index 8856a7f915..aef78c855c 100644
--- a/pandora_server/lib/PandoraFMS/PluginTools.pm
+++ b/pandora_server/lib/PandoraFMS/PluginTools.pm
@@ -34,7 +34,7 @@ our @ISA = qw(Exporter);
 
 # version: Defines actual version of Pandora Server for this module only
 my $pandora_version = "7.0NG.775";
-my $pandora_build = "240221";
+my $pandora_build = "240222";
 our $VERSION = $pandora_version." ".$pandora_build;
 
 our %EXPORT_TAGS = ( 'all' => [ qw() ] );
diff --git a/pandora_server/pandora_server.redhat.spec b/pandora_server/pandora_server.redhat.spec
index de2b710cfc..27afbbc523 100644
--- a/pandora_server/pandora_server.redhat.spec
+++ b/pandora_server/pandora_server.redhat.spec
@@ -7,7 +7,7 @@
 %define debug_package %{nil}
 %define name        pandorafms_server
 %define version     7.0NG.775
-%define release     240221
+%define release     240222
 
 Summary:            Pandora FMS Server
 Name:               %{name}
diff --git a/pandora_server/pandora_server.spec b/pandora_server/pandora_server.spec
index dba23ea4db..fb6473c163 100644
--- a/pandora_server/pandora_server.spec
+++ b/pandora_server/pandora_server.spec
@@ -4,7 +4,7 @@
 %global __os_install_post %{nil}
 %define name        pandorafms_server
 %define version     7.0NG.775
-%define release     240221
+%define release     240222
 
 Summary:            Pandora FMS Server
 Name:               %{name}
diff --git a/pandora_server/pandora_server_installer b/pandora_server/pandora_server_installer
index 6973401c56..6fdd7041cd 100755
--- a/pandora_server/pandora_server_installer
+++ b/pandora_server/pandora_server_installer
@@ -9,7 +9,7 @@
 # **********************************************************************
 
 PI_VERSION="7.0NG.775"
-PI_BUILD="240221"
+PI_BUILD="240222"
 
 MODE=$1
 if [ $# -gt 1 ]; then
diff --git a/pandora_server/util/pandora_db.pl b/pandora_server/util/pandora_db.pl
index 9feb4d3982..1007e32606 100755
--- a/pandora_server/util/pandora_db.pl
+++ b/pandora_server/util/pandora_db.pl
@@ -38,7 +38,7 @@ use PandoraFMS::Config;
 use PandoraFMS::DB;
 
 # version: define current version
-my $version = "7.0NG.775 Build 240221";
+my $version = "7.0NG.775 Build 240222";
 
 # Pandora server configuration
 my %conf;
diff --git a/pandora_server/util/pandora_manage.pl b/pandora_server/util/pandora_manage.pl
index 50540e43ab..ed3c4396ad 100755
--- a/pandora_server/util/pandora_manage.pl
+++ b/pandora_server/util/pandora_manage.pl
@@ -36,7 +36,7 @@ use Encode::Locale;
 Encode::Locale::decode_argv;
 
 # version: define current version
-my $version = "7.0NG.775 Build 240221";
+my $version = "7.0NG.775 Build 240222";
 
 # save program name for logging
 my $progname = basename($0);

From 260fcfe62b1a9ff1f05433f965d33565838c68bd Mon Sep 17 00:00:00 2001
From: Jonathan <jonathan.leon@pandorafms.com>
Date: Thu, 22 Feb 2024 10:07:47 +0100
Subject: [PATCH 23/26] #12695 remove warnings

---
 .../massive/massive_add_policies_alerts.php        |  2 +-
 ...massive_add_policies_alerts_action_external.php |  2 +-
 .../godmode/massive/massive_edit_agents.php        | 14 +++++++-------
 .../godmode/massive/massive_edit_modules.php       |  6 +++---
 .../godmode/massive/massive_edit_users.php         |  6 +++---
 .../godmode/massive/massive_operations.php         |  4 ++++
 .../godmode/resources/resources_export_import.php  |  4 ++--
 pandora_console/include/class/HTML.class.php       |  4 ++++
 pandora_console/include/functions_html.php         |  2 +-
 9 files changed, 26 insertions(+), 18 deletions(-)

diff --git a/pandora_console/godmode/massive/massive_add_policies_alerts.php b/pandora_console/godmode/massive/massive_add_policies_alerts.php
index b1f289a3e3..13bd8819ba 100644
--- a/pandora_console/godmode/massive/massive_add_policies_alerts.php
+++ b/pandora_console/godmode/massive/massive_add_policies_alerts.php
@@ -134,7 +134,7 @@ $table->data[0][0] = html_print_label_input_block(
 
 $table->data[0][1] = html_print_label_input_block(
     __('Group recursion'),
-    html_print_checkbox('recursion', 1, $recursion, true, false, '', true)
+    html_print_checkbox('recursion', 1, ($recursion ?? false), true, false, '', true)
 );
 
 $arr_policies = policies_get_policies();
diff --git a/pandora_console/godmode/massive/massive_add_policies_alerts_action_external.php b/pandora_console/godmode/massive/massive_add_policies_alerts_action_external.php
index 177af408f1..32efc15606 100644
--- a/pandora_console/godmode/massive/massive_add_policies_alerts_action_external.php
+++ b/pandora_console/godmode/massive/massive_add_policies_alerts_action_external.php
@@ -138,7 +138,7 @@ $table->data[0][0] = html_print_label_input_block(
 
 $table->data[0][1] = html_print_label_input_block(
     __('Group recursion'),
-    html_print_checkbox('recursion', 1, $recursion, true, false, '', true)
+    html_print_checkbox('recursion', 1, ($recursion ?? false), true, false, '', true)
 );
 
 $arr_policies = policies_get_policies();
diff --git a/pandora_console/godmode/massive/massive_edit_agents.php b/pandora_console/godmode/massive/massive_edit_agents.php
index 9a57ef9d53..26ab73603c 100755
--- a/pandora_console/godmode/massive/massive_edit_agents.php
+++ b/pandora_console/godmode/massive/massive_edit_agents.php
@@ -631,8 +631,8 @@ if (is_metaconsole() === true) {
 echo '<form method="post" autocomplete="off" id="form_agent" action="'.$url.'">';
 echo html_print_avoid_autocomplete();
 $params = [
-    'id_group'  => $id_group,
-    'recursion' => $recursion,
+    'id_group'  => ($id_group ?? ''),
+    'recursion' => ($recursion ?? ''),
 ];
 echo get_table_inputs_masive_agents($params);
 
@@ -712,9 +712,9 @@ if (is_metaconsole() === false) {
 
     $table->data[0][1] .= '&nbsp;&nbsp;'.__('Module').'&nbsp;';
     $table->data[0][1] .= html_print_select(
-        $modules,
+        ($modules ?? ''),
         'cascade_protection_module',
-        $cascade_protection_module,
+        ($cascade_protection_module ?? ''),
         '',
         '',
         0,
@@ -1162,7 +1162,7 @@ $table->data[7][0] = __('Safe operation mode').': '.ui_print_help_tip(
     ),
     true
 );
-$table->data[7][1] .= html_print_select(
+$table->data[7][1] = html_print_select(
     [
         1 => __('Enabled'),
         0 => __('Disabled'),
@@ -1229,7 +1229,7 @@ if ($fields === false) {
 foreach ($fields as $field) {
     $data[0] = '<b>'.$field['name'].'</b>';
     $combo = [];
-    $combo = $field['combo_values'];
+    $combo = ($field['combo_values'] ?? '');
     $combo = explode(',', $combo);
     $combo_values = [];
     foreach ($combo as $value) {
@@ -1258,7 +1258,7 @@ foreach ($fields as $field) {
             '',
             30,
             100,
-            $view_mode,
+            ($view_mode ?? ''),
             '',
             '',
             true,
diff --git a/pandora_console/godmode/massive/massive_edit_modules.php b/pandora_console/godmode/massive/massive_edit_modules.php
index 2b8990c065..672c59276c 100755
--- a/pandora_console/godmode/massive/massive_edit_modules.php
+++ b/pandora_console/godmode/massive/massive_edit_modules.php
@@ -421,7 +421,7 @@ $table->data[4][0] = html_print_label_input_block(
     html_print_select(
         $tags,
         'tags[]',
-        $tags_name,
+        ($tags_name ?? ''),
         false,
         __('Any'),
         -1,
@@ -537,7 +537,7 @@ $table->data[8][0] = html_print_label_input_block(
     html_print_select(
         $tags,
         'tags[]',
-        $tags_name,
+        ($tags_name ?? ''),
         false,
         __('Any'),
         -1,
@@ -1304,7 +1304,7 @@ $table->data[29][0] = html_print_label_input_block(
     html_print_select_from_sql(
         'SELECT id_tag, name FROM ttag ORDER BY name',
         'id_tag[]',
-        $id_tag,
+        ($id_tag ?? ''),
         '',
         __('None'),
         '0',
diff --git a/pandora_console/godmode/massive/massive_edit_users.php b/pandora_console/godmode/massive/massive_edit_users.php
index 57274dc129..87ffb80bd4 100644
--- a/pandora_console/godmode/massive/massive_edit_users.php
+++ b/pandora_console/godmode/massive/massive_edit_users.php
@@ -476,12 +476,12 @@ if (is_metaconsole() === false) {
             $timezone_name = 'Asia/Shanghai';
         }
 
-        $area_data_timezone_polys .= '';
+        $area_data_timezone_polys = '';
         foreach ($tz['polys'] as $coords) {
             $area_data_timezone_polys .= '<area data-timezone="'.$timezone_name.'" data-country="'.$tz['country'].'" data-pin="'.implode(',', $tz['pin']).'" data-offset="'.$tz['offset'].'" shape="poly" coords="'.implode(',', $coords).'" />';
         }
 
-        $area_data_timezone_rects .= '';
+        $area_data_timezone_rects = '';
         foreach ($tz['rects'] as $coords) {
             $area_data_timezone_rects .= '<area data-timezone="'.$timezone_name.'" data-country="'.$tz['country'].'" data-pin="'.implode(',', $tz['pin']).'" data-offset="'.$tz['offset'].'" shape="rect" coords="'.implode(',', $coords).'" />';
         }
@@ -543,7 +543,7 @@ echo sprintf(
     '<div class="edit_user_options">%s %s %s %s %s %s %s %s %s %s</div>',
     $language,
     $size_pagination,
-    $skin,
+    ($skin ?? ''),
     $home_screen,
     $event_filter,
     $autorefresh_show,
diff --git a/pandora_console/godmode/massive/massive_operations.php b/pandora_console/godmode/massive/massive_operations.php
index be396d2a1b..3480b66a92 100755
--- a/pandora_console/godmode/massive/massive_operations.php
+++ b/pandora_console/godmode/massive/massive_operations.php
@@ -348,6 +348,10 @@ if (check_acl($config['id_user'], 0, 'UM')) {
     $onheader['user_agents'] = $userstab;
 }
 
+if (isset($servicestab) === false) {
+    $servicestab = '';
+}
+
 $onheader['massive_alerts'] = $alertstab;
 $onheader['massive_policies_alerts'] = $policiesalertstab;
 $onheader['massive_policies_alerts_external'] = $policiesalertsexternaltab;
diff --git a/pandora_console/godmode/resources/resources_export_import.php b/pandora_console/godmode/resources/resources_export_import.php
index 86583ec69b..cbdd3b0f59 100644
--- a/pandora_console/godmode/resources/resources_export_import.php
+++ b/pandora_console/godmode/resources/resources_export_import.php
@@ -268,8 +268,8 @@ echo '</div>';
         if (msg.status === true) {
             title = "<?php echo __('Importation successfully completed'); ?>";
             message = "<?php echo __('PRD import successfull:'); ?>";
-            const name = "<?php echo $name; ?>";
-            const type = "<?php echo $type; ?>";
+            const name = "<?php echo ($name ?? ''); ?>";
+            const type = "<?php echo ($type ?? ''); ?>";
             message += ` ${type} - ${name}`;
         } else {
             title = "<?php echo __('Import failure'); ?>";
diff --git a/pandora_console/include/class/HTML.class.php b/pandora_console/include/class/HTML.class.php
index 50999ac67b..9247f2dbeb 100644
--- a/pandora_console/include/class/HTML.class.php
+++ b/pandora_console/include/class/HTML.class.php
@@ -676,6 +676,10 @@ class HTML
                 $input['arguments'] = '';
             }
 
+            if (isset($input['arguments']['type']) === false) {
+                $input['arguments']['type'] = '';
+            }
+
             if ($input['arguments']['type'] != 'hidden'
                 && $input['arguments']['type'] != 'hidden_extended'
             ) {
diff --git a/pandora_console/include/functions_html.php b/pandora_console/include/functions_html.php
index e520303c1d..8435c802b8 100644
--- a/pandora_console/include/functions_html.php
+++ b/pandora_console/include/functions_html.php
@@ -2075,7 +2075,7 @@ function html_print_extended_select_for_post_process(
     $found = false;
 
     if ($selected) {
-        if (array_key_exists(number_format($selected, 14, $config['decimal_separator'], $config['thousand_separator']), $fields)) {
+        if (array_key_exists(number_format($selected, 14, $config['decimal_separator'], ($config['thousand_separator'] ?? ',')), $fields)) {
             $found = true;
         }
     }

From f36ea56ad73f75e0cbf6989bd76d066dbca61bc8 Mon Sep 17 00:00:00 2001
From: Jonathan <jonathan.leon@pandorafms.com>
Date: Thu, 22 Feb 2024 13:34:53 +0100
Subject: [PATCH 24/26] #12497 css dots

---
 pandora_console/include/styles/pandora.css | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/pandora_console/include/styles/pandora.css b/pandora_console/include/styles/pandora.css
index 2ef8ce690e..61c91f9370 100644
--- a/pandora_console/include/styles/pandora.css
+++ b/pandora_console/include/styles/pandora.css
@@ -34,6 +34,9 @@
   --border-color: #eee;
   --border-dark-color: #e1e1e1;
   --text-color: #333;
+  --table-hover-background: #edfffe;
+  --background-main-color: #f6f7fb;
+  --border-color-4: #e5e9ed;
 }
 
 /*
@@ -13628,9 +13631,9 @@ button.disabled {
 
 .dot-tab-menu-overlay {
   position: absolute;
-  top: -5px;
-  right: -5px;
-  padding: 30px 10px 10px 10px;
+  top: 20px;
+  right: -20px;
+  padding: 0px 10px 10px 10px;
 }
 
 .dot-tab-menu {

From bb1b8099b8cf34aca9c612e4dd13dd3bfd1f56dc Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix=20Su=C3=A1rez?= <felix.suarez@pandorafms.com>
Date: Thu, 22 Feb 2024 08:10:15 -0600
Subject: [PATCH 25/26] Modify CPU Usage module

---
 pandora_agents/pc/Win32/pandora_agent.conf  | 12 ++++--------
 pandora_agents/win32/bin/pandora_agent.conf |  4 ++--
 2 files changed, 6 insertions(+), 10 deletions(-)

diff --git a/pandora_agents/pc/Win32/pandora_agent.conf b/pandora_agents/pc/Win32/pandora_agent.conf
index 7c8d826289..ffbc937875 100644
--- a/pandora_agents/pc/Win32/pandora_agent.conf
+++ b/pandora_agents/pc/Win32/pandora_agent.conf
@@ -113,17 +113,13 @@ win32_monitoring_lib NT
 module_begin
 module_name CPU Load
 module_type generic_data
-module_wmiquery SELECT PercentProcessorTime FROM Win32_PerfFormattedData_PerfOS_Processor where name like '_Total'
-module_wmicolumn PercentProcessorTime
-module_max 100
-module_min 0
-module_description User CPU Usage (%)
-module_min_warning 70
+module_wmiquery SELECT LoadPercentage FROM Win32_Processor
+module_wmicolumn LoadPercentage
+module_description CPU Load (%)
+module_min_warning 80
 module_max_warning 90
 module_min_critical 91
 module_max_critical 0
-module_unit %
-module_group System
 module_end
 
 
diff --git a/pandora_agents/win32/bin/pandora_agent.conf b/pandora_agents/win32/bin/pandora_agent.conf
index 2ff61033c6..cdde841254 100644
--- a/pandora_agents/win32/bin/pandora_agent.conf
+++ b/pandora_agents/win32/bin/pandora_agent.conf
@@ -157,8 +157,8 @@ ehorus_conf "C:\Program Files\ehorus_agent\ehorus_agent.conf"
 module_begin
 module_name CPU Load
 module_type generic_data
-module_wmiquery SELECT LoadPercentage FROM Win32_Processor
-module_wmicolumn LoadPercentage
+module_wmiquery SELECT PercentProcessorTime FROM Win32_PerfFormattedData_PerfOS_Processor where name like '_Total'
+module_wmicolumn PercentProcessorTime
 module_max 100
 module_min 0
 module_description User CPU Usage (%)

From 421598df6b5f739ecd2f4274f638d2de97cd8ef2 Mon Sep 17 00:00:00 2001
From: artica <artica.devel@gmail.com>
Date: Fri, 23 Feb 2024 01:00:05 +0100
Subject: [PATCH 26/26] Auto-updated build strings.

---
 pandora_agents/pc/Win32/pandora_agent.conf            | 2 +-
 pandora_agents/unix/DEBIAN/control                    | 2 +-
 pandora_agents/unix/DEBIAN/make_deb_package.sh        | 2 +-
 pandora_agents/unix/pandora_agent                     | 2 +-
 pandora_agents/unix/pandora_agent.redhat.spec         | 2 +-
 pandora_agents/unix/pandora_agent.redhat_bin.el8.spec | 2 +-
 pandora_agents/unix/pandora_agent.redhat_bin.el9.spec | 2 +-
 pandora_agents/unix/pandora_agent.redhat_bin.spec     | 2 +-
 pandora_agents/unix/pandora_agent.spec                | 2 +-
 pandora_agents/unix/pandora_agent_installer           | 2 +-
 pandora_agents/win32/installer/pandora.mpi            | 2 +-
 pandora_agents/win32/pandora.cc                       | 2 +-
 pandora_agents/win32/versioninfo.rc                   | 2 +-
 pandora_console/DEBIAN/control                        | 2 +-
 pandora_console/DEBIAN/make_deb_package.sh            | 2 +-
 pandora_console/include/config_process.php            | 2 +-
 pandora_console/install.php                           | 2 +-
 pandora_console/pandora_console.redhat.spec           | 2 +-
 pandora_console/pandora_console.rhel7.spec            | 2 +-
 pandora_console/pandora_console.spec                  | 2 +-
 pandora_server/DEBIAN/control                         | 2 +-
 pandora_server/DEBIAN/make_deb_package.sh             | 2 +-
 pandora_server/lib/PandoraFMS/Config.pm               | 2 +-
 pandora_server/lib/PandoraFMS/PluginTools.pm          | 2 +-
 pandora_server/pandora_server.redhat.spec             | 2 +-
 pandora_server/pandora_server.spec                    | 2 +-
 pandora_server/pandora_server_installer               | 2 +-
 pandora_server/util/pandora_db.pl                     | 2 +-
 pandora_server/util/pandora_manage.pl                 | 2 +-
 29 files changed, 29 insertions(+), 29 deletions(-)

diff --git a/pandora_agents/pc/Win32/pandora_agent.conf b/pandora_agents/pc/Win32/pandora_agent.conf
index ffbc937875..f1cc960a5c 100644
--- a/pandora_agents/pc/Win32/pandora_agent.conf
+++ b/pandora_agents/pc/Win32/pandora_agent.conf
@@ -1,6 +1,6 @@
 # Base config file for Pandora FMS Windows Agent
 # (c) 2006-2023 Pandora FMS 
-# Version 7.0NG.775
+# Version 7.0NG.775
 # This program is Free Software, you can redistribute it and/or modify it
 # under the terms of the GNU General Public Licence as published by the Free Software
 # Foundation; either version 2 of the Licence or any later version
diff --git a/pandora_agents/unix/DEBIAN/control b/pandora_agents/unix/DEBIAN/control
index acf998e94c..31b1752a4e 100644
--- a/pandora_agents/unix/DEBIAN/control
+++ b/pandora_agents/unix/DEBIAN/control
@@ -1,5 +1,5 @@
 package: pandorafms-agent-unix
-Version: 7.0NG.775-240222
+Version: 7.0NG.775-240223
 Architecture: all
 Priority: optional
 Section: admin
diff --git a/pandora_agents/unix/DEBIAN/make_deb_package.sh b/pandora_agents/unix/DEBIAN/make_deb_package.sh
index a3cb485e4b..501e690c23 100644
--- a/pandora_agents/unix/DEBIAN/make_deb_package.sh
+++ b/pandora_agents/unix/DEBIAN/make_deb_package.sh
@@ -14,7 +14,7 @@
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 # GNU General Public License for more details.
 
-pandora_version="7.0NG.775-240222"
+pandora_version="7.0NG.775-240223"
 
 echo "Test if you has the tools for to make the packages."
 whereis dpkg-deb | cut -d":" -f2 | grep dpkg-deb > /dev/null
diff --git a/pandora_agents/unix/pandora_agent b/pandora_agents/unix/pandora_agent
index 0947982db3..81bdfc118f 100755
--- a/pandora_agents/unix/pandora_agent
+++ b/pandora_agents/unix/pandora_agent
@@ -1039,7 +1039,7 @@ my $Sem = undef;
 my $ThreadSem = undef;
 
 use constant AGENT_VERSION => '7.0NG.775';
-use constant AGENT_BUILD => '240222';
+use constant AGENT_BUILD => '240223';
 
 # Agent log default file size maximum and instances
 use constant DEFAULT_MAX_LOG_SIZE => 600000;
diff --git a/pandora_agents/unix/pandora_agent.redhat.spec b/pandora_agents/unix/pandora_agent.redhat.spec
index 31dcaffaeb..bd06b0e4fc 100644
--- a/pandora_agents/unix/pandora_agent.redhat.spec
+++ b/pandora_agents/unix/pandora_agent.redhat.spec
@@ -4,7 +4,7 @@
 %global __os_install_post %{nil}
 %define name        pandorafms_agent_linux
 %define version     7.0NG.775
-%define release     240222
+%define release     240223
 
 Summary:            Pandora FMS Linux agent, PERL version
 Name:               %{name}
diff --git a/pandora_agents/unix/pandora_agent.redhat_bin.el8.spec b/pandora_agents/unix/pandora_agent.redhat_bin.el8.spec
index 2e29ba964f..4818693de8 100644
--- a/pandora_agents/unix/pandora_agent.redhat_bin.el8.spec
+++ b/pandora_agents/unix/pandora_agent.redhat_bin.el8.spec
@@ -5,7 +5,7 @@
 %define name        pandorafms_agent_linux_bin
 %define source_name pandorafms_agent_linux
 %define version     7.0NG.775
-%define release     240222
+%define release     240223
 %define debug_package %{nil}
 
 Summary:            Pandora FMS Linux agent, binary version
diff --git a/pandora_agents/unix/pandora_agent.redhat_bin.el9.spec b/pandora_agents/unix/pandora_agent.redhat_bin.el9.spec
index 7f53a67a6b..6e304c3849 100644
--- a/pandora_agents/unix/pandora_agent.redhat_bin.el9.spec
+++ b/pandora_agents/unix/pandora_agent.redhat_bin.el9.spec
@@ -5,7 +5,7 @@
 %define name        pandorafms_agent_linux_bin
 %define source_name pandorafms_agent_linux
 %define version     7.0NG.775
-%define release     240222
+%define release     240223
 %define debug_package %{nil}
 
 Summary:            Pandora FMS Linux agent, binary version
diff --git a/pandora_agents/unix/pandora_agent.redhat_bin.spec b/pandora_agents/unix/pandora_agent.redhat_bin.spec
index d018c4679f..36ace10ab4 100644
--- a/pandora_agents/unix/pandora_agent.redhat_bin.spec
+++ b/pandora_agents/unix/pandora_agent.redhat_bin.spec
@@ -5,7 +5,7 @@
 %define name        pandorafms_agent_linux_bin
 %define source_name pandorafms_agent_linux
 %define version     7.0NG.775
-%define release     240222
+%define release     240223
 
 Summary:            Pandora FMS Linux agent, binary version
 Name:               %{name}
diff --git a/pandora_agents/unix/pandora_agent.spec b/pandora_agents/unix/pandora_agent.spec
index f7cc2a290d..7d1bd6f6f7 100644
--- a/pandora_agents/unix/pandora_agent.spec
+++ b/pandora_agents/unix/pandora_agent.spec
@@ -4,7 +4,7 @@
 %global __os_install_post %{nil}
 %define name        pandorafms_agent_linux
 %define version     7.0NG.775
-%define release     240222
+%define release     240223
 
 Summary:            Pandora FMS Linux agent, PERL version
 Name:               %{name}
diff --git a/pandora_agents/unix/pandora_agent_installer b/pandora_agents/unix/pandora_agent_installer
index a275fcfa5c..2935baa16a 100755
--- a/pandora_agents/unix/pandora_agent_installer
+++ b/pandora_agents/unix/pandora_agent_installer
@@ -10,7 +10,7 @@
 # **********************************************************************
 
 PI_VERSION="7.0NG.775"
-PI_BUILD="240222"
+PI_BUILD="240223"
 OS_NAME=`uname -s`
 
 FORCE=0
diff --git a/pandora_agents/win32/installer/pandora.mpi b/pandora_agents/win32/installer/pandora.mpi
index 70c7ecb53b..7ef6c38b49 100644
--- a/pandora_agents/win32/installer/pandora.mpi
+++ b/pandora_agents/win32/installer/pandora.mpi
@@ -186,7 +186,7 @@ UpgradeApplicationID
 {}
 
 Version
-{240222}
+{240223}
 
 ViewReadme
 {Yes}
diff --git a/pandora_agents/win32/pandora.cc b/pandora_agents/win32/pandora.cc
index fa9c417123..05557e696c 100644
--- a/pandora_agents/win32/pandora.cc
+++ b/pandora_agents/win32/pandora.cc
@@ -30,7 +30,7 @@ using namespace Pandora;
 using namespace Pandora_Strutils;
 
 #define PATH_SIZE    _MAX_PATH+1
-#define PANDORA_VERSION ("7.0NG.775 Build 240222")
+#define PANDORA_VERSION ("7.0NG.775 Build 240223")
 
 string pandora_path;
 string pandora_dir;
diff --git a/pandora_agents/win32/versioninfo.rc b/pandora_agents/win32/versioninfo.rc
index 16ec5fe61c..9de5fc525c 100644
--- a/pandora_agents/win32/versioninfo.rc
+++ b/pandora_agents/win32/versioninfo.rc
@@ -11,7 +11,7 @@ BEGIN
       VALUE "LegalCopyright", "Pandora FMS"
       VALUE "OriginalFilename", "PandoraAgent.exe"
       VALUE "ProductName", "Pandora FMS Windows Agent"
-      VALUE "ProductVersion", "(7.0NG.775(Build 240222))"
+      VALUE "ProductVersion", "(7.0NG.775(Build 240223))"
       VALUE "FileVersion", "1.0.0.0"
     END
   END
diff --git a/pandora_console/DEBIAN/control b/pandora_console/DEBIAN/control
index de7e2de6f5..40d89f5b8c 100644
--- a/pandora_console/DEBIAN/control
+++ b/pandora_console/DEBIAN/control
@@ -1,5 +1,5 @@
 package: pandorafms-console
-Version: 7.0NG.775-240222
+Version: 7.0NG.775-240223
 Architecture: all
 Priority: optional
 Section: admin
diff --git a/pandora_console/DEBIAN/make_deb_package.sh b/pandora_console/DEBIAN/make_deb_package.sh
index 705993798a..b6e0dc13a3 100644
--- a/pandora_console/DEBIAN/make_deb_package.sh
+++ b/pandora_console/DEBIAN/make_deb_package.sh
@@ -14,7 +14,7 @@
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 # GNU General Public License for more details.
 
-pandora_version="7.0NG.775-240222"
+pandora_version="7.0NG.775-240223"
 
 package_pear=0
 package_pandora=1
diff --git a/pandora_console/include/config_process.php b/pandora_console/include/config_process.php
index 5c0f37b17a..b9febd5a01 100644
--- a/pandora_console/include/config_process.php
+++ b/pandora_console/include/config_process.php
@@ -20,7 +20,7 @@
 /**
  * Pandora build version and version
  */
-$build_version = 'PC240222';
+$build_version = 'PC240223';
 $pandora_version = 'v7.0NG.775';
 
 // Do not overwrite default timezone set if defined.
diff --git a/pandora_console/install.php b/pandora_console/install.php
index 6f9c6c9029..73e82bba6d 100644
--- a/pandora_console/install.php
+++ b/pandora_console/install.php
@@ -131,7 +131,7 @@
         <div style='padding-bottom: 50px'>
             <?php
             $version = '7.0NG.775';
-            $build = '240222';
+            $build = '240223';
             $banner = "v$version Build $build";
             error_reporting(0);
 
diff --git a/pandora_console/pandora_console.redhat.spec b/pandora_console/pandora_console.redhat.spec
index a92c929934..e6b682c8c7 100644
--- a/pandora_console/pandora_console.redhat.spec
+++ b/pandora_console/pandora_console.redhat.spec
@@ -6,7 +6,7 @@
 %define debug_package %{nil}
 %define name        pandorafms_console
 %define version     7.0NG.775
-%define release     240222
+%define release     240223
 
 # User and Group under which Apache is running
 %define httpd_name  httpd
diff --git a/pandora_console/pandora_console.rhel7.spec b/pandora_console/pandora_console.rhel7.spec
index 8d4e321369..0d3090e65c 100644
--- a/pandora_console/pandora_console.rhel7.spec
+++ b/pandora_console/pandora_console.rhel7.spec
@@ -6,7 +6,7 @@
 %define debug_package %{nil}
 %define name        pandorafms_console
 %define version     7.0NG.775
-%define release     240222
+%define release     240223
 
 # User and Group under which Apache is running
 %define httpd_name  httpd
diff --git a/pandora_console/pandora_console.spec b/pandora_console/pandora_console.spec
index e1a57b0c2a..93f5c86206 100644
--- a/pandora_console/pandora_console.spec
+++ b/pandora_console/pandora_console.spec
@@ -3,7 +3,7 @@
 #
 %define name        pandorafms_console
 %define version     7.0NG.775
-%define release     240222
+%define release     240223
 %define httpd_name      httpd
 # User and Group under which Apache is running
 %define httpd_name  apache2
diff --git a/pandora_server/DEBIAN/control b/pandora_server/DEBIAN/control
index e105d01fc0..bf7886e02f 100644
--- a/pandora_server/DEBIAN/control
+++ b/pandora_server/DEBIAN/control
@@ -1,5 +1,5 @@
 package: pandorafms-server
-Version: 7.0NG.775-240222
+Version: 7.0NG.775-240223
 Architecture: all
 Priority: optional
 Section: admin
diff --git a/pandora_server/DEBIAN/make_deb_package.sh b/pandora_server/DEBIAN/make_deb_package.sh
index 2262ccd93e..d6b1c3b013 100644
--- a/pandora_server/DEBIAN/make_deb_package.sh
+++ b/pandora_server/DEBIAN/make_deb_package.sh
@@ -14,7 +14,7 @@
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 # GNU General Public License for more details.
 
-pandora_version="7.0NG.775-240222"
+pandora_version="7.0NG.775-240223"
 
 package_cpan=0
 package_pandora=1
diff --git a/pandora_server/lib/PandoraFMS/Config.pm b/pandora_server/lib/PandoraFMS/Config.pm
index 89ef89c453..75b1303f7d 100644
--- a/pandora_server/lib/PandoraFMS/Config.pm
+++ b/pandora_server/lib/PandoraFMS/Config.pm
@@ -46,7 +46,7 @@ our @EXPORT = qw(
 
 # version: Defines actual version of Pandora Server for this module only
 my $pandora_version = "7.0NG.775";
-my $pandora_build = "240222";
+my $pandora_build = "240223";
 our $VERSION = $pandora_version." ".$pandora_build;
 
 # Setup hash
diff --git a/pandora_server/lib/PandoraFMS/PluginTools.pm b/pandora_server/lib/PandoraFMS/PluginTools.pm
index aef78c855c..d498494201 100644
--- a/pandora_server/lib/PandoraFMS/PluginTools.pm
+++ b/pandora_server/lib/PandoraFMS/PluginTools.pm
@@ -34,7 +34,7 @@ our @ISA = qw(Exporter);
 
 # version: Defines actual version of Pandora Server for this module only
 my $pandora_version = "7.0NG.775";
-my $pandora_build = "240222";
+my $pandora_build = "240223";
 our $VERSION = $pandora_version." ".$pandora_build;
 
 our %EXPORT_TAGS = ( 'all' => [ qw() ] );
diff --git a/pandora_server/pandora_server.redhat.spec b/pandora_server/pandora_server.redhat.spec
index 27afbbc523..a0d1f17417 100644
--- a/pandora_server/pandora_server.redhat.spec
+++ b/pandora_server/pandora_server.redhat.spec
@@ -7,7 +7,7 @@
 %define debug_package %{nil}
 %define name        pandorafms_server
 %define version     7.0NG.775
-%define release     240222
+%define release     240223
 
 Summary:            Pandora FMS Server
 Name:               %{name}
diff --git a/pandora_server/pandora_server.spec b/pandora_server/pandora_server.spec
index fb6473c163..80d046be93 100644
--- a/pandora_server/pandora_server.spec
+++ b/pandora_server/pandora_server.spec
@@ -4,7 +4,7 @@
 %global __os_install_post %{nil}
 %define name        pandorafms_server
 %define version     7.0NG.775
-%define release     240222
+%define release     240223
 
 Summary:            Pandora FMS Server
 Name:               %{name}
diff --git a/pandora_server/pandora_server_installer b/pandora_server/pandora_server_installer
index 6fdd7041cd..9e2cb1a0f1 100755
--- a/pandora_server/pandora_server_installer
+++ b/pandora_server/pandora_server_installer
@@ -9,7 +9,7 @@
 # **********************************************************************
 
 PI_VERSION="7.0NG.775"
-PI_BUILD="240222"
+PI_BUILD="240223"
 
 MODE=$1
 if [ $# -gt 1 ]; then
diff --git a/pandora_server/util/pandora_db.pl b/pandora_server/util/pandora_db.pl
index 1007e32606..29fceb9e59 100755
--- a/pandora_server/util/pandora_db.pl
+++ b/pandora_server/util/pandora_db.pl
@@ -38,7 +38,7 @@ use PandoraFMS::Config;
 use PandoraFMS::DB;
 
 # version: define current version
-my $version = "7.0NG.775 Build 240222";
+my $version = "7.0NG.775 Build 240223";
 
 # Pandora server configuration
 my %conf;
diff --git a/pandora_server/util/pandora_manage.pl b/pandora_server/util/pandora_manage.pl
index ed3c4396ad..c8f80529a6 100755
--- a/pandora_server/util/pandora_manage.pl
+++ b/pandora_server/util/pandora_manage.pl
@@ -36,7 +36,7 @@ use Encode::Locale;
 Encode::Locale::decode_argv;
 
 # version: define current version
-my $version = "7.0NG.775 Build 240222";
+my $version = "7.0NG.775 Build 240223";
 
 # save program name for logging
 my $progname = basename($0);