tyler.durden/pandorafms
1
0
Fork 0
mirror of https://github.com/pandorafms/pandorafms.git synced 2025-07-29 08:45:12 +02:00
Code Issues Packages Projects Releases Wiki Activity

Improve security message

Browse Source
This commit is contained in:
José González 2022-06-07 10:51:37 +02:00
parent 67ade2fccd
commit 06d9e0d137
1 changed files with 24 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

48
pandora_console/include/get_file.php
View File

@ -26,9 +26,10 @@
* ============================================================================ * ============================================================================
*/ */
// Get global data. // Begin.
require_once 'config.php'; require_once 'config.php';
require_once 'functions.php'; require_once 'functions.php';
require_once 'functions_ui.php';
require_once 'functions_filemanager.php'; require_once 'functions_filemanager.php';
global $config; global $config;
@ -41,17 +42,13 @@ if ($auth_method !== 'ad' && $auth_method !== 'ldap') {
include_once 'auth/'.$auth_method.'.php'; include_once 'auth/'.$auth_method.'.php';
} }
$hash = get_parameter('hash');
$styleError = 'background:url("../images/err.png") no-repeat scroll 0 0 transparent; padding:4px 1px 6px 30px; color:#CC0000;'; $file_raw = get_parameter('file');
$file_raw = get_parameter('file', null);
$file = base64_decode(urldecode($file_raw)); $file = base64_decode(urldecode($file_raw));
$hash = get_parameter('hash', null); if (empty($file) === true || empty($hash) === true || $hash !== md5($file_raw.$config['server_unique_identifier']) || isset($_SERVER['HTTP_REFERER']) === false) {
$errorMessage = __('Security error. Please contact the administrator.');
if ($file === '' || $hash === '' || $hash !== md5($file_raw.$config['server_unique_identifier']) || !isset($_SERVER['HTTP_REFERER'])) {
echo "<h3 style='".$styleError."'>".__('Security error. Please contact the administrator.').'</h3>';
} else { } else {
$downloadable_file = ''; $downloadable_file = '';
$parse_all_queries = explode('&', parse_url($_SERVER['HTTP_REFERER'], PHP_URL_QUERY)); $parse_all_queries = explode('&', parse_url($_SERVER['HTTP_REFERER'], PHP_URL_QUERY));
@ -79,28 +76,16 @@ if ($file === '' || $hash === '' || $hash !== md5($file_raw.$config['server_uniq
break; break;
default: default:
// Wrong action.
$downloadable_file = ''; $downloadable_file = '';
// Do nothing
break; break;
} }
} }
if (empty($downloadable_file) === true || file_exists($downloadable_file) === false) { if (empty($downloadable_file) === true || file_exists($downloadable_file) === false) {
?> $errorMessage = __('File is missing in disk storage. Please contact the administrator.');
<div id="mainDiv"></div>
<script type="text/javascript">
var refererPath = '<?php echo $_SERVER['HTTP_REFERER']; ?>';
var errorOutput = '<?php echo __('File is missing in disk storage. Please contact the administrator.'); ?>';
document.addEventListener('DOMContentLoaded', function () {
document.getElementById('mainDiv').innerHTML = `<form action="` + refererPath + `" name="failedReturn" method="post" style="display:none;">
<input type="hidden" name="errorOutput" value="` + errorOutput + `" />
</form>`;
document.forms['failedReturn'].submit();
}, false);
</script>
<?php
} else { } else {
// Everything went well.
header('Content-type: aplication/octet-stream;'); header('Content-type: aplication/octet-stream;');
header('Content-type: '.mime_content_type($downloadable_file).';'); header('Content-type: '.mime_content_type($downloadable_file).';');
header('Content-Length: '.filesize($downloadable_file)); header('Content-Length: '.filesize($downloadable_file));
@ -108,3 +93,18 @@ if ($file === '' || $hash === '' || $hash !== md5($file_raw.$config['server_uniq
readfile($downloadable_file); readfile($downloadable_file);
} }
} }
?>
<script type="text/javascript">
document.addEventListener('DOMContentLoaded', function () {
var refererPath = '<?php echo (($_SERVER['HTTP_REFERER']) ?? ui_get_full_url()); ?>';
var errorOutput = '<?php echo $errorMessage; ?>';
document.body.innerHTML = `<form action="` + refererPath + `" name="failedReturn" method="post" style="display:none;">
<input type="hidden" name="errorOutput" value="` + errorOutput + `" />
</form>`;
document.forms['failedReturn'].submit();
}, false);
</script>