From 07232d82d18b456cd1bcc51a8266292549344b4f Mon Sep 17 00:00:00 2001 From: "alejandro.campos@artica.es" Date: Tue, 11 Oct 2022 13:26:25 +0200 Subject: [PATCH] fix several problems in history db settings --- pandora_console/include/functions_config.php | 7 ++++--- pandora_console/include/lib/Core/Config.php | 2 ++ 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/pandora_console/include/functions_config.php b/pandora_console/include/functions_config.php index 647b719ae3..a4aa1f45de 100644 --- a/pandora_console/include/functions_config.php +++ b/pandora_console/include/functions_config.php @@ -1577,9 +1577,10 @@ function config_update_config() } $history_db_string_days = get_parameter('history_db_string_days'); - if (is_numeric($history_db_string_days) === false + if ((is_numeric($history_db_string_days) === false || $history_db_string_days <= 0 - || config_update_value('history_db_string_days', $history_db_string_days) === false + || config_update_value('history_db_string_days', $history_db_string_days) === false) + && get_parameter_switch('history_db_adv', 0) === 1 ) { $error_update[] = __('String Days'); } @@ -1843,7 +1844,7 @@ function config_update_config() $config['error_config_update_config']['correct'] = false; $values = implode('
-', $error_update); $config['error_config_update_config']['message'] = sprintf( - __('Failed updated: the next values cannot update:
-%s'), + __('Update failed. The next values could not be updated:
-%s'), $values ); diff --git a/pandora_console/include/lib/Core/Config.php b/pandora_console/include/lib/Core/Config.php index dbed566598..00875fd077 100644 --- a/pandora_console/include/lib/Core/Config.php +++ b/pandora_console/include/lib/Core/Config.php @@ -90,7 +90,9 @@ final class Config } ob_get_clean(); + } + if (empty($settings) === true) { if ($config['history_db_connection'] !== false) { $data = \db_get_all_rows_sql( 'SELECT * FROM `tconfig`',