Killing unicorns and magic numbers.

This commit is contained in:
mdtrooper 2015-06-11 20:45:40 +02:00
parent 9ad8b1035c
commit 0be8792b01
2 changed files with 165 additions and 160 deletions

View File

@ -314,6 +314,7 @@ define ('MODULE_PREDICTION_NETFLOW', 4);
/* SNMP CONSTANTS */ /* SNMP CONSTANTS */
define('SNMP_DIR_MIBS', "attachment/mibs"); define('SNMP_DIR_MIBS', "attachment/mibs");
define('SNMP_TRAP_TYPE_NONE', -1); define('SNMP_TRAP_TYPE_NONE', -1);
define('SNMP_TRAP_TYPE_COLD_START', 0); define('SNMP_TRAP_TYPE_COLD_START', 0);
define('SNMP_TRAP_TYPE_WARM_START', 1); define('SNMP_TRAP_TYPE_WARM_START', 1);
@ -428,4 +429,8 @@ define("COLLECTION_UNSAVED", 3);
/* PAGINATION */ /* PAGINATION */
define("PAGINATION_BLOCKS_LIMIT", 15); define("PAGINATION_BLOCKS_LIMIT", 15);
/* CHARTS */
define("CHART_DEFAULT_WIDTH", 150);
define("CHART_DEFAULT_HEIGHT", 110);
?> ?>

View File

@ -216,13 +216,13 @@ function area_graph($flash_chart, $chart_data, $width, $height, $color,
setup_watermark($water_mark, $water_mark_file, $water_mark_url); setup_watermark($water_mark, $water_mark_file, $water_mark_url);
// ATTENTION: The min size is 110x150 // ATTENTION: The min size is in constants.php
// It's not the same minsize for all graphs, but we are choosed a prudent minsize for all // It's not the same minsize for all graphs, but we are choosed a prudent minsize for all
if ($height <= 110) { if ($height <= CHART_DEFAULT_HEIGHT) {
$height = 110; $height = CHART_DEFAULT_HEIGHT;
} }
if ($width < 150) { if ($width < CHART_DEFAULT_WIDTH) {
$width = 150; $width = CHART_DEFAULT_WIDTH;
} }
if (empty($chart_data)) { if (empty($chart_data)) {