tyler.durden
/
pandorafms
mirror of https://github.com/pandorafms/pandorafms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

2008-10-27 Evi Vanoost <vanooste@rcbi.rochester.edu> 

* godmode/users/user_list.php: Rewrite to use print_table. Fixed 
        security hole where the acl check didn't call exit

        * godmode/users/configure_user.php: Fixed security hole with acl check

        * godmode/setup/setup.php, godmode/setup/news.php, 
        godmode/setup/links.php: Removed call to comprueba_login, made acl 
        checks exit and require_once config.php

        * godmode/reporting/reporting_builder.php,
        godmode/reporting/map_builder.php, godmode/reporting/graph_builder.php:
        Removed call to comprueba_login, made acl checks exit.

        * godmode/alerts/modify_alert.php, godmode/alerts/configure_alert.php: 
        Fixed acl check and removed call to comprueba_login.


git-svn-id: https://svn.code.sf.net/p/pandora/code/trunk@1196 c3f86ba8-e40f-0410-aaad-9ba5e7f4b01f
This commit is contained in:
guruevi 2008-10-27 15:17:20 +00:00
parent 61340cc1b6
commit 19a21a4685
11 changed files with 123 additions and 103 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
pandora_console/ChangeLog
View File

@ -1,3 +1,21 @@
2008-10-27 Evi Vanoost <vanooste@rcbi.rochester.edu>
* godmode/users/user_list.php: Rewrite to use print_table. Fixed
security hole where the acl check didn't call exit
* godmode/users/configure_user.php: Fixed security hole with acl check
* godmode/setup/setup.php, godmode/setup/news.php,
godmode/setup/links.php: Removed call to comprueba_login, made acl
checks exit and require_once config.php
* godmode/reporting/reporting_builder.php,
godmode/reporting/map_builder.php, godmode/reporting/graph_builder.php:
Removed call to comprueba_login, made acl checks exit.
* godmode/alerts/modify_alert.php, godmode/alerts/configure_alert.php:
Fixed acl check and removed call to comprueba_login.
2008-10-24 Esteban Sanchez <estebans@artica.es>
* operation/snmpconsole/snmp_alert.php: Fixed an error that doesn't

4
pandora_console/godmode/alerts/configure_alert.php
View File

@ -18,7 +18,7 @@
// Load global vars
require ("include/config.php");
require_once ("include/config.php");
check_login ();
@ -26,7 +26,7 @@ if (! give_acl ($config['id_user'], 0, "LM")) {
audit_db ($config['id_user'], $REMOTE_ADDR, "ACL Violation",
"Trying to access Alert Management");
require ("general/noaccess.php");
return;
exit;
}
// Var init
$descripcion = "";

6
pandora_console/godmode/alerts/modify_alert.php
View File

@ -19,7 +19,7 @@
// Load global vars
require ("include/config.php");
require_once ("include/config.php");
check_login ();
@ -27,13 +27,14 @@ if (! give_acl ($config['id_user'], 0, "LM")) {
audit_db ($config['id_user'], $REMOTE_ADDR, "ACL Violation",
"Trying to access Alert Management");
require ("general/noaccess.php");
return;
exit;
}
if (isset($_POST["update_alerta"])){ // if modified any parameter
$id_alerta = entrada_limpia($_POST["id_alerta"]);
if ($id_alerta < 4){
audit_db ($config['id_user'], $REMOTE_ADDR, "ACL Violation", "Trying to access Alert Management");
require ("general/noaccess.php");
exit;
}
$nombre = entrada_limpia($_POST["nombre"]);
$comando = entrada_limpia($_POST["comando"]);
@ -64,6 +65,7 @@ if (isset($_GET["borrar_alerta"])){ // if delete alert
if ($id_alerta < 4) {
audit_db ($config['id_user'],$REMOTE_ADDR, "ACL Violation","Trying to access Alert Management");
require ("general/noaccess.php");
exit;
}
$sql_delete= "DELETE FROM talerta WHERE id_alerta = ".$id_alerta;
$result=mysql_query($sql_delete);

2
pandora_console/godmode/reporting/graph_builder.php
View File

@ -18,7 +18,7 @@
// Login check
require ("include/config.php");
require_once ("include/config.php");
check_login ();

12
pandora_console/godmode/reporting/map_builder.php
View File

@ -16,19 +16,17 @@
// along with this program; if not, write to the Free Software
// Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
if (comprueba_login () != 0) {
audit_db ($config['id_user'], $REMOTE_ADDR, "ACL Violation", "Trying to access map builder");
include ("general/noaccess.php");
exit;
}
require_once ("include/config.php");
check_login ();
if (! give_acl ($config['id_user'], 0, "AW")) {
audit_db ($config['id_user'], $REMOTE_ADDR, "ACL Violation", "Trying to access map builder");
include ("general/noaccess.php");
require ("general/noaccess.php");
exit;
}
require ('include/functions_visual_map.php');
require_once ('include/functions_visual_map.php');
$id_layout = (int) get_parameter ('id_layout');
$edit_layout = (bool) get_parameter ('edit_layout');

6
pandora_console/godmode/reporting/reporting_builder.php
View File

@ -17,14 +17,14 @@
// Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
// Login check
require ("include/config.php");
require_once ("include/config.php");
check_login ();
if (! give_acl ($config['id_user'], 0, "AW")) {
audit_db ($config['id_user'], $REMOTE_ADDR, "ACL Violation",
"Trying to access graph builder");
include ("general/noaccess.php");
require ("general/noaccess.php");
exit;
}
@ -117,7 +117,7 @@ if ($delete_report) {
if ($add_content) {
if (! $id_report) {
audit_db ($config['id_user'], $REMOTE_ADDR, "Hack attempt", "Parameter trash in report builder");
include ("general/noaccess.php");
require ("general/noaccess.php");
exit ();
}
$id_agent_module = (int) get_parameter ('id_module');

9
pandora_console/godmode/setup/links.php
View File

@ -17,15 +17,14 @@
// Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
// Load global vars
require("include/config.php");
require_once ("include/config.php");
check_login ();
if (comprueba_login()) {
audit_db ($config['id_user'], $REMOTE_ADDR, "ACL Violation", "Trying to access Link Management");
require ("general/noaccess.php");
}
if (! give_acl ($config['id_user'], 0, "PM") || ! dame_admin ($config['id_user'])) {
audit_db ($config['id_user'], $REMOTE_ADDR, "ACL Violation", "Trying to access Link Management");
require ("general/noaccess.php");
exit;
}

2
pandora_console/godmode/setup/news.php
View File

@ -25,7 +25,7 @@ if (! give_acl ($config['id_user'], 0, "PM")) {
audit_db ($config['id_user'], $REMOTE_ADDR, "ACL Violation",
"Trying to access Link Management");
require ("general/noaccess.php");
return;
exit;
}
if (isset ($_POST["create"])) { // If create

2
pandora_console/godmode/setup/setup.php
View File

@ -17,7 +17,7 @@
// Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
// Load global vars
require("include/config.php");
require_once ("include/config.php");
check_login ();

7
pandora_console/godmode/users/configure_user.php
View File

@ -17,14 +17,15 @@
// Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
// Load global vars
require("include/config.php");
require_once ("include/config.php");
check_login();
check_login ();
if (! give_acl ($config['id_user'], 0, "UM")) {
audit_db($config['id_user'], $REMOTE_ADDR, "ACL Violation",
audit_db ($config['id_user'], $REMOTE_ADDR, "ACL Violation",
"Trying to access User Management");
require ("general/noaccess.php");
exit;
}
// Init. vars

158
pandora_console/godmode/users/user_list.php
View File

@ -17,99 +17,101 @@
// Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
// Load globar vars
require("include/config.php");
require_once ("include/config.php");
check_login ();
if (! give_acl ($config['id_user'], 0, "UM")) {
audit_db ($config['id_user'], $REMOTE_ADDR, "ACL Violation",
"Trying to access User Management");
require ("general/noaccess.php");
exit;
}
if (isset($_GET["borrar_usuario"])) { // if delete user
$nombre= entrada_limpia($_GET["borrar_usuario"]);
$nombre = get_parameter_get ("borrar_usuario");
// Delete user
// Delete cols from table tgrupo_usuario
$sql = "DELETE FROM tgrupo_usuario WHERE usuario = '".$nombre."'";
$result = mysql_query ($sql);
$result = process_sql ($sql);
$sql = "DELETE FROM tusuario WHERE id_usuario = '".$nombre."'";
$result = mysql_query ($sql);
if (! $result)
echo "<h3 class='error'>".__('There was a problem deleting user')."</h3>";
else
echo "<h3 class='suc'>".__('User successfully deleted')."</h3>";
}
?>
<h2><?php echo __('User management') ?> &gt;
<?php echo __('Users defined in Pandora') ?></h2>
<table width="700" cellpadding="4" cellspacing="4" class="databox">
<th width="80px"><?php echo __('UserID')?></th>
<th width="155px"><?php echo __('Last contact')?></th>
<th width="45px"><?php echo __('Profile')?></th>
<th width="120px"><?php echo __('Name')?></th>
<th><?php echo __('Description')?></th>
<th width="30px"><?php echo __('Delete')?></th>
<?php
$sql = "SELECT * FROM tusuario";
$resq1 = mysql_query ($sql);
// Init vars
$nombre = "";
$nivel = "";
$comentarios = "";
$fecha_registro = "";
$color=1;
while ($rowdup = mysql_fetch_array ($resq1)) {
$name = $rowdup["id_usuario"];
$nivel = $rowdup["nivel"];
$real_name = $rowdup["nombre_real"];
$comments = $rowdup["comentarios"];
$fecha_registro = $rowdup["fecha_registro"];
if ($color == 1){
$tdcolor = "datos";
$tip= "tip";
$color = 0;
}
else {
$tdcolor = "datos2";
$tip= "tip2";
$color = 1;
}
echo "<tr><td class='$tdcolor'>";
echo "<a href='index.php?sec=gusuarios&sec2=godmode/users/configure_user&id_usuario_mio=".$name."'><b>".$name."</b></a>";
echo "<td class='$tdcolor'>".$fecha_registro;
echo "<td class='$tdcolor'>";
if ($nivel == 1)
echo "<img src='images/user_suit.png'>";
else
echo "<img src='images/user_green.png'>";
$sql = 'SELECT * FROM tusuario_perfil WHERE id_usuario = "'.$name.'"';
$result = mysql_query ($sql);
echo "<a href='#' class='$tip'>&nbsp;<span>";
if (mysql_num_rows ($result)) {
while ($row = mysql_fetch_array ($result)) {
echo dame_perfil ($row["id_perfil"])."/ ";
echo dame_grupo ($row["id_grupo"])."<br>";
}
$result = process_sql ($sql);
if ($result === false) {
echo '<h3 class="error">'.__('There was a problem deleting user').'</h3>';
} else {
echo __('This user doesn\'t have any assigned profile/group');
echo '<h3 class="suc">'.__('User successfully deleted').'</h3>';
}
echo "</span></a>";
echo "<td class='$tdcolor' width='100'>".substr ($real_name, 0, 16)."</td>";
echo "<td class='$tdcolor'>".$comments."</td>";
echo "<td class='$tdcolor' align='center'><a href='index.php?sec=gagente&sec2=godmode/users/user_list&borrar_usuario=".$name."' onClick='if (!confirm(\' ".__('Are you sure?')."\')) return false;'><img border='0' src='images/cross.png'></a></td>";
}
echo "</tr></table>";
echo "<table width=700>";
echo "<tr><td align='right'>";
echo "<form method=post action='index.php?sec=gusuarios&sec2=godmode/users/configure_user&alta=1'>";
echo "<input type='submit' class='sub next' name='crt' value='".__('Create user')."'>";
echo "</form></td></tr></table>";
echo "</table>";
echo '<h2>'.__('User management').' &gt; '.__('Users defined in Pandora').'</h2>';
$table->width = 700;
$table->cellpadding = 4;
$table->cellspacing = 4;
$table->class = "databox";
$table->head = array ();
$table->size = array ();
$table->data = array ();
$table->align = array ();
$table->head[0] = __('User ID');
$table->head[1] = __('Last contact');
$table->align[1] = "center";
$table->head[2] = __('Profile');
$table->align[2] = "center";
$table->head[3] = __('Name');
$table->align[3] = "center";
$table->head[4] = __('Description');
$table->align[4] = "center";
$table->head[5] = __('Delete');
$table->align[5] = "center";
$result = get_db_all_rows_in_table ('tusuario');
foreach ($result as $row) {
$data = array ();
$data[0] = '<a href="index.php?sec=gusuarios&sec2=godmode/users/configure_user&id_usuario_mio='.$row["id_usuario"].'"><b>'.$row["id_usuario"].'</b></a>';
$data[1] = $row["fecha_registro"];
if ($row["nivel"] == 1) {
$data[2] = '<img src="images/user_suit.png" />';
} else {
$data[2] = '<img src="images/user_green.png" />';
}
$data[2] .= '<a href="#" class="tip"><span>';
$profiles = get_db_all_rows_field_filter ("tusuario_perfil", "id_usuario", $row["id_usuario"]);
if ($profiles === false) {
$data[2] .= __('This user doesn\'t have any assigned profile/group');
$profiles = array ();
}
foreach ($profiles as $profile) {
$data[2] .= dame_perfil ($profile["id_perfil"])." / ";
$data[2] .= dame_grupo ($profile["id_grupo"])."<br />";
}
$data[2] .= "</span></a>";
$data[3] = substr ($row["nombre_real"], 0, 16);
$data[4] = $row["comentarios"];
$data[5] = '<a href="index.php?sec=gagente&sec2=godmode/users/user_list&borrar_usuario='.$row["id_usuario"].'" onClick="if (!confirm(\''.__('Are you sure?').'\')) return false;">';
$data[5] .= '<img border="0" src="images/cross.png" /></a>';
array_push ($table->data, $data);
}
print_table ($table);
unset ($table);
echo '<div style="width:680px; text-align:right"><form method="post" action="index.php?sec=gusuarios&sec2=godmode/users/configure_user&alta=1">';
print_submit_button (__('Create user'), "crt", false, 'class="sub next"');
echo "</form></div>";
?>