From 19f07b9b9ee6ee49784db0ed7d08e9602b48e33b Mon Sep 17 00:00:00 2001 From: Tatiana Llorente Date: Mon, 10 Feb 2020 17:01:36 +0100 Subject: [PATCH] Changed id_agent for id_tagent --- pandora_console/include/functions_api.php | 2485 +++++++-------------- 1 file changed, 810 insertions(+), 1675 deletions(-) diff --git a/pandora_console/include/functions_api.php b/pandora_console/include/functions_api.php index 3ab65f072d..403c5e2067 100644 --- a/pandora_console/include/functions_api.php +++ b/pandora_console/include/functions_api.php @@ -301,13 +301,8 @@ function isInACL($ip) // example lab.artica.es without '*' $name = []; $name = gethostbyname($acl_ip); - if (preg_match('/'.$name.'/', $ip, $matches)) { - // This is for false matches, like '' or $. - if (count($matches) == 1 && $matches[0] == '') { - continue; - } else { - return true; - } + if (preg_match('/'.$name.'/', $ip)) { + return true; } } } @@ -406,11 +401,10 @@ function api_get_groups($thrash1, $thrash2, $other, $returnType, $user_in_db) function api_get_agent_module_name_last_value($agentName, $moduleName, $other=';', $returnType) { $idAgent = agents_get_agent_id($agentName); - $sql = sprintf( 'SELECT id_agente_modulo - FROM tagente_modulo - WHERE id_agente = %d AND nombre LIKE "%s"', + FROM tagente_modulo + WHERE id_agente = %d AND nombre LIKE "%s"', $idAgent, $moduleName ); @@ -424,8 +418,8 @@ function api_get_agent_module_name_last_value_alias($alias, $moduleName, $other= { $sql = sprintf( 'SELECT tagente_modulo.id_agente_modulo FROM tagente_modulo - INNER JOIN tagente ON tagente_modulo.id_agente = tagente.id_agente - WHERE tagente.alias LIKE "%s" AND tagente_modulo.nombre LIKE "%s"', + INNER JOIN tagente ON tagente_modulo.id_agente = tagente.id_agente + WHERE tagente.alias LIKE "%s" AND tagente_modulo.nombre LIKE "%s"', $alias, $moduleName ); @@ -450,8 +444,8 @@ function api_get_module_last_value($idAgentModule, $trash1, $other=';', $returnT $sql = sprintf( 'SELECT datos - FROM tagente_estado - WHERE id_agente_modulo = %d', + FROM tagente_estado + WHERE id_agente_modulo = %d', $idAgentModule ); $value = db_get_value_sql($sql); @@ -898,9 +892,9 @@ function api_get_tree_agents($trash1, $trahs2, $other, $returnType) $id_group = $group['group_id']; $agents = db_get_all_rows_sql( "SELECT id_agente AS agent_id, id_grupo AS agent_id_group , alias $agent_additional_columns - FROM tagente ta LEFT JOIN tagent_secondary_group tasg - ON ta.id_agente = tasg.id_agent - WHERE ta.id_grupo = $id_group OR tasg.id_group = $id_group" + FROM tagente ta LEFT JOIN tagent_secondary_group tasg + ON ta.id_agente = tasg.id_agent + WHERE ta.id_grupo = $id_group OR tasg.id_group = $id_group" ); if ($agents === false) { $agents = []; @@ -922,13 +916,13 @@ function api_get_tree_agents($trash1, $trahs2, $other, $returnType) $modules = db_get_all_rows_sql( 'SELECT * - FROM (SELECT id_agente_modulo as module_id_agent_modulo '.$module_additional_columns.' - FROM tagente_modulo - WHERE id_agente = '.$agent['agent_id'].') t1 - INNER JOIN (SELECT id_agente_modulo as module_id_agent_modulo '.$estado_additional_columns.' - FROM tagente_estado - WHERE id_agente = '.$agent['agent_id'].') t2 - ON t1.module_id_agent_modulo = t2.module_id_agent_modulo' + FROM (SELECT id_agente_modulo as module_id_agent_modulo '.$module_additional_columns.' + FROM tagente_modulo + WHERE id_agente = '.$agent['agent_id'].') t1 + INNER JOIN (SELECT id_agente_modulo as module_id_agent_modulo '.$estado_additional_columns.' + FROM tagente_estado + WHERE id_agente = '.$agent['agent_id'].') t2 + ON t1.module_id_agent_modulo = t2.module_id_agent_modulo' ); if ($modules === false) { @@ -953,16 +947,16 @@ function api_get_tree_agents($trash1, $trahs2, $other, $returnType) $alerts = db_get_all_rows_sql( 'SELECT t1.id_agent_module as alert_id_agent_module '.$alert_additional_columns.' - FROM (SELECT * FROM talert_template_modules - WHERE id_agent_module = '.$module['module_id_agent_modulo'].') t1 - INNER JOIN talert_templates t2 - ON t1.id_alert_template = t2.id - LEFT JOIN talert_template_module_actions t3 - ON t1.id = t3.id_alert_template_module - LEFT JOIN talert_actions t4 - ON t3.id_alert_action = t4.id - LEFT JOIN talert_commands t5 - ON t4.id_alert_command = t5.id' + FROM (SELECT * FROM talert_template_modules + WHERE id_agent_module = '.$module['module_id_agent_modulo'].') t1 + INNER JOIN talert_templates t2 + ON t1.id_alert_template = t2.id + LEFT JOIN talert_template_module_actions t3 + ON t1.id = t3.id_alert_template_module + LEFT JOIN talert_actions t4 + ON t3.id_alert_action = t4.id + LEFT JOIN talert_commands t5 + ON t4.id_alert_command = t5.id' ); if ($alerts === false) { @@ -1147,8 +1141,8 @@ function api_get_module_properties_by_alias($alias, $module_name, $other, $retur $sql = sprintf( 'SELECT tagente_modulo.id_agente_modulo, tagente.id_agente FROM tagente_modulo - INNER JOIN tagente ON tagente_modulo.id_agente = tagente.id_agente - WHERE tagente.alias LIKE "%s" AND tagente_modulo.nombre LIKE "%s"', + INNER JOIN tagente ON tagente_modulo.id_agente = tagente.id_agente + WHERE tagente.alias LIKE "%s" AND tagente_modulo.nombre LIKE "%s"', $alias, $module_name ); @@ -1264,13 +1258,13 @@ function get_module_properties($id_module, $fields, $separator, $returnType, $re $returnVar = []; $modules = db_get_all_rows_sql( 'SELECT * - FROM (SELECT id_agente_modulo as module_id_agent_modulo '.$module_additional_columns.' - FROM tagente_modulo - WHERE id_agente_modulo = '.$id_module.') t1 - INNER JOIN (SELECT id_agente_modulo as module_id_agent_modulo '.$estado_additional_columns.' - FROM tagente_estado - WHERE id_agente_modulo = '.$id_module.') t2 - ON t1.module_id_agent_modulo = t2.module_id_agent_modulo' + FROM (SELECT id_agente_modulo as module_id_agent_modulo '.$module_additional_columns.' + FROM tagente_modulo + WHERE id_agente_modulo = '.$id_module.') t1 + INNER JOIN (SELECT id_agente_modulo as module_id_agent_modulo '.$estado_additional_columns.' + FROM tagente_estado + WHERE id_agente_modulo = '.$id_module.') t2 + ON t1.module_id_agent_modulo = t2.module_id_agent_modulo' ); if ($modules === false) { @@ -1334,8 +1328,8 @@ function api_set_update_agent($id_agent, $thrash2, $other, $thrash3) if ($cascadeProtection == 1) { if (($idParent != 0) && (db_get_value_sql( 'SELECT id_agente_modulo - FROM tagente_modulo - WHERE id_agente = '.$idParent.' AND id_agente_modulo = '.$cascadeProtectionModule + FROM tagente_modulo + WHERE id_agente = '.$idParent.' AND id_agente_modulo = '.$cascadeProtectionModule ) === false) ) { returnError('parent_agent_not_exist', 'Is not a parent module to do cascade protection.'); @@ -1374,7 +1368,7 @@ function api_set_update_agent($id_agent, $thrash2, $other, $thrash3) ); $tpolicy_group_old = db_get_all_rows_sql( 'SELECT id_policy FROM tpolicy_groups - WHERE id_group = '.$values_old['id_grupo'] + WHERE id_group = '.$values_old['id_grupo'] ); $return = db_process_sql_update( @@ -1419,7 +1413,7 @@ function api_set_update_agent($id_agent, $thrash2, $other, $thrash3) foreach ($tpolicy_group_old as $key => $value) { $tpolicy_agents_old = db_get_sql( 'SELECT * FROM tpolicy_agents - WHERE id_policy = '.$value['id_policy'].' AND id_agent = '.$id_agent + WHERE id_policy = '.$value['id_policy'].' AND id_agent = '.$id_agent ); if ($tpolicy_agents_old) { @@ -1437,14 +1431,14 @@ function api_set_update_agent($id_agent, $thrash2, $other, $thrash3) $tpolicy_group = db_get_all_rows_sql( 'SELECT id_policy FROM tpolicy_groups - WHERE id_group = '.$idGroup + WHERE id_group = '.$idGroup ); if ($tpolicy_group) { foreach ($tpolicy_group as $key => $value) { $tpolicy_agents = db_get_sql( 'SELECT * FROM tpolicy_agents - WHERE id_policy = '.$value['id_policy'].' AND id_agent ='.$id_agent + WHERE id_policy = '.$value['id_policy'].' AND id_agent ='.$id_agent ); if (!$tpolicy_agents) { @@ -1498,7 +1492,7 @@ function api_set_new_agent($thrash1, $thrash2, $other, $thrash3) global $config; if (!check_acl($config['id_user'], 0, 'AW')) { - returnError('forbidden', 'you havent got permissions to do this'); + returnError('forbidden', 'string'); return; } @@ -1506,101 +1500,127 @@ function api_set_new_agent($thrash1, $thrash2, $other, $thrash3) return; } - $alias = io_safe_input(trim(preg_replace('/[\/\\\|%#&$]/', '', $other['data'][0]))); - $direccion_agente = io_safe_input($other['data'][1]); - $nombre_agente = hash('sha256', $direccion_agente.'|'.$direccion_agente.'|'.time().'|'.sprintf('%04d', rand(0, 10000))); - $id_parent = (int) $other['data'][2]; - $grupo = (int) $other['data'][3]; - $cascade_protection = (int) $other['data'][4]; - $cascade_protection_module = (int) $other['data'][5]; - $intervalo = (string) $other['data'][6]; - $id_os = (int) $other['data'][7]; - $server_name = (string) $other['data'][8]; - $custom_id = (string) $other['data'][9]; - $modo = (int) $other['data'][10]; - $disabled = (int) $other['data'][11]; - $comentarios = (string) $other['data'][12]; - $alias_as_name = (int) $other['data'][13]; - $update_module_count = (int) $config['metaconsole_agent_cache'] == 1; + $alias = $other['data'][0]; + $ip = $other['data'][1]; + $idParent = $other['data'][2]; + $idGroup = $other['data'][3]; + $cascadeProtection = $other['data'][4]; + $cascadeProtectionModule = $other['data'][5]; + $intervalSeconds = $other['data'][6]; + $idOS = $other['data'][7]; + // $idServer = $other['data'][7]; + $nameServer = $other['data'][8]; + $customId = $other['data'][9]; + $learningMode = $other['data'][10]; + $disabled = $other['data'][11]; + $description = $other['data'][12]; + $alias_as_name = $other['data'][13]; - if ($cascade_protection == 1) { - if (($id_parent != 0) && (db_get_value_sql( + if ($alias_as_name && !empty($alias)) { + $name = $alias; + } else { + $name = hash('sha256', $alias.'|'.$direccion_agente.'|'.time().'|'.sprintf('%04d', rand(0, 10000))); + if (empty($alias)) { + $alias = $name; + } + } + + if ($cascadeProtection == 1) { + if (($idParent != 0) && (db_get_value_sql( 'SELECT id_agente_modulo - FROM tagente_modulo - WHERE id_agente = '.$id_parent.' AND id_agente_modulo = '.$cascade_protection_module + FROM tagente_modulo + WHERE id_agente = '.$idParent.' AND id_agente_modulo = '.$cascadeProtectionModule ) === false) ) { returnError('parent_agent_not_exist', 'Is not a parent module to do cascade protection.'); - return; } } else { $cascadeProtectionModule = 0; } - $server_name = db_get_value_sql('SELECT name FROM tserver WHERE BINARY name LIKE "'.$server_name.'"'); + switch ($config['dbtype']) { + case 'mysql': + $sql1 = 'SELECT name + FROM tserver WHERE BINARY name LIKE "'.$nameServer.'"'; + break; - // Check if agent exists (BUG WC-50518-2). - if ($alias == '' && $alias_as_name === 0) { - returnError('alias_not_specified', 'No agent alias specified'); - } else if (agents_get_agent_id($name)) { + case 'postgresql': + case 'oracle': + $sql1 = 'SELECT name + FROM tserver WHERE name LIKE \''.$nameServer.'\''; + break; + } + + $nameServer = db_get_value_sql($sql1); + + // Check ACL group + if (!check_acl($config['id_user'], $idGroup, 'AW')) { + returnError('forbidden', 'string'); + return; + } + + // Check selected parent + if ($idParent != 0) { + $parentCheck = agents_check_access_agent($idParent); + if ($parentCheck === null) { + returnError('parent_agent_not_exist', __('The agent parent don`t exist.')); + return; + } + + if ($parentCheck === false) { + returnError('parent_agent_forbidden', __('The user cannot access to parent agent.')); + return; + } + } + + if (agents_get_agent_id($name)) { returnError('agent_name_exist', 'The name of agent yet exist in DB.'); - } else if (db_get_value_sql('SELECT id_grupo FROM tgrupo WHERE id_grupo = '.$grupo) === false) { + } else if (db_get_value_sql( + 'SELECT id_grupo + FROM tgrupo + WHERE id_grupo = '.$idGroup + ) === false + ) { returnError('id_grupo_not_exist', 'The group don`t exist.'); - } else if (db_get_value_sql('SELECT id_os FROM tconfig_os WHERE id_os = '.$id_os) === false) { + } else if (db_get_value_sql( + 'SELECT id_os + FROM tconfig_os + WHERE id_os = '.$idOS + ) === false + ) { returnError('id_os_not_exist', 'The OS don`t exist.'); - } else if ($server_name === false) { + } else if (db_get_value_sql($sql1) === false) { returnError('server_not_exist', 'The '.get_product_name().' Server don`t exist.'); } else { - if ($alias_as_name === 1) { - $exists_alias = db_get_row_sql('SELECT nombre FROM tagente WHERE nombre = "'.$alias.'"'); - $nombre_agente = $alias; + $idAgente = db_process_sql_insert( + 'tagente', + [ + 'nombre' => $name, + 'alias' => $alias, + 'direccion' => $ip, + 'id_grupo' => $idGroup, + 'intervalo' => $intervalSeconds, + 'comentarios' => $description, + 'modo' => $learningMode, + 'id_os' => $idOS, + 'disabled' => $disabled, + 'cascade_protection' => $cascadeProtection, + 'cascade_protection_module' => $cascadeProtectionModule, + 'server_name' => $nameServer, + 'id_parent' => $idParent, + 'custom_id' => $customId, + ] + ); + + if (!empty($idAgente) && !empty($ip)) { + // register ip for this agent in 'taddress' + agents_add_address($idAgente, $ip); } - if ($direccion_agente != '') { - $exists_ip = db_get_row_sql('SELECT direccion FROM tagente WHERE direccion = "'.$direccion_agente.'"'); - } - - if (!$exists_alias && !$exists_ip) { - $id_agente = db_process_sql_insert( - 'tagente', - [ - 'nombre' => $nombre_agente, - 'alias' => $alias, - 'alias_as_name' => $alias_as_name, - 'direccion' => $direccion_agente, - 'id_grupo' => $grupo, - 'intervalo' => $intervalo, - 'comentarios' => $comentarios, - 'modo' => $modo, - 'id_os' => $id_os, - 'disabled' => $disabled, - 'cascade_protection' => $cascade_protection, - 'cascade_protection_module' => $cascade_protection_module, - 'server_name' => $server_name, - 'id_parent' => $id_parent, - 'custom_id' => $custom_id, - 'os_version' => '', - 'agent_version' => '', - 'timezone_offset' => 0, - 'icon_path' => '', - 'url_address' => '', - 'update_module_count' => $update_module_count, - ] - ); - enterprise_hook('update_agent', [$id_agente]); - } else { - $id_agente = false; - } - - if ($id_agente !== false) { - // Create address for this agent in taddress. - if ($direccion_agente != '') { - agents_add_address($id_agente, $direccion_agente); - } - + if ($idGroup && !empty($idAgente)) { $tpolicy_group_old = db_get_all_rows_sql( 'SELECT id_policy FROM tpolicy_groups - WHERE id_group = '.$grupo + WHERE id_group = '.$idGroup ); if ($tpolicy_group_old) { @@ -1609,54 +1629,18 @@ function api_set_new_agent($thrash1, $thrash2, $other, $thrash3) 'tpolicy_agents', [ 'id_policy' => $old_group['id_policy'], - 'id_agent' => $id_agente, + 'id_agent' => $idAgente, ] ); } } - - $info = '{"Name":"'.$nombre_agente.'", - "IP":"'.$direccion_agente.'", - "Group":"'.$grupo.'", - "Interval":"'.$intervalo.'", - "Comments":"'.$comentarios.'", - "Mode":"'.$modo.'", - "ID_parent:":"'.$id_parent.'", - "Server":"'.$server_name.'", - "ID os":"'.$id_os.'", - "Disabled":"'.$disabled.'", - "Custom ID":"'.$custom_id.'", - "Cascade protection":"'.$cascade_protection.'", - "Cascade protection module":"'.$cascade_protection_module.'"}'; - - $unsafe_alias = io_safe_output($alias); - db_pandora_audit( - 'Agent management', - 'Created agent '.$unsafe_alias, - false, - true, - $info - ); - } else { - $id_agente = 0; - - if ($exists_alias) { - $agent_creation_error = __('Could not be created, because name already exists'); - } else if ($exists_ip) { - $agent_creation_error = __('Could not be created, because IP already exists'); - } else { - $agent_creation_error = __('Could not be created for unknown reason'); - } - - returnError('generic error', $agent_creation_error); - return; } returnData( 'string', [ 'type' => 'string', - 'data' => $id_agente, + 'data' => $idAgente, ] ); } @@ -1819,23 +1803,17 @@ function api_get_custom_field_id($t1, $t2, $other, $returnType) /** - * Delete an agent with the name as parameter. + * Delete a agent with the name pass as parameter. * * @param string $id Name of agent to delete. * @param $thrash1 Don't use. * @param $thrast2 Don't use. * @param $thrash3 Don't use. */ -function api_set_delete_agent($id, $thrash1, $other, $thrash3) +function api_set_delete_agent($id, $thrash1, $thrast2, $thrash3) { global $config; - $agent_by_alias = false; - - if ($other['data'][0] === '1') { - $agent_by_alias = true; - } - if (is_metaconsole()) { if (!check_acl($config['id_user'], 0, 'PM')) { returnError('forbidden', 'string'); @@ -1844,8 +1822,8 @@ function api_set_delete_agent($id, $thrash1, $other, $thrash3) $servers = db_get_all_rows_sql( 'SELECT * - FROM tmetaconsole_setup - WHERE disabled = 0' + FROM tmetaconsole_setup + WHERE disabled = 0' ); if ($servers === false) { @@ -1854,47 +1832,19 @@ function api_set_delete_agent($id, $thrash1, $other, $thrash3) foreach ($servers as $server) { if (metaconsole_connect($server) == NOERR) { - if ($other['data'][0] === '1') { - $idAgent[0] = agents_get_agent_id_by_alias($id); - } else { - $idAgent[0] = agents_get_agent_id($id, true); - } - + $idAgent[0] = agents_get_agent_id($id, true); if ($idAgent[0]) { $result = agents_delete_agent($idAgent, true); } - - metaconsole_restore_db(); } } } else { - if ($agent_by_alias) { - $idsAgents = agents_get_agent_id_by_alias(io_safe_input($id)); - } else { - $idAgent = agents_get_agent_id($id, true); + $idAgent = agents_get_agent_id($id); + if (!util_api_check_agent_and_print_error($idAgent, 'string', 'AD')) { + return; } - if (!$agent_by_alias) { - if (!util_api_check_agent_and_print_error($idAgent, 'string', 'AD')) { - return; - } - } - - if ($agent_by_alias) { - foreach ($idsAgents as $id) { - if (!util_api_check_agent_and_print_error($id['id_agente'], 'string', 'AD')) { - continue; - } - - $result = agents_delete_agent($id['id_agente'], true); - - if (!$result) { - break; - } - } - } else { - $result = agents_delete_agent($idAgent, true); - } + $result = agents_delete_agent($idAgent, true); } if (!$result) { @@ -1910,7 +1860,7 @@ function api_set_delete_agent($id, $thrash1, $other, $thrash3) * * @param $thrash1 Don't use. * @param $thrash2 Don't use. - * @param array $other it's array, $other as param are the filters available ;;;;; in this order + * @param array $other it's array, $other as param are the filters available ;;;;; in this order * and separator char (after text ; ) and separator (pass in param othermode as othermode=url_encode_separator_) * example for CSV: * @@ -1939,25 +1889,17 @@ function api_get_all_agents($thrash1, $thrash2, $other, $returnType) } if (isset($other['data'][0])) { - // Filter by SO. + // Filter by SO if ($other['data'][0] != '') { $where .= ' AND tconfig_os.id_os = '.$other['data'][0]; } } if (isset($other['data'][1])) { - // Filter by group. + // Filter by group if ($other['data'][1] != '') { - $ag_groups = $other['data'][1]; - // Recursion. - if ($other['data'][6] === '1') { - $ag_groups = groups_get_id_recursive($ag_groups, true); - } - - $ag_groups = implode(',', (array) $ag_groups); + $where .= ' AND id_grupo = '.$other['data'][1]; } - - $where .= ' AND (id_grupo IN ('.$ag_groups.') OR id_group IN ('.$ag_groups.'))'; } if (isset($other['data'][3])) { @@ -1987,27 +1929,24 @@ function api_get_all_agents($thrash1, $thrash2, $other, $returnType) // Initialization of array $result_agents = []; // Filter by state - if (is_metaconsole()) { - $sql = 'SELECT id_agente, alias, direccion, comentarios, + if (defined('METACONSOLE')) { + $sql = "SELECT id_agente, alias, direccion, comentarios, tconfig_os.name, url_address, nombre FROM tconfig_os, tmetaconsole_agent - LEFT JOIN tmetaconsole_agent_secondary_group - ON tmetaconsole_agent.id_agente = tmetaconsole_agent_secondary_group.id_agent + LEFT JOIN tagent_secondary_group + ON tmetaconsole_agent.id_agente = tagent_secondary_group.id_agent WHERE tmetaconsole_agent.id_os = tconfig_os.id_os - AND disabled = 0 '.$where.' AND '.$groups; + AND disabled = 0 $where AND $groups"; } else { - $sql = 'SELECT id_agente, alias, direccion, comentarios, - tconfig_os.name, url_address, nombre - FROM tconfig_os, tagente - LEFT JOIN tagent_secondary_group - ON tagente.id_agente = tagent_secondary_group.id_agent - WHERE tagente.id_os = tconfig_os.id_os - AND disabled = 0 '.$where.' AND '.$groups; + $sql = "SELECT id_agente, alias, direccion, comentarios, + tconfig_os.name, url_address, nombre + FROM tconfig_os, tagente + LEFT JOIN tagent_secondary_group + ON tagente.id_agente = tagent_secondary_group.id_agent + WHERE tagente.id_os = tconfig_os.id_os + AND disabled = 0 $where AND $groups"; } - // Group by agent - $sql .= ' GROUP BY id_agente'; - $all_agents = db_get_all_rows_sql($sql); // Filter by status: unknown, warning, critical, without modules @@ -2129,9 +2068,9 @@ function api_get_agent_modules($thrash1, $thrash2, $other, $thrash3) $sql = sprintf( 'SELECT id_agente, id_agente_modulo, nombre - FROM tagente_modulo - WHERE id_agente = %d AND disabled = 0 - AND delete_pending = 0', + FROM tagente_modulo + WHERE id_agente = %d AND disabled = 0 + AND delete_pending = 0', $other['data'][0] ); @@ -2478,9 +2417,9 @@ function api_get_module_id($id, $thrash1, $name, $thrash3) $sql = sprintf( 'SELECT id_agente_modulo - FROM tagente_modulo WHERE id_agente = %d - AND nombre = "%s" AND disabled = 0 - AND delete_pending = 0', + FROM tagente_modulo WHERE id_agente = %d + AND nombre = "%s" AND disabled = 0 + AND delete_pending = 0', $id, $name['data'] ); @@ -2520,10 +2459,10 @@ function api_get_group_agent($thrash1, $thrash2, $other, $thrash3) $sql = sprintf( 'SELECT groups.nombre nombre - FROM tagente agents, tgrupo groups - WHERE id_agente = %d AND agents.disabled = 0 - AND groups.disabled = 0 - AND agents.id_grupo = groups.id_grupo', + FROM tagente agents, tgrupo groups + WHERE id_agente = %d AND agents.disabled = 0 + AND groups.disabled = 0 + AND agents.id_grupo = groups.id_grupo', $other['data'][0] ); @@ -2562,8 +2501,8 @@ function api_get_group_agent_by_name($thrash1, $thrash2, $other, $thrash3) if (is_metaconsole()) { $servers = db_get_all_rows_sql( 'SELECT * - FROM tmetaconsole_setup - WHERE disabled = 0' + FROM tmetaconsole_setup + WHERE disabled = 0' ); if ($servers === false) { @@ -2577,9 +2516,9 @@ function api_get_group_agent_by_name($thrash1, $thrash2, $other, $thrash3) if ($agent_id) { $sql = sprintf( 'SELECT groups.nombre nombre - FROM tagente agents, tgrupo groups - WHERE id_agente = %d - AND agents.id_grupo = groups.id_grupo', + FROM tagente agents, tgrupo groups + WHERE id_agente = %d + AND agents.id_grupo = groups.id_grupo', $agent_id ); $group_server_names = db_get_all_rows_sql($sql); @@ -2602,9 +2541,9 @@ function api_get_group_agent_by_name($thrash1, $thrash2, $other, $thrash3) $sql = sprintf( 'SELECT groups.nombre nombre - FROM tagente agents, tgrupo groups - WHERE id_agente = %d - AND agents.id_grupo = groups.id_grupo', + FROM tagente agents, tgrupo groups + WHERE id_agente = %d + AND agents.id_grupo = groups.id_grupo', $agent_id ); $group_names = db_get_all_rows_sql($sql); @@ -2654,8 +2593,8 @@ function api_get_group_agent_by_alias($thrash1, $thrash2, $other, $thrash3) if (is_metaconsole()) { $servers = db_get_all_rows_sql( 'SELECT * - FROM tmetaconsole_setup - WHERE disabled = 0' + FROM tmetaconsole_setup + WHERE disabled = 0' ); if ($servers === false) { @@ -2670,9 +2609,9 @@ function api_get_group_agent_by_alias($thrash1, $thrash2, $other, $thrash3) foreach ($agent_id as &$id) { $sql = sprintf( 'SELECT groups.nombre nombre - FROM tagente agents, tgrupo groups - WHERE id_agente = %d - AND agents.id_grupo = groups.id_grupo', + FROM tagente agents, tgrupo groups + WHERE id_agente = %d + AND agents.id_grupo = groups.id_grupo', $id['id_agente'] ); $group_server_names = db_get_all_rows_sql($sql); @@ -2698,9 +2637,9 @@ function api_get_group_agent_by_alias($thrash1, $thrash2, $other, $thrash3) $sql = sprintf( 'SELECT groups.nombre nombre - FROM tagente agents, tgrupo groups - WHERE id_agente = %d - AND agents.id_grupo = groups.id_grupo', + FROM tagente agents, tgrupo groups + WHERE id_agente = %d + AND agents.id_grupo = groups.id_grupo', $id['id_agente'] ); $group_name = db_get_all_rows_sql($sql); @@ -2743,8 +2682,8 @@ function api_get_locate_agent($id, $thrash1, $thrash2, $thrash3) $servers = db_get_all_rows_sql( 'SELECT * - FROM tmetaconsole_setup - WHERE disabled = 0' + FROM tmetaconsole_setup + WHERE disabled = 0' ); if ($servers === false) { @@ -2801,8 +2740,8 @@ function api_get_id_group_agent_by_name($thrash1, $thrash2, $other, $thrash3) if (is_metaconsole()) { $servers = db_get_all_rows_sql( 'SELECT * - FROM tmetaconsole_setup - WHERE disabled = 0' + FROM tmetaconsole_setup + WHERE disabled = 0' ); if ($servers === false) { @@ -2816,9 +2755,9 @@ function api_get_id_group_agent_by_name($thrash1, $thrash2, $other, $thrash3) if ($agent_id) { $sql = sprintf( 'SELECT groups.id_grupo id_group - FROM tagente agents, tgrupo groups - WHERE id_agente = %d - AND agents.id_grupo = groups.id_grupo', + FROM tagente agents, tgrupo groups + WHERE id_agente = %d + AND agents.id_grupo = groups.id_grupo', $agent_id ); $group_server_names = db_get_all_rows_sql($sql); @@ -2842,9 +2781,9 @@ function api_get_id_group_agent_by_name($thrash1, $thrash2, $other, $thrash3) $sql = sprintf( 'SELECT groups.id_grupo id_group - FROM tagente agents, tgrupo groups - WHERE id_agente = %d - AND agents.id_grupo = groups.id_grupo', + FROM tagente agents, tgrupo groups + WHERE id_agente = %d + AND agents.id_grupo = groups.id_grupo', $agent_id ); $group_names = db_get_all_rows_sql($sql); @@ -2894,8 +2833,8 @@ function api_get_id_group_agent_by_alias($thrash1, $thrash2, $other, $thrash3) if (is_metaconsole()) { $servers = db_get_all_rows_sql( 'SELECT * - FROM tmetaconsole_setup - WHERE disabled = 0' + FROM tmetaconsole_setup + WHERE disabled = 0' ); if ($servers === false) { @@ -2910,9 +2849,9 @@ function api_get_id_group_agent_by_alias($thrash1, $thrash2, $other, $thrash3) foreach ($agent_id as &$id) { $sql = sprintf( 'SELECT groups.id_grupo id_group - FROM tagente agents, tgrupo groups - WHERE id_agente = %d - AND agents.id_grupo = groups.id_grupo', + FROM tagente agents, tgrupo groups + WHERE id_agente = %d + AND agents.id_grupo = groups.id_grupo', $id['id_agente'] ); $group_server_names = db_get_all_rows_sql($sql); @@ -2938,9 +2877,9 @@ function api_get_id_group_agent_by_alias($thrash1, $thrash2, $other, $thrash3) $sql = sprintf( 'SELECT groups.id_grupo id_group - FROM tagente agents, tgrupo groups - WHERE id_agente = %d - AND agents.id_grupo = groups.id_grupo', + FROM tagente agents, tgrupo groups + WHERE id_agente = %d + AND agents.id_grupo = groups.id_grupo', $id['id_agente'] ); $group_name = db_get_all_rows_sql($sql); @@ -2998,8 +2937,8 @@ function api_get_policies($thrash1, $thrash2, $other, $thrash3) $sql = sprintf( 'SELECT policy.id, name, id_agent - FROM tpolicies AS policy, tpolicy_agents AS pol_agents - WHERE policy.id = pol_agents.id_policy %s AND id_group IN (%s)', + FROM tpolicies AS policy, tpolicy_agents AS pol_agents + WHERE policy.id = pol_agents.id_policy %s AND id_group IN (%s)', $where, $user_groups ); @@ -3075,20 +3014,21 @@ function api_get_policy_modules($thrash1, $thrash2, $other, $thrash3) /** - * Create a network module in agent. - * And return the id_agent_module of new module. + * Create a network module in agent. And return the id_agent_module of new module. * - * @param string $id Name of agent to add the module. - * @param string $thrash1 Don't use. - * @param array $other It's array, $other as param is ;;; - * ;;;;;;;; - * ;;;;;;; - * ;;;;;; - * ;;;; in this order - * and separator char (after text ; ) and separator (pass in param othermode as othermode=url_encode_separator_). - * @param string $thrash3 Don't use. - * @example: api.php?op=set&op2=create_network_module&id=pepito&other=prueba|0|7|1|10|15|0|16|18|0|15|0|www.google.es|0||0|180|0|0|0|0|latency%20ping&other_mode=url_encode_separator_|* - * @return mixed Return. + * @param string $id Name of agent to add the module. + * @param $thrash1 Don't use. + * @param array $other it's array, $other as param is ;;; + * ;;;;;;;; + * ;;;;;;; + * ;;;;;; + * ;;;; in this order + * and separator char (after text ; ) and separator (pass in param othermode as othermode=url_encode_separator_) + * example: + * + * api.php?op=set&op2=create_network_module&id=pepito&other=prueba|0|7|1|10|15|0|16|18|0|15|0|www.google.es|0||0|180|0|0|0|0|latency%20ping&other_mode=url_encode_separator_| + * + * @param $thrash3 Don't use */ function api_set_create_network_module($id, $thrash1, $other, $thrash3) { @@ -3096,22 +3036,12 @@ function api_set_create_network_module($id, $thrash1, $other, $thrash3) return; } - $agent_by_alias = false; + $agentName = $id; - if ($other['data'][30] === '1') { - $agent_by_alias = true; - } + $idAgent = agents_get_agent_id($agentName); - if ($agent_by_alias) { - $idsAgents = agents_get_agent_id_by_alias($id); - } else { - $idAgent = agents_get_agent_id($id); - } - - if (!$agent_by_alias) { - if (!util_api_check_agent_and_print_error($idAgent, 'string', 'AW')) { - return; - } + if (!util_api_check_agent_and_print_error($idAgent, 'string', 'AW')) { + return; } if ($other['data'][2] < 6 or $other['data'][2] > 18) { @@ -3129,6 +3059,7 @@ function api_set_create_network_module($id, $thrash1, $other, $thrash3) $disabled_types_event = json_encode($disabled_types_event); $values = [ + 'id_agente' => $idAgent, 'disabled' => $other['data'][1], 'id_tipo_modulo' => $other['data'][2], 'id_module_group' => $other['data'][3], @@ -3159,43 +3090,22 @@ function api_set_create_network_module($id, $thrash1, $other, $thrash3) 'min_ff_event_critical' => $other['data'][27], 'critical_inverse' => $other['data'][28], 'warning_inverse' => $other['data'][29], - 'ff_type' => $other['data'][30], ]; if (! $values['descripcion']) { $values['descripcion'] = ''; - // Column 'descripcion' cannot be null. + // Column 'descripcion' cannot be null } if (! $values['module_macros']) { $values['module_macros'] = ''; - // Column 'module_macros' cannot be null. + // Column 'module_macros' cannot be null } - if ($agent_by_alias) { - $agents_affected = 0; - - foreach ($idsAgents as $id) { - if (!util_api_check_agent_and_print_error($id['id_agente'], 'string', 'AW')) { - continue; - } - - $idModule = modules_create_agent_module($id['id_agente'], $name, $values, true); - - if (!is_error($idModule)) { - $agents_affected++; - } - } - - returnData('string', ['type' => 'string', 'data' => $agents_affected.' agents affected']); - - return; - } else { - $idModule = modules_create_agent_module($idAgent, $name, $values, true); - } + $idModule = modules_create_agent_module($idAgent, $name, $values, true); if (is_error($idModule)) { - // TODO: Improve the error returning more info. + // TODO: Improve the error returning more info returnError('error_create_network_module', __('Error in creation network module.')); } else { returnData('string', ['type' => 'string', 'data' => $idModule]); @@ -3312,7 +3222,6 @@ function api_set_update_network_module($id_module, $thrash1, $other, $thrash3) 'critical_inverse', 'warning_inverse', 'policy_linked', - 'ff_type', ]; $values = []; @@ -3361,27 +3270,17 @@ function api_set_create_plugin_module($id, $thrash1, $other, $thrash3) return; } + $agentName = $id; + if ($other['data'][22] == '') { returnError('error_create_plugin_module', __('Error in creation plugin module. Id_plugin cannot be left blank.')); return; } - $agent_by_alias = false; + $idAgent = agents_get_agent_id($agentName); - if ($other['data'][36] === '1') { - $agent_by_alias = true; - } - - if ($agent_by_alias) { - $idsAgents = agents_get_agent_id_by_alias($id); - } else { - $idAgent = agents_get_agent_id($id); - } - - if (!$agent_by_alias) { - if (!util_api_check_agent_and_print_error($idAgent, 'string', 'AW')) { - return; - } + if (!util_api_check_agent_and_print_error($idAgent, 'string', 'AW')) { + return; } $disabled_types_event = []; @@ -3391,6 +3290,7 @@ function api_set_create_plugin_module($id, $thrash1, $other, $thrash3) $name = $other['data'][0]; $values = [ + 'id_agente' => $idAgent, 'disabled' => $other['data'][1], 'id_tipo_modulo' => $other['data'][2], 'id_module_group' => $other['data'][3], @@ -3426,43 +3326,22 @@ function api_set_create_plugin_module($id, $thrash1, $other, $thrash3) 'min_ff_event_critical' => $other['data'][32], 'critical_inverse' => $other['data'][33], 'warning_inverse' => $other['data'][34], - 'ff_type' => $other['data'][35], ]; if (! $values['descripcion']) { $values['descripcion'] = ''; - // Column 'descripcion' cannot be null. + // Column 'descripcion' cannot be null } if (! $values['module_macros']) { $values['module_macros'] = ''; - // Column 'module_macros' cannot be null. + // Column 'module_macros' cannot be null } - if ($agent_by_alias) { - $agents_affected = 0; - - foreach ($idsAgents as $id) { - if (!util_api_check_agent_and_print_error($id['id_agente'], 'string', 'AW')) { - continue; - } - - $idModule = modules_create_agent_module($id['id_agente'], $name, $values, true); - - if (!is_error($idModule)) { - $agents_affected++; - } - } - - returnData('string', ['type' => 'string', 'data' => $agents_affected.' agents affected']); - - return; - } else { - $idModule = modules_create_agent_module($idAgent, $name, $values, true); - } + $idModule = modules_create_agent_module($idAgent, $name, $values, true); if (is_error($idModule)) { - // TODO: Improve the error returning more info. + // TODO: Improve the error returning more info returnError('error_create_plugin_module', __('Error in creation plugin module.')); } else { returnData('string', ['type' => 'string', 'data' => $idModule]); @@ -3569,7 +3448,6 @@ function api_set_update_plugin_module($id_module, $thrash1, $other, $thrash3) 'critical_inverse', 'warning_inverse', 'policy_linked', - 'ff_type', ]; $values = []; @@ -3621,27 +3499,17 @@ function api_set_create_data_module($id, $thrash1, $other, $thrash3) return; } + $agentName = $id; + if ($other['data'][0] == '') { returnError('error_create_data_module', __('Error in creation data module. Module_name cannot be left blank.')); return; } - $agent_by_alias = false; + $idAgent = agents_get_agent_id($agentName); - if ($other['data'][27] === '1') { - $agent_by_alias = true; - } - - if ($agent_by_alias) { - $idsAgents = agents_get_agent_id_by_alias($id); - } else { - $idAgent = agents_get_agent_id($id); - } - - if (!$agent_by_alias) { - if (!util_api_check_agent_and_print_error($idAgent, 'string', 'AW')) { - return; - } + if (!util_api_check_agent_and_print_error($idAgent, 'string', 'AW')) { + return; } $name = $other['data'][0]; @@ -3651,6 +3519,7 @@ function api_set_create_data_module($id, $thrash1, $other, $thrash3) $disabled_types_event = json_encode($disabled_types_event); $values = [ + 'id_agente' => $idAgent, 'disabled' => $other['data'][1], 'id_tipo_modulo' => $other['data'][2], 'descripcion' => $other['data'][3], @@ -3677,43 +3546,22 @@ function api_set_create_data_module($id, $thrash1, $other, $thrash3) 'ff_timeout' => $other['data'][23], 'critical_inverse' => $other['data'][24], 'warning_inverse' => $other['data'][25], - 'ff_type' => $other['data'][26], ]; if (! $values['descripcion']) { $values['descripcion'] = ''; - // Column 'descripcion' cannot be null. + // Column 'descripcion' cannot be null } if (! $values['module_macros']) { $values['module_macros'] = ''; - // Column 'module_macros' cannot be null. + // Column 'module_macros' cannot be null } - if ($agent_by_alias) { - $agents_affected = 0; - - foreach ($idsAgents as $id) { - if (!util_api_check_agent_and_print_error($id['id_agente'], 'string', 'AW')) { - continue; - } - - $idModule = modules_create_agent_module($id['id_agente'], $name, $values, true); - - if (!is_error($idModule)) { - $agents_affected++; - } - } - - returnData('string', ['type' => 'string', 'data' => $agents_affected.' agents affected']); - - return; - } else { - $idModule = modules_create_agent_module($idAgent, $name, $values, true); - } + $idModule = modules_create_agent_module($idAgent, $name, $values, true); if (is_error($idModule)) { - // TODO: Improve the error returning more info. + // TODO: Improve the error returning more info returnError('error_create_data_module', __('Error in creation data module.')); } else { returnData('string', ['type' => 'string', 'data' => $idModule]); @@ -3735,7 +3583,7 @@ function api_set_create_data_module($id, $thrash1, $other, $thrash3) * * @param $thrash3 Don't use */ -function api_set_create_synthetic_module($id, $agent_by_alias, $other, $thrash3) +function api_set_create_synthetic_module($id, $thrash1, $other, $thrash3) { if (defined('METACONSOLE')) { return; @@ -3743,6 +3591,8 @@ function api_set_create_synthetic_module($id, $agent_by_alias, $other, $thrash3) global $config; + $agentName = $id; + io_safe_input_array($other); if ($other['data'][0] == '') { @@ -3750,34 +3600,15 @@ function api_set_create_synthetic_module($id, $agent_by_alias, $other, $thrash3) return; } - if ($agent_by_alias == '1') { - $ids_agents = agents_get_agent_id_by_alias(io_safe_output($id)); + $idAgent = agents_get_agent_id(io_safe_output($agentName), true); - foreach ($ids_agents as $id) { - if (!util_api_check_agent_and_print_error($id['id_agente'], 'string', 'AW')) { - return; - } - } - } else { - $idAgent = agents_get_agent_id(io_safe_output($id), true); - - if (!util_api_check_agent_and_print_error($idAgent, 'string', 'AW')) { - return; - } + if (!util_api_check_agent_and_print_error($idAgent, 'string', 'AW')) { + return; } - if ($agent_by_alias) { - foreach ($ids_agents as $id) { - if (!$id['id_agente']) { - returnError('error_create_data_module', __('Error in creation synthetic module. Agent name doesn\'t exist.')); - return; - } - } - } else { - if (!$idAgent) { - returnError('error_create_data_module', __('Error in creation synthetic module. Agent name doesn\'t exist.')); - return; - } + if (!$idAgent) { + returnError('error_create_data_module', __('Error in creation synthetic module. Agent name doesn\'t exist.')); + return; } $name = io_safe_output($other['data'][0]); @@ -3785,6 +3616,7 @@ function api_set_create_synthetic_module($id, $agent_by_alias, $other, $thrash3) $id_tipo_modulo = db_get_row_sql("SELECT id_tipo FROM ttipo_modulo WHERE nombre = 'generic_data'"); $values = [ + 'id_agente' => $idAgent, 'id_modulo' => 5, 'custom_integer_1' => 0, 'custom_integer_2' => 0, @@ -3794,315 +3626,154 @@ function api_set_create_synthetic_module($id, $agent_by_alias, $other, $thrash3) if (! $values['descripcion']) { $values['descripcion'] = ''; - // Column 'descripcion' cannot be null. + // Column 'descripcion' cannot be null } - if ($agent_by_alias) { - foreach ($ids_agents as $id) { - $idAgent = $id['id_agente']; + $idModule = modules_create_agent_module($idAgent, $name, $values, true); - $idModule = modules_create_agent_module($idAgent, $name, $values, true); - - if (is_error($idModule)) { - // TODO: Improve the error returning more info. - returnError('error_create_data_module', __('Error in creation data module.')); - } else { - $synthetic_type = $other['data'][1]; - unset($other['data'][0]); - unset($other['data'][1]); - - $filterdata = []; - foreach ($other['data'] as $data) { - $data = str_replace(['ADD', 'SUB', 'MUL', 'DIV'], ['+', '-', '*', '/'], $data); - $data = io_safe_output($data); - // Double safe output is necessary. - $split_data = explode(';', io_safe_output($data)); - - if (preg_match('/[x\/+*-]/', $split_data[0]) && strlen($split_data[0]) == 1) { - if (preg_match('/[\/|+|*|-]/', $split_data[0]) && $synthetic_type === 'average') { - returnError('', "[ERROR] With this type: $synthetic_type only be allow use this operator: 'x' \n\n"); - } - - $operator = strtolower($split_data[0]); - $data_module = [ - '', - $operator, - $split_data[1], - ]; - - $text_data = implode('_', $data_module); - array_push($filterdata, $text_data); - } else { - if (count($split_data) == 2) { - $idAgent = agents_get_agent_id($split_data[0], true); - $data_module = [ - $idAgent, - '', - $split_data[1], - ]; - $text_data = implode('_', $data_module); - array_push($filterdata, $text_data); - } else { - if (strlen($split_data[1]) > 1 && $synthetic_type != 'average') { - returnError('', "[ERROR] You can only use +, -, *, / or x, and you use this: @split_data[1] \n\n"); - return; - } - - if (preg_match('/[\/|+|*|-]/', $split_data[1]) && $synthetic_type === 'average') { - returnError('', "[ERROR] With this type: $synthetic_type only be allow use this operator: 'x' \n\n"); - return; - } - - $idAgent = agents_get_agent_id(io_safe_output($split_data[0]), true); - $operator = strtolower($split_data[1]); - $data_module = [ - $idAgent, - $operator, - $split_data[2], - ]; - $text_data = implode('_', $data_module); - array_push($filterdata, $text_data); - } - } - } - - $serialize_ops = implode(',', $filterdata); - - // modules_create_synthetic_operations - $synthetic = enterprise_hook( - 'modules_create_synthetic_operations', - [ - $idModule, - $serialize_ops, - ] - ); - - if ($synthetic === ENTERPRISE_NOT_HOOK) { - returnError('error_synthetic_modules', 'Error Synthetic modules.'); - db_process_sql_delete( - 'tagente_modulo', - ['id_agente_modulo' => $idModule] - ); - - return; - } else { - $status = AGENT_MODULE_STATUS_NO_DATA; - switch ($config['dbtype']) { - case 'mysql': - $result = db_process_sql_insert( - 'tagente_estado', - [ - 'id_agente_modulo' => $idModule, - 'datos' => 0, - 'timestamp' => '01-01-1970 00:00:00', - 'estado' => $status, - 'id_agente' => (int) $idAgent, - 'utimestamp' => 0, - 'status_changes' => 0, - 'last_status' => $status, - 'last_known_status' => $status, - ] - ); - break; - - case 'postgresql': - $result = db_process_sql_insert( - 'tagente_estado', - [ - 'id_agente_modulo' => $idModule, - 'datos' => 0, - 'timestamp' => null, - 'estado' => $status, - 'id_agente' => (int) $idAgent, - 'utimestamp' => 0, - 'status_changes' => 0, - 'last_status' => $status, - 'last_known_status' => $status, - ] - ); - break; - - case 'oracle': - $result = db_process_sql_insert( - 'tagente_estado', - [ - 'id_agente_modulo' => $idModule, - 'datos' => 0, - 'timestamp' => '#to_date(\'1970-01-01 00:00:00\', \'YYYY-MM-DD HH24:MI:SS\')', - 'estado' => $status, - 'id_agente' => (int) $idAgent, - 'utimestamp' => 0, - 'status_changes' => 0, - 'last_status' => $status, - 'last_known_status' => $status, - ] - ); - break; - } - - if ($result === false) { - db_process_sql_delete( - 'tagente_modulo', - ['id_agente_modulo' => $idModule] - ); - returnError('error_synthetic_modules', 'Error Synthetic modules.'); - } else { - db_process_sql('UPDATE tagente SET total_count=total_count+1, notinit_count=notinit_count+1 WHERE id_agente='.(int) $idAgent); - returnData('string', ['type' => 'string', 'data' => __('Synthetic module created ID: '.$idModule)]); - } - } - } - } + if (is_error($idModule)) { + // TODO: Improve the error returning more info + returnError('error_create_data_module', __('Error in creation data module.')); } else { - $idModule = modules_create_agent_module($idAgent, $name, $values, true); + $synthetic_type = $other['data'][1]; + unset($other['data'][0]); + unset($other['data'][1]); - if (is_error($idModule)) { - // TODO: Improve the error returning more info - returnError('error_create_data_module', __('Error in creation data module.')); - } else { - $synthetic_type = $other['data'][1]; - unset($other['data'][0]); - unset($other['data'][1]); + $filterdata = []; + foreach ($other['data'] as $data) { + $data = str_replace(['ADD', 'SUB', 'MUL', 'DIV'], ['+', '-', '*', '/'], $data); + $split_data = explode(';', $data); - $filterdata = []; - foreach ($other['data'] as $data) { - $data = str_replace(['ADD', 'SUB', 'MUL', 'DIV'], ['+', '-', '*', '/'], $data); - $data = io_safe_output($data); - // Double safe output is necessary. - $split_data = explode(';', io_safe_output($data)); + if (preg_match('/[x\/+*-]/', $split_data[0]) && strlen($split_data[0]) == 1) { + if (preg_match('/[\/|+|*|-]/', $split_data[0]) && $synthetic_type === 'average') { + returnError('', "[ERROR] With this type: $synthetic_type only be allow use this operator: 'x' \n\n"); + } - if (preg_match('/[x\/+*-]/', $split_data[0]) && strlen($split_data[0]) == 1) { - if (preg_match('/[\/|+|*|-]/', $split_data[0]) && $synthetic_type === 'average') { - returnError('', "[ERROR] With this type: $synthetic_type only be allow use this operator: 'x' \n\n"); - } + $operator = strtolower($split_data[0]); + $data_module = [ + '', + $operator, + $split_data[1], + ]; - $operator = strtolower($split_data[0]); + $text_data = implode('_', $data_module); + array_push($filterdata, $text_data); + } else { + if (count($split_data) == 2) { + $idAgent = agents_get_agent_id(io_safe_output($split_data[0]), true); $data_module = [ + $idAgent, '', - $operator, $split_data[1], ]; - $text_data = implode('_', $data_module); array_push($filterdata, $text_data); } else { - if (count($split_data) == 2) { - $idAgent = agents_get_agent_id($split_data[0], true); - $data_module = [ - $idAgent, - '', - $split_data[1], - ]; - $text_data = implode('_', $data_module); - array_push($filterdata, $text_data); - } else { - if (strlen($split_data[1]) > 1 && $synthetic_type != 'average') { - returnError('', "[ERROR] You can only use +, -, *, / or x, and you use this: @split_data[1] \n\n"); - return; - } - - if (preg_match('/[\/|+|*|-]/', $split_data[1]) && $synthetic_type === 'average') { - returnError('', "[ERROR] With this type: $synthetic_type only be allow use this operator: 'x' \n\n"); - return; - } - - $idAgent = agents_get_agent_id(io_safe_output($split_data[0]), true); - $operator = strtolower($split_data[1]); - $data_module = [ - $idAgent, - $operator, - $split_data[2], - ]; - $text_data = implode('_', $data_module); - array_push($filterdata, $text_data); + if (strlen($split_data[1]) > 1 && $synthetic_type != 'average') { + returnError('', "[ERROR] You can only use +, -, *, / or x, and you use this: @split_data[1] \n\n"); + return; } + + if (preg_match('/[\/|+|*|-]/', $split_data[1]) && $synthetic_type === 'average') { + returnError('', "[ERROR] With this type: $synthetic_type only be allow use this operator: 'x' \n\n"); + return; + } + + $idAgent = agents_get_agent_id(io_safe_output($split_data[0]), true); + $operator = strtolower($split_data[1]); + $data_module = [ + $idAgent, + $operator, + $split_data[2], + ]; + $text_data = implode('_', $data_module); + array_push($filterdata, $text_data); } } + } - $serialize_ops = implode(',', $filterdata); + $serialize_ops = implode(',', $filterdata); - // modules_create_synthetic_operations - $synthetic = enterprise_hook( - 'modules_create_synthetic_operations', - [ - $idModule, - $serialize_ops, - ] + // modules_create_synthetic_operations + $synthetic = enterprise_hook( + 'modules_create_synthetic_operations', + [ + $idModule, + $serialize_ops, + ] + ); + + if ($synthetic === ENTERPRISE_NOT_HOOK) { + returnError('error_synthetic_modules', 'Error Synthetic modules.'); + db_process_sql_delete( + 'tagente_modulo', + ['id_agente_modulo' => $idModule] ); + return; + } else { + $status = AGENT_MODULE_STATUS_NO_DATA; + switch ($config['dbtype']) { + case 'mysql': + $result = db_process_sql_insert( + 'tagente_estado', + [ + 'id_agente_modulo' => $idModule, + 'datos' => 0, + 'timestamp' => '01-01-1970 00:00:00', + 'estado' => $status, + 'id_agente' => (int) $idAgent, + 'utimestamp' => 0, + 'status_changes' => 0, + 'last_status' => $status, + 'last_known_status' => $status, + ] + ); + break; - if ($synthetic === ENTERPRISE_NOT_HOOK) { - returnError('error_synthetic_modules', 'Error Synthetic modules.'); + case 'postgresql': + $result = db_process_sql_insert( + 'tagente_estado', + [ + 'id_agente_modulo' => $idModule, + 'datos' => 0, + 'timestamp' => null, + 'estado' => $status, + 'id_agente' => (int) $idAgent, + 'utimestamp' => 0, + 'status_changes' => 0, + 'last_status' => $status, + 'last_known_status' => $status, + ] + ); + break; + + case 'oracle': + $result = db_process_sql_insert( + 'tagente_estado', + [ + 'id_agente_modulo' => $idModule, + 'datos' => 0, + 'timestamp' => '#to_date(\'1970-01-01 00:00:00\', \'YYYY-MM-DD HH24:MI:SS\')', + 'estado' => $status, + 'id_agente' => (int) $idAgent, + 'utimestamp' => 0, + 'status_changes' => 0, + 'last_status' => $status, + 'last_known_status' => $status, + ] + ); + break; + } + + if ($result === false) { db_process_sql_delete( 'tagente_modulo', ['id_agente_modulo' => $idModule] ); - - return; + returnError('error_synthetic_modules', 'Error Synthetic modules.'); } else { - $status = AGENT_MODULE_STATUS_NO_DATA; - switch ($config['dbtype']) { - case 'mysql': - $result = db_process_sql_insert( - 'tagente_estado', - [ - 'id_agente_modulo' => $idModule, - 'datos' => 0, - 'timestamp' => '01-01-1970 00:00:00', - 'estado' => $status, - 'id_agente' => (int) $idAgent, - 'utimestamp' => 0, - 'status_changes' => 0, - 'last_status' => $status, - 'last_known_status' => $status, - ] - ); - break; - - case 'postgresql': - $result = db_process_sql_insert( - 'tagente_estado', - [ - 'id_agente_modulo' => $idModule, - 'datos' => 0, - 'timestamp' => null, - 'estado' => $status, - 'id_agente' => (int) $idAgent, - 'utimestamp' => 0, - 'status_changes' => 0, - 'last_status' => $status, - 'last_known_status' => $status, - ] - ); - break; - - case 'oracle': - $result = db_process_sql_insert( - 'tagente_estado', - [ - 'id_agente_modulo' => $idModule, - 'datos' => 0, - 'timestamp' => '#to_date(\'1970-01-01 00:00:00\', \'YYYY-MM-DD HH24:MI:SS\')', - 'estado' => $status, - 'id_agente' => (int) $idAgent, - 'utimestamp' => 0, - 'status_changes' => 0, - 'last_status' => $status, - 'last_known_status' => $status, - ] - ); - break; - } - - if ($result === false) { - db_process_sql_delete( - 'tagente_modulo', - ['id_agente_modulo' => $idModule] - ); - returnError('error_synthetic_modules', 'Error Synthetic modules.'); - } else { - db_process_sql('UPDATE tagente SET total_count=total_count+1, notinit_count=notinit_count+1 WHERE id_agente='.(int) $idAgent); - returnData('string', ['type' => 'string', 'data' => __('Synthetic module created ID: '.$idModule)]); - } + db_process_sql('UPDATE tagente SET total_count=total_count+1, notinit_count=notinit_count+1 WHERE id_agente='.(int) $idAgent); + returnData('string', ['type' => 'string', 'data' => __('Synthetic module created ID: '.$idModule)]); } } } @@ -4199,7 +3870,6 @@ function api_set_update_data_module($id_module, $thrash1, $other, $thrash3) 'critical_inverse', 'warning_inverse', 'policy_linked', - 'ff_type', ]; $values = []; @@ -4253,6 +3923,8 @@ function api_set_create_snmp_module($id, $thrash1, $other, $thrash3) return; } + $agentName = $id; + if ($other['data'][0] == '') { returnError('error_create_snmp_module', __('Error in creation SNMP module. Module_name cannot be left blank.')); return; @@ -4263,22 +3935,10 @@ function api_set_create_snmp_module($id, $thrash1, $other, $thrash3) return; } - $agent_by_alias = false; + $idAgent = agents_get_agent_id($agentName); - if ($other['data'][35] === '1') { - $agent_by_alias = true; - } - - if ($agent_by_alias) { - $idsAgents = agents_get_agent_id_by_alias($id); - } else { - $idAgent = agents_get_agent_id($id); - } - - if (!$agent_by_alias) { - if (!util_api_check_agent_and_print_error($idAgent, 'string', 'AW')) { - return; - } + if (!util_api_check_agent_and_print_error($idAgent, 'string', 'AW')) { + return; } $name = $other['data'][0]; @@ -4287,7 +3947,7 @@ function api_set_create_snmp_module($id, $thrash1, $other, $thrash3) $disabled_types_event[EVENTS_GOING_UNKNOWN] = (int) !$other['data'][27]; $disabled_types_event = json_encode($disabled_types_event); - // SNMP version 3. + // SNMP version 3 if ($other['data'][14] == '3') { if ($other['data'][23] != 'AES' and $other['data'][23] != 'DES') { returnError('error_create_snmp_module', __('Error in creation SNMP module. snmp3_priv_method doesn\'t exist. Set it to \'AES\' or \'DES\'. ')); @@ -4305,6 +3965,7 @@ function api_set_create_snmp_module($id, $thrash1, $other, $thrash3) } $values = [ + 'id_agente' => $idAgent, 'disabled' => $other['data'][1], 'id_tipo_modulo' => $other['data'][2], 'id_module_group' => $other['data'][3], @@ -4339,10 +4000,10 @@ function api_set_create_snmp_module($id, $thrash1, $other, $thrash3) 'min_ff_event_normal' => $other['data'][31], 'min_ff_event_warning' => $other['data'][32], 'min_ff_event_critical' => $other['data'][33], - 'ff_type' => $other['data'][34], ]; } else { $values = [ + 'id_agente' => $idAgent, 'disabled' => $other['data'][1], 'id_tipo_modulo' => $other['data'][2], 'id_module_group' => $other['data'][3], @@ -4371,36 +4032,15 @@ function api_set_create_snmp_module($id, $thrash1, $other, $thrash3) 'min_ff_event_normal' => $other['data'][25], 'min_ff_event_warning' => $other['data'][26], 'min_ff_event_critical' => $other['data'][27], - 'ff_type' => $other['data'][28], ]; } if (! $values['descripcion']) { $values['descripcion'] = ''; - // Column 'descripcion' cannot be null. + // Column 'descripcion' cannot be null } - if ($agent_by_alias) { - $agents_affected = 0; - - foreach ($idsAgents as $id) { - if (!util_api_check_agent_and_print_error($id['id_agente'], 'string', 'AW')) { - continue; - } - - $idModule = modules_create_agent_module($id['id_agente'], $name, $values, true); - - if (!is_error($idModule)) { - $agents_affected++; - } - } - - returnData('string', ['type' => 'string', 'data' => $agents_affected.' agents affected']); - - return; - } else { - $idModule = modules_create_agent_module($idAgent, $name, $values, true); - } + $idModule = modules_create_agent_module($idAgent, $name, $values, true); if (is_error($idModule)) { // TODO: Improve the error returning more info @@ -4540,7 +4180,6 @@ function api_set_update_snmp_module($id_module, $thrash1, $other, $thrash3) 'min_ff_event_warning', 'min_ff_event_critical', 'policy_linked', - 'ff_type', ]; } else { $snmp_module_fields = [ @@ -4572,7 +4211,6 @@ function api_set_update_snmp_module($id_module, $thrash1, $other, $thrash3) 'min_ff_event_warning', 'min_ff_event_critical', 'policy_linked', - 'ff_type', ]; } @@ -4670,7 +4308,6 @@ function api_set_new_network_component($id, $thrash1, $other, $thrash2) 'min_ff_event_normal' => $other['data'][20], 'min_ff_event_warning' => $other['data'][21], 'min_ff_event_critical' => $other['data'][22], - 'ff_type' => $other['data'][23], ]; $name_check = db_get_value('name', 'tnetwork_component', 'name', $id); @@ -4771,7 +4408,6 @@ function api_set_new_plugin_component($id, $thrash1, $other, $thrash2) 'min_ff_event_normal' => $other['data'][24], 'min_ff_event_warning' => $other['data'][25], 'min_ff_event_critical' => $other['data'][26], - 'ff_type' => $other['data'][27], ]; $name_check = db_get_value('name', 'tnetwork_component', 'name', $id); @@ -4907,7 +4543,6 @@ function api_set_new_snmp_component($id, $thrash1, $other, $thrash2) 'min_ff_event_normal' => $other['data'][29], 'min_ff_event_warning' => $other['data'][30], 'min_ff_event_critical' => $other['data'][31], - 'ff_type' => $other['data'][32], ]; } else { $values = [ @@ -4939,7 +4574,6 @@ function api_set_new_snmp_component($id, $thrash1, $other, $thrash2) 'min_ff_event_normal' => $other['data'][25], 'min_ff_event_warning' => $other['data'][26], 'min_ff_event_critical' => $other['data'][27], - 'ff_type' => $other['data'][28], ]; } @@ -5020,7 +4654,6 @@ function api_set_new_local_component($id, $thrash1, $other, $thrash2) 'min_ff_event_warning' => $other['data'][8], 'min_ff_event_critical' => $other['data'][9], 'ff_timeout' => $other['data'][10], - 'ff_type' => $other['data'][11], ]; $name_check = enterprise_hook( @@ -5110,9 +4743,9 @@ function api_get_module_value_all_agents($id, $thrash1, $other, $thrash2) $sql = sprintf( "SELECT agent.id_agente, agent.alias, module_state.datos, agent.nombre - FROM tagente agent LEFT JOIN tagent_secondary_group tasg ON agent.id_agente = tasg.id_agent, tagente_modulo module, tagente_estado module_state - WHERE agent.id_agente = module.id_agente AND module.id_agente_modulo=module_state.id_agente_modulo AND module.nombre = '%s' - AND %s", + FROM tagente agent LEFT JOIN tagent_secondary_group tasg ON agent.id_agente = tasg.id_agent, tagente_modulo module, tagente_estado module_state + WHERE agent.id_agente = module.id_agente AND module.id_agente_modulo=module_state.id_agente_modulo AND module.nombre = '%s' + AND %s", $id, $groups ); @@ -5739,48 +5372,20 @@ function api_get_plugins($thrash1, $thrash2, $other, $thrash3) * @param $thrash1 Don't use * @param $thrash2 Don't use */ -function api_set_create_network_module_from_component($agent_name, $component_name, $other, $thrash2) +function api_set_create_network_module_from_component($agent_name, $component_name, $thrash1, $thrash2) { if (defined('METACONSOLE')) { return; } - $agent_by_alias = false; - - if ($other['data'][0] === '1') { - $agent_by_alias = true; + $agent_id = agents_get_agent_id($agent_name); + if (!util_api_check_agent_and_print_error($agent_id, 'string', 'AW')) { + return; } - if ($agent_by_alias) { - $ids_agents = agents_get_agent_id_by_alias($agent_name); - } else { - $agent_id = agents_get_agent_id($agent_name); - } - - if ($agent_by_alias) { - foreach ($ids_agents as $id) { - if (!util_api_check_agent_and_print_error($id['id_agente'], 'string', 'AW')) { - return; - } - } - } else { - if (!util_api_check_agent_and_print_error($agent_id, 'string', 'AW')) { - return; - } - } - - if ($agent_by_alias) { - foreach ($ids_agents as $id) { - if (!$id['id_agente']) { - returnError('error_network_module_from_component', __('Error creating module from network component. Agent doesn\'t exist.')); - return; - } - } - } else { - if (!$agent_id) { - returnError('error_network_module_from_component', __('Error creating module from network component. Agent doesn\'t exist.')); - return; - } + if (!$agent_id) { + returnError('error_network_module_from_component', __('Error creating module from network component. Agent doesn\'t exist.')); + return; } $component = db_get_row('tnetwork_component', 'name', $component_name); @@ -5801,29 +5406,14 @@ function api_set_create_network_module_from_component($agent_name, $component_na $component['ip_target'] = agents_get_address($agent_id); // Create module - if ($agent_by_alias) { - $agents_affected = 0; + $module_id = modules_create_agent_module($agent_id, $component_name, $component, true); - foreach ($ids_agents as $id) { - $module_id = modules_create_agent_module($id['id_agente'], $component_name, $component, true); - - if ($module_id) { - $agents_affected++; - } - } - - returnData('string', ['type' => 'string', 'data' => __('%d agents affected', $agents_affected)]); + if (!$module_id) { + returnError('error_network_module_from_component', __('Error creating module from network component. Error creating module.')); return; - } else { - $module_id = modules_create_agent_module($agent_id, $component_name, $component, true); - - if (!$module_id) { - returnError('error_network_module_from_component', __('Error creating module from network component. Error creating module.')); - return; - } - - return $module_id; } + + return $module_id; } @@ -5962,7 +5552,7 @@ function api_set_delete_module_template($id, $thrash1, $other, $thrash3) /** - * Delete a module assigned to a template and return a message with the result of the operation. + * Delete an module assigned to a template. And return a message with the result of the operation. * * @param $id Agent Name * @param $id2 Alert Template Name @@ -5983,6 +5573,11 @@ function api_set_delete_module_template_by_names($id, $id2, $other, $trash1) $result = 0; + if ($other['type'] != 'string') { + returnError('error_parameter', 'Error in the parameters.'); + return; + } + if (! check_acl($config['id_user'], 0, 'AD') && ! check_acl($config['id_user'], 0, 'LM') ) { @@ -5990,26 +5585,10 @@ function api_set_delete_module_template_by_names($id, $id2, $other, $trash1) return; } - $agent_by_alias = false; + $idAgent = agents_get_agent_id($id); - if ($other['data'][1] === '1') { - $agent_by_alias = true; - } - - if ($agent_by_alias) { - $idsAgents = agents_get_agent_id_by_alias($id); - - foreach ($idsAgents as $id) { - if (!util_api_check_agent_and_print_error($id['id_agente'], 'string', 'AD')) { - return; - } - } - } else { - $idAgent = agents_get_agent_id($id); - - if (!util_api_check_agent_and_print_error($idAgent, 'string', 'AD')) { - return; - } + if (!util_api_check_agent_and_print_error($idAgent, 'string', 'AD')) { + return; } $row = db_get_row_filter('talert_templates', ['name' => $id2]); @@ -6022,50 +5601,25 @@ function api_set_delete_module_template_by_names($id, $id2, $other, $trash1) $idTemplate = $row['id']; $idActionTemplate = $row['id_alert_action']; - $delete_count = 0; + $idAgentModule = db_get_value_filter('id_agente_modulo', 'tagente_modulo', ['id_agente' => $idAgent, 'nombre' => $other['data']]); - if ($agent_by_alias) { - foreach ($idsAgents as $id) { - $idAgentModule = db_get_value_filter('id_agente_modulo', 'tagente_modulo', ['id_agente' => $id['id_agente'], 'nombre' => $other['data'][0]]); + if ($idAgentModule === false) { + returnError('error_parameter', 'Error in the parameters.'); + return; + } - if ($idAgentModule === false) { - continue; - } + $values = [ + 'id_agent_module' => $idAgentModule, + 'id_alert_template' => $idTemplate, + ]; - $values = [ - 'id_agent_module' => $idAgentModule, - 'id_alert_template' => $idTemplate, - ]; + $result = db_process_sql_delete('talert_template_modules', $values); - $result = db_process_sql_delete('talert_template_modules', $values); - - if ($result != 0) { - $delete_count++; - } - } - - returnError('error_delete_module_template_by_name', __('Module template has been deleted in %d agents.', $delete_count)); + if ($result == 0) { + // TODO: Improve the error returning more info + returnError('error_delete_module_template_by_name', __('Error deleting module template.')); } else { - $idAgentModule = db_get_value_filter('id_agente_modulo', 'tagente_modulo', ['id_agente' => $idAgent, 'nombre' => $other['data'][0]]); - - if ($idAgentModule === false) { - returnError('error_parameter', 'Error in the parameters1.'); - return; - } - - $values = [ - 'id_agent_module' => $idAgentModule, - 'id_alert_template' => $idTemplate, - ]; - - $result = db_process_sql_delete('talert_template_modules', $values); - - if ($result == 0) { - // TODO: Improve the error returning more info - returnError('error_delete_module_template_by_name', __('Error deleting module template.')); - } else { - returnData('string', ['type' => 'string', 'data' => __('Correct deleting of module template.')]); - } + returnData('string', ['type' => 'string', 'data' => __('Correct deleting of module template.')]); } } @@ -6108,15 +5662,15 @@ function api_set_validate_all_alerts($id, $thrash1, $other, $thrash3) $sql = sprintf( ' - SELECT talert_template_modules.id - FROM talert_template_modules - INNER JOIN tagente_modulo t2 - ON talert_template_modules.id_agent_module = t2.id_agente_modulo - INNER JOIN tagente t3 - ON t2.id_agente = t3.id_agente - INNER JOIN talert_templates t4 - ON talert_template_modules.id_alert_template = t4.id - WHERE t3.id_agente in (%s)', + SELECT talert_template_modules.id + FROM talert_template_modules + INNER JOIN tagente_modulo t2 + ON talert_template_modules.id_agent_module = t2.id_agente_modulo + INNER JOIN tagente t3 + ON t2.id_agente = t3.id_agente + INNER JOIN talert_templates t4 + ON talert_template_modules.id_alert_template = t4.id + WHERE t3.id_agente in (%s)', $agents_string ); @@ -6204,9 +5758,9 @@ function api_set_validate_all_policy_alerts($id, $thrash1, $other, $thrash3) if (count($result_pol_alerts) != 0) { $sql = sprintf( ' - SELECT id - FROM talert_template_modules - WHERE id_policy_alerts IN (%s)', + SELECT id + FROM talert_template_modules + WHERE id_policy_alerts IN (%s)', $id_pol_alerts ); @@ -6661,8 +6215,9 @@ function api_set_planned_downtimes_created($id, $thrash1, $other, $thrash3) return; } - $date_from = strtotime(html_entity_decode($other['data'][1].' '.$other['data'][11])); - $date_to = strtotime(html_entity_decode($other['data'][2].' '.$other['data'][12])); + $date_from = strtotime(html_entity_decode($other['data'][1])); + $date_to = strtotime(html_entity_decode($other['data'][2])); + $values = []; $values['name'] = $id; $values = [ @@ -6854,7 +6409,6 @@ function api_set_add_data_module_policy($id, $thrash1, $other, $thrash3) $values['min_ff_event_warning'] = $other['data'][21]; $values['min_ff_event_critical'] = $other['data'][22]; $values['ff_timeout'] = $other['data'][23]; - $values['ff_type'] = $other['data'][24]; if ($name_module_policy !== false) { if ($name_module_policy[0]['name'] == $other['data'][0]) { @@ -7096,7 +6650,6 @@ function api_set_add_network_module_policy($id, $thrash1, $other, $thrash3) $values['min_ff_event_normal'] = $other['data'][24]; $values['min_ff_event_warning'] = $other['data'][25]; $values['min_ff_event_critical'] = $other['data'][26]; - $values['ff_type'] = $other['data'][27]; if ($name_module_policy !== false) { if ($name_module_policy[0]['name'] == $other['data'][0]) { @@ -7155,7 +6708,7 @@ function api_set_update_network_module_policy($id, $thrash1, $other, $thrash3) return; } - // Check if the module exists. + // Check if the module exists $module_policy = enterprise_hook('policies_get_modules', [$id, ['id' => $other['data'][0]], 'id_module']); if ($module_policy === false) { @@ -7262,7 +6815,7 @@ function api_set_add_plugin_module_policy($id, $thrash1, $other, $thrash3) return; } - // Check if the module is already in the policy. + // Check if the module is already in the policy $name_module_policy = enterprise_hook('policies_get_modules', [$id, ['name' => $other['data'][0]], 'name']); if ($name_module_policy === ENTERPRISE_NOT_HOOK) { @@ -7306,7 +6859,6 @@ function api_set_add_plugin_module_policy($id, $thrash1, $other, $thrash3) $values['min_ff_event_normal'] = $other['data'][29]; $values['min_ff_event_warning'] = $other['data'][30]; $values['min_ff_event_critical'] = $other['data'][31]; - $values['ff_type'] = $other['data'][32]; if ($name_module_policy !== false) { if ($name_module_policy[0]['name'] == $other['data'][0]) { @@ -7366,7 +6918,7 @@ function api_set_update_plugin_module_policy($id, $thrash1, $other, $thrash3) return; } - // Check if the module exists. + // Check if the module exists $module_policy = enterprise_hook('policies_get_modules', [$id, ['id' => $other['data'][0]], 'id_module']); if ($module_policy === false) { @@ -7471,10 +7023,10 @@ function api_set_add_module_in_conf($id_agent, $module_name, $configuration_data $new_configuration_data = io_safe_output(urldecode($configuration_data['data'])); - // Check if exist a current module with the same name in the conf file. + // Check if exist a current module with the same name in the conf file $old_configuration_data = config_agents_get_module_from_conf($id_agent, io_safe_output($module_name)); - // If exists a module with same name, abort. + // If exists a module with same name, abort if (!empty($old_configuration_data)) { returnError('error_adding_module_conf', '-2'); exit; @@ -7593,7 +7145,7 @@ function api_set_update_module_in_conf($id_agent, $module_name, $configuration_d $new_configuration_data = io_safe_output(urldecode($configuration_data_serialized['data'])); - // Get current configuration. + // Get current configuration $old_configuration_data = config_agents_get_module_from_conf($id_agent, io_safe_output($module_name)); // If not exists @@ -7602,7 +7154,7 @@ function api_set_update_module_in_conf($id_agent, $module_name, $configuration_d exit; } - // If current configuration and new configuration are equal, abort. + // If current configuration and new configuration are equal, abort if ($new_configuration_data == $old_configuration_data) { returnData('string', ['type' => 'string', 'data' => '1']); exit; @@ -7724,7 +7276,6 @@ function api_set_add_snmp_module_policy($id, $thrash1, $other, $thrash3) 'min_ff_event_normal' => $other['data'][30], 'min_ff_event_warning' => $other['data'][31], 'min_ff_event_critical' => $other['data'][32], - 'ff_type' => $other['data'][33], ]; } else { $values = [ @@ -7754,7 +7305,6 @@ function api_set_add_snmp_module_policy($id, $thrash1, $other, $thrash3) 'min_ff_event_normal' => $other['data'][24], 'min_ff_event_warning' => $other['data'][25], 'min_ff_event_critical' => $other['data'][26], - 'ff_type' => $other['data'][27], ]; } @@ -8095,8 +7645,8 @@ function api_set_create_group($id, $thrash1, $other, $thrash3) if (defined('METACONSOLE')) { $servers = db_get_all_rows_sql( 'SELECT * - FROM tmetaconsole_setup - WHERE disabled = 0' + FROM tmetaconsole_setup + WHERE disabled = 0' ); if ($servers === false) { @@ -8385,10 +7935,10 @@ function api_get_module_data($id, $thrash1, $other, $returnType) $sql = sprintf( 'SELECT utimestamp, datos - FROM tagente_datos - WHERE id_agente_modulo = %d AND utimestamp > %d - AND utimestamp < %d - ORDER BY utimestamp DESC', + FROM tagente_datos + WHERE id_agente_modulo = %d AND utimestamp > %d + AND utimestamp < %d + ORDER BY utimestamp DESC', $id, $date_start, $date_end @@ -8397,17 +7947,17 @@ function api_get_module_data($id, $thrash1, $other, $returnType) if ($periodSeconds == null) { $sql = sprintf( 'SELECT utimestamp, datos - FROM tagente_datos - WHERE id_agente_modulo = %d - ORDER BY utimestamp DESC', + FROM tagente_datos + WHERE id_agente_modulo = %d + ORDER BY utimestamp DESC', $id ); } else { $sql = sprintf( 'SELECT utimestamp, datos - FROM tagente_datos - WHERE id_agente_modulo = %d AND utimestamp > %d - ORDER BY utimestamp DESC', + FROM tagente_datos + WHERE id_agente_modulo = %d AND utimestamp > %d + ORDER BY utimestamp DESC', $id, (get_system_time() - $periodSeconds) ); @@ -8726,7 +8276,7 @@ function api_set_enable_disable_user($id, $thrash2, $other, $thrash3) } -function otherParameter2Filter($other, $return_as_array=false, $use_agent_name=false) +function otherParameter2Filter($other, $return_as_array=false) { $filter = []; @@ -8734,28 +8284,14 @@ function otherParameter2Filter($other, $return_as_array=false, $use_agent_name=f $filter['criticity'] = $other['data'][1]; } + $idAgent = null; if (isset($other['data'][2]) && $other['data'][2] != '') { - if ($use_agent_name === false) { - $idAgents = agents_get_agent_id_by_alias($other['data'][2]); + $idAgents = agents_get_agent_id_by_alias($other['data'][2]); - if (!empty($idAgents)) { - $idAgent = []; - foreach ($idAgents as $key => $value) { - $idAgent[] .= $value['id_agente']; - } - - $filter[] = 'id_agente IN ('.implode(',', $idAgent).')'; - } else { - $filter['sql'] = '1=0'; - } + if (!empty($idAgent)) { + $filter[] = 'id_agente IN ('.explode(',', $idAgents).')'; } else { - $idAgent = agents_get_agent_id($other['data'][2]); - - if (!empty($idAgent)) { - $filter[] = 'id_agente = '.$idAgent; - } else { - $filter['sql'] = '1=0'; - } + $filter['sql'] = '1=0'; } } @@ -8766,21 +8302,9 @@ function otherParameter2Filter($other, $return_as_array=false, $use_agent_name=f $filterModule['id_agente'] = $idAgent; } - $idAgentModulo = db_get_all_rows_filter('tagente_modulo', $filterModule, 'id_agente_modulo'); - - if (!empty($idAgentModulo)) { - $id_agentmodule = []; - foreach ($idAgentModulo as $key => $value) { - $id_agentmodule[] .= $value['id_agente_modulo']; - } - - $idAgentModulo = $id_agentmodule; - if ($idAgentModulo !== false) { - $filter['id_agentmodule'] = $idAgentModulo; - } - } else { - // If the module doesn't exist or doesn't exist in that agent. - $filter['sql'] = '1=0'; + $idAgentModulo = db_get_value_filter('id_agente_modulo', 'tagente_modulo', $filterModule); + if ($idAgentModulo !== false) { + $filter['id_agentmodule'] = $idAgentModulo; } } @@ -8869,11 +8393,13 @@ function otherParameter2Filter($other, $return_as_array=false, $use_agent_name=f if ($other['data'][12] == 'more_criticity') { $filter['more_criticity'] = true; } + } else { } } else { if ($return_as_array) { $filter['total'] = false; $filter['more_criticity'] = false; + } else { } } @@ -8881,7 +8407,7 @@ function otherParameter2Filter($other, $return_as_array=false, $use_agent_name=f if ($return_as_array) { $filter['id_group'] = $other['data'][13]; } else { - $filterString .= ' AND id_grupo = '.$other['data'][13]; + $filterString .= ' AND id_grupo ='.$other['data'][13]; } } @@ -8901,7 +8427,7 @@ function otherParameter2Filter($other, $return_as_array=false, $use_agent_name=f if ($event_type == 'not_normal') { $filterString .= " AND ( event_type LIKE '%warning%' - OR event_type LIKE '%critical%' OR event_type LIKE '%unknown%' ) "; + OR event_type LIKE '%critical%' OR event_type LIKE '%unknown%' ) "; } else { $filterString .= ' AND event_type LIKE "%'.$event_type.'%"'; } @@ -8937,91 +8463,48 @@ function api_set_new_alert_template($id, $id2, $other, $trash1) } if ($other['type'] == 'string') { - returnError('error_parameter', 'Error in the parameters0.'); + returnError('error_parameter', 'Error in the parameters.'); return; } else if ($other['type'] == 'array') { - $agent_by_alias = false; + $idAgent = agents_get_agent_id($id); - if ($other['data'][1] === '1') { - $agent_by_alias = true; - } - - if ($agent_by_alias) { - $idsAgents = agents_get_agent_id_by_alias($id); - } else { - $idAgent = agents_get_agent_id($id); - } - - if ($agent_by_alias) { - foreach ($idsAgents as $id) { - if (!util_api_check_agent_and_print_error($id['id_agente'], 'string', 'AW')) { - return; - } - } - } else { - if (!util_api_check_agent_and_print_error($idAgent, 'string', 'AW')) { - return; - } + if (!util_api_check_agent_and_print_error($idAgent, 'string', 'AW')) { + return; } $row = db_get_row_filter('talert_templates', ['name' => $id2]); if ($row === false) { - returnError('error_parameter', 'Error in the parameters1.'); + returnError('error_parameter', 'Error in the parameters.'); return; } $idTemplate = $row['id']; $idActionTemplate = $row['id_alert_action']; - $inserted_count = 0; + $idAgentModule = db_get_value_filter('id_agente_modulo', 'tagente_modulo', ['id_agente' => $idAgent, 'nombre' => $other['data'][0]]); - if ($agent_by_alias) { - foreach ($idsAgents as $id) { - $idAgentModule = db_get_value_filter('id_agente_modulo', 'tagente_modulo', ['id_agente' => $id['id_agente'], 'nombre' => $other['data'][0]]); - - if ($idAgentModule === false) { - continue; - } - - $values = [ - 'id_agent_module' => $idAgentModule, - 'id_alert_template' => $idTemplate, - ]; - - $return = db_process_sql_insert('talert_template_modules', $values); - - if ($return != false) { - $inserted_count++; - } - } - - returnData('string', ['type' => 'string', 'data' => __('Template have been inserted in %d agents.', $inserted_count)]); - } else { - $idAgentModule = db_get_value_filter('id_agente_modulo', 'tagente_modulo', ['id_agente' => $idAgent, 'nombre' => $other['data'][0]]); - - if ($idAgentModule === false) { - returnError('error_parameter', 'Error in the parameter2s.'); - return; - } - - $values = [ - 'id_agent_module' => $idAgentModule, - 'id_alert_template' => $idTemplate, - ]; - - $return = db_process_sql_insert('talert_template_modules', $values); - - $data['type'] = 'string'; - if ($return === false) { - $data['data'] = 0; - } else { - $data['data'] = $return; - } - - returnData('string', $data); + if ($idAgentModule === false) { + returnError('error_parameter', 'Error in the parameters.'); return; } + + $values = [ + 'id_agent_module' => $idAgentModule, + 'id_alert_template' => $idTemplate, + ]; + + $return = db_process_sql_insert('talert_template_modules', $values); + + $data['type'] = 'string'; + if ($return === false) { + $data['data'] = 0; + } else { + $data['data'] = $return; + } + + returnData('string', $data); + return; } } @@ -9032,61 +8515,18 @@ function api_set_delete_module($id, $id2, $other, $trash1) return; } - $simulate = false; - if ($other['data'][0] == 'simulate') { - $simulate = true; - } - - $agent_by_alias = false; - - if ($other['data'][1] === '1') { - $agent_by_alias = true; - } - - if ($agent_by_alias) { - $idsAgents = agents_get_agent_id_by_alias($id); - } else { - $idAgent = agents_get_agent_id($id); - } - - if ($agent_by_alias) { - foreach ($idsAgents as $id) { - if (!util_api_check_agent_and_print_error($id['id_agente'], 'string', 'AD')) { - return; - } + if ($other['type'] == 'string') { + $simulate = false; + if ($other['data'] == 'simulate') { + $simulate = true; } - } else { + + $idAgent = agents_get_agent_id($id); + if (!util_api_check_agent_and_print_error($idAgent, 'string', 'AD')) { return; } - } - if ($agent_by_alias) { - foreach ($idsAgents as $id) { - $idAgentModule = db_get_value_filter('id_agente_modulo', 'tagente_modulo', ['id_agente' => $id['id_agente'], 'nombre' => $id2]); - - if ($idAgentModule === false) { - continue; - } - - if (!$simulate) { - $return = modules_delete_agent_module($idAgentModule); - } else { - $return = true; - } - - $data['type'] = 'string'; - if ($return === false) { - $data['data'] = 0; - } else { - $data['data'] = $return; - } - - returnData('string', $data); - } - - return; - } else { $idAgentModule = db_get_value_filter('id_agente_modulo', 'tagente_modulo', ['id_agente' => $idAgent, 'nombre' => $id2]); if ($idAgentModule === false) { @@ -9109,15 +8549,16 @@ function api_set_delete_module($id, $id2, $other, $trash1) returnData('string', $data); return; + } else { + returnError('error_parameter', 'Error in the parameters.'); + return; } } function api_set_module_data($id, $thrash2, $other, $trash1) { - global $config; - - if (is_metaconsole()) { + if (defined('METACONSOLE')) { return; } @@ -9141,14 +8582,14 @@ function api_set_module_data($id, $thrash2, $other, $trash1) $agent = db_get_row_filter('tagente', ['id_agente' => $agentModule['id_agente']]); $xmlTemplate = " - - - - - - - - "; + + + + + + + + "; $xml = sprintf( $xmlTemplate, @@ -9166,9 +8607,8 @@ function api_set_module_data($id, $thrash2, $other, $trash1) ); if (false === @file_put_contents($config['remote_config'].'/'.io_safe_output($agent['nombre']).'.'.$time.'.data', $xml)) { - returnError('error_file', 'XML file could not be generated in path: '.$config['remote_config']); + returnError('error_file', 'Can save agent data xml.'); } else { - echo __('XML file was generated successfully in path: ').$config['remote_config']; returnData('string', ['type' => 'string', 'data' => $xml]); return; } @@ -9191,29 +8631,9 @@ function api_set_new_module($id, $id2, $other, $trash1) return; } else if ($other['type'] == 'array') { $values = []; - - $agent_by_alias = false; - - if ($other['data'][15] === '1') { - $agent_by_alias = true; - } - - if ($agent_by_alias) { - $idsAgents = agents_get_agent_id_by_alias($id); - } else { - $values['id_agente'] = agents_get_agent_id($id); - } - - if ($agent_by_alias) { - foreach ($idsAgents as $id) { - if (!util_api_check_agent_and_print_error($id['id_agente'], 'string', 'AW')) { - return; - } - } - } else { - if (!util_api_check_agent_and_print_error($values['id_agente'], 'string', 'AW')) { - return; - } + $values['id_agente'] = agents_get_agent_id($id); + if (!util_api_check_agent_and_print_error($values['id_agente'], 'string', 'AW')) { + return; } $values['nombre'] = $id2; @@ -9293,30 +8713,11 @@ function api_set_new_module($id, $id2, $other, $trash1) $values['id_modulo'] = 2; - if ($agent_by_alias) { - $agents_module_created = 0; - - foreach ($idsAgents as $id) { - $return = modules_create_agent_module( - $id['id_agente'], - $values['nombre'], - $values - ); - - if ($return != false) { - $agents_module_created++; - } - } - - returnData('string', ['type' => 'string', 'data' => __('Module has been created in %d agents.', $agents_module_created)]); - return; - } else { - $return = modules_create_agent_module( - $values['id_agente'], - $values['nombre'], - $values - ); - } + $return = modules_create_agent_module( + $values['id_agente'], + $values['nombre'], + $values + ); $data['type'] = 'string'; if ($return === false) { @@ -9352,133 +8753,66 @@ function api_set_alert_actions($id, $id2, $other, $trash1) } if ($other['type'] == 'string') { - returnError('error_parameter', 'Error in the parameters0.'); + returnError('error_parameter', 'Error in the parameters.'); return; } else if ($other['type'] == 'array') { - $agent_by_alias = false; - - if ($other['data'][4] === '1') { - $agent_by_alias = true; - } - - if ($agent_by_alias) { - $idsAgents = agents_get_agent_id_by_alias($id); - } else { - $idAgent = agents_get_agent_id($id); - } - - if ($agent_by_alias) { - foreach ($idsAgents as $id) { - if (!util_api_check_agent_and_print_error($id['id_agente'], 'string', 'AW')) { - return; - } - } - } else { - if (!util_api_check_agent_and_print_error($idAgent, 'string', 'AW')) { - return; - } + $idAgent = agents_get_agent_id($id); + if (!util_api_check_agent_and_print_error($idAgent, 'string', 'AW')) { + return; } $row = db_get_row_filter('talert_templates', ['name' => $id2]); if ($row === false) { - returnError('error_parameter', 'Error in the parameters1.'); + returnError('error_parameter', 'Error in the parameters.'); return; } $idTemplate = $row['id']; - if ($agent_by_alias) { - $actions_set = 0; - - foreach ($idsAgents as $id) { - $idAgentModule = db_get_value_filter('id_agente_modulo', 'tagente_modulo', ['id_agente' => $id['id_agente'], 'nombre' => $other['data'][0]]); - if ($idAgentModule === false) { - continue; - } - - $idAlertTemplateModule = db_get_value_filter('id', 'talert_template_modules', ['id_alert_template' => $idTemplate, 'id_agent_module' => $idAgentModule]); - if ($idAlertTemplateModule === false) { - returnError('error_parameter', 'Error in the parameters.'); - return; - } - - if ($other['data'][1] != '') { - $idAction = db_get_value_filter('id', 'talert_actions', ['name' => $other['data'][1]]); - if ($idAction === false) { - returnError('error_parameter', 'Error in the parameters.'); - return; - } - } else { - returnError('error_parameter', 'Error in the parameters.'); - return; - } - - $firesMin = $other['data'][2]; - $firesMax = $other['data'][3]; - - $values = [ - 'id_alert_template_module' => $idAlertTemplateModule, - 'id_alert_action' => $idAction, - 'fires_min' => $firesMin, - 'fires_max' => $firesMax, - ]; - - $return = db_process_sql_insert('talert_template_module_actions', $values); - - if ($return != false) { - $actions_set++; - } - } - - returnData('string', ['type' => 'string', 'data' => __('Action has been set for %d agents.', $actions_set)]); - - return; - } else { - $idAgentModule = db_get_value_filter('id_agente_modulo', 'tagente_modulo', ['id_agente' => $idAgent, 'nombre' => $other['data'][0]]); - if ($idAgentModule === false) { - returnError('error_parameter', 'Error in the parameters.'); - return; - } - - $idAlertTemplateModule = db_get_value_filter('id', 'talert_template_modules', ['id_alert_template' => $idTemplate, 'id_agent_module' => $idAgentModule]); - if ($idAlertTemplateModule === false) { - returnError('error_parameter', 'Error in the parameters.'); - return; - } - - if ($other['data'][1] != '') { - $idAction = db_get_value_filter('id', 'talert_actions', ['name' => $other['data'][1]]); - if ($idAction === false) { - returnError('error_parameter', 'Error in the parameters.'); - return; - } - } else { - returnError('error_parameter', 'Error in the parameters.'); - return; - } - - $firesMin = $other['data'][2]; - $firesMax = $other['data'][3]; - - $values = [ - 'id_alert_template_module' => $idAlertTemplateModule, - 'id_alert_action' => $idAction, - 'fires_min' => $firesMin, - 'fires_max' => $firesMax, - ]; - - $return = db_process_sql_insert('talert_template_module_actions', $values); - - $data['type'] = 'string'; - if ($return === false) { - $data['data'] = 0; - } else { - $data['data'] = $return; - } - - returnData('string', $data); + $idAgentModule = db_get_value_filter('id_agente_modulo', 'tagente_modulo', ['id_agente' => $idAgent, 'nombre' => $other['data'][0]]); + if ($idAgentModule === false) { + returnError('error_parameter', 'Error in the parameters.'); return; } + + $idAlertTemplateModule = db_get_value_filter('id', 'talert_template_modules', ['id_alert_template' => $idTemplate, 'id_agent_module' => $idAgentModule]); + if ($idAlertTemplateModule === false) { + returnError('error_parameter', 'Error in the parameters.'); + return; + } + + if ($other['data'][1] != '') { + $idAction = db_get_value_filter('id', 'talert_actions', ['name' => $other['data'][1]]); + if ($idAction === false) { + returnError('error_parameter', 'Error in the parameters.'); + return; + } + } else { + returnError('error_parameter', 'Error in the parameters.'); + return; + } + + $firesMin = $other['data'][2]; + $firesMax = $other['data'][3]; + + $values = [ + 'id_alert_template_module' => $idAlertTemplateModule, + 'id_alert_action' => $idAction, + 'fires_min' => $firesMin, + 'fires_max' => $firesMax, + ]; + + $return = db_process_sql_insert('talert_template_module_actions', $values); + + $data['type'] = 'string'; + if ($return === false) { + $data['data'] = 0; + } else { + $data['data'] = $return; + } + + returnData('string', $data); + return; } } @@ -9807,11 +9141,11 @@ function api_set_new_event($trash1, $trash2, $other, $trash3) } else { $idAlert = db_get_value_sql( "SELECT t1.id - FROM talert_template_modules t1 - INNER JOIN talert_templates t2 - ON t1.id_alert_template = t2.id - WHERE t1.id_agent_module = 1 - AND t2.name LIKE '".$other['data'][7]."'" + FROM talert_template_modules t1 + INNER JOIN talert_templates t2 + ON t1.id_alert_template = t2.id + WHERE t1.id_agent_module = 1 + AND t2.name LIKE '".$other['data'][7]."'" ); if ($idAlert === false) { @@ -9965,9 +9299,7 @@ function api_set_event_validate_filter($trash1, $trash2, $other, $trash3) } } - $use_agent_name = ($other['data'][8] === '1') ? true : false; - - $filterString = otherParameter2Filter($other, false, $use_agent_name); + $filterString = otherParameter2Filter($other); if (!users_can_manage_group_all('EW')) { $user_groups = implode( @@ -10050,9 +9382,9 @@ function api_get_gis_agent($id_agent, $trash1, $tresh2, $return_type, $user_in_d $agent_gis_data = db_get_row_sql( ' - SELECT * - FROM tgis_data_status - WHERE tagente_id_agente = '.$id_agent + SELECT * + FROM tgis_data_status + WHERE tagente_id_agente = '.$id_agent ); if ($agent_gis_data) { @@ -10284,9 +9616,7 @@ function get_events_with_user($trash1, $trash2, $other, $returnType, $user_in_db $utimestamp_upper = 0; $utimestamp_bottom = 0; - $use_agent_name = ($other['data'][16] === '1') ? true : false; - - $filter = otherParameter2Filter($other, true, $use_agent_name); + $filter = otherParameter2Filter($other, true); if (isset($filter['criticity'])) { $severity = $filter['criticity']; @@ -10421,7 +9751,7 @@ function get_events_with_user($trash1, $trash2, $other, $returnType, $user_in_db $sql_post .= " AND event_type LIKE '%$event_type%' "; } else if ($event_type == 'not_normal') { $sql_post .= " AND ( event_type LIKE '%warning%' - OR event_type LIKE '%critical%' OR event_type LIKE '%unknown%' ) "; + OR event_type LIKE '%critical%' OR event_type LIKE '%unknown%' ) "; } else { $sql_post .= " AND event_type = '".$event_type."'"; } @@ -10480,48 +9810,48 @@ function get_events_with_user($trash1, $trash2, $other, $returnType, $user_in_db case 'mysql': if ($filter['total']) { $sql = 'SELECT COUNT(*) - FROM '.$table_events.' - WHERE 1=1 '.$sql_post; + FROM '.$table_events.' + WHERE 1=1 '.$sql_post; } else if ($filter['more_criticity']) { $sql = 'SELECT criticity - FROM '.$table_events.' - WHERE 1=1 '.$sql_post.' - ORDER BY criticity DESC - LIMIT 1'; + FROM '.$table_events.' + WHERE 1=1 '.$sql_post.' + ORDER BY criticity DESC + LIMIT 1'; } else { if (defined('METACONSOLE')) { $sql = 'SELECT *, - (SELECT t2.nombre - FROM tgrupo t2 - WHERE t2.id_grupo = '.$table_events.'.id_grupo) AS group_name, - (SELECT t2.icon - FROM tgrupo t2 - WHERE t2.id_grupo = '.$table_events.'.id_grupo) AS group_icon - FROM '.$table_events.' - WHERE 1=1 '.$sql_post.' - ORDER BY utimestamp DESC - LIMIT '.$offset.','.$pagination; + (SELECT t2.nombre + FROM tgrupo t2 + WHERE t2.id_grupo = '.$table_events.'.id_grupo) AS group_name, + (SELECT t2.icon + FROM tgrupo t2 + WHERE t2.id_grupo = '.$table_events.'.id_grupo) AS group_icon + FROM '.$table_events.' + WHERE 1=1 '.$sql_post.' + ORDER BY utimestamp DESC + LIMIT '.$offset.','.$pagination; } else { $sql = 'SELECT *, - (SELECT t1.alias - FROM tagente t1 - WHERE t1.id_agente = tevento.id_agente) AS agent_name, - (SELECT t2.nombre - FROM tgrupo t2 - WHERE t2.id_grupo = tevento.id_grupo) AS group_name, - (SELECT t2.icon - FROM tgrupo t2 - WHERE t2.id_grupo = tevento.id_grupo) AS group_icon, - (SELECT tmodule.name - FROM tmodule - WHERE id_module IN ( - SELECT tagente_modulo.id_modulo - FROM tagente_modulo - WHERE tagente_modulo.id_agente_modulo=tevento.id_agentmodule)) AS module_name - FROM '.$table_events.' - WHERE 1=1 '.$sql_post.' - ORDER BY utimestamp DESC - LIMIT '.$offset.','.$pagination; + (SELECT t1.alias + FROM tagente t1 + WHERE t1.id_agente = tevento.id_agente) AS agent_name, + (SELECT t2.nombre + FROM tgrupo t2 + WHERE t2.id_grupo = tevento.id_grupo) AS group_name, + (SELECT t2.icon + FROM tgrupo t2 + WHERE t2.id_grupo = tevento.id_grupo) AS group_icon, + (SELECT tmodule.name + FROM tmodule + WHERE id_module IN ( + SELECT tagente_modulo.id_modulo + FROM tagente_modulo + WHERE tagente_modulo.id_agente_modulo=tevento.id_agentmodule)) AS module_name + FROM '.$table_events.' + WHERE 1=1 '.$sql_post.' + ORDER BY utimestamp DESC + LIMIT '.$offset.','.$pagination; } } break; @@ -10529,25 +9859,25 @@ function get_events_with_user($trash1, $trash2, $other, $returnType, $user_in_db case 'postgresql': // TODO TOTAL $sql = 'SELECT *, - (SELECT t1.alias - FROM tagente t1 - WHERE t1.id_agente = tevento.id_agente) AS agent_name, - (SELECT t2.nombre - FROM tgrupo t2 - WHERE t2.id_grupo = tevento.id_grupo) AS group_name, - (SELECT t2.icon - FROM tgrupo t2 - WHERE t2.id_grupo = tevento.id_grupo) AS group_icon, - (SELECT tmodule.name - FROM tmodule - WHERE id_module IN ( - SELECT tagente_modulo.id_modulo - FROM tagente_modulo - WHERE tagente_modulo.id_agente_modulo=tevento.id_agentmodule)) AS module_name - FROM tevento - WHERE 1=1 '.$sql_post.' - ORDER BY utimestamp DESC - LIMIT '.$pagination.' OFFSET '.$offset; + (SELECT t1.alias + FROM tagente t1 + WHERE t1.id_agente = tevento.id_agente) AS agent_name, + (SELECT t2.nombre + FROM tgrupo t2 + WHERE t2.id_grupo = tevento.id_grupo) AS group_name, + (SELECT t2.icon + FROM tgrupo t2 + WHERE t2.id_grupo = tevento.id_grupo) AS group_icon, + (SELECT tmodule.name + FROM tmodule + WHERE id_module IN ( + SELECT tagente_modulo.id_modulo + FROM tagente_modulo + WHERE tagente_modulo.id_agente_modulo=tevento.id_agentmodule)) AS module_name + FROM tevento + WHERE 1=1 '.$sql_post.' + ORDER BY utimestamp DESC + LIMIT '.$pagination.' OFFSET '.$offset; break; case 'oracle': @@ -10557,26 +9887,26 @@ function get_events_with_user($trash1, $trash2, $other, $returnType, $user_in_db $set['offset'] = $offset; $sql = 'SELECT *, - (SELECT t1.alias - FROM tagente t1 - WHERE t1.id_agente = tevento.id_agente) AS alias, - (SELECT t1.nombre - FROM tagente t1 - WHERE t1.id_agente = tevento.id_agente) AS agent_name, - (SELECT t2.nombre - FROM tgrupo t2 - WHERE t2.id_grupo = tevento.id_grupo) AS group_name, - (SELECT t2.icon - FROM tgrupo t2 - WHERE t2.id_grupo = tevento.id_grupo) AS group_icon, - (SELECT tmodule.name - FROM tmodule - WHERE id_module IN ( - SELECT tagente_modulo.id_modulo - FROM tagente_modulo - WHERE tagente_modulo.id_agente_modulo=tevento.id_agentmodule)) AS module_name - FROM tevento - WHERE 1=1 '.$sql_post.' ORDER BY utimestamp DESC'; + (SELECT t1.alias + FROM tagente t1 + WHERE t1.id_agente = tevento.id_agente) AS alias, + (SELECT t1.nombre + FROM tagente t1 + WHERE t1.id_agente = tevento.id_agente) AS agent_name, + (SELECT t2.nombre + FROM tgrupo t2 + WHERE t2.id_grupo = tevento.id_grupo) AS group_name, + (SELECT t2.icon + FROM tgrupo t2 + WHERE t2.id_grupo = tevento.id_grupo) AS group_icon, + (SELECT tmodule.name + FROM tmodule + WHERE id_module IN ( + SELECT tagente_modulo.id_modulo + FROM tagente_modulo + WHERE tagente_modulo.id_agente_modulo=tevento.id_agentmodule)) AS module_name + FROM tevento + WHERE 1=1 '.$sql_post.' ORDER BY utimestamp DESC'; $sql = oracle_recode_query($sql, $set); break; } @@ -10586,26 +9916,26 @@ function get_events_with_user($trash1, $trash2, $other, $returnType, $user_in_db db_process_sql('SET group_concat_max_len = 9999999'); $sql = "SELECT *, MAX(id_evento) AS id_evento, - GROUP_CONCAT(DISTINCT user_comment SEPARATOR '') AS user_comment, - MIN(estado) AS min_estado, MAX(estado) AS max_estado, - COUNT(*) AS event_rep, MAX(utimestamp) AS timestamp_rep - FROM ".$table_events.' - WHERE 1=1 '.$sql_post.' - GROUP BY evento, id_agentmodule - ORDER BY timestamp_rep DESC - LIMIT '.$offset.','.$pagination; + GROUP_CONCAT(DISTINCT user_comment SEPARATOR '') AS user_comment, + MIN(estado) AS min_estado, MAX(estado) AS max_estado, + COUNT(*) AS event_rep, MAX(utimestamp) AS timestamp_rep + FROM ".$table_events.' + WHERE 1=1 '.$sql_post.' + GROUP BY evento, id_agentmodule + ORDER BY timestamp_rep DESC + LIMIT '.$offset.','.$pagination; break; case 'postgresql': $sql = "SELECT *, MAX(id_evento) AS id_evento, - array_to_string(array_agg(DISTINCT user_comment), '') AS user_comment, - MIN(estado) AS min_estado, MAX(estado) AS max_estado, - COUNT(*) AS event_rep, MAX(utimestamp) AS timestamp_rep - FROM ".$table_events.' - WHERE 1=1 '.$sql_post.' - GROUP BY evento, id_agentmodule - ORDER BY timestamp_rep DESC - LIMIT '.$pagination.' OFFSET '.$offset; + array_to_string(array_agg(DISTINCT user_comment), '') AS user_comment, + MIN(estado) AS min_estado, MAX(estado) AS max_estado, + COUNT(*) AS event_rep, MAX(utimestamp) AS timestamp_rep + FROM ".$table_events.' + WHERE 1=1 '.$sql_post.' + GROUP BY evento, id_agentmodule + ORDER BY timestamp_rep DESC + LIMIT '.$pagination.' OFFSET '.$offset; break; case 'oracle': @@ -10614,21 +9944,21 @@ function get_events_with_user($trash1, $trash2, $other, $returnType, $user_in_db $set['offset'] = $offset; // TODO: Remove duplicate user comments $sql = 'SELECT a.*, b.event_rep, b.timestamp_rep - FROM (SELECT * - FROM tevento - WHERE 1=1 '.$sql_post.") a, - (SELECT MAX (id_evento) AS id_evento, - to_char(evento) AS evento, id_agentmodule, - COUNT(*) AS event_rep, MIN(estado) AS min_estado, - MAX(estado) AS max_estado, - LISTAGG(user_comment, '') AS user_comment, - MAX(utimestamp) AS timestamp_rep - FROM ".$table_events.' - WHERE 1=1 '.$sql_post.' - GROUP BY to_char(evento), id_agentmodule) b - WHERE a.id_evento=b.id_evento AND - to_char(a.evento)=to_char(b.evento) AND - a.id_agentmodule=b.id_agentmodule'; + FROM (SELECT * + FROM tevento + WHERE 1=1 '.$sql_post.") a, + (SELECT MAX (id_evento) AS id_evento, + to_char(evento) AS evento, id_agentmodule, + COUNT(*) AS event_rep, MIN(estado) AS min_estado, + MAX(estado) AS max_estado, + LISTAGG(user_comment, '') AS user_comment, + MAX(utimestamp) AS timestamp_rep + FROM ".$table_events.' + WHERE 1=1 '.$sql_post.' + GROUP BY to_char(evento), id_agentmodule) b + WHERE a.id_evento=b.id_evento AND + to_char(a.evento)=to_char(b.evento) AND + a.id_agentmodule=b.id_agentmodule'; $sql = oracle_recode_query($sql, $set); break; } @@ -10706,7 +10036,8 @@ function get_events_with_user($trash1, $trash2, $other, $returnType, $user_in_db $data['type'] = 'array'; $data['data'] = $result; - // returnData($returnType, $data, $separator); + returnData($returnType, $data, $separator); + if (empty($result)) { return false; } @@ -10746,6 +10077,8 @@ function api_get_events($trash1, $trash2, $other, $returnType, $user_in_db=null) returnError('ERROR_API_PANDORAFMS', $returnType); } } + + return; } if ($other['type'] == 'string') { @@ -10759,13 +10092,10 @@ function api_get_events($trash1, $trash2, $other, $returnType, $user_in_db=null) } else if ($other['type'] == 'array') { $separator = $other['data'][0]; - // By default it uses agent alias. - $use_agent_name = ($other['data'][16] === '1') ? true : false; - - $filterString = otherParameter2Filter($other, false, $use_agent_name); + $filterString = otherParameter2Filter($other); } - if (is_metaconsole()) { + if (defined('METACONSOLE')) { $dataRows = db_get_all_rows_filter('tmetaconsole_event', $filterString); } else { $dataRows = db_get_all_rows_filter('tevento', $filterString); @@ -11246,58 +10576,25 @@ function api_set_new_note_incident($id, $id2, $other, $thrash2) */ -function api_set_disable_module($agent_name, $module_name, $other, $thrash4) +function api_set_disable_module($agent_name, $module_name, $thrast3, $thrash4) { if (defined('METACONSOLE')) { return; } - $agent_by_alias = false; - - if ($other['data'][0] === '1') { - $agent_by_alias = true; + $id_agent = agents_get_agent_id($agent_name); + if (!util_api_check_agent_and_print_error($id_agent, 'string', 'AD')) { + return; } - if ($agent_by_alias) { - $ids_agents = agents_get_agent_id_by_alias($agent_name); + $id_agent_module = db_get_value_filter('id_agente_modulo', 'tagente_modulo', ['id_agente' => $id_agent, 'nombre' => $module_name]); - foreach ($ids_agents as $id) { - if (!util_api_check_agent_and_print_error($id['id_agente'], 'string', 'AD')) { - return; - } - } + $result = modules_change_disabled($id_agent_module, 1); + + if ($result === NOERR) { + returnData('string', ['type' => 'string', 'data' => __('Correct module disable')]); } else { - $id_agent = agents_get_agent_id($agent_name); - - if (!util_api_check_agent_and_print_error($id_agent, 'string', 'AD')) { - return; - } - } - - if ($agent_by_alias) { - $agents_affected = 0; - - foreach ($ids_agents as $id) { - $id_agent_module = db_get_value_filter('id_agente_modulo', 'tagente_modulo', ['id_agente' => $id['id_agente'], 'nombre' => $module_name]); - - $result = modules_change_disabled($id_agent_module, 1); - - if ($result === NOERR) { - $agents_affected++; - } - } - - returnData('string', ['type' => 'string', 'data' => __('%d agents affected', $agents_affected)]); - } else { - $id_agent_module = db_get_value_filter('id_agente_modulo', 'tagente_modulo', ['id_agente' => $id_agent, 'nombre' => $module_name]); - - $result = modules_change_disabled($id_agent_module, 1); - - if ($result === NOERR) { - returnData('string', ['type' => 'string', 'data' => __('Correct module disable')]); - } else { - returnData('string', ['type' => 'string', 'data' => __('Error disabling module')]); - } + returnData('string', ['type' => 'string', 'data' => __('Error disabling module')]); } } @@ -11312,58 +10609,25 @@ function api_set_disable_module($agent_name, $module_name, $other, $thrash4) */ -function api_set_enable_module($agent_name, $module_name, $other, $thrash4) +function api_set_enable_module($agent_name, $module_name, $thrast3, $thrash4) { if (defined('METACONSOLE')) { return; } - $agent_by_alias = false; - - if ($other['data'][0] === '1') { - $agent_by_alias = true; + $id_agent = agents_get_agent_id($agent_name); + if (!util_api_check_agent_and_print_error($id_agent, 'string', 'AD')) { + return; } - if ($agent_by_alias) { - $ids_agents = agents_get_agent_id_by_alias($agent_name); + $id_agent_module = db_get_value_filter('id_agente_modulo', 'tagente_modulo', ['id_agente' => $id_agent, 'nombre' => $module_name]); - foreach ($ids_agents as $id) { - if (!util_api_check_agent_and_print_error($id['id_agente'], 'string', 'AD')) { - return; - } - } + $result = modules_change_disabled($id_agent_module, 0); + + if ($result === NOERR) { + returnData('string', ['type' => 'string', 'data' => __('Correct module enable')]); } else { - $id_agent = agents_get_agent_id($agent_name); - - if (!util_api_check_agent_and_print_error($id_agent, 'string', 'AD')) { - return; - } - } - - if ($agent_by_alias) { - $agents_affected = 0; - - foreach ($ids_agents as $id) { - $id_agent_module = db_get_value_filter('id_agente_modulo', 'tagente_modulo', ['id_agente' => $id['id_agente'], 'nombre' => $module_name]); - - $result = modules_change_disabled($id_agent_module, 0); - - if ($result === NOERR) { - $agents_affected++; - } - } - - returnData('string', ['type' => 'string', 'data' => __('%d agents affected', $agents_affected)]); - } else { - $id_agent_module = db_get_value_filter('id_agente_modulo', 'tagente_modulo', ['id_agente' => $id_agent, 'nombre' => $module_name]); - - $result = modules_change_disabled($id_agent_module, 0); - - if ($result === NOERR) { - returnData('string', ['type' => 'string', 'data' => __('Correct module enable')]); - } else { - returnData('string', ['type' => 'string', 'data' => __('Error enabling module')]); - } + returnData('string', ['type' => 'string', 'data' => __('Error enabling module')]); } } @@ -11403,8 +10667,8 @@ function api_set_disable_alert($agent_name, $module_name, $template_name, $thras $result = db_process_sql( "UPDATE talert_template_modules - SET disabled = 1 - WHERE id_agent_module = $id_agent_module AND id_alert_template = $id_template" + SET disabled = 1 + WHERE id_agent_module = $id_agent_module AND id_alert_template = $id_template" ); if ($result) { @@ -11452,8 +10716,8 @@ function api_set_disable_alert_alias($agent_alias, $module_name, $template_name, $result = db_process_sql( "UPDATE talert_template_modules - SET disabled = 1 - WHERE id_agent_module = $id_agent_module AND id_alert_template = $id_template" + SET disabled = 1 + WHERE id_agent_module = $id_agent_module AND id_alert_template = $id_template" ); if ($result) { @@ -11503,8 +10767,8 @@ function api_set_enable_alert($agent_name, $module_name, $template_name, $thrash $result = db_process_sql( "UPDATE talert_template_modules - SET disabled = 0 - WHERE id_agent_module = $id_agent_module AND id_alert_template = $id_template" + SET disabled = 0 + WHERE id_agent_module = $id_agent_module AND id_alert_template = $id_template" ); if ($result) { @@ -11552,8 +10816,8 @@ function api_set_enable_alert_alias($agent_alias, $module_name, $template_name, $result = db_process_sql( "UPDATE talert_template_modules - SET disabled = 0 - WHERE id_agent_module = $id_agent_module AND id_alert_template = $id_template" + SET disabled = 0 + WHERE id_agent_module = $id_agent_module AND id_alert_template = $id_template" ); if ($result) { @@ -11580,7 +10844,7 @@ function api_set_enable_alert_alias($agent_alias, $module_name, $template_name, */ -function api_set_disable_module_alerts($agent_name, $module_name, $other, $thrash4) +function api_set_disable_module_alerts($agent_name, $module_name, $thrash3, $thrash4) { global $config; @@ -11593,59 +10857,20 @@ function api_set_disable_module_alerts($agent_name, $module_name, $other, $thras return; } - $agent_by_alias = false; - - if ($other['data'][0] === '1') { - $agent_by_alias = true; + $id_agent = agents_get_agent_id($agent_name); + if (!util_api_check_agent_and_print_error($id_agent, 'string', 'AW')) { + return; } - if ($agent_by_alias) { - $ids_agents = agents_get_agent_id_by_alias($agent_name); - } else { - $id_agent = agents_get_agent_id($agent_name); - } + $id_agent_module = db_get_value_filter('id_agente_modulo', 'tagente_modulo', ['id_agente' => $id_agent, 'nombre' => $module_name]); - if ($agent_by_alias) { - foreach ($ids_agents as $id) { - if (!util_api_check_agent_and_print_error($id['id_agente'], 'string', 'AW')) { - return; - } - } - } else { - if (!util_api_check_agent_and_print_error($id_agent, 'string', 'AW')) { - return; - } - } + db_process_sql( + "UPDATE talert_template_modules + SET disabled = 1 + WHERE id_agent_module = $id_agent_module" + ); - if ($agent_by_alias) { - $agents_affected = 0; - - foreach ($ids_agents as $id) { - $id_agent_module = db_get_value_filter('id_agente_modulo', 'tagente_modulo', ['id_agente' => $id['id_agente'], 'nombre' => $module_name]); - - $return_value = db_process_sql( - "UPDATE talert_template_modules - SET disabled = 1 - WHERE id_agent_module = $id_agent_module" - ); - - if ($return_value != false) { - $agents_affected++; - } - } - - returnData('string', ['type' => 'string', 'data' => __('%d agents affected', $agents_affected)]); - } else { - $id_agent_module = db_get_value_filter('id_agente_modulo', 'tagente_modulo', ['id_agente' => $id_agent, 'nombre' => $module_name]); - - db_process_sql( - "UPDATE talert_template_modules - SET disabled = 1 - WHERE id_agent_module = $id_agent_module" - ); - - returnData('string', ['type' => 'string', 'data' => 'Correct alerts disable']); - } + returnData('string', ['type' => 'string', 'data' => 'Correct alerts disable']); } @@ -11661,7 +10886,7 @@ function api_set_disable_module_alerts($agent_name, $module_name, $other, $thras */ -function api_set_enable_module_alerts($agent_name, $module_name, $other, $thrash4) +function api_set_enable_module_alerts($agent_name, $module_name, $thrash3, $thrash4) { global $config; @@ -11674,59 +10899,20 @@ function api_set_enable_module_alerts($agent_name, $module_name, $other, $thrash return; } - $agent_by_alias = false; - - if ($other['data'][0] === '1') { - $agent_by_alias = true; + $id_agent = agents_get_agent_id($agent_name); + if (!util_api_check_agent_and_print_error($id_agent, 'string', 'AW')) { + return; } - if ($agent_by_alias) { - $ids_agents = agents_get_agent_id_by_alias($agent_name); - } else { - $id_agent = agents_get_agent_id($agent_name); - } + $id_agent_module = db_get_value_filter('id_agente_modulo', 'tagente_modulo', ['id_agente' => $id_agent, 'nombre' => $module_name]); - if ($agent_by_alias) { - foreach ($ids_agents as $id) { - if (!util_api_check_agent_and_print_error($id['id_agente'], 'string', 'AW')) { - return; - } - } - } else { - if (!util_api_check_agent_and_print_error($id_agent, 'string', 'AW')) { - return; - } - } + db_process_sql( + "UPDATE talert_template_modules + SET disabled = 0 + WHERE id_agent_module = $id_agent_module" + ); - if ($agent_by_alias) { - $agents_affected = 0; - - foreach ($ids_agents as $id) { - $id_agent_module = db_get_value_filter('id_agente_modulo', 'tagente_modulo', ['id_agente' => $id['id_agente'], 'nombre' => $module_name]); - - $return_value = db_process_sql( - "UPDATE talert_template_modules - SET disabled = 0 - WHERE id_agent_module = $id_agent_module" - ); - - if ($return_value != false) { - $agents_affected++; - } - } - - returnData('string', ['type' => 'string', 'data' => __('%d agents affected', $agents_affected)]); - } else { - $id_agent_module = db_get_value_filter('id_agente_modulo', 'tagente_modulo', ['id_agente' => $id_agent, 'nombre' => $module_name]); - - db_process_sql( - "UPDATE talert_template_modules - SET disabled = 0 - WHERE id_agent_module = $id_agent_module" - ); - - returnData('string', ['type' => 'string', 'data' => 'Correct alerts enable']); - } + returnData('string', ['type' => 'string', 'data' => 'Correct alerts enable']); } @@ -11798,11 +10984,11 @@ function api_get_total_modules($id_group, $trash1, $trash2, $returnType) } $sql = "SELECT COUNT(DISTINCT(id_agente_modulo)) - FROM tagente_modulo tam, tagente ta - LEFT JOIN tagent_secondary_group tasg - ON ta.id_agente = tasg.id_agent - WHERE tam.id_agente = ta.id_agente AND id_module_group = $id_group - AND delete_pending = 0 AND $groups_clause"; + FROM tagente_modulo tam, tagente ta + LEFT JOIN tagent_secondary_group tasg + ON ta.id_agente = tasg.id_agent + WHERE tam.id_agente = ta.id_agente AND id_module_group = $id_group + AND delete_pending = 0 AND $groups_clause"; $total = db_get_value_sql($sql); @@ -11863,8 +11049,8 @@ function api_get_agent_name($id_agent, $trash1, $trash2, $returnType) $sql = sprintf( 'SELECT nombre - FROM tagente - WHERE id_agente = %d', + FROM tagente + WHERE id_agente = %d', $id_agent ); $value = db_get_value_sql($sql); @@ -11940,8 +11126,8 @@ function api_get_agent_alias($id_agent, $id_node, $trash1, $returnType) $sql = sprintf( 'SELECT alias - FROM '.$table_agent_alias.' - WHERE id_agente = %d', + FROM '.$table_agent_alias.' + WHERE id_agente = %d', $id_agent ); $value = db_get_value_sql($sql); @@ -11973,8 +11159,8 @@ function api_get_module_name($id_module, $trash1, $trash2, $returnType) $sql = sprintf( 'SELECT nombre - FROM tagente_modulo - WHERE id_agente_modulo = %d', + FROM tagente_modulo + WHERE id_agente_modulo = %d', $id_module ); @@ -12015,15 +11201,15 @@ function api_get_alert_action_by_group($id_group, $id_action, $trash2, $returnTy } $sql = "SELECT SUM(internal_counter) - FROM - talert_template_modules tatm, - tagente ta LEFT JOIN tagent_secondary_group tasg - ON ta.id_agente = tasg.id_agent, - tagente_modulo tam - WHERE tam.id_agente = ta.id_agente - AND tatm.id_agent_module = tam.id_agente_modulo - AND ta.disabled = 0 - AND $filter_groups"; + FROM + talert_template_modules tatm, + tagente ta LEFT JOIN tagent_secondary_group tasg + ON ta.id_agente = tasg.id_agent, + tagente_modulo tam + WHERE tam.id_agente = ta.id_agente + AND tatm.id_agent_module = tam.id_agente_modulo + AND ta.disabled = 0 + AND $filter_groups"; $value = db_get_value_sql($sql); @@ -12053,8 +11239,8 @@ function api_get_event_info($id_event, $trash1, $trash, $returnType) } $sql = 'SELECT * - FROM '.$table_events." - WHERE id_evento=$id_event"; + FROM '.$table_events." + WHERE id_evento=$id_event"; $event_data = db_get_row_sql($sql); // Check the access to group @@ -12195,7 +11381,7 @@ function api_set_create_event($id, $trash1, $other, $returnType) $id_agent = $other['data'][2]; if (is_metaconsole()) { // On metaconsole, connect with the node to check the permissions - $agent_cache = db_get_row('tmetaconsole_agent', 'id_agente', $id_agent); + $agent_cache = db_get_row('tmetaconsole_agent', 'id_tagente', $id_agent); if ($agent_cache === false) { returnError('id_not_found', 'string'); return; @@ -12573,23 +11759,12 @@ function api_get_netflow_get_summary($discard_1, $discard_2, $params) function api_set_validate_event_by_id($id, $trash1=null, $trash2=null, $returnType='string') { global $config; - - if (!check_acl($config['id_user'], 0, 'EW')) { - returnError('forbidden', 'string'); - return; - } - - $table_events = 'tevento'; - if (is_metaconsole()) { - $table_events = 'tmetaconsole_event'; - } - $data['type'] = 'string'; - $check_id = db_get_value('id_evento', $table_events, 'id_evento', $id); + $check_id = db_get_value('id_evento', 'tevento', 'id_evento', $id); if ($check_id) { // event exists - $status = db_get_value('estado', $table_events, 'id_evento', $id); + $status = db_get_value('estado', 'tevento', 'id_evento', $id); if ($status == 1) { // event already validated $data['data'] = 'Event already validated'; @@ -12603,7 +11778,7 @@ function api_set_validate_event_by_id($id, $trash1=null, $trash2=null, $returnTy 'estado' => 1, ]; - $result = db_process_sql_update($table_events, $values, ['id_evento' => $id]); + $result = db_process_sql_update('tevento', $values, ['id_evento' => $id]); if ($result === false) { $data['data'] = 'Error validating event'; @@ -13532,7 +12707,7 @@ function api_get_module_graph($id_module, $thrash2, $other, $thrash4) } $graph_seconds = (!empty($other) && isset($other['data'][0])) ? $other['data'][0] : SECONDS_1HOUR; - // 1 hour by default. + // 1 hour by default $graph_threshold = (!empty($other) && isset($other['data'][2]) && $other['data'][2]) ? $other['data'][2] : 0; if (is_nan($graph_seconds) || $graph_seconds <= 0) { @@ -13648,7 +12823,7 @@ function api_set_new_cluster($thrash1, $thrash2, $other, $thrash3) ]; if (!isset($name)) { - // avoid warnings. + // avoid warnings $name = ''; } @@ -13656,7 +12831,7 @@ function api_set_new_cluster($thrash1, $thrash2, $other, $thrash3) $id_agent = agents_create_agent($values_agent['nombre'], $values_agent['id_grupo'], 300, '', $values_agent); if ($id_agent !== false) { - // Create cluster. + // Create cluster $values_cluster = [ 'name' => $name, 'cluster_type' => $cluster_type, @@ -13668,7 +12843,7 @@ function api_set_new_cluster($thrash1, $thrash2, $other, $thrash3) $id_cluster = db_process_sql_insert('tcluster', $values_cluster); if ($id_cluster === false) { - // failed to create cluster, rollback previously created agent. + // failed to create cluster, rollback previously created agent agents_delete_agent($id_agent, true); } @@ -14013,7 +13188,7 @@ function api_set_apply_module_template($id_template, $id_agent, $thrash3, $thras return; } - // Take agent data. + // Take agent data $row = db_get_row('tagente', 'id_agente', $id_agent); $intervalo = $row['intervalo']; @@ -14047,7 +13222,7 @@ function api_set_apply_module_template($id_template, $id_agent, $thrash3, $thras } foreach ($nc as $row2) { - // Insert each module from tnetwork_component into agent. + // Insert each module from tnetwork_component into agent $values = [ 'id_agente' => $id_agent, 'id_tipo_modulo' => $row2['type'], @@ -14093,19 +13268,18 @@ function api_set_apply_module_template($id_template, $id_agent, $thrash3, $thras 'min_ff_event_normal' => $row2['min_ff_event_normal'], 'min_ff_event_warning' => $row2['min_ff_event_warning'], 'min_ff_event_critical' => $row2['min_ff_event_critical'], - 'ff_type' => $row2['ff_type'], ]; $name = $row2['name']; - // Put tags in array if the component has to add them later. + // Put tags in array if the component has to add them later if (!empty($row2['tags'])) { $tags = explode(',', $row2['tags']); } else { $tags = []; } - // Check if this module exists in the agent. + // Check if this module exists in the agent $module_name_check = db_get_value_filter('id_agente_modulo', 'tagente_modulo', ['delete_pending' => 0, 'nombre' => $name, 'id_agente' => $id_agent]); if ($module_name_check !== false) { @@ -14276,46 +13450,6 @@ function api_get_agents_id_name_by_cluster_name($cluster_name, $trash1, $trash2, } -/** - * Get agents alias, id and server id (if Metaconsole) given agent alias - * matching part of it. - * - * @param string $alias - * @param $trash1 - * @param $trash2 - * @param string $returnType - * Example: - * api.php?op=get&op2=agents_id_name_by_alias&return_type=json&apipass=1234&user=admin&pass=pandora&id=pandrora&id2=strict - */ -function api_get_agents_id_name_by_alias($alias, $strict, $trash2, $returnType) -{ - global $config; - - if ($strict == 'strict') { - $where_clause = " alias = '$alias'"; - } else { - $where_clause = " upper(alias) LIKE upper('%$alias%')"; - } - - if (is_metaconsole()) { - $all_agents = db_get_all_rows_sql("SELECT alias, id_agente, id_tagente,id_tmetaconsole_setup as 'id_server', server_name FROM tmetaconsole_agent WHERE $where_clause"); - } else { - $all_agents = db_get_all_rows_sql("SELECT alias, id_agente from tagente WHERE $where_clause"); - } - - if ($all_agents !== false) { - $data = [ - 'type' => 'json', - 'data' => $all_agents, - ]; - - returnData('json', $data, JSON_FORCE_OBJECT); - } else { - returnError('error_agents', 'Alias did not match any agent.'); - } -} - - function api_get_modules_id_name_by_cluster_id($cluster_id) { global $config; @@ -14451,7 +13585,7 @@ function api_set_delete_event_response($id_response, $trash1, $trash2, $returnTy * @param mixed $other. Serialized params * @param $returnType * Example: - * api.php?op=set&op2=create_event_response&other=response%7Cdescription%20response%7Ctouch%7Ccommand%7C0%7C650%7C400%7C0%7Cresponse%7C0%7C90&other_mode=url_encode_separator_%7C&apipass=1234&user=admin&pass=pandora + * api.php?op=set&op2=create_event_response&other=response%7Cdescription%20response%7Ctouch%7Ccommand%7C0%7C650%7C400%7C0%7Cresponse%7C0&other_mode=url_encode_separator_%7C&apipass=1234&user=admin&pass=pandora */ function api_set_create_event_response($trash1, $trash2, $other, $returnType) { @@ -14474,7 +13608,6 @@ function api_set_create_event_response($trash1, $trash2, $other, $returnType) $values['new_window'] = $other['data'][7]; $values['params'] = $other['data'][8]; $values['server_to_exec'] = $other['data'][9]; - $values['command_timeout'] = $other['data'][10]; // Error if user has not permission for the group. if (!check_acl($config['id_user'], $values['id_group'], 'PM')) { @@ -14494,7 +13627,7 @@ function api_set_create_event_response($trash1, $trash2, $other, $returnType) * @param mixed $other. Serialized params * @param $returnType * Example: - * api.php?op=set&op2=update_event_response&id=7&other=response%7Cdescription%20response%7Ctouch%7Ccommand%7C0%7C650%7C400%7C0%7Cresponse%7C0%7C90&other_mode=url_encode_separator_%7C&apipass=1234&user=admin&pass=pandora + * api.php?op=set&op2=update_event_response&id=7&other=response%7Cdescription%20response%7Ctouch%7Ccommand%7C0%7C650%7C400%7C0%7Cresponse%7C0&other_mode=url_encode_separator_%7C&apipass=1234&user=admin&pass=pandora */ function api_set_update_event_response($id_response, $trash1, $other, $returnType) { @@ -14530,7 +13663,6 @@ function api_set_update_event_response($id_response, $trash1, $other, $returnTyp $values['new_window'] = $other['data'][7] == '' ? $event_response['new_window'] : $other['data'][7]; $values['params'] = $other['data'][8] == '' ? $event_response['params'] : $other['data'][8]; $values['server_to_exec'] = $other['data'][9] == '' ? $event_response['server_to_exec'] : $other['data'][9]; - $values['command_timeout'] = $other['data'][10] == '' ? $event_response['command_timeout'] : $other['data'][10]; // Error if user has not permission for the group. if (!check_acl($config['id_user'], $values['id_group'], 'PM')) { @@ -14636,8 +13768,8 @@ function api_set_create_event_filter($name, $thrash1, $other, $thrash3) } else { $sql = sprintf( 'SELECT alias - FROM tagente - WHERE id_agente = %d', + FROM tagente + WHERE id_agente = %d', $agent[0]['id_agente'] ); @@ -14680,8 +13812,8 @@ function api_set_create_event_filter($name, $thrash1, $other, $thrash3) $agents = db_get_all_rows_sql( 'SELECT id_agente - FROM tagente - WHERE id_grupo IN ('.$id_groups.')' + FROM tagente + WHERE id_grupo IN ('.$id_groups.')' ); if ($agents === false) { @@ -14850,8 +13982,8 @@ function api_set_update_event_filter($id_event_filter, $thrash1, $other, $thrash } else { $sql = sprintf( 'SELECT alias - FROM tagente - WHERE id_agente = %d', + FROM tagente + WHERE id_agente = %d', $agent[0]['id_agente'] ); @@ -14893,10 +14025,12 @@ function api_set_update_event_filter($id_event_filter, $thrash1, $other, $thrash break; case 14: + print_r('14444444'); $values['tag_with'] = (preg_match('/^\[(("\d+"((,|\])("\d+"))+)|"\d+")\]$/', io_safe_output($other['data'][14]))) ? $other['data'][14] : '[]'; break; case 15: + print_r('1555555555'); $values['tag_without'] = (preg_match('/^\[(("\d+"((,|\])("\d+"))+)|"\d+")\]$/', io_safe_output($other['data'][15]))) ? $other['data'][15] : '[]'; break; @@ -14921,8 +14055,8 @@ function api_set_update_event_filter($id_event_filter, $thrash1, $other, $thrash $agents = db_get_all_rows_sql( 'SELECT id_agente - FROM tagente - WHERE id_grupo IN ('.$id_groups.')' + FROM tagente + WHERE id_grupo IN ('.$id_groups.')' ); if ($agents === false) { @@ -14955,6 +14089,7 @@ function api_set_update_event_filter($id_event_filter, $thrash1, $other, $thrash break; case 20: + print_r('adadadasds'); $values['user_comment'] = $other['data'][20]; break; } @@ -15343,7 +14478,7 @@ function api_get_group_id_by_name($thrash1, $thrash2, $other, $thrash3) $sql = sprintf( 'SELECT id_grupo - FROM tgrupo WHERE nombre = "'.$other['data'].'"' + FROM tgrupo WHERE nombre = "'.$other['data'].'"' ); $group_id = db_get_all_rows_sql($sql); @@ -15369,7 +14504,7 @@ function api_get_timezone($thrash1, $thrash2, $other, $thrash3) $sql = sprintf( 'SELECT value - FROM tconfig WHERE token = "timezone"' + FROM tconfig WHERE token = "timezone"' ); $timezone = db_get_all_rows_sql($sql); @@ -15395,7 +14530,7 @@ function api_get_language($thrash1, $thrash2, $other, $thrash3) $sql = sprintf( 'SELECT value - FROM tconfig WHERE token = "language"' + FROM tconfig WHERE token = "language"' ); $language = db_get_all_rows_sql($sql); @@ -15421,7 +14556,7 @@ function api_get_session_timeout($thrash1, $thrash2, $other, $thrash3) $sql = sprintf( 'SELECT value - FROM tconfig WHERE token = "session_timeout"' + FROM tconfig WHERE token = "session_timeout"' ); $language = db_get_all_rows_sql($sql);