tyler.durden
/
pandorafms
mirror of https://github.com/pandorafms/pandorafms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

check for agent name not empty

This commit is contained in:
alejandro.campos@artica.es 2024-02-21 15:26:08 +01:00
parent bf82e3c38f
commit 1de44686a1
1 changed files with 15 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
pandora_server/util/pandora_manage.pl
View File

@ -1228,11 +1228,11 @@ sub param_error ($$) {
} }
############################################################################### ###############################################################################
# Print a 'not exists' error and exit the program. # Print a 'does not exist' error and exit the program.
############################################################################### ###############################################################################
sub notexists_error ($$) { sub notexists_error ($$) {
print (STDERR "[ERROR] Error: The $_[0] '$_[1]' not exists.\n\n"); print (STDERR "[ERROR] Error: The $_[0] '$_[1]' does not exist.\n\n");
logger( $conf, "($progname) [ERROR] Error: The $_[0] '$_[1]' not exists.", 10); logger( $conf, "($progname) [ERROR] Error: The $_[0] '$_[1]' does not exist.", 10);
exit 1; exit 1;
} }
@ -3429,6 +3429,11 @@ sub cli_agent_update() {
my @id_agents; my @id_agents;
my $id_agent; my $id_agent;
# Check for mandatory fields.
if ($field eq 'agent_name' && !$new_value) {
}
if (defined $use_alias and $use_alias eq 'use_alias') { if (defined $use_alias and $use_alias eq 'use_alias') {
@id_agents = get_agent_ids_from_alias($dbh,$agent_name); @id_agents = get_agent_ids_from_alias($dbh,$agent_name);
foreach my $id (@id_agents) { foreach my $id (@id_agents) {
@ -3459,6 +3464,10 @@ sub cli_agent_update() {
$new_value = $id_parent; $new_value = $id_parent;
} }
elsif($field eq 'agent_name') { elsif($field eq 'agent_name') {
if (!$new_value) {
print_log "[ERROR] Agent name cannot be empty\n\n";
exit;
}
my $agent_exists = get_agent_id($dbh,$new_value); my $agent_exists = get_agent_id($dbh,$new_value);
non_exist_check($agent_exists,'agent',$new_value); non_exist_check($agent_exists,'agent',$new_value);
$field = 'nombre'; $field = 'nombre';
@ -4104,7 +4113,7 @@ sub cli_exec_from_file() {
elsif($c == 3) { elsif($c == 3) {
$file = $opt; $file = $opt;
if(!(-e $file)) { if(!(-e $file)) {
print_log "[ERROR] File '$file' not exists or cannot be opened\n\n"; print_log "[ERROR] File '$file' does not exist or cannot be opened\n\n";
exit; exit;
} }
} }
@ -4952,7 +4961,7 @@ sub cli_validate_alert() {
if (defined $use_alias and $use_alias eq 'use_alias') { if (defined $use_alias and $use_alias eq 'use_alias') {
my @id_agents = get_agent_ids_from_alias($dbh,$agent_id); my @id_agents = get_agent_ids_from_alias($dbh,$agent_id);
if(!@id_agents) { if(!@id_agents) {
print (STDERR "[ERROR] Error: The agent '$agent_id' not exists.\n\n"); print (STDERR "[ERROR] Error: The agent '$agent_id' does not exist.\n\n");
} }
foreach my $id (@id_agents) { foreach my $id (@id_agents) {
@ -5946,7 +5955,7 @@ sub cli_get_bad_conf_files() {
$missings++; $missings++;
} }
elsif ($result == -1) { elsif ($result == -1) {
print_log "[WARN] File not exists /conf/".$file."\n\n"; print_log "[WARN] File does not exist /conf/".$file."\n\n";
$bad_files++; $bad_files++;
last; last;
} }