tyler.durden
/
pandorafms
mirror of https://github.com/pandorafms/pandorafms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Pass version and cipher as args instead of validating afterwards.

This commit is contained in:
felix.suarez 2023-11-24 09:37:20 -06:00
parent 4ed724edcc
commit 245154ce21
1 changed files with 12 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

41
tentacle/tentacle_server
View File

@ -295,7 +295,7 @@ sub parse_options {
my @t_addresses_tmp; my @t_addresses_tmp;
# Get options # Get options
if (getopts ('a:b:c:de:f:F:g:hIi:k:l:m:op:qr:s:S:t:TvVwx:zu:', \%opts) == 0 || defined ($opts{'h'})) { if (getopts ('a:b:c:de:f:F:g:hIi:k:l:m:op:qr:s:S:t:TvVwx:z:u:', \%opts) == 0 || defined ($opts{'h'})) {
print_help (); print_help ();
exit 1; exit 1;
} }
@ -808,13 +808,19 @@ sub stop_server {
sub start_ssl { sub start_ssl {
my $err; my $err;
my %ssl_args = (
SSL_cert_file => $t_ssl_cert,
SSL_key_file => $t_ssl_key,
SSL_passwd_cb => sub {return $t_ssl_pwd},
SSL_server => 1,
SSL_cipher_list => $t_ssl_cipher // '',
SSL_version => $t_ssl_version // '',
);
if ($t_ssl_ca eq '') { if ($t_ssl_ca eq '') {
IO::Socket::SSL->start_SSL ( IO::Socket::SSL->start_SSL (
$t_client_socket, $t_client_socket,
SSL_cert_file => $t_ssl_cert, %ssl_args,
SSL_key_file => $t_ssl_key,
SSL_passwd_cb => sub {return $t_ssl_pwd},
SSL_server => 1,
# Verify peer # Verify peer
SSL_verify_mode => 0x01, SSL_verify_mode => 0x01,
); );
@ -822,11 +828,8 @@ sub start_ssl {
else { else {
IO::Socket::SSL->start_SSL ( IO::Socket::SSL->start_SSL (
$t_client_socket, $t_client_socket,
%ssl_args,
SSL_ca_file => $t_ssl_ca, SSL_ca_file => $t_ssl_ca,
SSL_cert_file => $t_ssl_cert,
SSL_key_file => $t_ssl_key,
SSL_passwd_cb => sub {return $t_ssl_pwd},
SSL_server => 1,
# Fail verification if no peer certificate exists # Fail verification if no peer certificate exists
SSL_verify_mode => 0x03, SSL_verify_mode => 0x03,
); );
@ -837,29 +840,9 @@ sub start_ssl {
error ($err); error ($err);
} }
validate_ssl();
print_log ("SSL started for " . $t_client_socket->sockhost ()); print_log ("SSL started for " . $t_client_socket->sockhost ());
} }
################################################################################
## SUB validate_ssl
## Validate that a socket has a defined ssl version and cipher.
################################################################################
sub validate_ssl{
my $ssl_version = $t_client_socket->get_ssl_version();
my $ssl_cipher = $t_client_socket->get_cipher();
if($t_ssl_version && $ssl_version ne $t_ssl_version){
$t_client_socket->close();
error ("Invalid SSL Version " . $ssl_version . ", expected version is " . $t_ssl_version . ".");
}
if($t_ssl_cipher && $ssl_cipher ne $t_ssl_cipher){
$t_client_socket->close();
error ("Invalid SSL Cipher " . $ssl_cipher . ", expected cipher is " . $t_ssl_cipher . ".");
}
}
################################################################################ ################################################################################
## SUB accept_connections ## SUB accept_connections