From 2b2daf2b8b58226ca2291708e5ed34dbed915295 Mon Sep 17 00:00:00 2001 From: Alejandro Gallardo Escobar Date: Thu, 16 May 2019 11:03:11 +0200 Subject: [PATCH] Type improvements Former-commit-id: eec4df39fc4ce81240974a32a3fe76618bb62d39 --- visual_console_client/src/Item.ts | 2 +- visual_console_client/src/items/Clock/index.ts | 9 ++------- visual_console_client/src/items/Percentile.ts | 8 ++++---- visual_console_client/src/items/SimpleValue.ts | 6 ++---- visual_console_client/src/items/StaticGraph.ts | 2 +- 5 files changed, 10 insertions(+), 17 deletions(-) diff --git a/visual_console_client/src/Item.ts b/visual_console_client/src/Item.ts index 2b635627c0..7ad0f779d6 100644 --- a/visual_console_client/src/Item.ts +++ b/visual_console_client/src/Item.ts @@ -67,7 +67,7 @@ export interface ItemRemoveEvent { * @param labelPosition Raw value. */ const parseLabelPosition = ( - labelPosition: any // eslint-disable-line @typescript-eslint/no-explicit-any + labelPosition: unknown ): ItemProps["labelPosition"] => { switch (labelPosition) { case "up": diff --git a/visual_console_client/src/items/Clock/index.ts b/visual_console_client/src/items/Clock/index.ts index a65f188659..5273a8630d 100644 --- a/visual_console_client/src/items/Clock/index.ts +++ b/visual_console_client/src/items/Clock/index.ts @@ -27,9 +27,7 @@ export type ClockProps = { * Extract a valid enum value from a raw unknown value. * @param clockType Raw value. */ -const parseClockType = ( - clockType: any // eslint-disable-line @typescript-eslint/no-explicit-any -): ClockProps["clockType"] => { +const parseClockType = (clockType: unknown): ClockProps["clockType"] => { switch (clockType) { case "analogic": case "digital": @@ -43,12 +41,9 @@ const parseClockType = ( * Extract a valid enum value from a raw unknown value. * @param clockFormat Raw value. */ -const parseClockFormat = ( - clockFormat: any // eslint-disable-line @typescript-eslint/no-explicit-any -): ClockProps["clockFormat"] => { +const parseClockFormat = (clockFormat: unknown): ClockProps["clockFormat"] => { switch (clockFormat) { case "datetime": - case "date": case "time": return clockFormat; default: diff --git a/visual_console_client/src/items/Percentile.ts b/visual_console_client/src/items/Percentile.ts index d4dec30d59..1041847b43 100644 --- a/visual_console_client/src/items/Percentile.ts +++ b/visual_console_client/src/items/Percentile.ts @@ -36,8 +36,9 @@ export type PercentileProps = { * Extract a valid enum value from a raw type value. * @param type Raw value. */ -// eslint-disable-next-line @typescript-eslint/no-explicit-any -function extractPercentileType(type: any): PercentileProps["percentileType"] { +function extractPercentileType( + type: unknown +): PercentileProps["percentileType"] { switch (type) { case "progress-bar": case "bubble": @@ -60,8 +61,7 @@ function extractPercentileType(type: any): PercentileProps["percentileType"] { * Extract a valid enum value from a raw value type value. * @param type Raw value. */ -// eslint-disable-next-line @typescript-eslint/no-explicit-any -function extractValueType(valueType: any): PercentileProps["valueType"] { +function extractValueType(valueType: unknown): PercentileProps["valueType"] { switch (valueType) { case "percent": case "value": diff --git a/visual_console_client/src/items/SimpleValue.ts b/visual_console_client/src/items/SimpleValue.ts index 8464881a61..7cc5e139af 100644 --- a/visual_console_client/src/items/SimpleValue.ts +++ b/visual_console_client/src/items/SimpleValue.ts @@ -31,9 +31,7 @@ export type SimpleValueProps = { * Extract a valid enum value from a raw value type. * @param valueType Raw value. */ -const parseValueType = ( - valueType: any // eslint-disable-line @typescript-eslint/no-explicit-any -): SimpleValueProps["valueType"] => { +const parseValueType = (valueType: unknown): SimpleValueProps["valueType"] => { switch (valueType) { case "string": case "image": @@ -48,7 +46,7 @@ const parseValueType = ( * @param processValue Raw value. */ const parseProcessValue = ( - processValue: any // eslint-disable-line @typescript-eslint/no-explicit-any + processValue: unknown ): SimpleValueProps["processValue"] => { switch (processValue) { case "none": diff --git a/visual_console_client/src/items/StaticGraph.ts b/visual_console_client/src/items/StaticGraph.ts index 0e713dc5f3..899d54ec70 100644 --- a/visual_console_client/src/items/StaticGraph.ts +++ b/visual_console_client/src/items/StaticGraph.ts @@ -25,7 +25,7 @@ export type StaticGraphProps = { * @param showLastValueTooltip Raw value. */ const parseShowLastValueTooltip = ( - showLastValueTooltip: any // eslint-disable-line @typescript-eslint/no-explicit-any + showLastValueTooltip: unknown ): StaticGraphProps["showLastValueTooltip"] => { switch (showLastValueTooltip) { case "default":