tyler.durden/pandorafms
1
0
Fork 0
mirror of https://github.com/pandorafms/pandorafms.git synced 2025-07-31 01:35:36 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix SQL errors in action queries.

Browse Source
This commit is contained in:
Ramon Novoa 2021-10-26 13:24:23 +02:00 committed by fbsanchez
parent a5bf72cca0
commit 35aa6b5258
1 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
pandora_server/lib/PandoraFMS/Core.pm
View File

@ -905,7 +905,8 @@ sub pandora_execute_alert ($$$$$$$$$;$$) {
# Get default action # Get default action
if ($#actions < 0) { if ($#actions < 0) {
@actions = get_db_rows ($dbh, 'SELECT talert_actions.name as action_name, * FROM talert_actions, talert_commands @actions = get_db_rows ($dbh, 'SELECT talert_actions.name as action_name, talert_actions.*, talert_commands.*
FROM talert_actions, talert_commands
WHERE talert_actions.id = ? WHERE talert_actions.id = ?
AND talert_actions.id_alert_command = talert_commands.id', AND talert_actions.id_alert_command = talert_commands.id',
$alert->{'id_alert_action'}); $alert->{'id_alert_action'});
@ -914,7 +915,8 @@ sub pandora_execute_alert ($$$$$$$$$;$$) {
# Event alert # Event alert
else { else {
if ($alert_mode == RECOVERED_ALERT) { if ($alert_mode == RECOVERED_ALERT) {
@actions = get_db_rows ($dbh, 'SELECT talert_actions.name as action_name, * FROM tevent_alert_action, talert_actions, talert_commands @actions = get_db_rows ($dbh, 'SELECT talert_actions.name as action_name, tevent_alert_action.*, talert_actions.*, talert_commands.*
FROM tevent_alert_action, talert_actions, talert_commands
WHERE tevent_alert_action.id_alert_action = talert_actions.id WHERE tevent_alert_action.id_alert_action = talert_actions.id
AND talert_actions.id_alert_command = talert_commands.id AND talert_actions.id_alert_command = talert_commands.id
AND tevent_alert_action.id_event_alert = ? AND tevent_alert_action.id_event_alert = ?
@ -922,7 +924,8 @@ sub pandora_execute_alert ($$$$$$$$$;$$) {
OR ? >= fires_min)', OR ? >= fires_min)',
$alert->{'id'}, $alert->{'times_fired'}); $alert->{'id'}, $alert->{'times_fired'});
} else { } else {
@actions = get_db_rows ($dbh, 'SELECT talert_actions.name as action_name, * FROM tevent_alert_action, talert_actions, talert_commands @actions = get_db_rows ($dbh, 'SELECT talert_actions.name as action_name, tevent_alert_action.*, talert_actions.*, talert_commands.*
FROM tevent_alert_action, talert_actions, talert_commands
WHERE tevent_alert_action.id_alert_action = talert_actions.id WHERE tevent_alert_action.id_alert_action = talert_actions.id
AND talert_actions.id_alert_command = talert_commands.id AND talert_actions.id_alert_command = talert_commands.id
AND tevent_alert_action.id_event_alert = ? AND tevent_alert_action.id_event_alert = ?
@ -934,7 +937,8 @@ sub pandora_execute_alert ($$$$$$$$$;$$) {
# Get default action # Get default action
if ($#actions < 0) { if ($#actions < 0) {
@actions = get_db_rows ($dbh, 'SELECT talert_actions.name as action_name, * FROM talert_actions, talert_commands @actions = get_db_rows ($dbh, 'SELECT talert_actions.name as action_name, talert_actions.*, talert_commands.*
FROM talert_actions, talert_commands
WHERE talert_actions.id = ? WHERE talert_actions.id = ?
AND talert_actions.id_alert_command = talert_commands.id', AND talert_actions.id_alert_command = talert_commands.id',
$alert->{'id_alert_action'}); $alert->{'id_alert_action'});
@ -4242,7 +4246,7 @@ sub pandora_evaluate_snmp_alerts ($$$$$$$$$) {
} }
# Execute alert # Execute alert
my $action = get_db_single_row ($dbh, 'SELECT talert_actions.name as action_name, * my $action = get_db_single_row ($dbh, 'SELECT talert_actions.name as action_name, talert_actions.*, talert_commands.*
FROM talert_actions, talert_commands FROM talert_actions, talert_commands
WHERE talert_actions.id_alert_command = talert_commands.id WHERE talert_actions.id_alert_command = talert_commands.id
AND talert_actions.id = ?', $alert->{'id_alert'}); AND talert_actions.id = ?', $alert->{'id_alert'});
@ -4276,7 +4280,7 @@ sub pandora_evaluate_snmp_alerts ($$$$$$$$$) {
$alert->{'id_as'}); $alert->{'id_as'});
foreach my $other_alert (@more_actions_snmp) { foreach my $other_alert (@more_actions_snmp) {
my $other_action = get_db_single_row ($dbh, 'SELECT talert_actions.name as action_name, * my $other_action = get_db_single_row ($dbh, 'SELECT talert_actions.name as action_name, talert_actions.*, talert_commands.*
FROM talert_actions, talert_commands FROM talert_actions, talert_commands
WHERE talert_actions.id_alert_command = talert_commands.id WHERE talert_actions.id_alert_command = talert_commands.id
AND talert_actions.id = ?', $other_alert->{'alert_type'}); AND talert_actions.id = ?', $other_alert->{'alert_type'});