diff --git a/pandora_console/ChangeLog b/pandora_console/ChangeLog index 0b0728b666..f02e461e44 100644 --- a/pandora_console/ChangeLog +++ b/pandora_console/ChangeLog @@ -1,3 +1,13 @@ +2014-03-10 Miguel de Dios + + * godmode/modules/manage_network_components_form.php: fixed the + fields for wmi that was disabled. + + Incident: #637 + + * godmode/modules/manage_network_components_form_common.php, + godmode/modules/manage_network_components_form_wmi.php: + 2014-03-10 Miguel de Dios * include/graphs/flot/pandora.flot.js: fixed the position of buttons diff --git a/pandora_console/godmode/modules/manage_network_components_form.php b/pandora_console/godmode/modules/manage_network_components_form.php index 82939863d9..07c57811c8 100644 --- a/pandora_console/godmode/modules/manage_network_components_form.php +++ b/pandora_console/godmode/modules/manage_network_components_form.php @@ -239,20 +239,27 @@ ui_require_javascript_file('pandora_modules'); function type_change () { // type 1-4 - Generic_xxxxxx if ((document.component.type.value > 0) && (document.component.type.value < 5)) { - $("input[name=snmp_oid]").css({backgroundColor: '#ddd'}); - $("input[name=snmp_oid]").attr("disabled", true); $("input[name=snmp_community]").css({backgroundColor: '#ddd'}); $("input[name=snmp_community]").attr("disabled", true); - $("input[name=tcp_send]").css({backgroundColor: '#ddd'}); - $("input[name=tcp_send]").attr("disabled", true); - $("input[name=tcp_rcv]").css({backgroundColor: '#ddd'}); $("input[name=tcp_rcv]").attr("disabled", true); - $("input[name=tcp_port]").css({backgroundColor: '#ddd'}); - $("input[name=tcp_port]").attr("disabled", true); + + $("input[name=snmp_oid]").css({backgroundColor: '#ddd'}); + $("input[name=snmp_oid]").attr("disabled", true); + + $("input[name=tcp_send]").css({backgroundColor: '#ddd'}); + $("input[name=tcp_send]").attr("disabled", true); + + $("input[name=tcp_port]").css({backgroundColor: '#ddd'}); + $("input[name=tcp_port]").attr("disabled", true); + $("input[name=snmp3_auth_user]").css({backgroundColor: '#ddd'}); $("input[name=snmp3_auth_user]").attr("disabled", true); diff --git a/pandora_console/godmode/modules/manage_network_components_form_common.php b/pandora_console/godmode/modules/manage_network_components_form_common.php index 0501a445b4..17e3c1ebb2 100644 --- a/pandora_console/godmode/modules/manage_network_components_form_common.php +++ b/pandora_console/godmode/modules/manage_network_components_form_common.php @@ -173,7 +173,7 @@ else { $table->data[$next_row][0] = __('Tags'); -if($tags == '') { +if ($tags == '') { $tags_condition_not = '1 = 1'; $tags_condition_in = '1 = 0'; } diff --git a/pandora_console/godmode/modules/manage_network_components_form_wmi.php b/pandora_console/godmode/modules/manage_network_components_form_wmi.php index 52168647da..9d5f401df6 100644 --- a/pandora_console/godmode/modules/manage_network_components_form_wmi.php +++ b/pandora_console/godmode/modules/manage_network_components_form_wmi.php @@ -57,174 +57,4 @@ $data[0] = __('Post process') . ' ' . ui_print_help_icon ('postprocess', true, u $data[1] = html_print_input_text ('post_process', $post_process, '', 12, 25, true); $data[2] = $data[3] = ''; push_table_row($data, 'field_process'); - -return; -// Update an existing component -if (! $id) { - $module_interval = SECONDS_5MINUTES; - $tcp_port = ""; - $tcp_rcv = ""; - $tcp_send = ""; - $snmp_community = ""; - $id_module_group = ""; - $id_group = ""; - $type = 0; - $plugin_user = "Administrator"; - $plugin_pass = ""; - $plugin_parameter = ""; - $max_timeout = 10; - $max_retries = 1; -} - -echo '
'; - -echo ''; -echo ''; - -// Name -echo ''; -echo ''; - -// Type -echo ''; -echo ''; -echo ''; - -// Component group -echo ''; -echo ''; -echo ''; - -// Interval -echo ''; -echo ''; -echo ''; - -// Timeout -echo ''; -echo ''; - -// WMI Query -echo ''; -echo ''; - -// Key string -echo ''; -echo ''; - -// Field -echo ''; -echo ''; - -// Namespace -echo ''; -echo ''; - -// Username -echo ''; -echo ''; - -// Password -echo ''; -echo ''; - -// Min data -echo ''; -echo ''; -echo ''; -echo ''; - -// Comments -echo ''; -echo ''; -echo '
' . __('Module name') . '' . __('Module type') . ''; -echo ''; -echo '
' . __('Group') . ''; -html_print_select (network_components_get_groups (), - 'id_group', $id_group, '', '', '', false, false, false); - -// Module group -echo '' . __('Module group') . ''; -echo ''; -echo '
' . __('Module Interval') . ''; -echo ''; - -// Timeout -echo '' . __('Max. timeout') . ''; -echo ''; -echo '
' . __('Max. retries') . ''; -echo ''; -echo '
' . __('WMI query') ; -ui_print_help_icon("wmiquery", true, ui_get_full_url(false, false, false, false)); -echo ''; -echo ''; -echo '' . __('Key string'); -ui_print_help_icon("wmikey", true, ui_get_full_url(false, false, false, false)); -echo ''; -echo ''; -echo '
' . __('Field number'); -ui_print_help_icon("wmifield", true, ui_get_full_url(false, false, false, false)); -echo ''; -echo ''; -echo '' . __('Namespace'); -ui_print_help_icon("wminamespace", true, ui_get_full_url(false, false, false, false)); -echo ''; -echo ''; -echo '
' . __('Username') . ''; -echo ''; -echo '' . __('Password') . ''; -echo ''; -echo '
' . __('Minimum Data') . ''; -echo ''; -echo '' . __('Maximum Data') . ''; - -// Max data -echo ''; -echo '
'.__('Comments') . ''; -echo ''; -echo '
'; - -html_print_input_hidden ('id_modulo', $id_component_type); - -// Update/Add buttons -echo '
'; -if ($id) { - html_print_input_hidden ('update_component', 1); - html_print_input_hidden ('id', $id); - html_print_submit_button (__('Update'), 'crt', false, 'class="sub upd"'); -} -else { - html_print_input_hidden ('create_component', 1); - html_print_submit_button (__('Create'), 'crt', false, 'class="sub next"'); -} -echo '
'; -echo '
'; - ?>