From edbc9d8f6b224c1d9da4418aa0b8027d70c4a9b0 Mon Sep 17 00:00:00 2001 From: Jose Gonzalez Date: Thu, 9 Mar 2023 23:31:40 +0100 Subject: [PATCH 01/12] Icons review --- pandora_console/extensions/files_repo.php | 8 +- .../extensions/files_repo/files_repo_list.php | 11 ++- .../godmode/agentes/inventory_manager.php | 8 +- .../agentes/module_manager_editor_common.php | 33 +++++---- .../godmode/alerts/alert_commands.php | 4 +- .../godmode/alerts/alert_list.list.php | 2 +- pandora_console/godmode/alerts/alert_list.php | 8 +- .../godmode/alerts/alert_templates.php | 2 +- pandora_console/godmode/extensions.php | 3 +- .../module_library/module_library_view.php | 6 +- .../godmode/reporting/reporting_builder.php | 14 ++-- .../godmode/setup/setup_general.php | 8 +- .../godmode/setup/setup_visuals.php | 10 +-- .../godmode/snmpconsole/snmp_alert.php | 6 +- .../wizards/DiscoveryTaskList.class.php | 74 +++++++++---------- .../include/class/CalendarManager.class.php | 10 +-- .../include/class/Diagnostics.class.php | 4 +- .../include/class/EventSound.class.php | 10 +-- pandora_console/include/functions_cron.php | 50 ++++++------- .../include/functions_integriaims.php | 10 +-- .../include/functions_notifications.php | 18 +++-- .../include/functions_snmp_browser.php | 2 +- .../lib/ClusterViewer/ClusterManager.php | 12 +-- .../rest-api/models/VisualConsole/View.php | 54 ++++++++------ .../operation/netflow/nf_live_view.php | 6 +- .../operation/reporting/reporting_viewer.php | 18 ++--- pandora_console/operation/users/user_edit.php | 4 +- pandora_console/views/cluster/edit.php | 8 +- pandora_console/views/cluster/view.php | 22 +++--- 29 files changed, 222 insertions(+), 203 deletions(-) diff --git a/pandora_console/extensions/files_repo.php b/pandora_console/extensions/files_repo.php index 0313af90b2..656c3377c7 100644 --- a/pandora_console/extensions/files_repo.php +++ b/pandora_console/extensions/files_repo.php @@ -115,11 +115,11 @@ function pandora_files_repo_godmode() } // Header tabs. - $godmode['text'] = ''.html_print_image('images/setup.png', true, ['title' => __('Administration view'), 'class' => 'invert_filter']).''; + $godmode['text'] = ''.html_print_image('images/configuration@svg.svg', true, ['title' => __('Administration view'), 'class' => 'main_menu_icon invert_filter']).''; $godmode['godmode'] = 1; $godmode['active'] = 1; - $operation['text'] = ''.html_print_image('images/eye_show.png', true, ['title' => __('Operation view'), 'class' => 'invert_filter']).''; + $operation['text'] = ''.html_print_image('images/see-details@svg.svg', true, ['title' => __('Operation view'), 'class' => 'main_menu_icon invert_filter']).''; $operation['operation'] = 1; $onheader = [ @@ -226,10 +226,10 @@ function pandora_files_repo_operation() // Header tabs. $onheader = []; if (check_acl($config['id_user'], 0, 'PM')) { - $godmode['text'] = ''.html_print_image('images/setup.png', true, ['title' => __('Administration view'), 'class' => 'invert_filter']).''; + $godmode['text'] = ''.html_print_image('images/configuration@svg.svg', true, ['title' => __('Administration view'), 'class' => 'main_menu_icon invert_filter']).''; $godmode['godmode'] = 1; - $operation['text'] = ''.html_print_image('images/eye_show.png', true, ['title' => __('Operation view'), 'class' => 'invert_filter']).''; + $operation['text'] = ''.html_print_image('images/see-details@svg.svg', true, ['title' => __('Operation view'), 'class' => 'main_menu_icon invert_filter']).''; $operation['operation'] = 1; $operation['active'] = 1; diff --git a/pandora_console/extensions/files_repo/files_repo_list.php b/pandora_console/extensions/files_repo/files_repo_list.php index 6c75218d18..2cb464eec3 100644 --- a/pandora_console/extensions/files_repo/files_repo_list.php +++ b/pandora_console/extensions/files_repo/files_repo_list.php @@ -133,9 +133,12 @@ if (!empty($files)) { ); $data[4] .= ""; $data[4] .= html_print_image( - 'images/config.png', + 'images/edit.svg', true, - ['title' => __('Edit')] + [ + 'title' => __('Edit'), + 'class' => 'main_menu_icon invert_filter', + ] ); // Edit image $data[4] .= ''; @@ -145,11 +148,11 @@ if (!empty($files)) { ); $data[4] .= " "; $data[4] .= html_print_image( - 'images/cross.png', + 'images/delete.svg', true, [ 'title' => __('Delete'), - 'class' => 'invert_filter', + 'class' => 'main_menu_icon invert_filter', ] ); // Delete image diff --git a/pandora_console/godmode/agentes/inventory_manager.php b/pandora_console/godmode/agentes/inventory_manager.php index b8d8014545..42984caeda 100644 --- a/pandora_console/godmode/agentes/inventory_manager.php +++ b/pandora_console/godmode/agentes/inventory_manager.php @@ -235,7 +235,7 @@ if (db_get_num_rows($sql) == 0) { if ($id_policy) { $policy = policies_get_policy($id_policy); $data[0] = ''; - $data[0] .= html_print_image('images/policies_mc.png', true, ['border' => '0', 'title' => $policy['name']]); + $data[0] .= html_print_image('images/policy@svg.svg', true, ['border' => '0', 'title' => $policy['name'], 'class' => 'main_menu_icon invert_filter']); $data[0] .= ''; } else { $data[0] = ''; @@ -247,15 +247,15 @@ if (db_get_num_rows($sql) == 0) { $data[4] = human_time_description_raw($row['interval']); // Delete module $data[5] = ''; - $data[5] .= html_print_image('images/cross.png', true, ['border' => '0', 'title' => __('Delete'), 'class' => 'invert_filter']); + $data[5] .= html_print_image('images/delete.svg', true, ['border' => '0', 'title' => __('Delete'), 'class' => 'main_menu_icon invert_filter']); $data[5] .= '  '; // Update module $data[5] .= ''; - $data[5] .= html_print_image('images/config.png', true, ['border' => '0', 'title' => __('Update'), 'class' => 'invert_filter']); + $data[5] .= html_print_image('images/edit.svg', true, ['border' => '0', 'title' => __('Update'), 'class' => 'main_menu_icon invert_filter']); $data[5] .= '  '; // Force refresh module $data[5] .= ''; - $data[5] .= html_print_image('images/target.png', true, ['border' => '0', 'title' => __('Force'), 'class' => 'invert_filter']).''; + $data[5] .= html_print_image('images/change-active.svg', true, ['border' => '0', 'title' => __('Force'), 'class' => 'main_menu_icon invert_filter']).''; array_push($table->data, $data); } diff --git a/pandora_console/godmode/agentes/module_manager_editor_common.php b/pandora_console/godmode/agentes/module_manager_editor_common.php index 085afcb455..2cceb5fa34 100644 --- a/pandora_console/godmode/agentes/module_manager_editor_common.php +++ b/pandora_console/godmode/agentes/module_manager_editor_common.php @@ -290,7 +290,7 @@ $table_simple->rowclass['captions_module_n_type'] = 'field_half_width pdd_t_10px $table_simple->rowclass['module_n_type'] = 'field_half_width'; $table_simple->data['captions_module_n_type'][0] = html_print_input_hidden('id_module_type_hidden', $id_module_type, true); $table_simple->data['captions_module_n_type'][0] .= __('Module group'); -$table_simple->data['captions_module_n_type'][1] = __('Type').ui_print_help_icon($help_type, true, '', 'images/help_green.png', '', 'module_type_help'); +$table_simple->data['captions_module_n_type'][1] = __('Type').ui_print_help_icon($help_type, true, '', '', '', 'module_type_help'); // Module group and Type. $table_simple->rowclass['module_n_type'] = 'field_half_width'; $table_simple->data['module_n_type'][0] .= html_print_select_from_sql( @@ -1437,7 +1437,7 @@ if (isset($module_macros)) { $table_macros->data[$macro_count][2] = __('Value'); $table_macros->data[$macro_count][3] = html_print_input_text('module_macro_values[]', $macro_value, '', 50, 60, true, $disabledBecauseInPolicy, false, '', $classdisabledBecauseInPolicy); if (!$disabledBecauseInPolicy) { - $table_macros->data[$macro_count][4] = ''.html_print_image('images/cross.png', true, ['class' => 'invert_filter']).''; + $table_macros->data[$macro_count][4] = ''.html_print_image('images/delete.svg', true, ['class' => 'main_menu_icon invert_filter']).''; } $macro_count++; @@ -1446,7 +1446,7 @@ if (isset($module_macros)) { } if (!$disabledBecauseInPolicy) { - $table_macros->data[$macro_count][0] = ''.__('Custom macros').' '.html_print_image('images/add.png', true, ['class' => 'invert_filter']).''; + $table_macros->data[$macro_count][0] = ''.__('Custom macros').' '.html_print_image('images/fail@svg.svg', true, ['style' => 'rotate:45deg', 'class' => 'main_menu_icon invert_filter']).''; $table_macros->colspan[$macro_count][0] = 5; } @@ -1535,14 +1535,15 @@ $table_relations->data[-1][1] = ''; $table_relations->data[-1][2] = ''; $table_relations->data[-1][3] = ''; $table_relations->data[-1][3] .= html_print_image( - 'images/lock_mc.png', - true + 'images/policy@svg.svg', + true, + ['class' => 'main_menu_icon invert_filter'] ).''; $table_relations->data[-1][4] = ''; $table_relations->data[-1][4] .= html_print_image( - 'images/cross.png', + 'images/delete.svg', true, - ['class' => 'invert_filter'] + ['class' => 'main_menu_icon invert_filter'] ).''; @@ -1598,15 +1599,15 @@ if ($id_agent_module) { $table_relations->data[$relations_count][2] = ($module_relation['type'] === 'direct') ? __('Direct') : __('Failover'); // Lock relationship updates. $table_relations->data[$relations_count][3] = ''.html_print_image( - 'images/lock_mc.png', + 'images/policy@svg.svg', true, - ['class' => 'invert_filter'] + ['class' => 'main_menu_icon invert_filter'] ).''; // Delete relationship. $table_relations->data[$relations_count][4] = ''.html_print_image( - 'images/cross.png', + 'images/delete.svg', true, - ['class' => 'invert_filter'] + ['class' => 'main_menu_icon invert_filter'] ).''; $relations_count++; } @@ -2035,7 +2036,7 @@ function change_modules_autocomplete_input () { var id_agent = parseInt($("#hidden-autocomplete_id_agent").val()); var module_autocomplete = $("#module_autocomplete"); var load_icon = ''; - var error_icon = ''; + var error_icon = ' 'main_menu_icon invert_filter']); ?>'; if (!module_autocomplete.hasClass('working')) { module_autocomplete.addClass('working'); module_autocomplete.html(load_icon); @@ -2086,8 +2087,8 @@ function add_new_relation () { var button = $("#button-add_relation"); var iconPlaceholder = $("#add_relation_status"); var load_icon = ' 'vertical-align:middle;']); ?>'; - var suc_icon = ' 'vertical-align:middle;']); ?>'; - var error_icon = ' 'vertical-align:middle;']); ?>'; + var suc_icon = ' 'main_menu_icon invert_filter', 'style' => 'vertical-align:middle;']); ?>'; + var error_icon = ' 'main_menu_icon invert_filter', 'style' => 'vertical-align:middle;']); ?>'; if (!button.hasClass('working')) { button.addClass('working'); @@ -2129,12 +2130,12 @@ function add_new_relation () { '' + relation_type + '' + '' + '' + - ' 'invert_filter']); ?>' + + ' 'main_menu_icon invert_filter']); ?>' + '' + '' + '' + '' + - ' 'invert_filter']); ?>' + + ' 'main_menu_icon invert_filter']); ?>' + '' + '' + ''; diff --git a/pandora_console/godmode/alerts/alert_commands.php b/pandora_console/godmode/alerts/alert_commands.php index 696882e133..9b22483f5c 100644 --- a/pandora_console/godmode/alerts/alert_commands.php +++ b/pandora_console/godmode/alerts/alert_commands.php @@ -809,10 +809,10 @@ foreach ($commands as $command) { if (is_user_admin($config['id_user']) === true) { $data['action'] = ''; $data['action'] .= ''.html_print_image('images/copy.png', true, ['class' => 'invert_filter']).''; + onClick="if (!confirm(\''.__('Are you sure?').'\')) return false;">'.html_print_image('images/copy.svg', true, ['class' => 'main_menu_icon invert_filter']).''; $data['action'] .= ''.html_print_image('images/cross.png', true, ['class' => 'invert_filter']).''; + onClick="if (!confirm(\''.__('Are you sure?').'\')) return false;">'.html_print_image('images/delete.svg', true, ['class' => 'main_menu_icon invert_filter']).''; $data['action'] .= ''; } } diff --git a/pandora_console/godmode/alerts/alert_list.list.php b/pandora_console/godmode/alerts/alert_list.list.php index 854905343a..f844d2c18d 100644 --- a/pandora_console/godmode/alerts/alert_list.list.php +++ b/pandora_console/godmode/alerts/alert_list.list.php @@ -1053,7 +1053,7 @@ foreach ($simple_alerts as $alert) { $data[4] .= '
'; $data[4] .= html_print_input_image( 'view_alert', - 'images/operation.png', + 'images/details.svg', 1, '', true, diff --git a/pandora_console/godmode/alerts/alert_list.php b/pandora_console/godmode/alerts/alert_list.php index 4d23bb8d6f..55f786c3c2 100644 --- a/pandora_console/godmode/alerts/alert_list.php +++ b/pandora_console/godmode/alerts/alert_list.php @@ -478,17 +478,17 @@ if ($standbyoff_alert) { $searchFlag = true; -if (!is_metaconsole()) { +if (is_metaconsole() === false) { // The tabs will be shown only with manage alerts permissions if (check_acl($config['id_user'], 0, 'LW') || check_acl($config['id_user'], 0, 'LM')) { $buttons = [ 'list' => [ 'active' => false, - 'text' => ''.html_print_image('images/list.png', true, ['title' => __('List alerts'), 'class' => 'invert_filter']).'', + 'text' => ''.html_print_image('images/load@svg.svg', true, ['title' => __('List alerts'), 'class' => 'main_menu_icon invert_filter']).'', ], 'builder' => [ 'active' => false, - 'text' => ''.html_print_image('images/pencil.png', true, ['title' => __('Builder alert'), 'class' => 'invert_filter']).'', + 'text' => ''.html_print_image('images/edit.svg', true, ['title' => __('Builder alert'), 'class' => 'main_menu_icon invert_filter']).'', ], ]; @@ -497,7 +497,7 @@ if (!is_metaconsole()) { $buttons = ''; } - if ($tab == 'list') { + if ($tab === 'list') { ui_print_standard_header( __('Alerts'), 'images/gm_alerts.png', diff --git a/pandora_console/godmode/alerts/alert_templates.php b/pandora_console/godmode/alerts/alert_templates.php index fbe2835354..23d94b094d 100644 --- a/pandora_console/godmode/alerts/alert_templates.php +++ b/pandora_console/godmode/alerts/alert_templates.php @@ -450,7 +450,7 @@ foreach ($templates as $template) { $data[4] .= html_print_input_hidden('source_id', $template['id'], true); $data[4] .= html_print_input_image( 'dup', - 'images/copy.png', + 'images/copy.svg', 1, '', true, diff --git a/pandora_console/godmode/extensions.php b/pandora_console/godmode/extensions.php index 8faef70d3e..69c5e59b8b 100644 --- a/pandora_console/godmode/extensions.php +++ b/pandora_console/godmode/extensions.php @@ -295,7 +295,8 @@ foreach ($extensions as $file => $extension) { $data[] = html_print_menu_button( [ 'href' => 'index.php?sec=godmode/extensions&sec2=godmode/extensions&enterprise='.(int) $extension['enterprise'].'&delete='.$file, - 'image' => 'images/cross.png', + 'image' => 'images/delete.svg', + 'class' => 'main_menu_icon invert_filter', 'title' => __('Delete'), 'onClick' => 'if (!confirm(\''.__('Are you sure?').'\')) return false;', ], diff --git a/pandora_console/godmode/module_library/module_library_view.php b/pandora_console/godmode/module_library/module_library_view.php index aeab26be20..aea7681f3b 100644 --- a/pandora_console/godmode/module_library/module_library_view.php +++ b/pandora_console/godmode/module_library/module_library_view.php @@ -45,18 +45,18 @@ if (! check_acl($config['id_user'], 0, 'AR')) { if (check_acl($config['id_user'], 0, 'PM') && enterprise_installed()) { $buttons['setup'] = [ 'active' => false, - 'text' => ''.html_print_image('images/gm_setup.png', true, ['title' => __('Setup'), 'class' => 'invert_filter']).'', + 'text' => ''.html_print_image('images/configuration@svg.svg', true, ['title' => __('Setup'), 'class' => 'main_menu_icon invert_filter']).'', ]; } $buttons['categories'] = [ 'active' => false, - 'text' => ''.html_print_image('images/list.png', true, ['title' => __('Categories'), 'class' => 'invert_filter']).'', + 'text' => ''.html_print_image('images/logs@svg.svg', true, ['title' => __('Categories'), 'class' => 'main_menu_icon invert_filter']).'', ]; $buttons['view'] = [ 'active' => false, - 'text' => ''.html_print_image('images/eye_show.png', true, ['title' => __('View'), 'class' => 'invert_filter']).'', + 'text' => ''.html_print_image('images/see-details@svg.svg', true, ['title' => __('View'), 'class' => 'main_menu_icon invert_filter']).'', ]; diff --git a/pandora_console/godmode/reporting/reporting_builder.php b/pandora_console/godmode/reporting/reporting_builder.php index a4f688ab05..a0e25d0e04 100755 --- a/pandora_console/godmode/reporting/reporting_builder.php +++ b/pandora_console/godmode/reporting/reporting_builder.php @@ -3680,21 +3680,21 @@ $buttons = [ true, [ 'title' => __('Reports list'), - 'class' => 'invert_filter', + 'class' => 'main_menu_icon invert_filter', ] ).'', ], 'main' => [ 'active' => false, - 'text' => ''.html_print_image('images/op_reporting.png', true, ['title' => __('Main data'), 'class' => 'invert_filter']).'', + 'text' => ''.html_print_image('images/op_reporting.png', true, ['title' => __('Main data'), 'class' => 'main_menu_icon invert_filter']).'', ], 'list_items' => [ 'active' => false, - 'text' => ''.html_print_image('images/list.png', true, ['title' => __('List items'), 'class' => 'invert_filter']).'', + 'text' => ''.html_print_image('images/logs@svg.svg', true, ['title' => __('List items'), 'class' => 'main_menu_icon invert_filter']).'', ], 'item_editor' => [ 'active' => false, - 'text' => ''.html_print_image('images/pencil.png', true, ['title' => __('Item editor'), 'class' => 'invert_filter']).'', + 'text' => ''.html_print_image('images/edit.svg', true, ['title' => __('Item editor'), 'class' => 'main_menu_icon invert_filter']).'', ], ]; @@ -3708,11 +3708,11 @@ if ($enterpriseEnable) { $buttons['view'] = [ 'active' => false, 'text' => ''.html_print_image( - 'images/eye.png', + 'images/see-details@svg.svg', true, [ 'title' => __('View report'), - 'class' => 'invert_filter', + 'class' => 'main_menu_icon invert_filter', ] ).'', ]; @@ -3727,7 +3727,7 @@ if ($idReport != 0) { $buttons = [ 'main' => [ 'active' => true, - 'text' => ''.html_print_image('images/report_list.png', true, ['title' => __('Reports list'), 'class' => 'invert_filter']).'', + 'text' => ''.html_print_image('images/report_list.png', true, ['title' => __('Reports list'), 'class' => 'main_menu_icon invert_filter']).'', ], ]; $textReportName = __('Create Custom Report'); diff --git a/pandora_console/godmode/setup/setup_general.php b/pandora_console/godmode/setup/setup_general.php index fc169f91a2..d19d3587c6 100644 --- a/pandora_console/godmode/setup/setup_general.php +++ b/pandora_console/godmode/setup/setup_general.php @@ -292,11 +292,11 @@ $table->data[$i][1] = html_print_input_text_extended( true ); $table->data[$i][1] .= ''.html_print_image( - 'images/pencil.png', + 'images/edit.svg', true, [ 'title' => __('Change timezone'), - 'class' => 'invert_filter', + 'class' => 'main_menu_icon invert_filter', ] ).''; $table->data[$i][1] .= '  '.html_print_select( @@ -423,9 +423,9 @@ $table_ichanges = ' diff --git a/pandora_console/godmode/setup/setup_visuals.php b/pandora_console/godmode/setup/setup_visuals.php index 73b2511b2b..5fb042fe66 100755 --- a/pandora_console/godmode/setup/setup_visuals.php +++ b/pandora_console/godmode/setup/setup_visuals.php @@ -1626,11 +1626,11 @@ if ($config['csv_divider'] != ';' && $config['csv_divider'] != ',' && $config['c true ); $table_other->data[$row][1] .= ''.html_print_image( - 'images/list.png', + 'images/logs@svg.svg', true, [ 'id' => 'select', - 'class' => 'invert_filter', + 'class' => 'main_menu_icon invert_filter', ] ).''; } else { @@ -1646,11 +1646,11 @@ if ($config['csv_divider'] != ';' && $config['csv_divider'] != ',' && $config['c false ); $table_other->data[$row][1] .= ''.html_print_image( - 'images/pencil.png', + 'images/edit.svg', true, [ 'id' => 'pencil', - 'class' => 'invert_filter', + 'class' => 'main_menu_icon invert_filter', ] ).''; } @@ -1777,7 +1777,7 @@ function edit_csv_divider () { $("#text-csv_divider").val(value); } else { - $("#csv_divider_custom img").attr("src", "images/pencil.png"); + $("#csv_divider_custom img").attr("src", "images/edit.svg"); $("#csv_divider_custom img").attr("id", "pencil"); $("#text-csv_divider").replaceWith("'; echo ''; @@ -545,14 +545,14 @@ if (is_metaconsole()) {
'.$select_out.' - '.html_print_image('images/darrowright.png', true, ['id' => 'right_iblacklist', 'alt' => __('Push selected modules into blacklist'), 'title' => __('Push selected modules into blacklist'), 'class' => 'invert_filter']).' + '.html_print_image('images/arrow@svg.svg', true, ['style' => 'rotate: 180deg;', 'id' => 'right_iblacklist', 'alt' => __('Push selected modules into blacklist'), 'title' => __('Push selected modules into blacklist'), 'class' => 'main_menu_icon invert_filter']).'

- '.html_print_image('images/darrowleft.png', true, ['id' => 'left_iblacklist', 'alt' => __('Pop selected modules out of blacklist'), 'title' => __('Pop selected modules out of blacklist'), 'class' => 'invert_filter']).' + '.html_print_image('images/arrow@svg.svg', true, ['style' => 'rotate: 0', 'id' => 'left_iblacklist', 'alt' => __('Pop selected modules out of blacklist'), 'title' => __('Pop selected modules out of blacklist'), 'class' => 'main_menu_icon invert_filter']).'
'.$select_in.'
'.html_print_select($max_values, 'max_aggregates', $max_aggregates, '', '', 0, true).''.html_print_image('images/pencil.png', true, ['id' => 'pencil']).''; + echo ''.html_print_select($max_values, 'max_aggregates', $max_aggregates, '', '', 0, true).''.html_print_image('images/edit.svg', true, ['id' => 'pencil', 'class' => 'main_menu_icon invert_filter']).''; echo ''.__('Aggregate by').'