From 3e2391a7c3bbc264d377219c32d707c7d8960346 Mon Sep 17 00:00:00 2001
From: Alejandro Gallardo Escobar <alex@artica.es>
Date: Tue, 16 Jun 2015 17:53:30 +0200
Subject: [PATCH] Fixed the alert info retrieving for oracle databases

---
 pandora_console/include/functions_alerts.php | 50 ++++++++++++--------
 1 file changed, 29 insertions(+), 21 deletions(-)

diff --git a/pandora_console/include/functions_alerts.php b/pandora_console/include/functions_alerts.php
index 088f215741..c6edeffea1 100644
--- a/pandora_console/include/functions_alerts.php
+++ b/pandora_console/include/functions_alerts.php
@@ -662,30 +662,38 @@ function alerts_get_alert_templates ($filter = false, $fields = false) {
 function alerts_get_alert_template ($id_alert_template) {
 	global $config;
 	
+	$alert_templates = false;
 	$id_alert_template = safe_int ($id_alert_template, 1);
-	if (empty ($id_alert_template))
-		return false;
 	
-	switch ($config['dbtype']) {
-		case "mysql":
-		case "postgresql":
-			return db_get_row ('talert_templates', 'id', $id_alert_template);
-			break;
-		case "oracle":
-			$fields_select = db_get_all_rows_sql('SELECT column_name
-				FROM user_tab_columns
-				WHERE table_name = \'TALERT_TEMPLATES\'
-					AND column_name NOT IN (\'TIME_FROM\',\'TIME_TO\')');
-			foreach ($fields_select as $field_select){
-				$select_field[] = $field_select['column_name'];
-			}
-			$select_stmt = implode(',', $select_field);
-			return db_get_row_sql("SELECT $select_stmt,
-					to_char(time_from, 'hh24:mi:ss') AS time_from,
-					to_char(time_to, 'hh24:mi:ss') AS time_to
-				FROM talert_templates");	
-			break;
+	if (!empty ($id_alert_template)) {
+		switch ($config['dbtype']) {
+			case "mysql":
+			case "postgresql":
+				$alert_templates = db_get_row ('talert_templates', 'id', $id_alert_template);
+				break;
+			case "oracle":
+				$sql = "SELECT column_name
+						FROM user_tab_columns
+						WHERE table_name = 'TALERT_TEMPLATES'
+							AND column_name NOT IN ('TIME_FROM','TIME_TO')";
+				$fields_select = db_get_all_rows_sql($sql);
+				
+				$column_names = array_map(function($item) {
+					return $item['column_name'];
+				}, $fields_select);
+				$column_names_str = implode(',', $column_names);
+				
+				$sql = "SELECT $column_names_str,
+							to_char(time_from, 'hh24:mi:ss') AS time_from,
+							to_char(time_to, 'hh24:mi:ss') AS time_to
+						FROM talert_templates
+						WHERE id = $id_alert_template";
+				$alert_templates = db_get_row_sql($sql);
+				break;
+		}
 	}
+	
+	return $alert_templates;
 }
 
 /**