From 48e9c1466ba7486661fa00b8c7fd29bd5c80ff3f Mon Sep 17 00:00:00 2001 From: Alejandro Gallardo Escobar Date: Mon, 8 Apr 2019 17:16:05 +0200 Subject: [PATCH] Visual Console Refactor: fixed some linter errors Former-commit-id: 728223630dc81243e37057657428646b7f03dc78 --- .../models/VisualConsole/Container.php | 32 ++++++++----------- 1 file changed, 13 insertions(+), 19 deletions(-) diff --git a/pandora_console/include/rest-api/models/VisualConsole/Container.php b/pandora_console/include/rest-api/models/VisualConsole/Container.php index 9c8e18bc6d..9212527627 100644 --- a/pandora_console/include/rest-api/models/VisualConsole/Container.php +++ b/pandora_console/include/rest-api/models/VisualConsole/Container.php @@ -230,40 +230,34 @@ final class Container extends Model return Items\Icon::class; // Enterprise item. - case SERVICE:{ - if (\class_exists('Service') === true) { - return Service::class; - } else { - return Item::class; - } - } + case SERVICE: + return \class_exists('Service') ? Service::class : Item::class; case GROUP_ITEM: - return Items\Group::class; + return Items\Group::class; - case BOX_ITEM: + case BOX_ITEM: return Items\Box::class; - case LINE_ITEM: + case LINE_ITEM: return Items\Line::class; - case AUTO_SLA_GRAPH: + case AUTO_SLA_GRAPH: return Items\EventsHistory::class; - case DONUT_GRAPH: + case DONUT_GRAPH: return Items\DonutGraph::class; - case BARS_GRAPH: - // TODO: Instance return. - break; + case BARS_GRAPH: + return Items\BarsGraph::class; - case CLOCK: + case CLOCK: return Items\Clock::class; - case COLOR_CLOUD: + case COLOR_CLOUD: return Items\ColorCloud::class; - default: + default: return Item::class; } } @@ -288,7 +282,7 @@ final class Container extends Model if ($rows === false) { $rows = []; - // TODO: throw new \Exception('error fetching the data from the DB'); + // TODO: throw new \Exception('error fetching the data from the DB');. } $items = [];