';
echo __('Edit or delete groups can cause problems with synchronization');
@@ -368,7 +380,7 @@ $delete_group = (bool) get_parameter('delete_group');
$pure = get_parameter('pure', 0);
// Create group.
-if (($create_group) && (check_acl($config['id_user'], 0, 'PM'))) {
+if (($create_group) && (check_acl($config['id_user'], 0, 'PM') === true)) {
$name = (string) get_parameter('name');
$icon = (string) get_parameter('icon');
$id_parent = (int) get_parameter('id_parent');
@@ -460,7 +472,7 @@ if ($update_group) {
$values = [
'nombre' => $name,
'icon' => empty($icon) ? '' : substr($icon, 0, -4),
- 'parent' => $id_parent,
+ 'parent' => $id_parent == -1 ? 0 : $id_parent,
'disabled' => !$alerts_enabled,
'custom_id' => $custom_id,
'id_skin' => $skin,
@@ -492,7 +504,7 @@ if ($update_group) {
}
// Delete group.
-if (($delete_group) && (check_acl($config['id_user'], 0, 'PM'))) {
+if (($delete_group) && (check_acl($config['id_user'], 0, 'PM') === true)) {
$id_group = (int) get_parameter('id_group');
$usedGroup = groups_check_used($id_group);
@@ -508,28 +520,42 @@ if (($delete_group) && (check_acl($config['id_user'], 0, 'PM'))) {
$success_nodes = [];
$error_nodes = [];
// Check if the group can be deleted or not.
- foreach ($servers as $server) {
- if (metaconsole_connect($server) == NOERR) {
- $result_exist_group = db_get_row_filter('tgrupo', ['nombre' => $group_name, 'id_grupo' => $id_group]);
- if ($result_exist_group !== false) {
- $used_group = groups_check_used($id_group);
- // Save the names of the nodes that are empty and can be deleted, and those that cannot.
- if (!$used_group['return']) {
- $success_nodes[] .= $server['server_name'];
- $success_counter++;
- } else {
- $error_nodes[] .= $server['server_name'];
- $error_counter++;
+ if (isset($servers) === true
+ && is_array($servers) === true
+ ) {
+ foreach ($servers as $server) {
+ if (metaconsole_connect($server) == NOERR) {
+ $result_exist_group = db_get_row_filter(
+ 'tgrupo',
+ [
+ 'nombre' => $group_name,
+ 'id_grupo' => $id_group,
+ ]
+ );
+ if ($result_exist_group !== false) {
+ $used_group = groups_check_used($id_group);
+ // Save the names of the nodes that are empty
+ // and can be deleted, and those that cannot.
+ if (!$used_group['return']) {
+ $success_nodes[] .= $server['server_name'];
+ $success_counter++;
+ } else {
+ $error_nodes[] .= $server['server_name'];
+ $error_counter++;
+ }
}
}
- }
- metaconsole_restore_db();
+ metaconsole_restore_db();
+ }
}
if ($error_counter > 0) {
ui_print_error_message(
- __('The group %s could not be deleted because it is not empty in the nodes', $group_name).': '.implode(', ', $error_nodes)
+ __(
+ 'The group %s could not be deleted because it is not empty in the nodes',
+ $group_name
+ ).': '.implode(', ', $error_nodes)
);
$errors_meta = true;
} else {
@@ -540,60 +566,80 @@ if (($delete_group) && (check_acl($config['id_user'], 0, 'PM'))) {
$success_deleting = [];
$error_connecting_node = [];
// Delete the group in the nodes.
- foreach ($servers as $server) {
- if (metaconsole_connect($server) == NOERR) {
- $group = db_get_row_filter(
- 'tgrupo',
- ['id_grupo' => $id_group]
- );
+ if (isset($servers) === true
+ && is_array($servers) === true
+ ) {
+ foreach ($servers as $server) {
+ if (metaconsole_connect($server) == NOERR) {
+ $group = db_get_row_filter(
+ 'tgrupo',
+ ['id_grupo' => $id_group]
+ );
- db_process_sql_update(
- 'tgrupo',
- ['parent' => $group['parent']],
- ['parent' => $id_group]
- );
+ db_process_sql_update(
+ 'tgrupo',
+ ['parent' => $group['parent']],
+ ['parent' => $id_group]
+ );
- db_process_sql_delete(
- 'tgroup_stat',
- ['id_group' => $id_group]
- );
+ db_process_sql_delete(
+ 'tgroup_stat',
+ ['id_group' => $id_group]
+ );
- $result = db_process_sql_delete(
- 'tgrupo',
- ['id_grupo' => $id_group]
- );
+ $result = db_process_sql_delete(
+ 'tgrupo',
+ ['id_grupo' => $id_group]
+ );
- if ($result === false) {
- $error_deleting[] .= $server['server_name'];
- $error_deleting_counter++;
+ if ($result === false) {
+ $error_deleting[] .= $server['server_name'];
+ $error_deleting_counter++;
+ } else {
+ $success_deleting[] .= $server['server_name'];
+ $success_deleting_counter++;
+ }
} else {
- $success_deleting[] .= $server['server_name'];
- $success_deleting_counter++;
+ $error_deleting_counter++;
+ $error_connecting_node[] .= $server['server_name'];
}
- } else {
- $error_deleting_counter++;
- $error_connecting_node[] .= $server['server_name'];
- }
- metaconsole_restore_db();
+ metaconsole_restore_db();
+ }
}
- // If the group could not be deleted in any node, do not delete it in meta.
+ // If the group could not be deleted in any node,
+ // do not delete it in meta.
if ($error_deleting_counter > 0) {
$errors_meta = true;
- if (!empty($error_connecting_node)) {
- ui_print_error_message(__('Error connecting to %s', implode(', ', $error_connecting_node).'. The group has not been deleted in the metaconsole.'));
+ if (empty($error_connecting_node) === false) {
+ ui_print_error_message(
+ __(
+ 'Error connecting to %s',
+ implode(
+ ', ',
+ $error_connecting_node
+ ).'. The group has not been deleted in the metaconsole.'
+ )
+ );
}
- if (!empty($error_deleting)) {
+ if (empty($error_deleting) === false) {
ui_print_error_message(
- __('The group has not been deleted in the metaconsole due to an error in the node database').': '.implode(', ', $error_deleting)
+ __(
+ 'The group has not been deleted in the metaconsole due to an error in the node database'
+ ).': '.implode(', ', $error_deleting)
);
}
}
if ($success_deleting_counter > 0) {
- ui_print_success_message(__('The group %s has been deleted in the nodes', $group_name).': '.implode(', ', $success_deleting));
+ ui_print_success_message(
+ __(
+ 'The group %s has been deleted in the nodes',
+ $group_name
+ ).': '.implode(', ', $success_deleting)
+ );
}
}
}
@@ -624,12 +670,17 @@ if (($delete_group) && (check_acl($config['id_user'], 0, 'PM'))) {
if ($result && (!$usedGroup['return'])) {
ui_print_success_message(__('Group successfully deleted'));
} else {
- ui_print_error_message(__('There was a problem deleting group'));
+ ui_print_error_message(
+ __('There was a problem deleting group')
+ );
}
}
} else {
ui_print_error_message(
- sprintf(__('The group is not empty. It is use in %s.'), implode(', ', $usedGroup['tables']))
+ sprintf(
+ __('The group is not empty. It is use in %s.'),
+ implode(', ', $usedGroup['tables'])
+ )
);
}
}
@@ -662,14 +713,14 @@ if ($tab == 'tree') {
$search = (string) get_parameter('search', '');
$block_size = $config['block_size'];
- if (!empty($search)) {
+ if (empty($search) === false) {
$search_name = 'AND t.nombre LIKE "%'.$search.'%"';
}
- if (!users_can_manage_group_all('AR')) {
+ if (users_can_manage_group_all('AR') === false) {
$user_groups_acl = users_get_groups(false, 'AR');
- $groups_acl = implode(',', $user_groups_ACL);
- if (empty($groups_acl)) {
+ $groups_acl = implode('","', $user_groups_acl);
+ if (empty($groups_acl) === true) {
return ui_print_info_message(
[
'no_close' => true,
@@ -678,13 +729,20 @@ if ($tab == 'tree') {
);
}
- $acl = 'AND t.id_grupo IN ('.$groups_acl.')';
+ $acl = 'AND t.nombre IN ("'.$groups_acl.'")';
}
$form = "