From 3f9bdf65df137a4d503e4dac742b35e9976da414 Mon Sep 17 00:00:00 2001
From: fbsanchez <fborja.sanchez@artica.es>
Date: Mon, 6 Apr 2020 13:00:09 +0200
Subject: [PATCH 1/4] minor fixes and target selection (buttons)

---
 .../godmode/wizards/DiscoveryTaskList.class.php            | 4 ++--
 pandora_console/include/styles/task_list.css               | 7 ++++++-
 2 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/pandora_console/godmode/wizards/DiscoveryTaskList.class.php b/pandora_console/godmode/wizards/DiscoveryTaskList.class.php
index 434c79fbc4..f41eada844 100644
--- a/pandora_console/godmode/wizards/DiscoveryTaskList.class.php
+++ b/pandora_console/godmode/wizards/DiscoveryTaskList.class.php
@@ -1295,10 +1295,10 @@ class DiscoveryTaskList extends HTML
             echo '<span>';
             echo __('Please select devices to be monitored');
             echo '</span><div class="manage">';
-            echo '<button onclick="$(\'.sim-tree li a\').each(function(){simTree_tree.doCheck($(this), false); simTree_tree.clickNode($(this));});">';
+            echo '<button onclick="$(\'.sim-tree li:not(.disabled) a\').each(function(){simTree_tree.doCheck($(this), false); simTree_tree.clickNode($(this));});">';
             echo __('select all');
             echo '</button>';
-            echo '<button onclick="$(\'.sim-tree li a\').each(function(){simTree_tree.doCheck($(this), true); simTree_tree.clickNode($(this));});">';
+            echo '<button onclick="$(\'.sim-tree li:not(.disabled) a\').each(function(){simTree_tree.doCheck($(this), true); simTree_tree.clickNode($(this));});">';
             echo __('deselect all');
             echo '</button>';
             echo '<button onclick="$(\'.sim-tree-spread.sim-icon-r\').click();">';
diff --git a/pandora_console/include/styles/task_list.css b/pandora_console/include/styles/task_list.css
index 1b29103cfd..4cb248460f 100644
--- a/pandora_console/include/styles/task_list.css
+++ b/pandora_console/include/styles/task_list.css
@@ -57,10 +57,15 @@ div.subtitle div.manage button {
   font-size: 1.2em;
   font-family: "lato", "Open Sans", sans-serif;
   display: inline-block;
-  padding: 5px;
   margin-right: 1em;
   cursor: pointer;
   text-align: left;
+  border-radius: 21px;
+  box-shadow: 0 0 10px -5px #888;
+  padding: 0.5em 1em;
+  border: 1px solid #ddd;
+  user-select: none;
+  color: #424242;
 }
 
 div.subtitle .link.review {

From 6cb9b06cea84f8c88333f9943381ef5530e6d1fb Mon Sep 17 00:00:00 2001
From: fbsanchez <fborja.sanchez@artica.es>
Date: Mon, 6 Apr 2020 13:42:39 +0200
Subject: [PATCH 2/4] minor fix, license limits while reapplying queue

---
 .../wizards/DiscoveryTaskList.class.php        | 18 +++++++++++++++---
 1 file changed, 15 insertions(+), 3 deletions(-)

diff --git a/pandora_console/godmode/wizards/DiscoveryTaskList.class.php b/pandora_console/godmode/wizards/DiscoveryTaskList.class.php
index f41eada844..379ac3dae5 100644
--- a/pandora_console/godmode/wizards/DiscoveryTaskList.class.php
+++ b/pandora_console/godmode/wizards/DiscoveryTaskList.class.php
@@ -1343,9 +1343,21 @@ class DiscoveryTaskList extends HTML
             $ids = array_reduce(
                 $selection,
                 function ($carry, $item) use (&$n_agents) {
-                    if (explode('-', $item['id'])[1] === null) {
-                        // String is agent-module.
-                        $n_agents++;
+                    // String is agent-module.
+                    $fields = explode('-', $item['id']);
+                    $agent_name = $fields[0];
+                    $module_name = $fields[1];
+                    if ($module_name === null) {
+                        // Do not count if already created.
+                        if (db_get_value(
+                            'id_agente',
+                            'tagente',
+                            'nombre',
+                            io_safe_input($agent_name)
+                        ) === false
+                        ) {
+                            $n_agents++;
+                        }
                     }
 
                     $carry[] = $item['id'];

From c743a2b204e3438d89c26854a7601d8a5366b709 Mon Sep 17 00:00:00 2001
From: fbsanchez <fborja.sanchez@artica.es>
Date: Mon, 6 Apr 2020 14:32:20 +0200
Subject: [PATCH 3/4] minor fix

---
 pandora_console/godmode/wizards/DiscoveryTaskList.class.php | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/pandora_console/godmode/wizards/DiscoveryTaskList.class.php b/pandora_console/godmode/wizards/DiscoveryTaskList.class.php
index 379ac3dae5..041053c2be 100644
--- a/pandora_console/godmode/wizards/DiscoveryTaskList.class.php
+++ b/pandora_console/godmode/wizards/DiscoveryTaskList.class.php
@@ -1423,7 +1423,9 @@ class DiscoveryTaskList extends HTML
                                 $data['modules'][$module_name]['checked'] = 1;
                             } else {
                                 if ($data['modules'][$module_name]['checked'] == 1) {
-                                    $summary[] = '<li class="removed">'.__('Removed').' '.$agent_name.' - '.$module_name.'</li>';
+                                    if ($module_name != 'Host Alive') {
+                                        $summary[] = '<li class="removed">'.__('Removed').' '.$agent_name.' - '.$module_name.'</li>';
+                                    }
                                 }
 
                                 $data['modules'][$module_name]['checked'] = 0;

From eb64fd87585d9b25ba162870b269bd2ef78cb0c2 Mon Sep 17 00:00:00 2001
From: fbsanchez <fborja.sanchez@artica.es>
Date: Mon, 6 Apr 2020 16:10:37 +0200
Subject: [PATCH 4/4] minor fixes

---
 pandora_console/include/styles/task_list.css | 5 +++++
 pandora_server/lib/PandoraFMS/Core.pm        | 8 ++++++++
 2 files changed, 13 insertions(+)

diff --git a/pandora_console/include/styles/task_list.css b/pandora_console/include/styles/task_list.css
index 4cb248460f..01f7a82549 100644
--- a/pandora_console/include/styles/task_list.css
+++ b/pandora_console/include/styles/task_list.css
@@ -105,3 +105,8 @@ span.link {
 span.link.review {
   font-weight: bold;
 }
+
+#review {
+  padding-top: 2em;
+  padding-left: 6.7em;
+}
diff --git a/pandora_server/lib/PandoraFMS/Core.pm b/pandora_server/lib/PandoraFMS/Core.pm
index c781d6b9fb..96777fe158 100644
--- a/pandora_server/lib/PandoraFMS/Core.pm
+++ b/pandora_server/lib/PandoraFMS/Core.pm
@@ -6275,6 +6275,10 @@ sub notification_get_users {
 		',
 		safe_input($source)
 	);
+
+	@results = map { $_->{'id_user'} } @results;
+
+	return @results;
 }
 
 ##########################################################################
@@ -6296,6 +6300,10 @@ sub notification_get_groups {
 		',
 		safe_input($source)
 	);
+
+	@results = map { $_->{'id_group'} } @results;
+
+	return @results;
 }