diff --git a/pandora_console/ChangeLog b/pandora_console/ChangeLog index 8973c329a6..41d86927bb 100644 --- a/pandora_console/ChangeLog +++ b/pandora_console/ChangeLog @@ -1,3 +1,19 @@ +2013-02-27 Miguel de Dios + + * godmode/agentes/module_manager_editor_common.php, + godmode/agentes/modificar_agente.php, + godmode/agentes/module_manager_editor.php, + godmode/agentes/agent_manager.php: updated the code to module + constants. + + * include/javascript/pandora_modules.js: fixed the set the + module_data from to the json. + + * include/functions_api.php: cleaned source code style. + + * include/constants.php: addded lost constant for the module + prediction. + 2013-02-26 Sancho Lerena * include/functions_filemanager.php: Fixed tooltips to use new format. diff --git a/pandora_console/godmode/agentes/agent_manager.php b/pandora_console/godmode/agentes/agent_manager.php index 14bbcc3909..bffb0a30f7 100644 --- a/pandora_console/godmode/agentes/agent_manager.php +++ b/pandora_console/godmode/agentes/agent_manager.php @@ -118,8 +118,10 @@ echo '
 
'; if (!$new_agent) { // Agent remote configuration editor $agent_md5 = md5 ($nombre_agente, false); - $filename['md5'] = $config["remote_config"]."/md5/".$agent_md5.".md5"; - $filename['conf'] = $config["remote_config"]."/conf/".$agent_md5.".conf"; + $filename['md5'] = $config["remote_config"] . "/md5/" . + $agent_md5 . ".md5"; + $filename['conf'] = $config["remote_config"] . "/conf/" . + $agent_md5 . ".conf"; } $disk_conf = (bool) get_parameter ('disk_conf'); @@ -170,7 +172,7 @@ if (!$new_agent) { // Delete link from here if (!$new_agent) { -$table->data[0][1] .= "  "; + $table->data[0][1] .= "  "; } $table->data[1][0] = __('IP Address'); @@ -274,7 +276,7 @@ foreach ($listIcons as $index => $value) $arraySelectIcon[$index] = $index; $path = 'images/gis_map/icons/'; //TODO set better method the path $table->data[4][0] = __('Agent icon') . ui_print_help_tip(__('Agent icon for GIS Maps.'), true); -if($icon_path == '') { +if ($icon_path == '') { $display_icons = 'none'; // Hack to show no icon. Use any given image to fix not found image errors $path_without = "images/spinner.png"; @@ -331,7 +333,7 @@ $table->data = array (); $fields = db_get_all_fields_in_table('tagent_custom_fields'); -if($fields === false) $fields = array(); +if ($fields === false) $fields = array(); foreach ($fields as $field) { @@ -339,7 +341,7 @@ foreach ($fields as $field) { $custom_value = db_get_value_filter('description', 'tagent_custom_data', array('id_field' => $field['id_field'], 'id_agent' => $id_agente)); - if($custom_value === false) { + if ($custom_value === false) { $custom_value = ''; } @@ -348,7 +350,7 @@ foreach ($fields as $field) { array_push ($table->data, $data); } -if(!empty($fields)) { +if (!empty($fields)) { ui_toggle(html_print_table ($table, true), __('Custom fields')); } diff --git a/pandora_console/godmode/agentes/modificar_agente.php b/pandora_console/godmode/agentes/modificar_agente.php index cd11b83177..e1802f734a 100644 --- a/pandora_console/godmode/agentes/modificar_agente.php +++ b/pandora_console/godmode/agentes/modificar_agente.php @@ -89,7 +89,7 @@ if ($agent_to_delete) { // Check if the remote config file still exist if (isset ($config["remote_config"])) { $agent_md5 = md5 (agents_get_name($id_agente, ""), FALSE); - + if (file_exists ($config["remote_config"]."/md5/".$agent_md5.".md5") || file_exists ($config["remote_config"]."/conf/".$agent_md5.".conf")) { ui_print_error_message(__('Maybe the files conf or md5 could not be deleted')); @@ -97,7 +97,7 @@ if ($agent_to_delete) { } } -if($enable_agent) { +if ($enable_agent) { $result = db_process_sql_update('tagente', array('disabled' => 0), array('id_agente' => $enable_agent)); if ($result) { @@ -111,7 +111,7 @@ if($enable_agent) { __('Successfully enabled'), __('Could not be enabled')); } -if($disable_agent) { +if ($disable_agent) { $result = db_process_sql_update('tagente', array('disabled' => 1), array('id_agente' => $disable_agent)); if ($result) { @@ -186,11 +186,15 @@ switch ($sortField) { switch ($sort) { case 'up': $selectNameUp = $selected; - $order = array('field' => 'nombre COLLATE utf8_general_ci', 'field2' => 'nombre COLLATE utf8_general_ci', 'order' => 'ASC'); + $order = array('field' => 'nombre COLLATE utf8_general_ci', + 'field2' => 'nombre COLLATE utf8_general_ci', + 'order' => 'ASC'); break; case 'down': $selectNameDown = $selected; - $order = array('field' => 'nombre COLLATE utf8_general_ci', 'field2' => 'nombre COLLATE utf8_general_ci', 'order' => 'DESC'); + $order = array('field' => 'nombre COLLATE utf8_general_ci', + 'field2' => 'nombre COLLATE utf8_general_ci', + 'order' => 'DESC'); break; } break; @@ -198,11 +202,15 @@ switch ($sortField) { switch ($sort) { case 'up': $selectOsUp = $selected; - $order = array('field' => 'id_os', 'field2' => 'nombre COLLATE utf8_general_ci', 'order' => 'ASC'); + $order = array('field' => 'id_os', + 'field2' => 'nombre COLLATE utf8_general_ci', + 'order' => 'ASC'); break; case 'down': $selectOsDown = $selected; - $order = array('field' => 'id_os', 'field2' => 'nombre COLLATE utf8_general_ci', 'order' => 'DESC'); + $order = array('field' => 'id_os', + 'field2' => 'nombre COLLATE utf8_general_ci', + 'order' => 'DESC'); break; } break; @@ -210,11 +218,15 @@ switch ($sortField) { switch ($sort) { case 'up': $selectGroupUp = $selected; - $order = array('field' => 'id_grupo', 'field2' => 'nombre COLLATE utf8_general_ci', 'order' => 'ASC'); + $order = array('field' => 'id_grupo', + 'field2' => 'nombre COLLATE utf8_general_ci', + 'order' => 'ASC'); break; case 'down': $selectGroupDown = $selected; - $order = array('field' => 'id_grupo', 'field2' => 'nombre COLLATE utf8_general_ci', 'order' => 'DESC'); + $order = array('field' => 'id_grupo', + 'field2' => 'nombre COLLATE utf8_general_ci', + 'order' => 'DESC'); break; } break; @@ -230,7 +242,7 @@ switch ($sortField) { } $search_sql = ''; -if ($search != ""){ +if ($search != "") { $search_sql = " AND ( nombre COLLATE utf8_general_ci LIKE '%$search%' OR direccion LIKE '%$search%') "; } @@ -239,7 +251,7 @@ if ($ag_group > 0) { $sql = sprintf ('SELECT COUNT(*) FROM tagente WHERE id_grupo = %d - %s', + %s', $ag_group, $search_sql); $total_agents = db_get_sql ($sql); @@ -254,16 +266,18 @@ if ($ag_group > 0) { $sql = sprintf ('SELECT * FROM tagente WHERE id_grupo IN (%s) - %s - ORDER BY %s, %s %s LIMIT %d, %d', + %s + ORDER BY %s, %s %s + LIMIT %d, %d', implode (",", $ag_groups), $search_sql, $order['field'], $order['field2'], $order['order'], $offset, $config["block_size"]); break; case "postgresql": $sql = sprintf ('SELECT * FROM tagente WHERE id_grupo IN (%s) - %s - ORDER BY %s, %s %s LIMIT %d OFFSET %d', + %s + ORDER BY %s, %s %s + LIMIT %d OFFSET %d', implode (",", $ag_groups), $search_sql, $order['field'], $order['field2'], $order['order'], $config["block_size"], $offset); break; case "oracle": @@ -273,7 +287,7 @@ if ($ag_group > 0) { $sql = sprintf ('SELECT * FROM tagente WHERE id_grupo IN (%s) - %s + %s ORDER BY %s, %s %s', implode (",", $ag_groups), $search_sql, $order['field'], $order['field2'], $order['order']); $sql = oracle_recode_query ($sql, $set); @@ -288,13 +302,17 @@ else { switch ($config["dbtype"]) { case "mysql": $sql = sprintf ('SELECT * - FROM tagente WHERE 1=1 %s + FROM tagente + WHERE 1=1 + %s ORDER BY %s, %s %s LIMIT %d, %d', $search_sql, $order['field'], $order['field2'], $order['order'], $offset, $config["block_size"]); break; case "postgresql": $sql = sprintf ('SELECT * - FROM tagente WHERE 1=1 %s + FROM tagente + WHERE 1=1 + %s ORDER BY %s, %s %s LIMIT %d OFFSET %d', $search_sql, $order['field'], $order['field2'], $order['order'], $config["block_size"], $offset); break; @@ -303,7 +321,9 @@ else { $set['limit'] = $config["block_size"]; $set['offset'] = $offset; $sql = sprintf ('SELECT * - FROM tagente WHERE 1=1 %s + FROM tagente + WHERE 1=1 + %s ORDER BY %s, %s %s', $search_sql, $order['field'], $order['field2'], $order['order']); $sql = oracle_recode_query ($sql, $set); break; @@ -319,19 +339,20 @@ else { $sql = sprintf ('SELECT COUNT(*) FROM tagente WHERE id_grupo IN (%s) - %s', + %s', implode (',', array_keys ($user_groups)), $search_sql); $total_agents = db_get_sql ($sql); - + switch ($config["dbtype"]) { case "mysql": $sql = sprintf ('SELECT * FROM tagente WHERE id_grupo IN (%s) - %s - ORDER BY %s, %s %s LIMIT %d, %d', + %s + ORDER BY %s, %s %s + LIMIT %d, %d', implode (',', array_keys ($user_groups)), $search_sql, $order['field'], $order['field2'], $order['order'], $offset, $config["block_size"]); break; @@ -339,8 +360,9 @@ else { $sql = sprintf ('SELECT * FROM tagente WHERE id_grupo IN (%s) - %s - ORDER BY %s, %s %s LIMIT %d OFFSET %d', + %s + ORDER BY %s, %s %s + LIMIT %d OFFSET %d', implode (',', array_keys ($user_groups)), $search_sql, $order['field'], $order['field2'], $order['order'], $config["block_size"], $offset); break; @@ -351,7 +373,7 @@ else { $sql = sprintf ('SELECT * FROM tagente WHERE id_grupo IN (%s) - %s + %s ORDER BY %s, %s %s', implode (',', array_keys ($user_groups)), $search_sql, $order['field'], $order['field2'], $order['order']); @@ -366,7 +388,7 @@ $agents = db_get_all_rows_sql ($sql); // Delete rnum row generated by oracle_recode_query() function if (($config['dbtype'] == 'oracle') && ($agents !== false)) { for ($i=0; $i < count($agents); $i++) { - unset($agents[$i]['rnum']); + unset($agents[$i]['rnum']); } } @@ -398,7 +420,7 @@ if ($agents !== false) { $iterator = 0; foreach ($agents as $agent) { $id_grupo = $agent["id_grupo"]; - + if (! check_acl ($config["id_user"], $id_grupo, "AW", $agent['id_agente']) && ! check_acl ($config["id_user"], $id_grupo, "AD", $agent['id_agente'])) continue; @@ -429,8 +451,8 @@ if ($agents !== false) { html_print_image("images/dot_green.disabled.png", false, array("border" => '0', "title" => __('Quiet'), "alt" => "")); echo " "; } - - if(check_acl ($config["id_user"], $agent["id_grupo"], "AW")) { + + if (check_acl ($config["id_user"], $agent["id_grupo"], "AW")) { $main_tab = 'main'; } else { @@ -448,7 +470,7 @@ if ($agents !== false) { echo ""; } echo '