From 838b6b30e9f1ecfc4c5653d0afef4bf4d503a9b1 Mon Sep 17 00:00:00 2001
From: fbsanchez <fborja.sanchez@artica.es>
Date: Mon, 7 Feb 2022 14:32:59 +0100
Subject: [PATCH] php8 compatibility review

---
 .../wizards/DiscoveryTaskList.class.php       |  2 +-
 .../include/functions_integriaims.php         |  4 +-
 .../include/functions_reporting.php           |  4 +-
 .../include/functions_reporting_html.php      | 41 ++++++++++---------
 4 files changed, 26 insertions(+), 25 deletions(-)

diff --git a/pandora_console/godmode/wizards/DiscoveryTaskList.class.php b/pandora_console/godmode/wizards/DiscoveryTaskList.class.php
index 1c7149588c..0aa063c520 100644
--- a/pandora_console/godmode/wizards/DiscoveryTaskList.class.php
+++ b/pandora_console/godmode/wizards/DiscoveryTaskList.class.php
@@ -1254,7 +1254,7 @@ class DiscoveryTaskList extends HTML
      *
      * @param array $task Task.
      *
-     * @return html code with summary.
+     * @return string HTML code. code with summary.
      */
     private function progressTaskSummary($task)
     {
diff --git a/pandora_console/include/functions_integriaims.php b/pandora_console/include/functions_integriaims.php
index cbeb0cffb3..50795b70af 100644
--- a/pandora_console/include/functions_integriaims.php
+++ b/pandora_console/include/functions_integriaims.php
@@ -31,7 +31,7 @@ require_once $config['homedir'].'/include/functions.php';
  * @param string $active_tab Current tab or false for View page.
  * @param number $view       Id of incident. Show View tab.
  *
- * @return html Print tabs in header.
+ * @return string HTML code. Print tabs in header.
  */
 function integriaims_tabs($active_tab, $view=false)
 {
@@ -375,7 +375,7 @@ function get_array_from_csv_data_all($csv_data, &$array_values, $index=false)
  * @param string $priority       value of priority in Integria IMS.
  * @param string $priority_label text shown in color box.
  *
- * @return HTML  code to print the color box.
+ * @return string HTML code.  code to print the color box.
  */
 function ui_print_integria_incident_priority($priority, $priority_label)
 {
diff --git a/pandora_console/include/functions_reporting.php b/pandora_console/include/functions_reporting.php
index b12cb919c2..b7ae5cad90 100755
--- a/pandora_console/include/functions_reporting.php
+++ b/pandora_console/include/functions_reporting.php
@@ -14047,7 +14047,7 @@ function reporting_translate_sla_status_for_graph($status)
  * @param string $title       Title of report.
  * @param string $description Description of report.
  *
- * @return html Return table of header.
+ * @return string HTML code. Return table of header.
  */
 function reporting_header_table_for_pdf($title='', $description='')
 {
@@ -14072,7 +14072,7 @@ function reporting_header_table_for_pdf($title='', $description='')
  * @param array   $content Info contents.
  * @param boolean $pdf     If pdf.
  *
- * @return html
+ * @return string HTML code.
  */
 function reporting_module_histogram_graph($report, $content, $pdf=0)
 {
diff --git a/pandora_console/include/functions_reporting_html.php b/pandora_console/include/functions_reporting_html.php
index 3405adbf5a..2f4e342876 100644
--- a/pandora_console/include/functions_reporting_html.php
+++ b/pandora_console/include/functions_reporting_html.php
@@ -468,7 +468,7 @@ function reporting_html_print_report($report, $mini=false, $report_info=1)
  * @param boolean $mini  If true or false letter mini.
  * @param boolean $pdf   If it comes from pdf.
  *
- * @return html
+ * @return string HTML code.
  */
 function reporting_html_SLA($table, $item, $mini, $pdf=0)
 {
@@ -897,7 +897,7 @@ function reporting_html_SLA($table, $item, $mini, $pdf=0)
  * @param array   $item  Items data.
  * @param boolean $pdf   If it comes from pdf.
  *
- * @return html
+ * @return string HTML code.
  */
 function reporting_html_top_n($table, $item, $pdf=0)
 {
@@ -1443,7 +1443,7 @@ function reporting_html_event_report_module($table, $item, $pdf=0)
  * @param array   $item  Items data.
  * @param boolean $pdf   Print pdf true or false.
  *
- * @return html
+ * @return string HTML code.
  */
 function reporting_html_agents_inventory($table, $item, $pdf=0)
 {
@@ -1610,7 +1610,7 @@ function reporting_html_agents_inventory($table, $item, $pdf=0)
  * @param array   $item  Items data.
  * @param boolean $pdf   Print pdf true or false.
  *
- * @return html
+ * @return string HTML code.
  */
 function reporting_html_inventory_changes($table, $item, $pdf=0)
 {
@@ -1691,7 +1691,7 @@ function reporting_html_inventory_changes($table, $item, $pdf=0)
  * @param array   $item  Items data.
  * @param boolean $pdf   Print pdf true or false.
  *
- * @return html
+ * @return string HTML code.
  */
 function reporting_html_inventory($table, $item, $pdf=0)
 {
@@ -2006,7 +2006,7 @@ function reporting_html_agent_module($table, $item)
  * @param array   $item  Items data.
  * @param boolean $pdf   If it comes from pdf.
  *
- * @return html
+ * @return string HTML code.
  */
 function reporting_html_exception($table, $item, $pdf=0)
 {
@@ -2131,7 +2131,7 @@ function reporting_html_exception($table, $item, $pdf=0)
  * @param array   $item  Items data.
  * @param boolean $pdf   If it comes from pdf.
  *
- * @return html
+ * @return string HTML code.
  */
 function reporting_html_group_report($table, $item, $pdf=0)
 {
@@ -2386,7 +2386,7 @@ function reporting_html_event_report_agent($table, $item, $pdf=0)
  * @param array   $item  Items data.
  * @param boolean $pdf   If it comes from pdf.
  *
- * @return html
+ * @return string HTML code.
  */
 function reporting_html_historical_data($table, $item, $pdf=0)
 {
@@ -2470,7 +2470,7 @@ function reporting_html_historical_data($table, $item, $pdf=0)
  * @param array   $item  Items data.
  * @param boolean $pdf   If it comes from pdf.
  *
- * @return html
+ * @return string HTML code.
  */
 function reporting_html_database_serialized($table, $item, $pdf=0)
 {
@@ -2537,7 +2537,7 @@ function reporting_html_database_serialized($table, $item, $pdf=0)
  * @param array   $item  Items data.
  * @param boolean $pdf   If it comes from pdf.
  *
- * @return html
+ * @return string Html code.
  */
 function reporting_html_last_value($table, $item, $pdf=0)
 {
@@ -2697,7 +2697,7 @@ function reporting_html_last_value($table, $item, $pdf=0)
  * @param array   $item  Items data.
  * @param boolean $pdf   If it comes from pdf.
  *
- * @return html
+ * @return string HTML code.
  */
 function reporting_html_group_configuration($table, $item, $pdf=0)
 {
@@ -2839,7 +2839,7 @@ function get_alert_table($data)
  * @param array   $item  Items data.
  * @param boolean $pdf   If it comes from pdf.
  *
- * @return html
+ * @return string HTML code.
  */
 function reporting_html_network_interfaces_report($table, $item, $pdf=0)
 {
@@ -2936,6 +2936,7 @@ function reporting_html_alert_report($table, $item, $pdf=0)
     $table->colspan['alerts']['cell'] = 3;
     $table->cellstyle['alerts']['cell'] = 'text-align: left;';
 
+    $table1 = new stdClass();
     $table1->width   = '99%';
     $table1->head    = [];
     $table1->data    = [];
@@ -3143,7 +3144,7 @@ function reporting_html_prediction_date($table, $item, $mini)
  * @param boolean $pdf   If it comes from pdf.
  * @param string  $title Show title pdf.
  *
- * @return html
+ * @return string HTML code.
  */
 function reporting_html_agent_configuration(
     $table,
@@ -3497,7 +3498,7 @@ function reporting_html_value(
  * @param array   $item  Parameters for item pdf.
  * @param boolean $pdf   Send pdf.
  *
- * @return html
+ * @return string HTML code.
  */
 function reporting_html_increment($table, $item, $pdf=0)
 {
@@ -3607,7 +3608,7 @@ function reporting_html_text(&$table, $item)
  * @param array   $item  Parameters for item pdf.
  * @param boolean $pdf   Send pdf.
  *
- * @return html
+ * @return string HTML code.
  */
 function reporting_html_availability($table, $item, $pdf=0)
 {
@@ -4146,7 +4147,7 @@ function reporting_html_availability($table, $item, $pdf=0)
  * @param array   $item  Parameters for item pdf.
  * @param boolean $pdf   Send pdf.
  *
- * @return html
+ * @return string HTML code.
  */
 function reporting_html_availability_graph($table, $item, $pdf=0)
 {
@@ -4444,7 +4445,7 @@ function get_agent_first_time($agent_name)
  * @param array   $item  Items data.
  * @param boolean $pdf   If it comes from pdf.
  *
- * @return html
+ * @return string HTML code.
  */
 function reporting_html_general($table, $item, $pdf=0)
 {
@@ -4641,7 +4642,7 @@ function reporting_html_general($table, $item, $pdf=0)
  * @param array   $item  Items data.
  * @param boolean $pdf   If it comes from pdf.
  *
- * @return html
+ * @return string HTML code.
  */
 function reporting_html_sql($table, $item, $pdf=0)
 {
@@ -4704,7 +4705,7 @@ function reporting_html_sql($table, $item, $pdf=0)
  * @param integer $graph_width  Items data.
  * @param integer $graph_height If it comes from pdf.
  *
- * @return html
+ * @return string HTML code.
  */
 function reporting_get_stats_summary($data, $graph_width, $graph_height)
 {
@@ -4943,7 +4944,7 @@ function reporting_get_monitors_down_table($monitors_down)
  * @param integer $id_group Group to get the report.
  * @param boolean $return   Flag to return or echo the report (by default).
  *
- * @return HTML string with group report
+ * @return string HTML code. string with group report
  */
 function reporting_print_group_reporting($id_group, $return=false)
 {