2013-05-23 Sergio Martin <sergio.martin@artica.es>

* include/functions_html.php
	include/styles/pandora_minimal.css
	include/styles/dialog.css
	include/styles/menu.css
	include/styles/jquery-ui-1.10.0.custom.css
	include/functions_events.php
	operation/events/events_list.php
	include/functions_snmp_browser.php
	include/styles/pandora.css: A lot of graphic
	changes including events form and snmp browser
	layout

	* include/ajax/module.php
	include/functions_ui.php
	include/functions.php
	include/functions_agents.php
	include/functions_graph.php
	include/graphs/functions_gd.php
	include/graphs/fgraph.php
	include/functions_reporting.php
	include/functions_filemanager.php
	include/javascript/pandora_snmp_browser.js
	include/functions_treeview.php
	include/constants.php
	index.php
	extensions/net_tools.php
	extensions/pandora_logs.php
	extensions/ssh_gateway.php
	extensions/update_manager/settings.php
	extensions/plugin_registration.php
	operation/incidents/incident.php
	operation/incidents/incident_detail.php
	operation/visual_console/render_view.php
	operation/users/user_edit.php
	operation/reporting/reporting_viewer.php
	operation/reporting/graph_viewer.php
	operation/agentes/datos_agente.php
	operation/agentes/alerts_status.php
	operation/agentes/estado_generalagente.php
	operation/agentes/custom_fields.php
	operation/agentes/estado_agente.php
	operation/agentes/estado_monitores.php
	operation/agentes/agent_fields.php
	operation/agentes/stat_win.php
	operation/servers/recon_view.php
	operation/integria_incidents/incident_detail.php
	operation/netflow/nf_live_view.php
	godmode/groups/configure_group.php
	godmode/groups/configure_modu_group.php
	godmode/groups/group_list.php
	godmode/db/db_refine.php
	godmode/db/db_event.php
	godmode/agentes/module_manager_editor_common.php
	godmode/agentes/fields_manager.php
	godmode/agentes/modificar_agente.php
	godmode/agentes/module_manager_editor.php
	godmode/servers/recon_script.php
	godmode/servers/plugin.php
	godmode/servers/manage_recontask.php
	godmode/servers/modificar_server.php
	godmode/setup/news.php
	godmode/setup/links.php
	godmode/setup/gis.php
	godmode/users/configure_profile.php
	godmode/massive/massive_add_alerts.php
	godmode/massive/massive_delete_profiles.php
	godmode/modules/module_list.php
	godmode/reporting/visual_console_builder.php
	godmode/reporting/map_builder.php
	godmode/reporting/graphs.php
	godmode/tag/tag.php
	godmode/tag/edit_tag.php: Changing the old way of 
	print errors to encapsulated UI function to unify 
	styles

	* images/status_sets/color_text/agent_no_monitors.png
	images/status_sets/color_text/agent_no_monitors_ball.pn
	images/status_sets/color_text/agent_down_ball.png
	images/status_sets/color_text/agent_down.png
	images/status_sets/default/agent_no_monitors.png
	images/status_sets/default/agent_no_monitors_ball.png
	images/status_sets/default/agent_down_ball.png
	images/status_sets/default/agent_down.png: Modify some
	status set images

	* images/gis_map/icons/star.default.png
	images/gis_map/icons/cross.warning.png
	images/gis_map/icons/star.bad.png
	images/gis_map/icons/cross.ok.png
	images/gis_map/icons/marker.default.png
	images/gis_map/icons/square_marker.warning.png
	images/gis_map/icons/circle.warning.png
	images/gis_map/icons/marker.bad.png
	images/gis_map/icons/square_marker.ok.png
	images/gis_map/icons/circle.ok.png
	images/gis_map/icons/triangle.warning.png
	images/gis_map/icons/cross.default.png
	images/gis_map/icons/star.warning.png
	images/gis_map/icons/triangle.ok.png
	images/gis_map/icons/cross.bad.png
	images/gis_map/icons/star.ok.png
	images/gis_map/icons/square_marker.default.png
	images/gis_map/icons/circle.default.png
	images/gis_map/icons/marker.warning.png
	images/gis_map/icons/square_marker.bad.png
	images/gis_map/icons/circle.bad.png
	images/gis_map/icons/triangle.default.png
	images/gis_map/icons/marker.ok.png
	images/gis_map/icons/triangle.bad.png: Change whole the
	gis icons by new ones

	* images/os_icons/so_win.png
	images/os_icons/so_linux.png
	images/os_icons/so_mac.png
	images/os_icons/so_cisco.png
	images/os_icons/so_vmware.png
	images/os_icons/so_bsd.png
	images/os_icons/android.png
	images/os_icons/so_aix.png
	images/os_icons/so_other.png
	images/os_icons/so_hpux.png
	images/os_icons/network.png
	images/os_icons/embedded.png: Reduce the operating 
	system icons size

	* images/vnc.png
	images/op_inventory.png
	images/refresh_mc.png
	images/heart.png
	images/service.png
	images/go.png
	images/graphmenu_arrow_hide.png
	images/submenu_tree_first.png
	images/config_mc.png
	images/cross_double.png
	images/wand.png
	images/expand.png
	images/submenu_tree_middle.png
	images/visual_console.png
	images/down.png
	images/chart_curve_threshold.png
	images/people_1.png
	images/cancel.png
	images/graphmenu_arrow.png
	images/people_2.png
	images/collapse.png
	images/camera_mc.png: Improve a lot of
	icons





git-svn-id: https://svn.code.sf.net/p/pandora/code/trunk@8198 c3f86ba8-e40f-0410-aaad-9ba5e7f4b01f

pandora_console/ChangeLog

@@ -1,3 +1,154 @@
+2013-05-23  Sergio Martin <sergio.martin@artica.es>
+
+	* include/functions_html.php
+	include/styles/pandora_minimal.css
+	include/styles/dialog.css
+	include/styles/menu.css
+	include/styles/jquery-ui-1.10.0.custom.css
+	include/functions_events.php
+	operation/events/events_list.php
+	include/functions_snmp_browser.php
+	include/styles/pandora.css: A lot of graphic
+	changes including events form and snmp browser
+	layout
+
+	* include/ajax/module.php
+	include/functions_ui.php
+	include/functions.php
+	include/functions_agents.php
+	include/functions_graph.php
+	include/graphs/functions_gd.php
+	include/graphs/fgraph.php
+	include/functions_reporting.php
+	include/functions_filemanager.php
+	include/javascript/pandora_snmp_browser.js
+	include/functions_treeview.php
+	include/constants.php
+	index.php
+	extensions/net_tools.php
+	extensions/pandora_logs.php
+	extensions/ssh_gateway.php
+	extensions/update_manager/settings.php
+	extensions/plugin_registration.php
+	operation/incidents/incident.php
+	operation/incidents/incident_detail.php
+	operation/visual_console/render_view.php
+	operation/users/user_edit.php
+	operation/reporting/reporting_viewer.php
+	operation/reporting/graph_viewer.php
+	operation/agentes/datos_agente.php
+	operation/agentes/alerts_status.php
+	operation/agentes/estado_generalagente.php
+	operation/agentes/custom_fields.php
+	operation/agentes/estado_agente.php
+	operation/agentes/estado_monitores.php
+	operation/agentes/agent_fields.php
+	operation/agentes/stat_win.php
+	operation/servers/recon_view.php
+	operation/integria_incidents/incident_detail.php
+	operation/netflow/nf_live_view.php
+	godmode/groups/configure_group.php
+	godmode/groups/configure_modu_group.php
+	godmode/groups/group_list.php
+	godmode/db/db_refine.php
+	godmode/db/db_event.php
+	godmode/agentes/module_manager_editor_common.php
+	godmode/agentes/fields_manager.php
+	godmode/agentes/modificar_agente.php
+	godmode/agentes/module_manager_editor.php
+	godmode/servers/recon_script.php
+	godmode/servers/plugin.php
+	godmode/servers/manage_recontask.php
+	godmode/servers/modificar_server.php
+	godmode/setup/news.php
+	godmode/setup/links.php
+	godmode/setup/gis.php
+	godmode/users/configure_profile.php
+	godmode/massive/massive_add_alerts.php
+	godmode/massive/massive_delete_profiles.php
+	godmode/modules/module_list.php
+	godmode/reporting/visual_console_builder.php
+	godmode/reporting/map_builder.php
+	godmode/reporting/graphs.php
+	godmode/tag/tag.php
+	godmode/tag/edit_tag.php: Changing the old way of 
+	print errors to encapsulated UI function to unify 
+	styles
+
+	* images/status_sets/color_text/agent_no_monitors.png
+	images/status_sets/color_text/agent_no_monitors_ball.png
+	images/status_sets/color_text/agent_down_ball.png
+	images/status_sets/color_text/agent_down.png
+	images/status_sets/default/agent_no_monitors.png
+	images/status_sets/default/agent_no_monitors_ball.png
+	images/status_sets/default/agent_down_ball.png
+	images/status_sets/default/agent_down.png: Modify some
+	status set images
+
+	* images/gis_map/icons/star.default.png
+	images/gis_map/icons/cross.warning.png
+	images/gis_map/icons/star.bad.png
+	images/gis_map/icons/cross.ok.png
+	images/gis_map/icons/marker.default.png
+	images/gis_map/icons/square_marker.warning.png
+	images/gis_map/icons/circle.warning.png
+	images/gis_map/icons/marker.bad.png
+	images/gis_map/icons/square_marker.ok.png
+	images/gis_map/icons/circle.ok.png
+	images/gis_map/icons/triangle.warning.png
+	images/gis_map/icons/cross.default.png
+	images/gis_map/icons/star.warning.png
+	images/gis_map/icons/triangle.ok.png
+	images/gis_map/icons/cross.bad.png
+	images/gis_map/icons/star.ok.png
+	images/gis_map/icons/square_marker.default.png
+	images/gis_map/icons/circle.default.png
+	images/gis_map/icons/marker.warning.png
+	images/gis_map/icons/square_marker.bad.png
+	images/gis_map/icons/circle.bad.png
+	images/gis_map/icons/triangle.default.png
+	images/gis_map/icons/marker.ok.png
+	images/gis_map/icons/triangle.bad.png: Change whole the 
+	gis icons by new ones
+
+	* images/os_icons/so_win.png
+	images/os_icons/so_linux.png
+	images/os_icons/so_mac.png
+	images/os_icons/so_cisco.png
+	images/os_icons/so_vmware.png
+	images/os_icons/so_bsd.png
+	images/os_icons/android.png
+	images/os_icons/so_aix.png
+	images/os_icons/so_other.png
+	images/os_icons/so_hpux.png
+	images/os_icons/network.png
+	images/os_icons/embedded.png: Reduce the operating 
+	system icons size
+
+	* images/vnc.png
+	images/op_inventory.png
+	images/refresh_mc.png
+	images/heart.png
+	images/service.png
+	images/go.png
+	images/graphmenu_arrow_hide.png
+	images/submenu_tree_first.png
+	images/config_mc.png
+	images/cross_double.png
+	images/wand.png
+	images/expand.png
+	images/submenu_tree_middle.png
+	images/visual_console.png
+	images/down.png
+	images/chart_curve_threshold.png
+	images/people_1.png
+	images/cancel.png
+	images/graphmenu_arrow.png
+	images/people_2.png
+	images/collapse.png
+	images/camera_mc.png: Improve a lot of
+	icons
+
 2013-05-23 Miguel de Dios <miguel.dedios@artica.es>
 
 	* godmode/reporting/reporting_builder.item_editor.php,

pandora_console/extensions/net_tools.php

@@ -85,7 +85,7 @@ function main_net_tools () {
 	$id_agente = get_parameter ("id_agente");
 	$ip = db_get_sql ("SELECT direccion FROM tagente WHERE id_agente = $id_agente");
 	if ($ip == "") {
-		echo "<div class='error' style='margin-top:5px'>The agent hasn't got IP</div>";
+		echo "<div class='error' style='margin-top:5px'>" . __('The agent hasn\'t got IP') . "</div>";
 		return;
 	}
 	echo "<div>";

pandora_console/extensions/pandora_logs.php

@@ -29,8 +29,7 @@ function view_logfile ($file_name) {
 	
 	
 	if (!file_exists($file_name)) {
-		echo "<h2 class='error'>".__("Cannot find file"). "(".$file_name;
-		echo ")</h2>";
+		ui_print_error_message(__("Cannot find file") . "(" . $file_name . ")");
 	}
 	else {
 		$file_size = filesize($file_name);

pandora_console/extensions/plugin_registration.php

@@ -184,10 +184,10 @@ function pluginreg_extension_main () {
 		
 		db_process_sql_insert('tnetwork_component', $values);
 		
-		echo "<h3 class=suc>".__("Module plugin registered"). " : ". $ini_array[$label]["name"] ."</h2>";
+		ui_print_success_message(__("Module plugin registered"). " : ". $ini_array[$label]["name"]);
 	}
 	
-	echo "<h2 class=suc>".__("Plugin"). " ". $ini_array["plugin_definition"]["name"] . " ". __("Registered successfully")."</h2>";
+	ui_print_success_message(__("Plugin"). " ". $ini_array["plugin_definition"]["name"] . " ". __("Registered successfully"));
 	unlink ($config["attachment_store"] . "/plugin_definition.ini");
 
 }

pandora_console/extensions/ssh_gateway.php

@@ -49,7 +49,7 @@ function ssh_gateway () {
 	
 	if (($HOST == "") OR ($USER == "")) {
 		if ($COMMIT == 1) {
-			echo "<h3 class=error>".__("You need to specify a user and a host address")."</h3>";
+			ui_print_error_message(__("You need to specify a user and a host address"));
 		}
 		
 		echo "<form method=post>";

pandora_console/extensions/update_manager/settings.php

@@ -55,7 +55,7 @@ if ($update_settings) {
 		update_pandora_update_conf();
 	}
 	
-	echo "<h3 class=suc>" . __('Update manager settings updated') . "</h3>";
+	ui_print_success_message(__('Update manager settings updated'));
 }
 
 $settings = null;

pandora_console/godmode/agentes/fields_manager.php

@@ -41,14 +41,14 @@ $display_on_front = (int) get_parameter ('display_on_front', 0);
 if ($create_field) {
 	/*Check if name field is empty*/
 	if ($name == ""){
-		echo "<h3 class='error'>".__('The name must not be empty')."</h3>";
+		ui_print_error_message(__('The name must not be empty'));
 	}
 	else if ($name == db_get_value ('name', 'tagent_custom_fields', 'name', $name)) {
-		echo "<h3 class='error'>".__('The name must be unique')."</h3>";
+		ui_print_error_message(__('The name must be unique'));
 	}
 	else {
 		$result = db_process_sql_insert('tagent_custom_fields', array('name' => $name, 'display_on_front' => $display_on_front));
-		echo "<h3 class='suc'>".__('Field successfully created')."</h3>";
+		ui_print_success_message(__('Field successfully created'));
 	}
 }
 
@@ -65,10 +65,10 @@ if ($update_field) {
 	}
 	
 	if ($result !== false) {
-		echo "<h3 class='suc'>".__('Field successfully updated')."</h3>";
+		ui_print_success_message(__('Field successfully updated'));
 	}
 	else {
-		echo "<h3 class='error'>".__('There was a problem modifying field')."</h3>";
+		ui_print_error_message(__('There was a problem modifying field'));
 	}
 }
 
@@ -77,9 +77,9 @@ if ($delete_field) {
 	$result = db_process_sql_delete('tagent_custom_fields', array('id_field' => $id_field));
 	
 	if (!$result)
-		echo "<h3 class='error'>".__('There was a problem deleting field')."</h3>"; 
+		ui_print_error_message(__('There was a problem deleting field')); 
 	else
-		echo "<h3 class='suc'>".__('Field successfully deleted')."</h3>";	 
+		ui_print_success_message(__('Field successfully deleted'));	 
 }
 
 $fields = db_get_all_fields_in_table('tagent_custom_fields');

pandora_console/godmode/agentes/modificar_agente.php

@@ -58,7 +58,7 @@ $viewtab['active'] = false;
 $onheader = array('view' => $viewtab);
 
 // Header
-ui_print_page_header (__('Agent configuration')." » ".__('Agents defined in Pandora'), "images/agent_mc.png", false, "", true, $onheader);
+ui_print_page_header (__('Agents defined in Pandora'), "images/agent_mc.png", false, "", true, $onheader);
 
 // Perform actions
 $agent_to_delete = (int)get_parameter('borrar_agente');
@@ -124,6 +124,8 @@ if ($disable_agent) {
 		__('Successfully disabled'), __('Could not be disabled'));
 }
 
+echo "<table cellpadding='4' cellspacing='4' class='databox' width='98%' style='font-weight: bold; margin-bottom: 10px;'><tr>";
+
 // Show group selector
 if (isset($_POST["ag_group"])) {
 	$ag_group = get_parameter_post ("ag_group");
@@ -135,9 +137,9 @@ else {
 	action='index.php?sec=gagente&sec2=godmode/agentes/modificar_agente'>";
 }
 
-echo "<table cellpadding='4' cellspacing='4' class='databox' width='98%'><tr>";
-echo "<td valign='top'>".__('Group')."</td>";
-echo "<td valign='top'>";
+echo "<td>";
+
+echo __('Group') . '&nbsp;';
 $own_info = get_user_info($config['id_user']);
 if (!$own_info['is_admin'] && !check_acl ($config['id_user'], 0, "PM"))
 	$return_all_group = false;
@@ -150,28 +152,28 @@ echo "<td valign='top'>
 <input name='uptbutton' type='submit' class='sub upd' value='".__('Show')."'>
 </noscript>
 </td>
-<td valign='top'>";
-echo __('Group recursion') . ': ';
+<td>";
+echo __('Recursion') . '&nbsp;';
 html_print_checkbox ("recursion", 1, $recursion, false, false, 'this.form.submit()');
 
-echo "</td></form><td valign='top'>";
-echo __('Free text for search (*)');
-echo "</td><td>";
+echo "</td></form><td>";
+echo __('Search') . '&nbsp;';
+html_print_input_text ("search", $search, '', 12);
 
 // Show group selector
 echo "<form method='post' action='index.php?sec=gagente&sec2=godmode/agentes/modificar_agente&refr=60&ag_group_refresh=$ag_group&recursion=$recursion'>";
-echo "<input type=text name='search' size='15' value='$search' >";
-echo "</td><td valign='top'>";
+echo "</td><td>";
 echo "<input name='srcbutton' type='submit' class='sub search' value='".__('Search')."'>";
 echo "</form>";
 echo "<td>";
+echo "</tr></table>";
 
+echo '<div style="text-align: right; float: right;">';
 echo '<form method="post" action="index.php?sec=gagente&amp;sec2=godmode/agentes/configurar_agente">';
 	html_print_input_hidden ('new_agent', 1);
 	html_print_submit_button (__('Create agent'), 'crt', false, 'class="sub next"');
 echo "</form>";
-
-echo "</td></tr></table>";
+echo "</div>";
 
 $selected = 'border: 1px solid black;';
 $selectNameUp = '';
@@ -393,7 +395,6 @@ if (($config['dbtype'] == 'oracle') && ($agents !== false)) {
 
 // Prepare pagination
 ui_pagination ($total_agents, "index.php?sec=gagente&sec2=godmode/agentes/modificar_agente&group_id=$ag_group&recursion=$recursion&search=$search&sort_field=$sortField&sort=$sort", $offset);
-echo "<div style='height: 20px'> </div>";
 
 if ($agents !== false) {
 	

pandora_console/godmode/agentes/module_manager_editor.php

@@ -386,9 +386,7 @@ switch ($moduletype) {
 	/* WARNING: type 7 is reserved on enterprise */
 	default:
 		if (enterprise_include ('godmode/agentes/module_manager_editor.php') === ENTERPRISE_NOT_HOOK) {
-			echo '<h3 class="error">';
-			echo sprintf(__('DEBUG: Invalid module type specified in %s:%s'), __FILE__, __LINE__);
-			echo '</h3>';
+			ui_print_error_message(sprintf(__('DEBUG: Invalid module type specified in %s:%s'), __FILE__, __LINE__));
 			echo __('Most likely you have recently upgraded from an earlier version of Pandora and either <br />
 				1) forgot to use the database converter<br />
 				2) used a bad version of the database converter (see Bugreport #2124706 for the solution)<br />
@@ -407,6 +405,7 @@ if ($config['enterprise_installed'] && $id_agent_module) {
 
 echo '<h3 id="message" class="error invisible"></h3>';
 
+// TODO: Change to the ui_print_error system
 echo '<form method="post" id="module_form">';
 html_print_table ($table_simple);
 

pandora_console/godmode/agentes/module_manager_editor_common.php

@@ -87,7 +87,7 @@ function add_component_selection ($id_network_component_type) {
 	$data[1] .= '</span>';
 	
 	$table_simple->colspan['module_component'][1] = 3;
-	$table_simple->rowstyle['module_component'] = 'background-color: #D4DDC6';
+	$table_simple->rowstyle['module_component'] = 'background-color: #cfcfcf';
 	
 	prepend_table_simple ($data, 'module_component');
 }

pandora_console/godmode/db/db_event.php

@@ -35,10 +35,10 @@ if (isset ($_POST["date_purge"])){
 	$deleted = db_process_sql_delete('tevento', array('utimestamp' => '< ' . $from_date));
 	
 	if ($deleted !== false) {
-		echo '<h3 class="suc">'.__('Successfully deleted old events').'</h3>';
+		ui_print_success_message(__('Successfully deleted old events'));
 	}
 	else {
-		echo '<h3 class="error">'.__('Error deleting old events').'</h3>';
+		ui_print_error_message(__('Error deleting old events'));
 	}
 }
 # End of get parameters block

pandora_console/godmode/db/db_refine.php

@@ -39,12 +39,12 @@ if ((isset ($_GET["operacion"])) && (!isset ($_POST["update_agent"]))) {
 		$max = get_parameter_post ("max", 0);
 		$min = get_parameter_post ("min", 0);
 		if ($max == $min) {
-			echo '<h3 class="error">'.__('Error').': '.__('Maximum is equal to minimum').'</h3>';
+			ui_print_error_message(__('Error').': '.__('Maximum is equal to minimum'));
 			return;
 		}
 		$origen_modulo = get_parameter_post ("origen_modulo", array ());
 		if (empty ($origen_modulo)) {
-			echo '<h3 class="error">'.__('Error').': '.__('No modules have been selected').'</h3>';
+			ui_print_success_message(__('Error').': '.__('No modules have been selected'));
 			return;
 		}
 
@@ -58,7 +58,9 @@ if ((isset ($_GET["operacion"])) && (!isset ($_POST["update_agent"]))) {
 			db_process_sql ($sql);
 		} 
 	} //if copy modules or alerts
-	echo '<br /><br /><h3 class="suc">'.__('Filtering completed').'</h3>';
+	
+	echo '<br /><br />';
+	ui_print_success_message(__('Filtering completed'));
 }
 echo '<form method="post" action="index.php?sec=gdbman&sec2=godmode/db/db_refine&operacion=1">';
 echo "<table width='98%' border='0' cellspacing='4' cellpadding='4' class='databox'>";

pandora_console/godmode/groups/configure_group.php

@@ -63,7 +63,7 @@ if ($id_group) {
 		$other = $group["other"];
 	}
 	else {
-		echo "<h3 class='error'>".__('There was a problem loading group')."</h3>";
+		ui_print_error_message(__('There was a problem loading group'));
 		echo "</table>";
 		echo '</div>';
 		echo '<div style="clear:both">&nbsp;</div>';

pandora_console/godmode/groups/configure_modu_group.php

@@ -44,7 +44,7 @@ if ($id_group) {
 		$name = $group["name"];
 	}
 	else {
-		echo "<h3 class='error'>".__('There was a problem loading group')."</h3>";
+		ui_print_error_message(__('There was a problem loading group'));
 		echo "</table>";
 		echo '</div>';
 		echo '<div style="clear:both">&nbsp;</div>';

pandora_console/godmode/groups/group_list.php

@@ -156,19 +156,19 @@ if ($create_group) {
 		
 			$result = db_process_sql_insert('tgrupo', $values);
 			if ($result) {
-				echo "<h3 class='suc'>".__('Group successfully created')."</h3>"; 
+				ui_print_success_message(__('Group successfully created')); 
 			}
 			else {
-				echo "<h3 class='error'>".__('There was a problem creating group')."</h3>";
+				ui_print_error_message(__('There was a problem creating group'));
 			}
 		}
 		else {
-			echo "<h3 class='error'>".__('Each group must have a different name')."</h3>";
+			ui_print_error_message(__('Each group must have a different name'));
 		}
 	}
 	else {
 		//$result = false;
-		echo "<h3 class='error'>".__('Group must have a name')."</h3>";
+		ui_print_error_message(__('Group must have a name'));
 	}
 }
 
@@ -211,10 +211,10 @@ if ($update_group) {
 	}
 	
 	if ($result !== false) {
-		echo "<h3 class='suc'>".__('Group successfully updated')."</h3>";
+		ui_print_success_message(__('Group successfully updated'));
 	}
 	else {
-		echo "<h3 class='error'>".__('There was a problem modifying group')."</h3>";
+		ui_print_error_message(__('There was a problem modifying group'));
 	}
 }
 
@@ -235,15 +235,14 @@ if ($delete_group) {
 		$result = db_process_sql_delete('tgrupo', array('id_grupo' => $id_group));
 	}
 	else {
-		echo "<h3 class='error'>" .
-			sprintf(__('The group is not empty. It is use in %s.'), implode(', ', $usedGroup['tables'])) . "</h3>";
+		ui_print_error_message(sprintf(__('The group is not empty. It is use in %s.'), implode(', ', $usedGroup['tables'])));
 	}
 	
 	if ($result && (!$usedGroup['return'])) {
-		echo "<h3 class='suc'>".__('Group successfully deleted')."</h3>";
+		ui_print_success_message(__('Group successfully deleted'));
 	} 
 	else {
-		echo "<h3 class='error'>".__('There was a problem deleting group')."</h3>";
+		ui_print_error_message(__('There was a problem deleting group'));
 	}
 }
 db_clean_cache();

pandora_console/godmode/massive/massive_add_alerts.php

@@ -46,12 +46,12 @@ if (is_ajax ()) {
 
 function process_manage_add ($id_alert_template, $id_agents, $module_names) {
 	if (empty ($id_agents) || $id_agents[0] == 0) {
-		echo '<h3 class="error">'.__('No agents selected').'</h3>';
+		ui_print_error_message(__('No agents selected'));
 		return false;
 	}
 	
 	if (empty ($id_alert_template)) {
-		echo '<h3 class="error">'.__('No alert selected').'</h3>';
+		ui_print_error_message(__('No alert selected'));
 		return false;
 	}
 	
@@ -155,6 +155,7 @@ html_print_submit_button (__('Add'), 'go', false, 'class="sub add"');
 echo '</div>';
 echo '</form>';
 
+// TODO: Change to iu_print_error system
 echo '<h3 class="error invisible" id="message"> </h3>';
 
 //Hack to translate text "none" in PHP to javascript

pandora_console/godmode/massive/massive_delete_profiles.php

@@ -58,7 +58,7 @@ if ($delete_profiles) {
 			foreach ($groups_id as $group) {
 				foreach ($users_id as $id_up) {
 					 if ($id_up == 0) {
-						echo '<h3 class="error">'.__('Not deleted. You must select an existing user').'</h3>';
+						ui_print_error_message(__('Not deleted. You must select an existing user'));
 						$result="";
 					}
 					else {
@@ -135,6 +135,7 @@ echo '</form>';
 
 unset ($table);
 
+// TODO: Change to iu_print_error system
 echo '<h3 class="error invisible" id="message"> </h3>';
 
 ui_require_jquery_file ('form');

pandora_console/godmode/modules/module_list.php

@@ -47,9 +47,9 @@ if ($update_module) {
 	$result = db_process_sql_update('ttipo_modulo', $values, array('id_tipo' => $id_type));
 	
 	if (! $result)
-		echo "<h3 class='error'>".__('Problem modifying module')."</h3>";
+		ui_print_error_message(__('Problem modifying module'));
 	else
-		echo "<h3 class='suc'>".__('Module updated successfully')."</h3>";
+		ui_print_success_message(__('Module updated successfully'));
 }
 
 

pandora_console/godmode/reporting/graphs.php

@@ -76,19 +76,19 @@ if ($delete_graph) {
 		$result = db_process_sql_delete("tgraph_source", array('id_graph' =>$id));
 		
 		if ($result)
-			$result = "<h3 class=suc>".__('Successfully deleted')."</h3>";
+			$result = ui_print_success_message(__('Successfully deleted'));
 		else
-			$result = "<h3 class=error>".__('Not deleted. Error deleting data')."</h3>";
+			$result = ui_print_error_message(__('Not deleted. Error deleting data'));
 		
 		$result = db_process_sql_delete("tgraph", array('id_graph' =>$id));
 		
 		if ($result) {
 			db_pandora_audit("Report management", "Delete graph #$id");
-			$result = "<h3 class=suc>".__('Successfully deleted')."</h3>";
+			$result = ui_print_success_message(__('Successfully deleted'));
 		}
 		else {
 			db_pandora_audit("Report management", "Fail try to delete graph #$id");
-			$result = "<h3 class=error>".__('Not deleted. Error deleting data')."</h3>";
+			$result = ui_print_error_message(__('Not deleted. Error deleting data'));
 		}
 		
 		echo $result;

pandora_console/godmode/reporting/map_builder.php

@@ -36,12 +36,12 @@ if ($delete_layout) {
 	$result = db_process_sql_delete ('tlayout', array ('id' => $id_layout));
 	if ($result) {
 		db_pandora_audit( "Visual console builder", "Delete visual console #$id_layout");
-		echo '<h3 class="suc">'.__('Successfully deleted').'</h3>';
+		ui_print_success_message(__('Successfully deleted'));
 		db_clean_cache();
 	}
 	else {
 		db_pandora_audit( "Visual console builder", "Fail try to delete visual console #$id_layout");
-		echo '<h3 class="error">'.__('Not deleted. Error deleting data').'</h3>';
+		ui_print_error_message(__('Not deleted. Error deleting data'));
 	}
 	$id_layout = 0;
 }
@@ -118,21 +118,21 @@ if ($copy_layout) {
 				}
 				
 				
-				echo '<h3 class="suc">'.__('Successfully copied').'</h3>';
+				ui_print_success_message(__('Successfully copied'));
 				db_clean_cache();
 			}
 			else {
-				echo '<h3 class="error">'.__('Not copied. Error copying data').'</h3>';
+				ui_print_error_message(__('Not copied. Error copying data'));
 			}
 		}
 		else{
 			// If the array is empty the copy is completed
-			echo '<h3 class="suc">'.__('Successfully copied').'</h3>';
+			ui_print_success_message(__('Successfully copied'));
 			db_clean_cache();
 		}
 	}
 	else {
-		echo '<h3 class="error">'.__('Not copied. Error copying data').'</h3>';
+		ui_print_error_message(__('Not copied. Error copying data'));
 	}
 	
 }

pandora_console/godmode/reporting/visual_console_builder.php

@@ -87,11 +87,11 @@ switch ($activeTab) {
 						if ($result !== false && $values['background']) {
 							db_pandora_audit( "Visual console builder", "Update visual console #$idVisualConsole");
 							$action = 'edit';
-							$statusProcessInDB = array('flag' => true, 'message' => '<h3 class="suc">'.__('Successfully update.').'</h3>');
+							$statusProcessInDB = array('flag' => true, 'message' => ui_print_success_message(__('Successfully update.'), '', true));
 						}
 						else {
 							db_pandora_audit( "Visual console builder", "Fail update visual console #$idVisualConsole");
-							$statusProcessInDB = array('flag' => false, 'message' => '<h3 class="error">'.__('Could not be update.').'</h3>');
+							$statusProcessInDB = array('flag' => false, 'message' => ui_print_error_message(__('Could not be update.'), '', true));
 						}
 						break;
 					
@@ -104,11 +104,11 @@ switch ($activeTab) {
 						if ($idVisualConsole !== false) {
 							db_pandora_audit( "Visual console builder", "Create visual console #$idVisualConsole");
 							$action = 'edit';
-							$statusProcessInDB = array('flag' => true, 'message' => '<h3 class="suc">'.__('Successfully created.').'</h3>');
+							$statusProcessInDB = array('flag' => true, 'message' => ui_print_success_message(__('Successfully created.'), '', true));
 						}
 						else {
 							db_pandora_audit( "Visual console builder", "Fail try to create visual console");
-							$statusProcessInDB = array('flag' => false, 'message' => '<h3 class="error">'.__('Could not be created.').'</h3>');
+							$statusProcessInDB = array('flag' => false, 'message' => ui_print_error_message(__('Could not be created.'), '', true));
 						}
 						break;
 				}
@@ -199,7 +199,7 @@ switch ($activeTab) {
 				$id_element = get_parameter('id_element');
 				$result = db_process_sql_delete('tlayout_data', array('id' => $id_element));
 				if ($result !== false) {
-					$statusProcessInDB = array('flag' => true, 'message' => '<h3 class="suc">'.__('Successfully delete.').'</h3>');
+					$statusProcessInDB = array('flag' => true, 'message' => ui_print_success_message(__('Successfully delete.'), '', true));
 				}
 				break;
 		}
@@ -441,7 +441,7 @@ if ($action == 'new' || $idVisualConsole === false) {
 $buttons[$activeTab]['active'] = true;
  
 if (!defined('METACONSOLE')) {
-	ui_print_page_header(__('Visual console') . " &raquo; " . $visualConsoleName, "images/op_reporting.png", false, "visual_console_editor_" . $activeTab . "_tab", false, $buttons);
+	ui_print_page_header($visualConsoleName, "images/visual_console.png", false, "visual_console_editor_" . $activeTab . "_tab", false, $buttons);
 }
 
 //The source code for PAINT THE PAGE

pandora_console/godmode/servers/manage_recontask.php

@@ -40,10 +40,10 @@ if (isset ($_GET["delete"])) {
 	$result = db_process_sql_delete('trecon_task', array('id_rt' => $id));
 	
 	if ($result !== false) {
-		echo '<h3 class="suc">'.__('Successfully deleted recon task').'</h3>';
+		ui_print_success_message(__('Successfully deleted recon task'));
 	}
 	else {
-		echo '<h3 class="error">'.__('Error deleting recon task').'</h3>';
+		ui_print_error_message(__('Error deleting recon task'));
 	}
 }
 else if(isset($_GET["disabled"])) {
@@ -53,14 +53,14 @@ else if(isset($_GET["disabled"])) {
 	$result = db_process_sql_update('trecon_task', array('disabled' => $disabled), array('id_rt' => $id));
 	
 	if ($result !== false) {
-		echo '<h3 class="suc">'.__('Successfully updated recon task').'</h3>';
+		ui_print_success_message(__('Successfully updated recon task'));
 		// If the action is enabled, we force recon_task to be queued asap
 		if($disabled == 0) {
 			servers_force_recon_task($id);
 		}
 	}
 	else {
-		echo '<h3 class="error">'.__('Error updating recon task').'</h3>';
+		ui_print_error_message(__('Error updating recon task'));
 	}
 }
 
@@ -143,10 +143,10 @@ if (isset($_GET["update"])) {
 		$result = false;
 	
 	if ($result !== false) {
-		echo '<h3 class="suc">'.__('Successfully updated recon task').'</h3>';
+		ui_print_success_message(__('Successfully updated recon task'));
 	}
 	else {
-		echo '<h3 class="error">'.__('Error updating recon task').'</h3>';
+		ui_print_error_message(__('Error updating recon task'));
 		echo $reason;
 	}
 }
@@ -198,10 +198,10 @@ if (isset($_GET["create"])) {
 		$result = false;
 		
 	if ($result !== false) {
-		echo '<h3 class="suc">'.__('Successfully created recon task').'</h3>';
+		ui_print_success_message(__('Successfully created recon task'));
 	}
 	else {
-		echo '<h3 class="error">'.__('Error creating recon task').'</h3>';
+		ui_print_error_message(__('Error creating recon task'));
 		echo $reason;
 	}
 }

pandora_console/godmode/servers/modificar_server.php

@@ -86,10 +86,10 @@ else {
 		$result = db_process_sql_delete('tserver', array('id_server' => $id_server));
 		
 		if ($result !== false) {
-			 echo '<h3 class="suc">'.__('Server deleted successfully').'</h3>';
+			 ui_print_success_message(__('Server deleted successfully'));
 		}
 		else { 
-			echo '<h3 class="error">'.__('There was a problem deleting the server').'</h3>';
+			ui_print_error_message(__('There was a problem deleting the server'));
 		}
 	}
 	elseif (isset($_GET["update"])) {
@@ -100,10 +100,10 @@ else {
 		$values = array('ip_address' => $address, 'description' => $description);
 		$result = db_process_sql_update('tserver', $values, array('id_server' => $id_server));
 		if ($result !== false) {
-			echo '<h3 class="suc">'.__('Server updated successfully').'</h3>';
+			ui_print_success_message(__('Server updated successfully'));
 		}
 		else { 
-			echo '<h3 class="error">'.__('There was a problem updating the server').'</h3>';
+			ui_print_error_message(__('There was a problem updating the server'));
 		}
 	}
 	

pandora_console/godmode/servers/plugin.php

@@ -351,10 +351,10 @@ else {
 			$result = db_process_sql_update('tplugin', $values, array('id' => $plugin_id));
 		
 		if (! $result) {
-			echo "<h3 class='error'>".__('Problem updating plugin')."</h3>";
+			ui_print_error_message(__('Problem updating plugin'));
 		}
 		else {
-			echo "<h3 class='suc'>".__('Plugin updated successfully')."</h3>";
+			ui_print_success_message(__('Plugin updated successfully'));
 		}
 	}
 	
@@ -405,12 +405,10 @@ else {
 			$result = db_process_sql_insert('tplugin', $values);
 		
 		if (! $result) {
-			echo "<h3 class='error'>" .
-				__('Problem creating plugin') . "</h3>";
+			ui_print_error_message(__('Problem creating plugin'));
 		}
 		else {
-			echo "<h3 class='suc'>" .
-				__('Plugin created successfully') . "</h3>";
+			ui_print_success_message(__('Plugin created successfully'));
 		}
 	}
 	
@@ -420,10 +418,10 @@ else {
 		$result = db_process_sql_delete('tplugin', array('id' => $plugin_id));
 			
 		if (! $result) {
-			echo "<h3 class='error'>".__('Problem deleting plugin')."</h3>";
+			ui_print_error_message(__('Problem deleting plugin'));
 		}
 		else {
-			echo "<h3 class='suc'>".__('Plugin deleted successfully')."</h3>";
+			ui_print_success_message(__('Plugin deleted successfully'));
 		}
 		if ($plugin_id != 0) {
 			// Delete all the modules with this plugin

pandora_console/godmode/servers/recon_script.php

@@ -126,10 +126,10 @@ else {
 		if ($reconscript_name != '' && $reconscript_script != '')
 			$result = db_process_sql ($sql_update);
 		if (! $result) {
-			echo "<h3 class='error'>" . __('Problem updating') . "</h3>";
+			ui_print_error_message(__('Problem updating'));
 		}
 		else {
-			echo "<h3 class='suc'>" . __('Updated successfully') . "</h3>";
+			ui_print_success_message(__('Updated successfully'));
 		}
 	}
 	
@@ -147,10 +147,10 @@ else {
 		if ($values['name'] != '' && $values['script'] != '')
 			$result = db_process_sql_insert('trecon_script', $values);
 		if (! $result) {
-			echo "<h3 class='error'>" . __('Problem creating') . "</h3>";
+			ui_print_error_message(__('Problem creating'));
 		}
 		else {
-			echo "<h3 class='suc'>" . __('Created successfully') . "</h3>";
+			ui_print_success_message(__('Created successfully'));
 		}
 	}
 	
@@ -161,10 +161,10 @@ else {
 			array('id_recon_script' => $reconscript_id));
 		
 		if (! $result) {
-			echo "<h3 class='error'>" . __('Problem deleting reconscript') . "</h3>";
+			ui_print_error_message(__('Problem deleting reconscript'));
 		}
 		else {
-			echo "<h3 class='suc'>" . __('reconscript deleted successfully') . "</h3>";
+			ui_print_success_message(__('reconscript deleted successfully'));
 		}
 		if ($reconscript_id != 0){
 			$result = db_process_sql_delete('trecon_task',

pandora_console/godmode/setup/gis.php

@@ -36,15 +36,15 @@ $action = get_parameter('action');
 switch ($action) {
 	case 'save_edit_map_connection':
 		if(!$errorfill)
-			echo '<h3 class="suc">'.__('Successfully updated').'</h3>';
+			ui_print_success_message(__('Successfully updated'));
 		else
-			echo '<h3 class="error">'.__('Could not be updated').'</h3>';
+			ui_print_error_message(__('Could not be updated'));
 		break;
 	case 'save_map_connection':
 		if(!$errorfill)
-			echo '<h3 class="suc">'.__('Successfully created').'</h3>';
+			ui_print_success_message(__('Successfully created'));
 		else
-			echo '<h3 class="error">'.__('Could not be created').'</h3>';
+			ui_print_error_message(__('Could not be created'));
 		break;
 	case 'delete_connection':
 		$idConnectionMap = get_parameter('id_connection_map');
@@ -52,9 +52,9 @@ switch ($action) {
 		$result = gis_delete_map_connection($idConnectionMap);
 		
 		if($result === false)
-			echo '<h3 class="error">'.__('Could not be deleted').'</h3>';
+			ui_print_error_message(__('Could not be deleted'));
 		else
-			echo '<h3 class="suc">'.__('Successfully deleted').'</h3>';
+			ui_print_success_message(__('Successfully deleted'));
 		break;
 }
 

pandora_console/godmode/setup/links.php

@@ -36,9 +36,9 @@ if (isset($_POST["create"])) { // If create
 		$result = db_process_sql_insert("tlink", array('name' => $name, 'link' => $link));
 	
 	if (! $result)
-		echo "<h3 class='error'>".__('There was a problem creating link')."</h3>";
+		ui_print_error_message(__('There was a problem creating link'));
 	else {
-		echo "<h3 class='suc'>".__('Successfully created')."</h3>"; 
+		ui_print_success_message(__('Successfully created')); 
 		$id_link = $result;
 	}
 }
@@ -53,9 +53,9 @@ if (isset($_POST["update"])) { // if update
 		$result = db_process_sql_update("tlink", array('name' => $name, 'link' => $link), array('id_link' => $id_link));
 	
 	if (! $result)
-		echo "<h3 class='error'>".__('There was a problem modifying link')."</h3>";
+		ui_print_error_message(__('There was a problem modifying link'));
 	else
-		echo "<h3 class='suc'>".__('Successfully updated')."</h3>";
+		ui_print_success_message(__('Successfully updated'));
 }
 
 if (isset($_GET["borrar"])) { // if delete
@@ -64,9 +64,9 @@ if (isset($_GET["borrar"])) { // if delete
 	$result = db_process_sql_delete("tlink", array("id_link" => $id_link));
 	
 	if (! $result)
-		echo "<h3 class='error'>".__('There was a problem deleting link')."</h3>";
+		ui_print_error_message(__('There was a problem deleting link'));
 	else
-		echo "<h3 class='suc'>".__('Successfully deleted')."</h3>"; 
+		ui_print_success_message(__('Successfully deleted')); 
 
 }
 
@@ -82,7 +82,9 @@ if ((isset($_GET["form_add"])) or (isset($_GET["form_edit"]))) {
 				$nombre = $row["name"];
 				$link = $row["link"];
 			}
-			else echo "<h3 class='error'>".__('Name error')."</h3>";
+			else {
+				ui_print_error_message(__('Name error'));
+			}
 	}
 	else { // form_add
 		$creation_mode =1;

pandora_console/godmode/setup/news.php

@@ -87,7 +87,7 @@ if ((isset ($_GET["form_add"])) || (isset ($_GET["form_edit"]))) {
 			$timestamp = $result["timestamp"];
 		}
 		else {
-			echo "<h3 class='error'>".__('Name error')."</h3>";
+			ui_print_error_message(__('Name error'));
 		}
 	}
 	else { // form_add

pandora_console/godmode/tag/edit_tag.php

@@ -80,11 +80,11 @@ if ($update_tag && $id_tag != 0) {
 	
 	if ($result === false) {
 		db_pandora_audit("Tag management", "Fail try to update tag #$id_tag");
-		echo '<h3 class="error">'.__('Error updating tag').'</h3>';
+		ui_print_error_message(__('Error updating tag'));
 	}
 	else {
 		db_pandora_audit("Tag management", "Update tag #$id_tag");
-		echo '<h3 class="suc">'.__('Successfully updated tag').'</h3>';
+		ui_print_success_message(__('Successfully updated tag'));
 	}
 }
 
@@ -109,13 +109,13 @@ if ($create_tag) {
 	
 	if ($return_create === false) {
 		db_pandora_audit("Tag management", "Fail try to create tag");
-		echo '<h3 class="error">'.__('Error creating tag').'</h3>';
+		ui_print_error_message(__('Error creating tag'));
 		$action = "new";
 	// If create action ends successfully then current action is update
 	}
 	else {
 		db_pandora_audit("Tag management", "Create tag #$return_create");
-		echo '<h3 class="suc">'.__('Successfully created tag').'</h3>';
+		ui_print_success_message(__('Successfully created tag'));
 		$id_tag = $return_create;
 		$action = "update";
 	}

pandora_console/godmode/tag/tag.php

@@ -92,11 +92,11 @@ if ($delete != 0) {
 	
 	if ($return_delete === false) {
 		db_pandora_audit("Tag management", "Fail try to delete tag #$delete");
-		echo '<h3 class="error">'.__('Error deleting tag').'</h3>';
+		ui_print_error_message(__('Error deleting tag'));
 	}
 	else {
 		db_pandora_audit("Tag management", "Delete tag #$delete");
-		echo '<h3 class="suc">'.__('Successfully deleted tag').'</h3>';
+		ui_print_success_message(__('Successfully deleted tag'));
 	}
 }
 

pandora_console/godmode/users/configure_profile.php

@@ -88,7 +88,7 @@ if ($id_profile || $new_profile) {
 		$profile = db_get_row ('tperfil', 'id_perfil', $id_profile);
 		
 		if ($profile === false) {
-			echo '<h3 class="error">'.__('There was a problem loading profile').'</h3></table>';
+			ui_print_error_message(__('There was a problem loading profile')) . '</table>';
 			echo '</div>';
 			echo '<div style="clear:both">&nbsp;</div>';
 			echo '</div>';

pandora_console/include/ajax/module.php

@@ -237,7 +237,7 @@ if ($get_module_detail) {
 	}
 
 	if (empty ($table->data)) {
-		echo '<h3 class="error">'.__('No available data to show').'</h3>';
+		ui_print_error_message(__('No available data to show'));
 	}
 	else {
 		ui_pagination($count, false, $offset);

pandora_console/include/constants.php

@@ -209,6 +209,7 @@ define ('STATUS_AGENT_UNKNOWN', 'agent_unknown.png');
 define ('STATUS_AGENT_OK', 'agent_ok.png');
 define ('STATUS_AGENT_NO_DATA', 'agent_no_data.png');
 define ('STATUS_AGENT_NO_MONITORS', 'agent_no_monitors.png');
+define ('STATUS_AGENT_NOT_INIT', 'agent_notinit.png');
 //For alerts
 define ('STATUS_ALERT_FIRED', 'alert_fired.png');
 define ('STATUS_ALERT_NOT_FIRED', 'alert_not_fired.png');
@@ -280,4 +281,4 @@ define ('REPORT_EXCEPTION_CONDITION_E', 7);
 define ('REPORT_EXCEPTION_CONDITION_NE', 8);
 define ('REPORT_EXCEPTION_CONDITION_OK', 3);
 define ('REPORT_EXCEPTION_CONDITION_NOT_OK', 4);
-?>
+?>

pandora_console/include/functions.php

@@ -145,7 +145,7 @@ function safe_url_extraclean ($string, $default_string = '') {
 function no_permission () {
 	require ("config.php");
 	
-	echo "<h3 class='error'>".__('You don\'t have access')."</h3>";
+	ui_print_error_message(__('You don\'t have access'));
 	echo html_print_image('images/noaccess.png', true, array("alt" => 'No access', "width" => '120')) . "<br /><br />";
 	echo "<table width=550>";
 	echo "<tr><td>";
@@ -166,7 +166,7 @@ function no_permission () {
 function unmanaged_error ($error = "") {
 	require_once ("config.php");
 	
-	echo "<h3 class='error'>".__('Unmanaged error')."</h3>";
+	ui_print_error_message(__('Unmanaged error'));
 	echo html_print_image('images/error.png', true, array("alt" => 'error')) . "<br /><br />";
 	echo "<table width=550>";
 	echo "<tr><td>";